fixes intermittent soft reboot issue with firmware load
increases wait time of reset, as required by HW
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/media/usb/s2255
fixes intermittent soft reboot issue with firmware load
increases wait time of reset, as required by HW
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/media/usb/s2255
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255/s2255drv.c
index a56a05b..82014bb 100644
--- a/drivers/media/usb/s2255/s2255drv.c
+++ b/drivers
.
On 2014-11-04 14:34, Dean Anderson wrote:
qlock spinlock controls access to buf_list and sequence.
qlock spinlock should not be locked during a copy to video buffers, an
operation that may sleep.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 23 +++
1
qlock spinlock controls access to buf_list and sequence.
qlock spinlock should not be locked during a copy to video buffers, an
operation that may sleep.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 23 +++
1 file changed, 11 insertions(+), 12
Critical bug fix. Fixes memory leak introduced by
commit 47d8c881c304642a68d398b87d9e8846e643c81a.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255
14 17:01, Dean Anderson wrote:
"./utils/v4l2-compliance/v4l2-compliance -s"
Driver Info:
Driver name : s2255
Card type : s2255
Bus info : usb-:00:1a.7-3.6
Driver version: 3.13.0
Capabilities : 0x8401
Video Capture
Streaming
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
test read/write: OK
test MMAP: OK
test USERPTR: OK
Total: 39, Succeeded: 39, Failed: 0, Warnings: 9
On 2014-02-12 14:25, Dean Anderson wrote:
Upgrade to videobuf2 libraries.
No errors reported with "v4l2-compliance -s".
Upgrade to videobuf2 libraries.
No errors reported with "v4l2-compliance -s".
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 512 +++-
1 file changed, 152 insertions(+), 360 deletions(-)
diff --git a/drivers/media/usb/s2255/
RPTR: FAIL
Total: 39, Succeeded: 36, Failed: 3, Warnings: 9
On 2014-02-11 17:07, Hans Verkuil wrote:
Hi Dean,
On 02/12/2014 12:05 AM, Dean Anderson wrote:
The output of v4l2-compliance looks fine. The warnings can be
ignored
for this patch.
Can you update to the latest v4l2-compliance that I just
Upgrade to videobuf2 libraries.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 507 +++-
1 file changed, 148 insertions(+), 359 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255/s2255drv.c
index
REATE_BUFS not
supported
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
Total: 36, Succeeded: 36, Failed: 0, Warnings: 9
On 2014-02-11 16:56, Dean Anderson wrote:
Upgrade to videobuf2 libraries.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255dr
On 2014-02-04 04:04, Hans Verkuil wrote:
Hi Dean,
On 02/03/14 18:06, Dean Anderson wrote:
On 2014-02-03 03:51, Hans Verkuil wrote:
Hi Dean,
Some specific comments below, but first two general comments:
It is easier to review if at least the removal of the old s2255_fh
struct
was done as a
Removal of unnecessary parameters from s2255_fh.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 94 +---
1 file changed, 44 insertions(+), 50 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255
Start acquisition return code was not being checked. Return error
if start acquisition fails.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b
Driver was allocating a kernel buffer each time it was sending a command.
It is better to allocate this buffer once at startup.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 67
1 file changed, 37 insertions(+), 30 deletions
Start acquisition return code was not being checked. Return error
if start acquisition fails.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers
Buffer setup should check if minimum number of buffers is used.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255/s2255drv.c
Removing duplicate fmt from buffer structure.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255/s2255drv.c
index 1b267b1..517901b 100644
2-04 16:36, Dean Anderson wrote:
Removes most parameters from s2255_fh. These elements belong in
s2255_ch.
In the future, s2255_fh will be removed when videobuf2 is used.
videobuf2
has convenient and safe functions for locking streaming resources.
The removal of s2255_fh (and s2255_fh->resources)
ing videobuf_queue_is_busy.
videobuf_queue_is busy may be unsafe as noted by the following comment
in videobuf-core.c:
"/* Locking: Only usage in bttv unsafe find way to remove */"
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 224 +-
Renaming s2255_channel and all instances of channel to vc (video channel).
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 517 ++--
1 file changed, 259 insertions(+), 258 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b
There are some missing changes. It compiles, but please review v2
instead.
On 2014-02-04 15:04, Dean Anderson wrote:
Renaming s2255_channel and all instances of channel to vc (video
channel).
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 469
Renaming s2255_channel and all instances of channel to vc (video channel).
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 469 ++--
1 file changed, 235 insertions(+), 234 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b
Removal of unused and unnecessary s2255dma_queue structure.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 29 ++---
1 file changed, 10 insertions(+), 19 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255
On 2014-02-04 04:04, Hans Verkuil wrote:
Hi Dean,
On 02/03/14 18:06, Dean Anderson wrote:
On 2014-02-03 03:51, Hans Verkuil wrote:
Hi Dean,
Some specific comments below, but first two general comments:
It is easier to review if at least the removal of the old s2255_fh
struct
was done as a
Fixes all style warnings from scripts/checkpatch -f
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 333
1 file changed, 151 insertions(+), 182 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255
ange? What's wrong with dprintk?
"dev" wasn't available in this function without a back-reference from
channel, which may be a good idea. The other issue you mention below is
also important. I'll update this patch.
Thanks,
On 2014-01-29 01:19, Hans Verkuil wrote:
H
Fixes all style warnings from scripts/checkpatch -f
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c | 328
1 file changed, 147 insertions(+), 181 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers/media/usb/s2255
Removes unnecessary query of buffer state. The code already checks if stream
is active or not.
Signed-off-by: Dean Anderson
---
drivers/media/usb/s2255/s2255drv.c |9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
b/drivers
Hi Dan,
The original code has an issue on big endian hardware. The patch looks ok.
Signed-off-by: Dean Anderson
On 2/16/2012 10:44 PM, Dan Carpenter wrote:
I don't have this hardware and I don't know the subsystem very well. So
please review this patch carefully. The ori
Thanks Dan,
I can sign off on this. The check isn't required.
Signed-off-by: Dean Anderson
On 2/16/2012 10:43 PM, Dan Carpenter wrote:
"f" wasn't checked consistently, so static checkers complain. This
function is always called with a valid "f" pointer, so I
You are correct. Please withdraw this
patch(https://patchwork.kernel.org/patch/89985/).
Regards,
Hans Verkuil wrote:
On Wednesday 31 March 2010 18:34:39 Dean A. wrote:
# HG changeset patch
# User Dean Anderson
# Date 1270053044 25200
# Node ID 0690e4e1d81e785af1a5f06a13573dcf2cc5cb0c
# HG changeset patch
# User Dean Anderson
# Date 1270056198 25200
# Node ID db81e2f83909ee79dcca8496ceeda2653775e60a
# Parent 0690e4e1d81e785af1a5f06a13573dcf2cc5cb0c
s2255drv: cleanup of debug messages
From: Dean Anderson
Priority: normal
Signed-off-by: Dean Anderson
diff -r 0690e4e1d81e
# HG changeset patch
# User Dean Anderson
# Date 1270053044 25200
# Node ID 0690e4e1d81e785af1a5f06a13573dcf2cc5cb0c
# Parent c72bdc8732abc0cf7bc376babfd06b2d999bdcf4
s2255drv: adding v4l2_device structure. video_register_device cleanup
From: Dean Anderson
adding v4l2_device structure.
if one
# HG changeset patch
# User Dean Anderson
# Date 1270046291 25200
# Node ID c72bdc8732abc0cf7bc376babfd06b2d999bdcf4
# Parent 2ab296deae938864b06b29cc224eb4b670ae3aa9
s2255drv: removal of BKL
From: Dean Anderson
big kernel lock removed from open function.
v4l2 code does not require locking
# HG changeset patch
# User Dean Anderson
# Date 1270045856 25200
# Node ID 2ab296deae938864b06b29cc224eb4b670ae3aa9
# Parent 18586e4ac3ed5972dac2015600f8c21e26c0fc16
s2255drv: video_device allocation fix
From: Dean Anderson
call to video_device_alloc was not being checked in probe function
similar to solution #2.
The call definitely needs checked, but I'd like some more feedback on this.
Thanks and best regards,
Dean
David Ellingsworth wrote:
This patch looks good, but there was one other thing that caught my eye.
In s2255_probe_v4l, video_device_alloc is called for ea
# HG changeset patch
# User Dean Anderson
# Date 1269900678 25200
# Node ID 18586e4ac3ed5972dac2015600f8c21e26c0fc16
# Parent c437bd6f3659885afbe20ad12857347f0850156b
s2255drv: code cleanup
From: Dean Anderson
removal of unused pipe array (of size one).
Priority: normal
Signed-off-by: Dean
# HG changeset patch
# User Dean Anderson
# Date 1269899865 25200
# Node ID c437bd6f3659885afbe20ad12857347f0850156b
# Parent a539e5b689454b8feb6b5acf5a67516b142c2823
s2255drv: cleanup of driver disconnect code
From: Dean Anderson
simplifies use of kref in driver
Priority: normal
Signed-off
# HG changeset patch
# User Dean Anderson
# Date 1268089334 28800
# Node ID 3ac8a7637cf3db984665e5aa43e03c22ee0c16f2
# Parent 08932f075cb147c47e2acc4b1f464c736080bc96
s2255drv: frame decimation support
From: Dean Anderson
adds hardware frame skipping using VIDIOC_S_PARM ioctl.
adds support
# HG changeset patch
# User Dean Anderson
# Date 1267829723 28800
# Node ID 54b44c52d908b363f69488fed84f1e8b9ccaf038
# Parent bdfee5ee52c800a24e1231cd52eeeb91636c013c
s2255drv: support for 2257 device
From: Dean Anderson
2257 is 2255 with 2 svideo inputs
Priority: normal
Signed-off-by: Dean
# HG changeset patch
# User Dean Anderson
# Date 1267809968 28800
# Node ID bdfee5ee52c800a24e1231cd52eeeb91636c013c
# Parent ff343fa70b4def92d35f9ef7ee56a953b012d169
s2255drv cleanup of V4L2 video controls
From: Dean Anderson
s2255drv cleanup of V4L2 video controls
Priority: normal
Signed
# HG changeset patch
# User Dean Anderson
# Date 1267746208 28800
# Node ID ff343fa70b4def92d35f9ef7ee56a953b012d169
# Parent c9c1bcda21557cea425589f281b6b3100e2c15a0
s2255drv: fixes for big endian arch
From: Dean Anderson
s2255drv fixes for big endian architecture
Priority: normal
Signed
# HG changeset patch
# User Dean Anderson
# Date 1267655333 28800
# Node ID 3bf09a2ab1100269d6424c487ca98a1b1e4ead54
# Parent 5e0d6be7f020d6c0741795b0bd039ace7d54d310
Adds video status capability to 2255 driver
From: Dean Anderson
Video status capability for inputs on Sensoray 2255 driver
I am trying to use an 'OnAir USB HDTV Creator' (from autumnwave.com).
According to
http://www.linuxtv.org/wiki/index.php/OnAir_USB_HDTV_Creator
This device is supported, however it's not working for me. Following the
instructions at above link, I tried this:
modprobe pvrusb2 initusbreset=0
The
Devin Heitmueller wrote:
> On Tue, Feb 23, 2010 at 1:37 AM, Dean wrote:
>> Hi,
>>
>> I have the KWorld DVB-T 305U, an em28xx device. Only the video works for me
>> under Linux, no audio. In case anyone wants to see it, I have attached the
>> full dm
Hi,
I have the KWorld DVB-T 305U, an em28xx device. Only the video works for me
under Linux, no audio. In case anyone wants to see it, I have attached the
full dmesg text, solely from this device.
Cheers,
Dean
Devin Heitmueller wrote:
>
> Also, please provide the *full* dmesg
My dmesg gave the following (excerpt) when I connected my KWorld 305U.
em28xx #0: Identified as KWorld DVB-T 305U (card=47)
em28xx #0:
em28xx #0: The support for this board weren't valid yet.
em28xx #0: Please send a report of having this working
em28xx #0: not to V4L mailing list (and/or to oth
This seems ok. This portion of code was based on vivi.c, so that might
be checked also.
Mike Isely wrote:
# HG changeset patch
# User Mike Isely
# Date 1253739604 18000
# Node ID 522a74147753ba59c7f45e368439928090a286f2
# Parent e349075171ddf939381fad432c23c1269abc4899
s2255drv: Don't cond
From: Dean Anderson
Adding V4L2_MODE_HIGHQUALITY feature.
Signed-off-by: Dean Anderson
--- v4l-dvb-0018ed9bbca3/linux/drivers/media/video/s2255drv.c.orig
2009-05-15 10:15:36.0 -0700
+++ v4l-dvb-0018ed9bbca3/linux/drivers/media/video/s2255drv.c 2009-05-15
10:20:43.0
From: Dean Anderson
Error count in read pipe completion corrected.
URB not resubmitted if shutting down.
URB not freed in completion routine if new urb_submit_fails.
(URB is freed on shutdown).
Signed-off-by: Dean Anderson
--- v4l-dvb-83712d149893/linux/drivers/media/video/s2255drv.c.orig
From: Dean Anderson
Removal of unused structure items. Response values defined. Driver revision
printk.
Signed-off-by: Dean Anderson
--- v4l-dvb-ebb7b82f2b48/linux/drivers/media/video/s2255drv.c.orig
2009-04-23 11:37:28.0 -0700
+++ v4l-dvb-ebb7b82f2b48/linux/drivers/media/video
From: Dean Anderson
set_modeready flag must be set before command sent to USB in
s2255_write_config.
Signed-off-by: Dean Anderson
--- v4l-dvb-74b7f650670a/linux/drivers/media/video/s2255drv.c.orig
2009-04-20 14:33:04.0 -0700
+++ v4l-dvb-74b7f650670a/linux/drivers/media/video
From: Dean Anderson
This patch adds V4L2 video status capability and V4L2_MODE_HIGHQUALITY
operation.
Signed-off-by: Dean Anderson
--- v4l-dvb-1e670024659d/linux/drivers/media/video/s2255drv.c.orig
2009-04-07 10:38:42.0 -0700
+++ v4l-dvb-1e670024659d/linux/drivers/media/video
Alexey Klimov wrote:
Hello, all
Dean, so you think that we don't need s2255 name in the beginning of
message and we doesn't need s2255_dev_err macros, right ?
As i remember pr_err is just printk with KERN_ERR..
Not at all. We must have s2255 in the beginning of the message.
Carvalho Chehab wrote:
Alexey,
You should get the driver maintainer's ack or at least let them know that
you're touching on their drivers.
Mike, Thierry an Dean,
Could you please review this patch?
Cheers,
Mauro.
Forwarded message:
Date: Thu, 01 Jan 2009 11:06:08 +0300
From: Alex
57 matches
Mail list logo