Re: [PATCH] [media] mt9p031: fixed calculation of clk_div

2015-02-04 Thread Enrico Scholz
Laurent Pinchart writes: >> and the upper limit is '63' (value uses 6:0 register bits). > > And this I don't. You can encode numbers from 0 to 127 on 7 bits. yes; you are right (original '64' was correct because sensor allows only dividers of a power-of-two). >> -mt9p031->clk_div =

Re: [PATCH] [media] mt9p031: fixed calculation of clk_div

2015-02-04 Thread Laurent Pinchart
Hi Enrico, Thank you for the patch. On Wednesday 04 February 2015 15:53:32 Enrico Scholz wrote: > There must be used 'min_t', not 'max_t' for calculating the divider That I agree with. > and the upper limit is '63' (value uses 6:0 register bits). And this I don't. You can encode numbers from 0

[PATCH] [media] mt9p031: fixed calculation of clk_div

2015-02-04 Thread Enrico Scholz
There must be used 'min_t', not 'max_t' for calculating the divider and the upper limit is '63' (value uses 6:0 register bits). Signed-off-by: Enrico Scholz Cc: Laurent Pinchart --- drivers/media/i2c/mt9p031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c