ddresses both of the above by a) calling
> usb_free_urb() when usb_alloc_coherent() fails and by explicitly
> initializing 'i' to zero.
> I also moved the variables 'mem' and 'urb' inside the for loop. This does
> not actually make any difference, it just s
://www.telegent.com/press/2009Sept14_CSI.html
Huang Shijie (10):
add maitainers for tlg2300
add readme file for tlg2300
add Kconfig and Makefile for tlg2300
add header files for tlg2300
add the generic file
add video file for tlg2300
add vbi code for tlg2300
add audio support for tlg2300
From: root
modify the two files for tlg2300.
Signed-off-by: Huang Shijie
---
drivers/media/video/Kconfig |2 ++
drivers/media/video/Makefile |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index dcf9fa9
add maitainers for the driver.
Signed-off-by: Huang Shijie
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 60299a9..a8f02d6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5673,6 +5673,12 @@ F: Documentation
add Kconfig and Makefile for tlg2300.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/Kconfig | 16
drivers/media/video/tlg2300/Makefile |9 +
2 files changed, 25 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300/Kconfig
pd-common.h contains the common data structures, while
vendorcmds.h contains the vendor commands for firmware.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-common.h | 318 ++
drivers/media/video/tlg2300/vendorcmds.h | 243
pd-main.c contains the ->probe(), it privides the generic
functions for analog TV,DVB-T and radio.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-main.c | 546 +
1 files changed, 546 insertions(+), 0 deletions(-)
create mode 100644 drivers/me
pd-video.c and pd-bufqueue.c contain the code for V4L2 implementation.
The code support read,mmap and user pointer.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-bufqueue.c | 185
drivers/media/video/tlg2300/pd-video.c| 1636 +
2 files
This is the vbi module for tlg2300.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-vbi.c | 183 ++
1 files changed, 183 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300/pd-vbi.c
diff --git a/drivers/media/video
The module uses ALSA for the audio, it will register
a new card for tlg2300.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-alsa.c | 379 +
1 files changed, 379 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300/pd
This module contains the code for DVB-T.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-dvb.c | 649 ++
1 files changed, 649 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300/pd-dvb.c
diff --git a/drivers/media/video
adevice=hw=1,0:arate=48000 -rawaudio rate=48000:channels=2
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-radio.c | 383
1 files changed, 383 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300/pd-radio.c
diff --git a
> +#ifdef CONFIG_PM
> +/* Is the card working now ? */
> +static inline int is_working(struct poseidon *pd)
> +{
> + if (pd->state & POSEIDON_STATE_IDLE_HIBERANTION)
> + return 0;
> + return pd->interface->pm_usage_cnt > 0;
> +}
> +
> +static int poseidon_suspend(struct usb_int
Em Wed, 09 Dec 2009 17:08:27 -0200
Mauro Carvalho Chehab escreveu:
Huang Shijie wrote:
The TLG2300 is a chip of Telegent System.
It support analog tv,DVB-T and radio in a single chip.
The chip has been used in several dongles, such as aeromax DH-9000:
http://www.b2bdvb.com
e.
[3] optimize the power management code.
[4] misc bugs.
Huang Shijie (10):
add header files for tlg2300
add the generic file
add video/vbi file for tlg2300
add DVB-T support for tlg2300
add FM support for tlg2300
add audio support for tlg2300
add document file for tl
pd-common.h contains the common data structures, while
vendorcmds.h contains the vendor commands for firmware.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-common.h | 280 ++
drivers/media/video/tlg2300/vendorcmds.h | 243
pd-main.c contains the ->probe(), it privides the
generic functions for analog TV, DVB-T and radio.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-main.c | 566 +
1 files changed, 566 insertions(+), 0 deletions(-)
create mode 100644 driv
This file contains the code for DVB-T.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-dvb.c | 593 ++
1 files changed, 593 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300/pd-dvb.c
diff --git a/drivers/media/video
adevice=hw=1,0:arate=48000 -rawaudio
rate=48000:channels=2
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-radio.c | 351
1 files changed, 351 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300
this is the document for tlg2300.
Signed-off-by: Huang Shijie
---
Documentation/video4linux/README.tlg2300 | 231 ++
1 files changed, 231 insertions(+), 0 deletions(-)
create mode 100644 Documentation/video4linux/README.tlg2300
diff --git a/Documentation
The file contains the code for audio which uses the ALSA.
The audio will register a new card for tlg2300.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-alsa.c | 332 +
1 files changed, 332 insertions(+), 0 deletions(-)
create mode 100644
add Kconfig and Makefile for tlg2300 driver.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/Kconfig | 16
drivers/media/video/tlg2300/Makefile |9 +
2 files changed, 25 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300
This file contains the code for V4L2 implementation.
The VBI shares the same code with the video.
The code support read and mmap for IO, and you can
also choose the USB transfer mode : bulk or isochronous.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-video.c
add the items for tlg2300 in the two files.
Signed-off-by: Huang Shijie
---
drivers/media/video/Kconfig |2 ++
drivers/media/video/Makefile |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index 2f83be7
I'm assuming that you're referring to the analog part, right?
right.
The country code only effects the Analog TV and radio, it has no
effect on DVB-T.
Instead of a country code, the driver should use the V4L2_STD_ macros to
If we are in the radio mode, I do not have any video stand
you mean that the frequency range can be used to set the pre-emphasis?
I am not sure about this.
ioctls. There's no standard way to control the preemphasis, but I recommend
adding a ctrl to select between 50us/75us and no preemphasis.
Best Regards
Huang Shijie
--
To unsubscribe from
t again.
Ok. no problem.
Cheers,
Mauro
Best Regards
Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in the two days(today and tomorrow).
Take a look at si4713-i2c.c for an example on how to use it.
Ah, please submit those changes as another series of patches. This helps me
to not needing to review the entire changeset again.
Cheers,
Mauro
Best Regards
Huang Shijie
--
To unsubscribe fro
video :
use the V4L2_STD macros to select the proper audio setting.
radio :
add preemphasis ctr.
test it by the command:
v4l2-ctl -d /dev/radio0 --set-ctrl=pre_emphasis_settings=1
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd-common.h |4
remove the the country code section.
Signed-off-by: Huang Shijie
---
Documentation/video4linux/README.tlg2300 | 198 +
1 files changed, 7 insertions(+), 191 deletions(-)
diff --git a/Documentation/video4linux/README.tlg2300
b/Documentation/video4linux
linux-next commit 2ff8223957d901999bf76aaf2c6183e33a6ad14e
exposes an infinite loop defect in scripts/get_maintainer.pl
Fix the incorrect format of the MAINTAINERS "M:" entries.
Signed-off-by: Joe Perches
thanks ,
acked by : Huang Shijie
---
diff --git a/MAINTAINERS b/MAINTAI
thanks.
Acked-by: Huang Shijie
linux-next commit 2ff8223957d901999bf76aaf2c6183e33a6ad14e
exposes an infinite loop defect in scripts/get_maintainer.pl
Fix the incorrect format of the MAINTAINERS "M:" entries.
Signed-off-by: Joe Perches
---
diff --git a/MAINTAINERS b/MAINTAINERS
ind
From: Márton Németh
Make the local variables and functions static. Some of them are not exported by
their
symbol name but used trough other means. For example a pointer of the operation
structure is passed through a function call.
This will remove the following sparse warnings (see "make C=1"
hi Marton, thanks a lot.
From: Márton Németh
When power management is not configured (CONFIG_PM) then some code is no longer
necessary.
This patch will remove the following compiler warnings:
* pd-dvb.c: In function 'poseidon_fe_release':
* pd-dvb.c:101: warning: unused variable 'pd'
* p
thanks.
Acked-by: Huang Shijie
From: Márton Németh
Make the local variables and functions static. Some of them are not exported by
their
symbol name but used trough other means. For example a pointer of the operation
structure is passed through a function call.
This will remove the
The function poseidon_fe_release is redundent in fact, I will remove it
in future.
But now I still acked this patch. thanks a lot.
Acked-by: Huang Shijie
From: Márton Németh
When power management is not configured (CONFIG_PM) then some code is no longer
necessary.
This patch will remove
The orgin parameters may cause a bug : The audio may lost in certain
situation (such as open the VLC at the first time).
The origin parameters set a small stop_threshold for snd_pcm_runtime{}.
So a xrun occurs in some situation.
Signed-off-by: Huang Shijie
---
drivers/media/video/tlg2300/pd
Hi Mauro:
Please ignore this patch.
This patch has side effect : the radio does not run well with this patch.
Best Regards
Huang Shijie.
> The orgin parameters may cause a bug : The audio may lost in certain
> situation (such as open the VLC at the first time).
>
> The origin para
). the
radio runs well.
Do you have any advice ? Do you think this is a problem?
thanks.
> Best Regards
> Huang Shijie.
>
>
>> The orgin parameters may cause a bug : The audio may lost in certain
>> situation (such as open the VLC at the first time).
>>
Hi Strakh:
Thanks for your patch.
But I prefer to remove the mutex_unlock() in the pd_vidioc_s_fmt(),
since the pd_vidioc_s_fmt() is also called in restore_v4l2_context().
would you please change the patch?
I will ack it.
Best Regards
Huang Shijie
2010/12/13 Alexander Strakh
someone else ever manages to get a working tlg2300 that code might be used
> for further work.
Could you tell me how did you test your patch set?
did you test the hibernate and suspend/resume?
>
> Huang Shijie, are you still able to act as maintainer? If not, then I can
> put my nam
On Fri, Feb 1, 2013 at 3:49 PM, Hans Verkuil wrote:
> On Fri February 1 2013 03:22:22 Huang Shijie wrote:
>> Hi Hans:
>>
>> On Thu, Jan 31, 2013 at 6:25 PM, Hans Verkuil wrote:
>> > Hi all,
>> >
>> > Last year I worked on this driver to improve it
if (!is_working(pd)) {
> if (PM_EVENT_AUTO_SUSPEND == pd->msg.event)
> @@ -439,7 +438,7 @@ static int poseidon_probe(struct usb_interface *interface,
> /* register v4l2 device */
> snprintf(pd->v4l2_dev.name, sizeof(pd->v4l2_de
*p)
> {
> struct video_device *fm_dev;
> + int err;
>
> fm_dev = vdev_init(p, &poseidon_fm_template);
> if (fm_dev == NULL)
> - return -1;
> + return -ENOMEM;
>
> - if (video_register_device(fm_dev, VFL_TYPE_RADIO, -
ations poseidon_fm_fops
> = {
> .owner = THIS_MODULE,
> .open = poseidon_fm_open,
> .release = poseidon_fm_close,
> - .ioctl = video_ioctl2,
> + .unlocked_ioctl = video_ioctl2,
> };
>
> static int tlg_fm_vid
my office.
thanks
Huang Shijie
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/usb/tlg2300/pd-radio.c | 27 ---
> 1 file changed, 27 deletions(-)
>
> diff --git a/drivers/media/usb/tlg2300/pd-radio.c
> b/drivers/media/usb/tlg2300/pd-radio.c
&g
video_device_release(fm_dev);
> - return err;
> - }
> - return 0;
> + return video_register_device(vfd, VFL_TYPE_RADIO, -1);
> }
>
> int poseidon_fm_exit(struct poseidon *p)
> {
> - destroy_video_device(&p->radio_data
>private_data;
> + struct poseidon *p = video_drvdata(file);
>
> if (argp->tuner)
> return -EINVAL;
> @@ -293,6 +293,8 @@ static const struct v4l2_ioctl_ops poseidon_fm_ioctl_ops
> = {
> .vidioc_g_tuner = tlg_fm_vidioc_g_tuner,
> .v
于 2013年01月31日 05:25, Hans Verkuil 写道:
> From: Hans Verkuil
>
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/usb/tlg2300/pd-radio.c |7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/tlg2300/pd-radio.c
> b/drivers/media/usb/tlg2300/pd-radio.c
+ video_unregister_device(&p->radio_data.fm_dev);
> v4l2_ctrl_handler_free(&p->radio_data.ctrl_handler);
> return 0;
> }
Acked-by: Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ut;
>
> /* VBI uses the same template as video */
> - vbi->v_dev = vdev_init(pd, &pd_video_template);
> - if (vbi->v_dev == NULL) {
> - ret = -ENOMEM;
> - goto out;
> - }
> - ret = video_register_device(vbi->v_dev, VFL_TYPE_VBI
if (vdev->vfl_type == VFL_TYPE_VBI)
> + cap->device_caps |= V4L2_CAP_VBI_CAPTURE;
> + else
> + cap->device_caps |= V4L2_CAP_VIDEO_CAPTURE;
> + cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS |
> + V4L2_CAP_RADIO | V4L2_CAP
q);
> + set_frequency(pd, &context->freq);
> return 0;
> }
>
> @@ -1615,8 +1617,10 @@ int pd_video_init(struct poseidon *pd)
> {
> struct video_data *video = &pd->video_data;
> struct vbi_data *vbi= &pd->vbi_data;
> +
D_CONTRAST,
> + 0, 1, 1, 100);
> + v4l2_ctrl_new_std(hdl, &tlg_ctrl_ops, V4L2_CID_HUE,
> + 0, 1, 1, 100);
> + v4l2_ctrl_new_std(hdl, &tlg_ctrl_ops, V4L2_CID_SATURATION,
> + 0, 1, 1, 100);
> + if (hdl-&
trl_handler;
>
> *vfd = poseidon_fm_template;
> - vfd->v4l2_dev = &p->v4l2_dev;
> - video_set_drvdata(vfd, p);
>
> set_frequency(p, TUNER_FREQ_MIN_FM);
> + v4l2_ctrl_handler_init(hdl, 1);
> + v4l2_ctrl_new_std_menu(hdl, &tlg_
audio input index mixed with this video input,
>* Poseidon only have one audio/video, set to "0"
>*/
> - in->audioset= 0;
> + in->audioset = 1;
i think it should be 0. it's need to be test.
thanks
Huang Shijie
> in->tuner = 0;
>
td = vidioc_g_std,
> .vidioc_s_std = vidioc_s_std,
> .vidioc_g_frequency = vidioc_g_frequency,
> .vidioc_s_frequency = vidioc_s_frequency,
Acked-by: Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t;video_data);
> @@ -1442,10 +1431,11 @@ static int pd_video_release(struct file *file)
> pd->file_for_stream = NULL;
> pd->video_data.users--;
> } else if (front->type == V4L2_BUF_TYPE_VBI_CAPTURE) {
> - pd->state &= ~POSEIDON_STATE_VBI;
> pd->vbi_data.front = NULL;
> pd->vbi_data.users--;
> }
> + if (!pd->vbi_data.users && !pd->video_data.users)
> + pd->state &= ~POSEIDON_STATE_ANALOG;
> videobuf_stop(&front->q);
> videobuf_mmap_free(&front->q);
>
Acked-by: Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
erybuf(&front->q, b);
> }
>
> @@ -1207,7 +1191,6 @@ static int vidioc_streamon(struct file *file, void *fh,
> {
> struct front_face *front = fh;
>
> - logs(front);
> if (unlikely(type != front->type))
> return -EINVAL;
>
;
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 975ba7c..00bb196 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6778,8 +6778,6 @@ F: drivers/clocksource
>
> TLG2300 VIDEO4LINUX-2 DRIVER
> M: Huang Shijie
> -M: Kang Yong
> -M: Zhang Xiaobing
>
queryctrl = tlg_fm_vidioc_queryctrl,
> .vidioc_querymenu = tlg_fm_vidioc_querymenu,
> .vidioc_g_ctrl = tlg_fm_vidioc_g_ctrl,
I tested this patch. it seems ok.
thanks.
Acked-by: Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
?? 2013??02??04?? 03:38, Hans Verkuil :
On Mon February 4 2013 05:36:56 Huang Shijie wrote:
?? 2013??01??31?? 05:25, Hans Verkuil :
From: Hans Verkuil
Signed-off-by: Hans Verkuil
---
drivers/media/usb/tlg2300/pd-radio.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion
audio input index mixed with this video input,
>* Poseidon only have one audio/video, set to "0"
>*/
> - in->audioset= 0;
> + in->audioset= 1;
> in->tuner = 0;
> in->std = V4L2_STD_ALL;
> in->status
@ -530,7 +525,7 @@ module_init(poseidon_init);
> module_exit(poseidon_exit);
>
> MODULE_AUTHOR("Telegent Systems");
> -MODULE_DESCRIPTION("For tlg2300-based USB device ");
> +MODULE_DESCRIPTION("For tlg2300-based USB device");
> MODULE_LICENSE("GPL");
> MODULE_VERSION("0.0.2");
> MODULE_FIRMWARE(TLG2300_FIRMWARE);
> --
> 1.7.10.4
>
sorry for the later reply. I was on vacation.
Acked-by: Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hans
>
> Signed-off-by: Hans Verkuil
> ---
> MAINTAINERS |5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5334229..9a83a1c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6794,9 +6794,8 @@ F:
h on
> cap->version anymore. See the enclosed patch.
>
>>
>> Cc: Mauro Carvalho Chehab
>> Cc: Huang Shijie
>> Cc: Kang Yong
>> Cc: Zhang Xiaobing
>> Cc:
>> Signed-off-by: Marcos Paulo de Souza
>> ---
>> drivers/media/video/tlg2
n < 0 is always false [-Wtype-limits]
>
> Cc: Huang Shijie
> Cc: Kang Yong
> Cc: Zhang Xiaobing
> Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/media/usb/tlg2300/pd-video.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers
thanks.
Acked-by: Huang Shijie
On Thu, Jul 26, 2012 at 3:41 AM, Tim Gardner wrote:
> Cc: Huang Shijie
> Cc: Kang Yong
> Cc: Zhang Xiaobing
> Cc: Mauro Carvalho Chehab
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Tim Gardner
> ---
> drivers/media/video/
68 matches
Mail list logo
