[PATCH v2 2/2] Doc: update 00-INDEX files to reflect the runnable code move

2016-10-06 Thread Shuah Khan
Update 00-INDEX files with the current file list to reflect the runnable code move. Acked-by: Michal Marek Acked-by: Jonathan Corbet Reviewed-by: Kees Cook Signed-off-by: Shuah Khan --- Documentation/00-INDEX | 3 ++- Documentation/arm/00-INDEX | 2 -- Documentation

[PATCH v2 1/2] samples: move blackfin gptimers-example from Documentation

2016-10-06 Thread Shuah Khan
: Paul Gortmaker Signed-off-by: Shuah Khan --- Documentation/Makefile| 2 +- Documentation/blackfin/00-INDEX | 4 -- Documentation/blackfin/Makefile | 5 -- Documentation/blackfin/gptimers-example.c | 91 --- Makefile

[PATCH v2 0/2] Moving runnable code from Documentation (last 2 patches)

2016-10-06 Thread Shuah Khan
Michal Marek, and reviewed by from Kees Cook Shuah Khan (2): samples: move blackfin gptimers-example from Documentation Doc: update 00-INDEX files to reflect the runnable code move Documentation/00-INDEX| 3 +- Documentation/Makefile| 2 +- Document

[PATCH] media: s5p-mfc include buffer size in error message

2016-10-17 Thread Shuah Khan
Include buffer size in s5p_mfc_alloc_priv_buf() the error message when it fails to allocate the buffer. Remove the debug message that does the same. Signed-off-by: Shuah Khan --- drivers/media/platform/s5p-mfc/s5p_mfc_opr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH] media: s5p-mfc collapse two error message into one

2016-10-18 Thread Shuah Khan
s5p_mfc_alloc_priv_buf() prints two message to report invalid memory configuration error. Collapse them into a single message. Signed-off-by: Shuah Khan --- drivers/media/platform/s5p-mfc/s5p_mfc_opr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform

[PATCH] media: v4l2-core: v4l2-mc: Add SPDX license identifier

2018-01-10 Thread Shuah Khan
Replace GPL license statement with SPDX GPL-2.0 license identifier. Signed-off-by: Shuah Khan --- drivers/media/v4l2-core/v4l2-mc.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c index

Re: [PATCH] media: v4l2-core: v4l2-mc: Add SPDX license identifier

2018-01-11 Thread Shuah Khan
On 01/11/2018 05:55 AM, Laurent Pinchart wrote: > Hi Shuah, > > Thank you for the patch. > > On Wednesday, 10 January 2018 18:35:36 EET Shuah Khan wrote: >> Replace GPL license statement with SPDX GPL-2.0 license identifier. >> >> Signed-off-by: Shuah Khan &

Re: [PATCH] media: v4l2-core: v4l2-mc: Add SPDX license identifier

2018-01-11 Thread Shuah Khan
On 01/11/2018 11:42 AM, Laurent Pinchart wrote: > Hi Shuah, > > On Thursday, 11 January 2018 17:45:15 EET Shuah Khan wrote: >> On 01/11/2018 05:55 AM, Laurent Pinchart wrote: >>> On Wednesday, 10 January 2018 18:35:36 EET Shuah Khan wrote: >>>> Replace GPL

Re: [PATCH] media: v4l2-core: v4l2-mc: Add SPDX license identifier

2018-01-11 Thread Shuah Khan
On 01/11/2018 02:33 PM, Laurent Pinchart wrote: > Hi Shuah, > > On Thursday, 11 January 2018 22:44:08 EET Shuah Khan wrote: >> On 01/11/2018 11:42 AM, Laurent Pinchart wrote: >>> On Thursday, 11 January 2018 17:45:15 EET Shuah Khan wrote: >>>> On 01/11/2

[PATCH v2] media: v4l2-core: v4l2-mc: Add SPDX license identifier

2018-01-11 Thread Shuah Khan
Replace GPL license statement with SPDX GPL-2.0 license identifier. Signed-off-by: Shuah Khan --- Changes since v1: - Fixed SPDX comment format - Fixed SPDX license text to eliminate change in license. It now reads GPL-2.0-or-later to maintain the original. drivers/media/v4l2-core/v4l2-mc.c

Re: [PATCH 2/2] media: rc: self test for IR encoders and decoders

2018-10-04 Thread Shuah Khan
Hi Sean, Thanks for the patch. I just happened to see this when Mauro sent it to me. Doesn't look like linux-ksefltest and I weren't on the patch? On 07/17/2018 03:33 PM, Sean Young (by way of Mauro Carvalho Chehab ) wrote: > ir-loopback can transmit IR on one rc device and check the correct > s

Re: [PATCH] media: rc: self test for IR encoders and decoders

2018-11-01 Thread Shuah Khan
IR encoders and decoders themselves. > > No hardware is required for this test. > > Signed-off-by: Sean Young > Cc: Shuah Khan Hi Sean, This looks good. I will get this into the next release. It will show up in linux-kselftest next after 4.20-rc1 comes out. thanks, -- Shuah

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Shuah Khan
On 11/07/2018 12:10 PM, Mauro Carvalho Chehab wrote: > Em Wed, 07 Nov 2018 12:06:55 +0200 > Laurent Pinchart escreveu: > >> Hi Hans, >> >> On Wednesday, 7 November 2018 10:05:12 EET Hans Verkuil wrote: >>> On 11/06/2018 08:58 PM, Laurent Pinchart wrote: On Tuesday, 6 November 2018 15:56:34

[PATCH v10 0/4] Media Device Allocator API

2019-01-24 Thread Shuah Khan
device based on comments from Hans Verkuil - Carried Reviewed-by tag from Takashi Iwai for the sound from v9. - No changes to Patches 2 and 3. References: https://lkml.org/lkml/2018/11/2/169 https://www.mail-archive.com/linux-media@vger.kernel.org/msg105854.html Shuah Khan (4): media: Media Device

[PATCH v10 4/4] sound/usb: Use Media Controller API to share media resources

2019-01-24 Thread Shuah Khan
snd_usb_hw_free(). If resource is busy, -EBUSY is returned. Media specific cleanup is done in usb_audio_disconnect(). Reviewed-by: Takashi Iwai Signed-off-by: Shuah Khan --- sound/usb/Kconfig| 4 + sound/usb/Makefile | 2 + sound/usb/card.c | 14 ++ sound/usb/card.h

[PATCH v10 3/4] media: media.h: Enable ALSA MEDIA_INTF_T* interface types

2019-01-24 Thread Shuah Khan
Move PCM_CAPTURE, PCM_PLAYBACK, and CONTROL ALSA MEDIA_INTF_T* interface types back into __KERNEL__ scope to get ready for adding ALSA support for these to the media controller. Signed-off-by: Shuah Khan --- include/uapi/linux/media.h | 25 +++-- 1 file changed, 15

[PATCH v10 2/4] media: change au0828 to use Media Device Allocator API

2019-01-24 Thread Shuah Khan
can get a reference to it. The media device is released when all the references are released. Change au0828 to use Media Device Allocator API to allocate media device with the parent usb struct device as the key, so it can be shared with the snd_usb_audio driver. Signed-off-by: Shuah Khan

[PATCH v10 1/4] media: Media Device Allocator API

2019-01-24 Thread Shuah Khan
can get a reference to it. The media device is released when all the references are released. Signed-off-by: Shuah Khan --- Documentation/media/kapi/mc-core.rst | 41 drivers/media/Makefile | 4 + drivers/media/media-dev-allocator.c | 144

[PATCH] media: media.h: Fix shifting signed 32-bit value by 31 bits problem

2019-06-13 Thread Shuah Khan
andle this condition safely resulting in undefined behavior. Signed-off-by: Shuah Khan --- include/uapi/linux/media.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h index 9aedb187bc48..383ac7b7d8f0 100644 --- a/includ

Re: [PATCH 0/2] Use Media Dev Allocator to fix vimc dev lifetime bugs

2019-07-03 Thread Shuah Khan
Hi Niklas, Laurent, On 7/3/19 10:17 AM, Niklas Söderlund wrote: Hi Shauah, Laurent, On 2019-06-30 14:41:02 +0300, Laurent Pinchart wrote: Hi Shuah, On Fri, Jun 28, 2019 at 10:41:07AM -0600, Shuah Khan wrote: On 6/16/19 12:45 PM, Laurent Pinchart wrote: On Fri, Jun 14, 2019 at 05:26:46PM

Re: [RFC] Make entity to interface links immutable

2018-07-09 Thread Shuah Khan
Hi Mauro and Hans, On 07/02/2018 03:41 AM, Mauro Carvalho Chehab wrote: > Em Mon, 2 Jul 2018 10:18:37 +0200 > Hans Verkuil escreveu: > >> While working on v4l2-compliance I noticed that entity to interface links >> have just the MEDIA_LNK_FL_ENABLED flag set. >> >> Shouldn't we also set the MEDI

[PATCH v11 0/5] Media Device Allocator API

2019-02-22 Thread Shuah Khan
registering the device based on comments from Hans Verkuil - Carried Reviewed-by tag from Takashi Iwai for the sound from v9. - No changes to Patches 2 and 3. References: https://lkml.org/lkml/2018/11/2/169 https://www.mail-archive.com/linux-media@vger.kernel.org/msg105854.html Shuah Khan (5): medi

[PATCH v11 5/5] au0828: fix enable and disable source audio and video inconsistencies

2019-02-22 Thread Shuah Khan
ation disables it. Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 178 +++-- drivers/media/usb/au0828/au0828.h | 5 +- 2 files changed, 144 insertions(+), 39 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/a

[PATCH v11 4/5] sound/usb: Use Media Controller API to share media resources

2019-02-22 Thread Shuah Khan
snd_usb_hw_free(). If resource is busy, -EBUSY is returned. Media specific cleanup is done in usb_audio_disconnect(). Reviewed-by: Takashi Iwai Signed-off-by: Shuah Khan --- sound/usb/Kconfig| 4 + sound/usb/Makefile | 2 + sound/usb/card.c | 14 ++ sound/usb/card.h

[PATCH v11 3/5] media: media.h: Enable ALSA MEDIA_INTF_T* interface types

2019-02-22 Thread Shuah Khan
Move PCM_CAPTURE, PCM_PLAYBACK, and CONTROL ALSA MEDIA_INTF_T* interface types back into __KERNEL__ scope to get ready for adding ALSA support for these to the media controller. Signed-off-by: Shuah Khan --- include/uapi/linux/media.h | 25 +++-- 1 file changed, 15

[PATCH v11 2/5] media: change au0828 to use Media Device Allocator API

2019-02-22 Thread Shuah Khan
can get a reference to it. The media device is released when all the references are released. Change au0828 to use Media Device Allocator API to allocate media device with the parent usb struct device as the key, so it can be shared with the snd_usb_audio driver. Signed-off-by: Shuah Khan

[PATCH v11 1/5] media: Media Device Allocator API

2019-02-22 Thread Shuah Khan
can get a reference to it. The media device is released when all the references are released. Signed-off-by: Shuah Khan --- Documentation/media/kapi/mc-core.rst | 41 drivers/media/Makefile | 4 + drivers/media/media-dev-allocator.c | 142

[PATCH] au0828: minor fix to a misleading comment in _close()

2019-02-22 Thread Shuah Khan
Fix misleading comment in _close() Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c index 7876c897cc1d..08f566006a1f 100644

[PATCH] media: replace WARN_ON in __media_pipeline_start()

2019-02-22 Thread Shuah Khan
__media_pipeline_start() does WARN_ON() when active pipe doesn't match the input arg entity's pipe. Replace WARN_ON with a conditional and error message that includes names of both entities. Signed-off-by: Shuah Khan --- drivers/media/media-entity.c | 5 - 1 file changed, 4

[PATCH v2] au0828: minor fix to a misleading comment in _close()

2019-02-25 Thread Shuah Khan
Fix a misleading comment in _close() and a spelling error. Reviewed-by: Niklas Söderlund Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb

Re: [Linux-kernel-mentees] [PATCH v2] cec-compliance: system audio control tests

2019-09-03 Thread Shuah Khan
On 9/2/19 10:59 AM, Jiunn Chang wrote: Add user control press operands: - Mute Function - Restore Volume Function Please add more details to the commit message. It would be helpful to know more about the features that are getting added. Signed-off-by: Jiunn Chang --- Changes made since

Re: [Linux-kernel-mentees] [PATCH v6] cec-follower: add tuner analog service emulation

2019-09-20 Thread Shuah Khan
On 9/20/19 1:32 PM, Jiunn Chang wrote: Implement the following tuner control features: - - and reply More information is needed on what this feature does. This commit log to terse. Signed-off-by: Jiunn Chang --- Changes made since v1: - Fix typos/bugs - Import reply_feature_

Re: [ANN] Media sessions in Lyon in October: libcamera

2019-09-23 Thread Shuah Khan
Hristev Shuah Khan Helen Koike Jacopo Mondi Laurent Pinchart Niklas Söderlund Hans Verkuil If I missed someone, or you are on the list but won't attend after all, then please let me know. I would like to join this one to, as after ELCE I should have some time to spend on this. I under

Re: [Linux-kernel-mentees] [PATCH v8] v4l2-ctl: Print UVC meta info

2019-09-24 Thread Shuah Khan
On 9/24/19 5:04 AM, Vandana BN wrote: Print UVC Metadata information in verbose mode. Cam you add more information on what this Metadata is and how it is used. Signed-off-by: Vandana BN --- Changes since v7: Not to call print_meta_buffer, if V4L2_BUF_FLAG_ERROR is set or bytesused i

Re: [Linux-kernel-mentees] [PATCH v8] cec-follower: add tuner analog service emulation

2019-09-24 Thread Shuah Khan
On 9/24/19 6:14 AM, Jiunn Chang wrote: The cec-follower will now emulate an analog service. This allows an initiator device can directly select an analog service by choosing an to select? Something doesn't read right in this sentence. analog broadcast type, broadcast system, and frequency. A

Re: [Linux-kernel-mentees] [PATCH v2 1/2] cec-follower: add tuner step increment/decrement

2019-09-24 Thread Shuah Khan
On 9/24/19 1:24 PM, Jiunn Chang wrote: Tuner step increment/decrement will select the next highest or next lowest service frequency. There are a total of three possible frequencies from analog_freqs_khz given a broadcast type and system. Opcodes implemented: - - Signed-off-by: Jiunn Ch

Re: [Linux-kernel-mentees] [PATCH v2 2/2] cec-compliance: add/refactor tuner control tests

2019-09-24 Thread Shuah Khan
On 9/24/19 1:24 PM, Jiunn Chang wrote: Tests added/refactored for new features added to the cec-follower. Analog tuner control tests added/refactored: - give analog tuner status - select tuner analog service - analog tuner step decrement - analog tuner step increment Signed-off-by:

Re: [PATCH 1/5] media: vimc: upon streaming, check that the pipeline starts with a source entity

2019-09-26 Thread Shuah Khan
On 9/19/19 2:32 PM, Dafna Hirschfeld wrote: Userspace can disable links and create pipelines that do not start with a source entity. Trying to stream from such a pipeline should fail with -EPIPE currently this is not handled and cause kernel crash. Minor: Can you make these 75 long. Makes it e

Re: [PATCH 2/5] docs: media: vimc: Documenting vimc topology configuration using configfs

2019-09-26 Thread Shuah Khan
On 9/19/19 2:32 PM, Dafna Hirschfeld wrote: Add explanation of how to use configfs in order to create a vimc device with a given topology. Can you add more detail on the problem configfs solves and what value it adds. Signed-off-by: Dafna Hirschfeld --- Documentation/media/v4l-drivers/vim

Re: [PATCH 3/5] media: vimc: Add the implementation for the configfs api

2019-09-26 Thread Shuah Khan
On 9/19/19 2:32 PM, Dafna Hirschfeld wrote: Add the code that implements the usage of configfs in order to create and configure a device topology from userspace. The code is only added in this patch but is not used. It will be used in next patch in the series. This somehow doesn't read right.

Re: [PATCH 4/5] media: vimc: use configfs instead of having hardcoded configuration

2019-09-26 Thread Shuah Khan
On 9/19/19 2:32 PM, Dafna Hirschfeld wrote: Use configfs in order to create a device and set its topology and remove the hardcoded device. Signed-off-by: Helen Koike [refactored for upstream] What does this mean? Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-captur

Re: [Linux-kernel-mentees] [PATCH v2 1/2] v4l2-core: Add new metadata format

2019-10-03 Thread Shuah Khan
On 10/3/19 5:08 AM, Vandana BN wrote: Add new metadata format to support metadata output in vivid. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l

Re: [Linux-kernel-mentees] [PATCH v2 2/2] vivid: Add metadata output support

2019-10-03 Thread Shuah Khan
On 10/3/19 5:08 AM, Vandana BN wrote: Support metadata output in vivid driver. Metadata output is used to set brightness, contrast, saturation and hue. Adds new files for metadata output. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/plat

Re: [PATCH RFC] [media] Postpone the addition of MEDIA_IOC_G_TOPOLOGY

2015-12-28 Thread Shuah Khan
_IOWR('|', 0x01, struct > media_entity_desc) > #define MEDIA_IOC_ENUM_LINKS _IOWR('|', 0x02, struct > media_links_enum) > #define MEDIA_IOC_SETUP_LINK _IOWR('|', 0x03, struct media_link_desc) > + > +#if 0 /* Let's postpone

Re: [PATCH RFC] [media] Postpone the addition of MEDIA_IOC_G_TOPOLOGY

2015-12-28 Thread Shuah Khan
On 12/28/2015 08:44 AM, Greg KH wrote: > On Mon, Dec 28, 2015 at 08:37:19AM -0700, Shuah Khan wrote: >> On 12/28/2015 07:03 AM, Mauro Carvalho Chehab wrote: >>> There are a few discussions left with regards to this ioctl: >>> >>> 1) the name of the new st

[PATCH 00/31] Sharing media resources across ALSA and au0828 drivers

2016-01-06 Thread Shuah Khan
html Mauro Carvalho Chehab (1): uapi/media.h: Declare interface types for ALSA Shuah Khan (30): media: Add ALSA Media Controller function entities media: Media Controller register/unregister entity_notify API media: Media Controller enable/disable source handler API media: Media Controller

[PATCH 01/31] uapi/media.h: Declare interface types for ALSA

2016-01-06 Thread Shuah Khan
From: Mauro Carvalho Chehab Declare the interface types to be used on alsa for the new G_TOPOLOGY ioctl. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/media-entity.c | 12 include/uapi/linux/media.h | 8 2 files changed, 20 insertions(+) diff --git a/drivers/

[PATCH 03/31] media: Media Controller register/unregister entity_notify API

2016-01-06 Thread Shuah Khan
-by: Shuah Khan --- drivers/media/media-device.c | 61 include/media/media-device.h | 25 ++ 2 files changed, 86 insertions(+) diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index b786b10..20c85a9 100644 --- a

[PATCH 08/31] media: v4l-core add v4l_enable/disable_media_tuner() helper functions

2016-01-06 Thread Shuah Khan
is activated and pipeline is started. The disable_source helper function invokes the disable_source handler to deactivate and stop the pipeline. Signed-off-by: Shuah Khan --- drivers/media/v4l2-core/v4l2-dev.c | 27 +++ include/media/v4l2-dev.h | 4 2 files

[PATCH 02/31] media: Add ALSA Media Controller function entities

2016-01-06 Thread Shuah Khan
Add ALSA Media Controller capture, playback, and mixer function entity defines. Signed-off-by: Shuah Khan --- include/uapi/linux/media.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h index 75cbe92..53a96ae

[PATCH 05/31] media: Media Controller fix to not let stream_count go negative

2016-01-06 Thread Shuah Khan
ine interface. Signed-off-by: Shuah Khan --- drivers/media/media-entity.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index 6e02d19..78486a9 100644 --- a/drivers/media/media-entity.c +++ b/driv

[PATCH 07/31] media: Media Controller non-locking __media_entity_pipeline_start/stop()

2016-01-06 Thread Shuah Khan
__media_entity_pipeline_stop() holding the graph_lock. Signed-off-by: Shuah Khan --- drivers/media/media-entity.c | 34 -- include/media/media-entity.h | 12 2 files changed, 36 insertions(+), 10 deletions(-) diff --git a/drivers/media/media-entity.c b/drivers/media/media

[PATCH 06/31] media: Media Controller export non locking __media_entity_setup_link()

2016-01-06 Thread Shuah Khan
Export __media_entity_setup_link() to be used from code paths that hold the graph_mutex. Signed-off-by: Shuah Khan --- drivers/media/media-entity.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index 78486a9..b8769aa 100644 --- a

[PATCH 18/31] media: au0828 change to use Managed Media Controller API

2016-01-06 Thread Shuah Khan
. Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 44 +- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c index 8ef7c71..1f97fc0 100644 --- a/drivers

[PATCH 23/31] media: au0828 implement enable_source and disable_source handlers

2016-01-06 Thread Shuah Khan
Implements enable_source and disable_source handlers for other drivers (v4l2-core, dvb-core, and ALSA) to use to check for tuner connected to the decoder and activate the link if tuner is free, and deactivate and free the tuner when it is no longer needed. Signed-off-by: Shuah Khan --- drivers

[PATCH 22/31] media: dvb-core create tuner to demod pad link in disabled state

2016-01-06 Thread Shuah Khan
Create tuner to demod pad link in disabled state to help avoid disable step when tuner resource is requested by video or audio. Signed-off-by: Shuah Khan --- drivers/media/dvb-core/dvbdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvbdev.c b

[PATCH 19/31] media: au0828 handle media_init and media_register window

2016-01-06 Thread Shuah Khan
. Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c index 1f97fc0..6ef177c 100644 --- a/drivers/media

[PATCH 24/31] media: au0828 fix null pointer reference in au0828_create_media_graph()

2016-01-06 Thread Shuah Khan
[snd_usb_audio] [ 69.006247] [] snd_usb_pcm_open+0xcd0/0x1280 [snd_usb_audio] Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828

[PATCH 09/31] media: v4l2-core add v4l_vb2q_enable_media_tuner() helper

2016-01-06 Thread Shuah Khan
eamon(). This function simply calls v4l_enable_media_tuner() passing in the pointer to struct video_device. Signed-off-by: Shuah Khan --- drivers/media/v4l2-core/v4l2-dev.c | 21 + include/media/v4l2-dev.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/

[PATCH 12/31] media: au0828 Use au8522_media_pads enum for pad defines

2016-01-06 Thread Shuah Khan
Change au0828-core to use au8522_media_pads enum defines instead of hard-coding the pad values when it creates media graph linking decode pads to other entities. Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

[PATCH 17/31] media: au0828 video change to use v4l_enable_media_tuner()

2016-01-06 Thread Shuah Khan
ering down to save energy. Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-video.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c index 32bcc56..ed3ba05 100644

[PATCH 10/31] media: Move au8522_media_pads enum to au8522.h from au8522_priv.h

2016-01-06 Thread Shuah Khan
Move the au8522_media_pads enum to au8522.h from au8522_priv.h. This will allow au0828-core to use these defines instead of hard-coding the pad values when it creates media graph linking decode pads to other entities. Signed-off-by: Shuah Khan --- drivers/media/dvb-frontends/au8522.h | 7

[PATCH 21/31] media: au0828 create tuner to decoder link in deactivated state

2016-01-06 Thread Shuah Khan
Create tuner to demod pad link in disabled state to help avoid disable step when tuner resource is requested by dvb. Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/au0828/au0828

[PATCH 20/31] media: au0828 change to register/unregister entity_notify hook

2016-01-06 Thread Shuah Khan
added, it has to maintain state on the links it already created. New fields are added to au0828_dev to keep this state information. entity_notify gets unregistered before media_device unregister. Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 104

[PATCH 13/31] media: au0828 fix au0828_create_media_graph() entity checks

2016-01-06 Thread Shuah Khan
.mdev field before creating pad links. Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c index f4

[PATCH 16/31] media: au0828 video remove au0828_enable_analog_tuner()

2016-01-06 Thread Shuah Khan
au0828_enable_analog_tuner() is no longer needed with v4l2-core and au0828-video invoking enable_source and disable_source handlers. In addition, it is unnecessary to check for tuner availability in queue_setup() as v4l2-core handles the tuner availability checks. Signed-off-by: Shuah Khan

[PATCH 15/31] media: dvb-frontend invoke enable/disable_source handlers

2016-01-06 Thread Shuah Khan
longer necessary with dvb invoking enable_source and disable_source handlers. pipe_start_entity field is removed and pipe field is moved to dvb_frontend from dvb_frontend_private. Signed-off-by: Shuah Khan --- drivers/media/dvb-core/dvb_frontend.c | 139 +- drivers

[PATCH 14/31] media: Change v4l-core to check for tuner availability

2016-01-06 Thread Shuah Khan
_exit() to release the tuner. vb2_core_streamon() uses v4l_vb2q_enable_media_tuner(). Signed-off-by: Shuah Khan --- drivers/media/v4l2-core/v4l2-fh.c| 1 + drivers/media/v4l2-core/v4l2-ioctl.c | 29 + drivers/media/v4l2-core/videobuf2-core.c | 4 3

[PATCH 04/31] media: Media Controller enable/disable source handler API

2016-01-06 Thread Shuah Khan
device. Signed-off-by: Shuah Khan --- include/media/media-device.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/media/media-device.h b/include/media/media-device.h index 6520d1c..04b6c2e 100644 --- a/include/media/media-device.h +++ b/include/media/media-device.h

[PATCH 28/31] media: au0828 create link between ALSA Mixer and decoder

2016-01-06 Thread Shuah Khan
Change au0828_create_media_graph() to create pad link between MEDIA_ENT_F_AUDIO_MIXER entity and decoder's AU8522_PAD_AUDIO_OUT. With mixer entity now linked to decoder, change to link MEDIA_ENT_F_AUDIO_CAPTURE to mixer's source pad. Signed-off-by: Shuah Khan --- drivers/media/usb/au0

[PATCH 11/31] media: au8522 change to create MC pad for ALSA Audio Out

2016-01-06 Thread Shuah Khan
Add new pad for ALSA Audio Out to au8522_media_pads. Signed-off-by: Shuah Khan --- drivers/media/dvb-frontends/au8522.h | 1 + drivers/media/dvb-frontends/au8522_decoder.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/dvb-frontends/au8522.h b/drivers/media/dvb

[PATCH 29/31] media: track media device unregister in progress

2016-01-06 Thread Shuah Khan
: Shuah Khan --- drivers/media/media-device.c | 5 - include/media/media-device.h | 17 + 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index 20c85a9..1bb9a5f 100644 --- a/drivers/media/media-device.c

[PATCH 30/31] sound/usb: Check media device unregister progress state

2016-01-06 Thread Shuah Khan
care of all of this. This fixes the the general protection faults while snd-usb-audio was cleaning up media resources for pcm streams and mixers. Signed-off-by: Shuah Khan --- sound/usb/card.c | 8 ++-- sound/usb/media.c | 41 +++-- sound/usb/media.h

[PATCH 31/31] media: au0828 change to check media device unregister progress state

2016-01-06 Thread Shuah Khan
Change au0828_unregister_media_device() to check media device media device unregister is in progress and avoid calling media_device_unregister() and other cleanup done in au0828_unregister_media_device(). Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 4 +++- 1 file

[PATCH 25/31] media: au0828 fix to not call media_device_unregister_entity_notify()

2016-01-06 Thread Shuah Khan
entity_notify handlers are removed from media_device_unregister(). There is no need to call media_device_unregister_entity_notify() to do that right before calling media_device_unregister(). Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 2 -- 1 file changed, 2 deletions

[PATCH 26/31] sound/usb: Update ALSA driver to use Managed Media Controller API

2016-01-06 Thread Shuah Khan
). Signed-off-by: Shuah Khan --- sound/usb/Makefile | 15 +++- sound/usb/card.c | 7 ++ sound/usb/card.h | 1 + sound/usb/media.c| 214 +++ sound/usb/media.h| 54 sound/usb/pcm.c | 26 +++

[PATCH 27/31] sound/usb: Create media mixer function and control interface entities

2016-01-06 Thread Shuah Khan
Add support for creating MEDIA_ENT_F_AUDIO_MIXER entity for each mixer and a MEDIA_INTF_T_ALSA_CONTROL control interface entity that links to mixer entities. MEDIA_INTF_T_ALSA_CONTROL entity corresponds to the control device for the card. Signed-off-by: Shuah Khan --- sound/usb/card.c | 5

[PATCH] v4l-utils: mc_nextgen_test renable ALSA interfaces

2016-01-06 Thread Shuah Khan
ALSA interfaces were disable with #if 0. Renable them. Signed-off-by: Shuah Khan --- contrib/test/mc_nextgen_test.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/contrib/test/mc_nextgen_test.c b/contrib/test/mc_nextgen_test.c index 14a0917..7d0344b 100644 --- a/contrib/test

[PATCH RESEND] v4l-utils: mc_nextgen_test add ALSA capture, playback, and mixer

2016-01-06 Thread Shuah Khan
Add support for ALSA capture, playback, and mixer entity functions. Signed-off-by: Shuah Khan --- contrib/test/mc_nextgen_test.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/contrib/test/mc_nextgen_test.c b/contrib/test/mc_nextgen_test.c index e287096..e0d0ad2 100644 --- a/contrib

[PATCH v5 22/22] sound/usb: Use Media Controller API to share media resources

2016-03-02 Thread Shuah Khan
usb_audio_disconnect(). Signed-off-by: Shuah Khan Acked-by: Takashi Iwai --- Changes since v4: 1. Renamed media_* interfaces in sound/usb to media_snd* to avoid potential conflicts with the MC interfaces. This addresses Laurent Pinchart's comment. 2. Added Acked-by from Takashi Iwai soun

Re: [PATCH v4 22/22] sound/usb: Use Media Controller API to share media resources

2016-03-02 Thread Shuah Khan
{ return 0; } >> +static inline void media_stream_delete(struct snd_usb_substream *subs) { } >> +static inline int media_start_pipeline(struct snd_usb_substream *subs) >> +{ return 0; } >> +static inlin

Re: [RFC] Representing hardware connections via MC

2016-03-02 Thread Shuah Khan
signal. It corresponds to the logical input or output > + associated with the a single signal that carries both > + chrominance and luminance information (Y+C). > > > MEDIA_ENT_F_CAM_SENSOR Finally caught up with

Re: [PATCH v5 22/22] sound/usb: Use Media Controller API to share media resources

2016-03-02 Thread Shuah Khan
On 03/02/2016 01:41 PM, Dan Carpenter wrote: > On Wed, Mar 02, 2016 at 09:50:31AM -0700, Shuah Khan wrote: >> +mctl = kzalloc(sizeof(*mctl), GFP_KERNEL); >> +if (!mctl) >> +return -ENOMEM; >> + >> +mctl->media_dev = mdev; >> +

[PATCH] media: au0828 audio mixer isn't connected to decoder

2016-03-02 Thread Shuah Khan
were created prior to registering the notify handler. Signed-off-by: Shuah Khan Reported-by: Mauro Carvalho Chehab --- Tested by black listing au0828 to force snd_usb_audio to load first and then modprobe au0828. Generated graphs to verify audio graph is connected to the au0828 graph. drivers/medi

Re: [PATCH v5 22/22] sound/usb: Use Media Controller API to share media resources

2016-03-03 Thread Shuah Khan
On 03/03/2016 03:36 AM, Dan Carpenter wrote: > On Wed, Mar 02, 2016 at 03:57:03PM -0700, Shuah Khan wrote: >> On 03/02/2016 01:41 PM, Dan Carpenter wrote: >>> On Wed, Mar 02, 2016 at 09:50:31AM -0700, Shuah Khan wrote: >>>> + mctl = kzalloc(sizeof(*mctl),

Re: [PATCH v3 02/22] uapi/media.h: Declare interface types for ALSA

2016-03-03 Thread Shuah Khan
On 03/03/2016 07:59 AM, Hans Verkuil wrote: > On 02/12/16 00:41, Shuah Khan wrote: >> Declare the interface types to be used on alsa for >> the new G_TOPOLOGY ioctl. >> >> Signed-off-by: Shuah Khan >> --- >> drivers/media/media-entity.c | 16 +++

[PATCH] sound/usb: Use meaninful names for goto labels

2016-03-03 Thread Shuah Khan
Fix to use meaningful names instead of numbered goto labels Signed-off-by: Shuah Khan --- sound/usb/media.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/usb/media.c b/sound/usb/media.c index b87d5b3..ab6a642 100644 --- a/sound/usb/media.c +++ b

Re: [PATCH v5 22/22] sound/usb: Use Media Controller API to share media resources

2016-03-03 Thread Shuah Khan
On 03/03/2016 11:21 AM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Mar 2016 15:57:03 -0700 > Shuah Khan escreveu: > >> On 03/02/2016 01:41 PM, Dan Carpenter wrote: >>> On Wed, Mar 02, 2016 at 09:50:31AM -0700, Shuah Khan wrote: >>>> + mctl = kzalloc(sizeof(*m

Re: [PATCH v3 13/22] media: Change v4l-core to check if source is free

2016-03-03 Thread Shuah Khan
v4l2-mc.c @@ -214,6 +214,8 @@ int v4l_vb2q_enable_media_source(struct vb2_queue *q) { struct v4l2_fh *fh = q->owner; - return v4l_enable_media_source(fh->vdev); + if (fh && fh->vdev) + return v4l_enable_media_source(fh->vdev); + return 0

Re: [PATCH v3 13/22] media: Change v4l-core to check if source is free

2016-03-03 Thread Shuah Khan
On 03/03/2016 02:18 PM, Shuah Khan wrote: > On 03/03/2016 01:39 PM, Olli Salonen wrote: >> Hello Shuah, >> >> This patch seems to cause issues with my setup. Basically, when I try >> to tune to a channel, I get an oops. I'm using TechnoTrend CT2-4650 >> PCIe D

Re: [PATCH v3 03/22] [media] Docbook: media-types.xml: Add Audio Function Entities

2016-03-03 Thread Shuah Khan
On 02/28/2016 07:46 PM, Laurent Pinchart wrote: > Hi Shuah, > > Thank you for the patch. > > On Thursday 11 February 2016 16:41:19 Shuah Khan wrote: >> Add Audio Function Entities >> >> Signed-off-by: Shuah Khan >> --- >> Documentation/DocBook/medi

[PATCH] media: add prefixes to interface types

2016-03-03 Thread Shuah Khan
Add missing prefixes for DVB, V4L, and ALSA interface types. Signed-off-by: Shuah Khan --- drivers/media/media-entity.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index

[PATCH] media: fix null pointer dereference in v4l_vb2q_enable_media_source()

2016-03-03 Thread Shuah Khan
eodev] [ 548.460792] PGD b820e067 PUD bb3df067 PMD 0 [ 548.465582] Oops: [#1] SMP Signed-off-by: Shuah Khan Reported-by: Olli Salonen --- drivers/media/v4l2-core/v4l2-mc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2

Re: [PATCH] media: add prefixes to interface types

2016-03-04 Thread Shuah Khan
Hi Hans, Thanks for the review. Mauro, Do you prefer dvb-conditional-access or dvb-ca? thanks, -- Shuah On 03/04/2016 01:25 AM, Hans Verkuil wrote: > > > On 03/04/2016 01:08 AM, Shuah Khan wrote: >> Add missing prefixes for DVB, V4L, and ALSA interface types. >> >>

[PATCH v2] media: add prefixes to interface types

2016-03-04 Thread Shuah Khan
Add missing prefixes for DVB, V4L, and ALSA interface types. Signed-off-by: Shuah Khan --- Changes since v1: Addresses Hans's comments on v1 drivers/media/media-entity.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/

Re: [PATCH] [media] hide unused functions for !MEDIA_CONTROLLER

2016-03-04 Thread Shuah Khan
a_device *mdev = entity->graph_obj.mdev; > struct au0828_dev *dev; > @@ -453,8 +449,8 @@ static void au0828_disable_source(struct media_entity > *entity) > > end: > mutex_unlock(&mdev->graph_mutex); > -#endif > } > +#endif > > static int au0828_media_

Re: [PATCH v5 22/22] sound/usb: Use Media Controller API to share media resources

2016-03-07 Thread Shuah Khan
On 03/05/2016 03:00 AM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Mar 2016 09:50:31 -0700 > Shuah Khan escreveu: > >> Change ALSA driver to use Media Controller API to >> share media resources with DVB and V4L2 drivers >> on a AU0828 media device. Media Controller sp

Re: [PATCH v5 22/22] sound/usb: Use Media Controller API to share media resources

2016-03-07 Thread Shuah Khan
On 03/07/2016 07:16 AM, Shuah Khan wrote: > On 03/05/2016 03:00 AM, Mauro Carvalho Chehab wrote: >> Em Wed, 2 Mar 2016 09:50:31 -0700 >> Shuah Khan escreveu: >> >>> Change ALSA driver to use Media Controller API to >>> share media resources with DVB and V4

Re: [PATCH v5 22/22] sound/usb: Use Media Controller API to share media resources

2016-03-07 Thread Shuah Khan
On 03/05/2016 03:00 AM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Mar 2016 09:50:31 -0700 > Shuah Khan escreveu: > >> Change ALSA driver to use Media Controller API to >> share media resources with DVB and V4L2 drivers >> on a AU0828 media device. Media Controller sp

Re: [PATCH v5 22/22] sound/usb: Use Media Controller API to share media resources

2016-03-07 Thread Shuah Khan
On 03/05/2016 03:00 AM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Mar 2016 09:50:31 -0700 > Shuah Khan escreveu: > >> Change ALSA driver to use Media Controller API to >> share media resources with DVB and V4L2 drivers >> on a AU0828 media device. Media Controller sp

  1   2   3   4   5   6   7   >