[PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function

Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared on software reset. These bits need to be cleared explicitly. Signed-off-by: Tony K Nadackal --- This patch is created and tested on top of linux-next-20141210. It can be cleanly applied on media-next and kgene/for-next. drivers

[PATCH] [media] s5p-jpeg: Fix crash in jpeg isr due to multiple interrupts.

/0x3bc Code: 94045c34 f9406e60 97ffdc74 aa0003f4 (f9406400) ---[ end trace fa6dc0ea2efad21f ]--- Kernel panic - not syncing: Fatal exception in interrupt ---[ end Kernel panic - not syncing: Fatal exception in interrupt Signed-off-by: Tony K Nadackal --- This patch is created and tested on top of

[PATCH] [media] s5p-jpeg: Initialize cb and cr to zero.

To avoid garbage value written into image base address planes, initialize cb and cr of structure s5p_jpeg_addr to zero. Signed-off-by: Tony K Nadackal --- This patch is created and tested on top of linux-next-20141210. It can be cleanly applied on media-next and kgene/for-next. drivers/media

[PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

Fimp_jpeg used in Exynos7 is a revised version. Some register configurations are slightly different from Jpeg in Exynos4. Added one more variant SJPEG_EXYNOS7 to handle these differences. Signed-off-by: Tony K Nadackal --- This patch is created and tested on top of linux-next-20141210. It can be

RE: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

[snip] > > -void exynos4_jpeg_set_interrupt(void __iomem *base) > > +void exynos4_jpeg_set_interrupt(void __iomem *base, unsigned int > > +version) > > { > > - writel(EXYNOS4_INT_EN_ALL, base + EXYNOS4_INT_EN_REG); > > + unsigned int reg; > > + > > + reg = readl(base + EXYNOS4_INT_EN_REG) & > ~EXYNOS4_INT_EN_MASK(version); > > + writel(EXYNOS4_INT_EN_ALL(version), base + EXYNOS4_INT_EN_REG); > > } > > I believe that adding readl is a fix. I'd enclose it into separate patch and explain its > merit. > Thanks for the suggestion. I will make a separate patch for this bug fix. [snip] > > -- > Best Regards, > Jacek Anaszewski Thanks, Tony K Nadackal -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/2] [media] s5p-jpeg: Adding Exynos7 JPEG variant

Fimp_jpeg used in Exynos7 is a revised version. Some register configurations are slightly different from JPEG in Exynos4. Added one more variant SJPEG_EXYNOS7 to handle these differences. Signed-off-by: Tony K Nadackal --- .../bindings/media/exynos-jpeg-codec.txt | 2 +- drivers

[PATCH v2 1/2] [media] s5p-jpeg: Fix modification sequence of interrupt enable register

Fix the bug in modifying the interrupt enable register. Signed-off-by: Tony K Nadackal --- drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/s5p

[PATCH v2 0/2] Adding support for Exynos7 Jpeg variant

macros into enum as suggested by Jacek Anaszewski. Tony K Nadackal (2): [media] s5p-jpeg: Fix modification sequence of interrupt enable register [media] s5p-jpeg: Adding Exynos7 Jpeg variant .../bindings/media/exynos-jpeg-codec.txt | 2 +- drivers/media/platform/s5p-jpeg/jpeg

RE: [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function

Gentle Reminder. Thanks Tony > -Original Message- > From: Tony K Nadackal [mailto:tony...@samsung.com] > Sent: Wednesday, December 17, 2014 11:52 AM > To: linux-media@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > samsung-...@vger.kernel.org > Cc: mche.

RE: [PATCH] [media] s5p-jpeg: Fix crash in jpeg isr due to multiple interrupts.

Gentle Reminder. Thanks Tony > -Original Message- > From: Tony K Nadackal [mailto:tony...@samsung.com] > Sent: Wednesday, December 17, 2014 11:55 AM > To: linux-media@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > samsung-...@vger.kernel.org > Cc: mche.

RE: [PATCH] [media] s5p-jpeg: Initialize cb and cr to zero.

Gentle Reminder. Thanks, Tony > -Original Message- > From: Tony K Nadackal [mailto:tony...@samsung.com] > Sent: Wednesday, December 17, 2014 12:51 PM > To: linux-media@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > samsung-...@vger.kernel

RE: [PATCH v2 0/2] Adding support for Exynos7 Jpeg variant

Gentle Reminder. Thanks, Tony > -Original Message- > From: Tony K Nadackal [mailto:tony...@samsung.com] > Sent: Friday, December 19, 2014 1:08 PM > To: linux-media@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > samsung-...@vger.kernel.org; devicet...@vger.

RE: [PATCH v2 2/2] [media] s5p-jpeg: Adding Exynos7 JPEG variant

Hi Jacek, On Wednesday, January 07, 2015 3:43 PM : Jacek Anaszewski wrote, > Hi Tony, > > On 12/19/2014 08:38 AM, Tony K Nadackal wrote: > > Fimp_jpeg used in Exynos7 is a revised version. Some register > > configurations are slightly different from JPEG in Exynos4. >

RE: [PATCH v2 1/2] [media] s5p-jpeg: Fix modification sequence of interrupt enable register

Hi Jacek, On Wednesday, January 07, 2015 3:38 PM Jacek Anaszewski wrote, > Hi Tony, > > On 12/19/2014 08:37 AM, Tony K Nadackal wrote: > > Fix the bug in modifying the interrupt enable register. > > For Exynos4 this was not a bug as there are only five b

RE: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

Dear Jacek, On Wednesday, January 07, 2015 3:15 PM Jacek Anaszewski wrote, > Hi Tony, > > Sorry for late response, just got back from vacation. > > On 12/19/2014 04:37 AM, Tony K Nadackal wrote: > > Hi Jacek, > > > > On Wednesday, December 17, 2014 7:46 PM Jac

RE: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

Hi Kukjin, On Wednesday, January 07, 2015 6:09 PM, Jacek Anaszewski wrote, > Hi Tony, > > On 01/07/2015 01:08 PM, Tony K Nadackal wrote: > > Dear Jacek, > > > > On Wednesday, January 07, 2015 3:15 PM Jacek Anaszewski wrote, > > > >> Hi Tony, > >&g