Re: [PATCH V3 3/3] mfd: palmas: Add support for optional wakeup

2014-10-01 Thread Tony Lindgren
Hi Thomas, * Thomas Gleixner [140919 12:47]: > > The wakeup handler is supposed to bring the thing out of deep sleep > and nothing else. All you want it to do is to mask itself and save the > information that the real device irq is pending. > > A stub handler for the wakeup irq is enough. We ca

Re: 3.17-rc6 on ODROID: ERROR: Bad of_node_put() on /ehci@12580000/port@1

2014-10-01 Thread Sid Boyce
3.17-rc7 boots on ODROID-U3 Ubuntu 14.04. I deleted references to of_node_put in drivers/usb/host/ehci-exynos.c as recommended. # make exynos_defconfig # make menuconfig root@odroidu3:/b2/linux-3.17.0-rc7# grep DTB .config CONFIG_ARM_APPENDED_DTB=y CONFIG_ARM_ATAG_DTB_COMPAT=y CONFIG_ARM_ATAG_D

Re: [PATCH] regmap: Allow read_reg_mask to be 0

2014-10-01 Thread Lars-Peter Clausen
On 10/01/2014 01:39 PM, Dan Murphy wrote: Lars On 09/30/2014 04:29 PM, Lars-Peter Clausen wrote: On 09/30/2014 11:18 PM, Dan Murphy wrote: Lars On 09/30/2014 04:03 PM, Lars-Peter Clausen wrote: On 09/30/2014 06:07 PM, Dan Murphy wrote: There may be spi devices that do not require a register

Re: [PATCH 12/17] iommu/omap: Integrate omap-iommu-debug into omap-iommu

2014-10-01 Thread Suman Anna
Hi Laurent, > On Tuesday 30 September 2014 16:16:07 Suman Anna wrote: >> The debugfs support for OMAP IOMMU is currently implemented >> as a module, warranting certain OMAP-specific IOMMU API to >> be exported. The OMAP IOMMU, when enabled, can only be built-in >> into the kernel, so integrate the

Re: [PATCH 09/13] dmaengine: edma: check for echan->edesc => NULL in edma_dma_pause()

2014-10-01 Thread Peter Ujfalusi
On 09/29/2014 09:06 PM, Sebastian Andrzej Siewior wrote: > I added book keeping of whether or not the 8250-dma driver has an RX > transfer pending or not so we don't BUG here if it calls > dmaengine_pause() on a channel which has not a pending transfer. Guess > what, this is not enough. > The follo

Re: [PATCH] regmap: Allow read_reg_mask to be 0

2014-10-01 Thread Dan Murphy
Lars On 09/30/2014 04:29 PM, Lars-Peter Clausen wrote: > On 09/30/2014 11:18 PM, Dan Murphy wrote: >> Lars >> >> On 09/30/2014 04:03 PM, Lars-Peter Clausen wrote: >>> On 09/30/2014 06:07 PM, Dan Murphy wrote: There may be spi devices that do not require a register read mask to read the r

[PATCH 0/2] mtd: nand: omap: Fix build with CONFIG_MTD_NAND_OMAP_BCH=m

2014-10-01 Thread Roger Quadros
Hi, Patch 1 fixes build with OMAP nand driver as built-in and the BCH driver as a module. Ezequiel, I took the liberty to address an issue with your original patch so this is v2. Patch 2 fixes the help message for CONFIG_MTD_NAND_OMAP_BCH to avoid user confusion. CONFIG_MTD_NAND_OMAP_BCH is op

[PATCH 2/2] mtd: nand: omap: Correct CONFIG_MTD_NAND_OMAP_BCH help message

2014-10-01 Thread Roger Quadros
The MTD_NAND_OMAP_BCH doesn't harm on legacy OMAP platforms so don't state that it should be disabled for them. Signed-off-by: Roger Quadros --- drivers/mtd/nand/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index

[PATCH v2 1/2] mtd: nand: Force omap_elm to be built as a module if omap2_nand is a module

2014-10-01 Thread Roger Quadros
From: Ezequiel Garcia This commit adds a hidden option to build the omap_elm as a module, if omap2_nand is a module (and similarly in the built-in case). This fixes the following build error when omap2_nand is chosen built-in, and omap_elm is chosen as a module: drivers/built-in.o: In function

Re: [PATCH] regmap: Allow read_reg_mask to be 0

2014-10-01 Thread Mark Brown
On Tue, Sep 30, 2014 at 11:29:34PM +0200, Lars-Peter Clausen wrote: > On 09/30/2014 11:18 PM, Dan Murphy wrote: Dan, please fix your mail client to word wrap within paragraphs. > >The device, which is already in production, has a specific control register > >that sets either the reading or writi

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Marc Kleine-Budde
On 10/01/2014 12:43 PM, Wolfram Sang wrote: > compatible = "commodore,c64ultra", "bosch,d_can"; \o/ -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Wolfram Sang
> Is it OK to create a new platform_data structure for CAN and put the type and > raminit start/stop > bits there? I'd say yes, don't see a reason not to. signature.asc Description: Digital signature

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Marc Kleine-Budde
On 10/01/2014 12:57 PM, Roger Quadros wrote: >>> ...if we just have the instance parameter in the syscon phandle, we have >>> to put the mapping into the driver, which makes IMHO no sense, because >>> you have to touch the driver, if there is another SoC with the DCAN core. > > My guess is that TI

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Roger Quadros
On 10/01/2014 01:43 PM, Wolfram Sang wrote: > >>> Unfortunately it is 5 ;) >>> We have display IP related bit in between 3 and 5 :P >> >> What on earth were the HW engineers thinking > > "Let's test my RNG on the bit-placement of this register" :) :D > >> ...if we just have the ins

Re: [PATCH 12/17] iommu/omap: Integrate omap-iommu-debug into omap-iommu

2014-10-01 Thread Laurent Pinchart
Hi Suman, Thank you for the patch. On Tuesday 30 September 2014 16:16:07 Suman Anna wrote: > The debugfs support for OMAP IOMMU is currently implemented > as a module, warranting certain OMAP-specific IOMMU API to > be exported. The OMAP IOMMU, when enabled, can only be built-in > into the kernel

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Wolfram Sang
> > Unfortunately it is 5 ;) > > We have display IP related bit in between 3 and 5 :P > > What on earth were the HW engineers thinking "Let's test my RNG on the bit-placement of this register" :) > ...if we just have the instance parameter in the syscon phandle, we have > to put the

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Marc Kleine-Budde
On 10/01/2014 12:12 PM, Roger Quadros wrote: > On 10/01/2014 01:01 PM, Marc Kleine-Budde wrote: >> On 10/01/2014 11:06 AM, Roger Quadros wrote: >>> On 10/01/2014 11:47 AM, Marc Kleine-Budde wrote: On 10/01/2014 10:45 AM, Roger Quadros wrote: > On 09/30/2014 07:04 PM, Marc Kleine-Budde wrot

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Roger Quadros
On 10/01/2014 01:01 PM, Marc Kleine-Budde wrote: > On 10/01/2014 11:06 AM, Roger Quadros wrote: >> On 10/01/2014 11:47 AM, Marc Kleine-Budde wrote: >>> On 10/01/2014 10:45 AM, Roger Quadros wrote: On 09/30/2014 07:04 PM, Marc Kleine-Budde wrote: > On 09/30/2014 05:25 PM, Wolfram Sang wrote

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Marc Kleine-Budde
On 10/01/2014 11:06 AM, Roger Quadros wrote: > On 10/01/2014 11:47 AM, Marc Kleine-Budde wrote: >> On 10/01/2014 10:45 AM, Roger Quadros wrote: >>> On 09/30/2014 07:04 PM, Marc Kleine-Budde wrote: On 09/30/2014 05:25 PM, Wolfram Sang wrote: > >> Yes, but syscon_regmap_lookup_by_phandle

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Roger Quadros
On 10/01/2014 11:47 AM, Marc Kleine-Budde wrote: > On 10/01/2014 10:45 AM, Roger Quadros wrote: >> On 09/30/2014 07:04 PM, Marc Kleine-Budde wrote: >>> On 09/30/2014 05:25 PM, Wolfram Sang wrote: > Yes, but syscon_regmap_lookup_by_phandle() doesn't need any support for > additional par

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Marc Kleine-Budde
On 10/01/2014 10:45 AM, Roger Quadros wrote: > On 09/30/2014 07:04 PM, Marc Kleine-Budde wrote: >> On 09/30/2014 05:25 PM, Wolfram Sang wrote: >>> Yes, but syscon_regmap_lookup_by_phandle() doesn't need any support for additional parameters. Have a look at: drivers/net/ethernet/

Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism

2014-10-01 Thread Roger Quadros
On 09/30/2014 07:04 PM, Marc Kleine-Budde wrote: > On 09/30/2014 05:25 PM, Wolfram Sang wrote: >> >>> Yes, but syscon_regmap_lookup_by_phandle() doesn't need any support for >>> additional parameters. Have a look at: >>> >>> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c >>> >>> First get the