Re: [PATCH v2 2/3] gpio: twl4030: Cache the direction and output states in private data

2012-12-19 Thread Grant Likely
On Wed, 19 Dec 2012 21:53:23 +0100, Michael Trimarchi wrote: > Hi > > Grant Likely wrote: > > >On Thu, 6 Dec 2012 11:52:06 +0100, Peter Ujfalusi > > wrote: > >> Use more coherent locking in the driver. Use bitfield to store the > >GPIO > >> direction and if the pin is configured as output stor

Re: [PATCH v2 2/3] gpio: twl4030: Cache the direction and output states in private data

2012-12-19 Thread Michael Trimarchi
Hi Grant Likely wrote: >On Thu, 6 Dec 2012 11:52:06 +0100, Peter Ujfalusi > wrote: >> Use more coherent locking in the driver. Use bitfield to store the >GPIO >> direction and if the pin is configured as output store the status >also in a >> bitfiled. >> In this way we can just look at these bit

Re: [PATCH v2 2/3] gpio: twl4030: Cache the direction and output states in private data

2012-12-19 Thread Grant Likely
On Thu, 6 Dec 2012 11:52:06 +0100, Peter Ujfalusi wrote: > Use more coherent locking in the driver. Use bitfield to store the GPIO > direction and if the pin is configured as output store the status also in a > bitfiled. > In this way we can just look at these bitfields when we need information >

[PATCH v2 2/3] gpio: twl4030: Cache the direction and output states in private data

2012-12-06 Thread Peter Ujfalusi
Use more coherent locking in the driver. Use bitfield to store the GPIO direction and if the pin is configured as output store the status also in a bitfiled. In this way we can just look at these bitfields when we need information about the pin status and only reach out to the chip when it is neede