Re: [PATCH] media: renesas-ceu: fix a potential NULL pointer dereference

Hi Kangjie, thanks for the patch. On Sat, Mar 09, 2019 at 01:14:24AM -0600, Kangjie Lu wrote: > In case of_match_device cannot find a match, the check returns > -EINVAL to avoid a potential NULL pointer dereference > > Signed-off-by: Kangjie Lu > --- > drivers/media/platform/renesas-ceu.c | 5

Re: [PATCH 1/2] i2c: rcar: fix concurrency issue related to ICDMAER

On Sun, Mar 03, 2019 at 04:03:13PM +0100, Wolfram Sang wrote: > From: Hiromitsu Yamasaki > > This patch fixes the problem that an interrupt may set up a new I2C > message and the DMA callback overwrites this setup. > > By disabling the DMA Enable Register(ICDMAER), rcar_i2c_dma_unmap() > enables

Re: [PATCH 2/2] i2c: rcar: explain the lockless design

On Sun, Mar 03, 2019 at 04:03:14PM +0100, Wolfram Sang wrote: > To make sure people can understand the lockless design of this driver > without the need to dive into git history, add a comment giving an > overview of the situation. > > Signed-off-by: Wolfram Sang Applied to for-current, thanks!

[PATCH] i2c: add extra check to safe DMA buffer helper

Make sure we report no buffer for 0-length messages. This can only happen if threshold is set to 0 which is kind of bogus but we should handle this situation nonetheless. Reported-by: Hsin-Yi Wang Fixes: e94bc5d18be0 ("i2c: add helpers to ease DMA handling") Signed-off-by: Wolfram Sang --- driv

Re: [PATCH] media: rcar-vin: fix a potential NULL pointer dereference

Hi Kangjie, Thanks for your patch. On 2019-03-09 01:05:27 -0600, Kangjie Lu wrote: > In case of_match_node cannot find a match, the fix returns > -EINVAL to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu > --- > drivers/media/platform/rcar-vin/rcar-core.c | 2 ++ > 1 file change

Re: [PATCH 1/2] PCI: rcar: Clean up remaining macros defining bits

Hi Marek, Thanks for your patch. On 2019-03-09 01:56:12 +0100, Marek Vasut wrote: > From: Marek Vasut > > Replace macros using constants with BIT()s instead, no functional change. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Phil Edworthy > Cc: Simon Horman > Cc: Wolfram S

Re: [PATCH/RFC 11/15] drm: rcar-du: lvds: Add support for dual-link mode

Hi Laurent, On Fri, Mar 08, 2019 at 08:12:39PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Fri, Mar 08, 2019 at 06:20:23PM +0100, Jacopo Mondi wrote: > > On Thu, Mar 07, 2019 at 01:23:41AM +0200, Laurent Pinchart wrote: > > > In dual-link mode the LVDS0 encoder transmits even-numbered pixel

Re: [PATCH 2/2] PCI: rcar: Replace unsigned long with u32 in register accessors

Hi Marek, Thanks for your work. On 2019-03-09 01:56:13 +0100, Marek Vasut wrote: > From: Marek Vasut > > Replace unsigned long with u32 in register accessor functions, > since they access 32bit registers. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Phil Edworthy > Cc: Simo

Re: [PATCH/RFC 05/15] dt-bindings: display: bridge: thc63lvd1024: Document dual-link operation

HI Laurent, On Fri, Mar 08, 2019 at 07:57:39PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Fri, Mar 08, 2019 at 05:49:25PM +0100, Jacopo Mondi wrote: > > On Thu, Mar 07, 2019 at 01:23:35AM +0200, Laurent Pinchart wrote: > > > The THC63LVD1024 LVDS decoder can operate in two modes, single-li

Re: [PATCH/RFC 06/15] drm: bridge: thc63: Report input bus mode through bridge timings

Hi Laurent On Fri, Mar 08, 2019 at 08:00:28PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Fri, Mar 08, 2019 at 06:32:59PM +0100, Jacopo Mondi wrote: > > On Thu, Mar 07, 2019 at 01:23:36AM +0200, Laurent Pinchart wrote: > > > Set a drm_bridge_timings in the drm_bridge, and use it to report t

Re: [PATCH/RFC 11/15] drm: rcar-du: lvds: Add support for dual-link mode

Hi Jacopo, On Sat, Mar 09, 2019 at 12:11:32PM +0100, Jacopo Mondi wrote: > On Fri, Mar 08, 2019 at 08:12:39PM +0200, Laurent Pinchart wrote: > > On Fri, Mar 08, 2019 at 06:20:23PM +0100, Jacopo Mondi wrote: > >> On Thu, Mar 07, 2019 at 01:23:41AM +0200, Laurent Pinchart wrote: > >>> In dual-link m

Re: [PATCH/RFC 06/15] drm: bridge: thc63: Report input bus mode through bridge timings

Hi Jacopo, On Sat, Mar 09, 2019 at 12:24:08PM +0100, Jacopo Mondi wrote: > On Fri, Mar 08, 2019 at 08:00:28PM +0200, Laurent Pinchart wrote: > > On Fri, Mar 08, 2019 at 06:32:59PM +0100, Jacopo Mondi wrote: > >> On Thu, Mar 07, 2019 at 01:23:36AM +0200, Laurent Pinchart wrote: > >>> Set a drm_brid

Re: [PATCH/RFC 05/15] dt-bindings: display: bridge: thc63lvd1024: Document dual-link operation

Hi Jacopo, On Sat, Mar 09, 2019 at 12:23:08PM +0100, Jacopo Mondi wrote: > On Fri, Mar 08, 2019 at 07:57:39PM +0200, Laurent Pinchart wrote: > > On Fri, Mar 08, 2019 at 05:49:25PM +0100, Jacopo Mondi wrote: > >> On Thu, Mar 07, 2019 at 01:23:35AM +0200, Laurent Pinchart wrote: > >>> The THC63LVD10