Re: [PATCH 0/5] Add Maxim 77802 PMIC support

2014-06-10 Thread Krzysztof Kozlowski
On pon, 2014-06-09 at 09:04 -0700, Doug Anderson wrote: > Krzystof, > > On Mon, Jun 9, 2014 at 3:16 AM, Krzysztof Kozlowski > wrote: > > On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote: > >> MAX77802 is a PMIC that contains 10 high efficiency Buck regulators, > >> 32 Low-dropout

Re: [PATCH 0/5] Add Maxim 77802 PMIC support

2014-06-10 Thread Krzysztof Kozlowski
On wto, 2014-06-10 at 00:55 +0200, Javier Martinez Canillas wrote: > Hello Krzystof, > > Thanks a lot for your feedback. > > On 06/09/2014 06:04 PM, Doug Anderson wrote: > > Krzystof, > > > > On Mon, Jun 9, 2014 at 3:16 AM, Krzysztof Kozlowski > > wrote: > >> On pon, 2014-06-09 at 11:37 +0200,

Re: [PATCH 0/5] Add Maxim 77802 PMIC support

2014-06-10 Thread Javier Martinez Canillas
Hello Krzysztof, > On 10/06/2014, at 09:32, Krzysztof Kozlowski wrote: > >> On pon, 2014-06-09 at 09:04 -0700, Doug Anderson wrote: >> Krzystof, >> >> On Mon, Jun 9, 2014 at 3:16 AM, Krzysztof Kozlowski >> wrote: >>> On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote: MAX77

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-10 Thread Chander Kashyap
On 10 June 2014 04:08, Lorenzo Pieralisi wrote: > On Mon, Jun 09, 2014 at 06:03:31PM +0100, Doug Anderson wrote: > > [...] > >> Cold boot and resume from suspend are detected via various special >> flags in various special locations. Resume from suspend looks at >> INFORM1 (0x10048004) for flags.

Re: [PATCH CRITICAL] ARM: s3c64xx: dt: Fix boot failure due to double clock initialization

2014-06-10 Thread Olof Johansson
On Tue, Dec 17, 2013 at 11:12 AM, Olof Johansson wrote: > On Tue, Dec 17, 2013 at 7:14 AM, Charles Keepax > wrote: >> On Mon, Dec 16, 2013 at 09:09:15PM +, Mark Brown wrote: >>> On Sat, Dec 14, 2013 at 04:41:06AM -0800, Tomasz Figa wrote: >>> >>> > - Wolfson Cragganmore 6410 - Mark Brown (co

[PATCH 1/3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Naveen Krishna Chatradhi
This patch makes the changes in spi-s3c64xx.c driver to make use of "cs-gpios" from SPI node(parent) instead of "cs-gpio" defined in slaves "controller-data"(child) node. Signed-off-by: Naveen Krishna Chatradhi Cc: Javier Martinez Canillas Cc: Doug Anderson --- drivers/spi/spi-s3c64xx.c | 56

[PATCH 2/3] spi: s3c64xx: remove a compilation warning with an assignment

2014-06-10 Thread Naveen Krishna Chatradhi
This patch returns an integer error value instead of the pointer. "warning: return makes integer from pointer without a cast" Signed-off-by: Naveen Krishna Chatradhi Cc: Javier Martinez Canillas Cc: Doug Anderson --- drivers/spi/spi-s3c64xx.c |2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 3/3] ARM: DTS: move "cs-gpio" from "controller-data" to under spi node

2014-06-10 Thread Naveen Krishna Chatradhi
This patch moves the "cs-gpio" field from "controller-data" child node to under the spi device node. Respective changes are preposed to spi-s3c64xx.c driver. Signed-off-by: Naveen Krishna Chatradhi Cc: Javier Martinez Canillas Cc: Doug Anderson --- arch/arm/boot/dts/exynos4210-smdkv310.dts |

[PATCH 0/3] spi: s3c64xx: use "cs-gpios" in spi node instead of "cs-gpio"

2014-06-10 Thread Naveen Krishna Chatradhi
Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be defined under "controller-data" node under each slave node. &spi_x { cs-gpios <>; ... slave_node { controller-data { cs-gpio = <>; ...

Re: Problems booting exynos5420 with >1 CPU

2014-06-10 Thread Lorenzo Pieralisi
On Tue, Jun 10, 2014 at 05:25:47AM +0100, Nicolas Pitre wrote: > On Mon, 9 Jun 2014, Lorenzo Pieralisi wrote: > > > I commented on Nico's patch because I did not like how it was > > implemented (at least remove the CPU PM notifier calls please, because > > they are not needed). > > OK no problem.

Re: [PATCH 2/3] spi: s3c64xx: remove a compilation warning with an assignment

2014-06-10 Thread Sachin Kamat
Hi Naveen, On Tue, Jun 10, 2014 at 2:30 PM, Naveen Krishna Chatradhi wrote: > This patch returns an integer error value instead of the > pointer. > > "warning: return makes integer from pointer without a cast" > > Signed-off-by: Naveen Krishna Chatradhi > Cc: Javier Martinez Canillas > Cc: Doug

Re: [PATCH 1/3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Naveen Krishna Ch
Hello All, On 10 June 2014 14:30, Naveen Krishna Chatradhi wrote: > This patch makes the changes in spi-s3c64xx.c driver to make use of > "cs-gpios" from SPI node(parent) instead of "cs-gpio" defined in > slaves "controller-data"(child) node. > > Signed-off-by: Naveen Krishna Chatradhi > Cc: Ja

Re: [PATCH 2/3] spi: s3c64xx: remove a compilation warning with an assignment

2014-06-10 Thread Naveen Krishna Ch
Hello Sachin, On 10 June 2014 15:15, Sachin Kamat wrote: > Hi Naveen, > > On Tue, Jun 10, 2014 at 2:30 PM, Naveen Krishna Chatradhi > wrote: >> This patch returns an integer error value instead of the >> pointer. >> >> "warning: return makes integer from pointer without a cast" >> >> Signed-off-

[PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Naveen Krishna Chatradhi
Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be defined under "controller-data" node under each slave node. &spi_x { cs-gpios <>; ... slave_node { controller-data { cs-gpio = <>; ...

[PATCH 0/2 v2] spi: s3c64xx: use "cs-gpios" in spi node instead of "cs-gpio"

2014-06-10 Thread Naveen Krishna Chatradhi
Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be defined under "controller-data" node under each slave node. &spi_x { cs-gpios <>; ... slave_node { controller-data { cs-gpio = <>; ...

[PATCH 2/2 v2] ARM: DTS: move "cs-gpio" from "controller-data" to under spi node

2014-06-10 Thread Naveen Krishna Chatradhi
This patch moves the "cs-gpio" field from "controller-data" child node to under the spi device node. Respective changes are preposed to spi-s3c64xx.c driver. Signed-off-by: Naveen Krishna Chatradhi Cc: Javier Martinez Canillas Cc: Doug Anderson --- Changes since v1: None arch/arm/boot/dts/ex

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Sylwester Nawrocki
On 10/06/14 12:08, Naveen Krishna Chatradhi wrote: > Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be > defined under "controller-data" node under each slave node. > > &spi_x { > cs-gpios <>; > ... > slave_node { > > controller-data { >

Re: [PATCH 2/5] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-10 Thread Mark Brown
On Tue, Jun 10, 2014 at 01:29:17AM +0200, Javier Martinez Canillas wrote: > On 06/09/2014 09:38 PM, Mark Brown wrote: > > On Mon, Jun 09, 2014 at 11:37:47AM +0200, Javier Martinez Canillas wrote: > >> + case REGULATOR_MODE_STANDBY:/* switch off */ > >> + if (id != MAX

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Naveen Krishna Ch
Hello Sylwester, Thanks for the review. On 10 June 2014 16:09, Sylwester Nawrocki wrote: > On 10/06/14 12:08, Naveen Krishna Chatradhi wrote: >> Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be >> defined under "controller-data" node under each slave node. >> >> &spi_x { >> c

Re: [PATCH v4 01/11] ARM: EXYNOS: Make exynos machine_ops as static

2014-06-10 Thread Tomasz Figa
Hi Pankaj, On 10.05.2014 08:56, Pankaj Dubey wrote: > As machine function ops are used only in this file let's make > them static. Also remove unused and unwanted declarations from > common.h. > > Signed-off-by: Pankaj Dubey > --- > arch/arm/mach-exynos/common.h |8 > arch/arm/mach

Re: [PATCH v4 02/11] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine

2014-06-10 Thread Tomasz Figa
Hi Pankaj, On 10.05.2014 08:56, Pankaj Dubey wrote: > As exynos_cpuidle_init and exynos_cpufreq_init function have just one lines > of code for registering platform devices. We can move these lines to > exynos_dt_machine_init and delete exynos_cpuidle_init and exynos_cpufreq_init > function. This

Re: [PATCH v6 0/6] add cpuidle support for Exynos5420

2014-06-10 Thread Chander M. Kashyap
On Thu, May 29, 2014 at 10:07 AM, Chander Kashyap wrote: > On 28 May 2014 14:32, Daniel Lezcano wrote: >> On 05/28/2014 06:35 AM, Kukjin Kim wrote: >>> >>> Chander Kashyap wrote: On 26 May 2014 15:59, Tomasz Figa wrote: > > Hi Chander, > > On 16.05.2014 10:03, Chan

re: drm/exynos: consider deferred probe case

2014-06-10 Thread Dan Carpenter
Hello Inki Dae, The patch df5225bc9a87: "drm/exynos: consider deferred probe case" from May 29, 2014, leads to the following static checker warning: drivers/gpu/drm/exynos/exynos_drm_fimd.c:996 fimd_probe() warn: 'ctx->display' isn't an ERR_PTR drivers/gpu/drm/exynos/exynos_drm_f

Re: [PATCH] ARM: exynos: move sysram info to exynos.c

2014-06-10 Thread Tomasz Figa
Hi Olof, On 03.06.2014 06:47, Olof Johansson wrote: > This solves a problem with building with CONFIG_SMP=n due to missing > sysram_base_addr (or sysram_ns_base_addr) variables. > > The new setup method is more awkward than I'd like for it to be, but > it can't be done in init_early() since iorem

Re: [PATCH] ARM: exynos: mark machine descriptor functions static

2014-06-10 Thread Tomasz Figa
Hi Olof, On 03.06.2014 06:57, Olof Johansson wrote: > There's no reason to export these functions, and I have no idea why > they have over time ended up in the header file. As a result, none of > the checker tools caught it (i.e. sparse was silent on it). > > Signed-off-by: Olof Johansson > ---

Re: [PATCH v3 1/6] i2c: s3c2410: Handle i2c sys_cfg register in i2c driver

2014-06-10 Thread Tomasz Figa
Hi Pankaj, On 10.05.2014 09:20, Pankaj Dubey wrote: > Let's handle i2c interrupt re-configuration in i2c driver. This will > help us in removing some soc specific checks from machine files. > Since only Exynos5250, and Exynos5420 need to do this, added syscon > based phandle to i2c device nodes of

Re: [PATCH v3 2/6] ARM: EXYNOS: Remove i2c sys configuration related code

2014-06-10 Thread Tomasz Figa
Hi Pankaj, On 10.05.2014 09:20, Pankaj Dubey wrote: > Since all these code has been moved into i2c driver, now we can > safely remove them from machine files. > > CC: Russell King > Signed-off-by: Pankaj Dubey > --- > arch/arm/mach-exynos/exynos.c | 38 > +-

Re: [PATCH v3 3/6] ARM: EXYNOS: Remove soc_is_exynos4/5 from exynos.c

2014-06-10 Thread Tomasz Figa
On 10.05.2014 09:20, Pankaj Dubey wrote: > This patch removes usage of soc_is_exynos4/5 from exynos.c. > For this we need to separate machine descriptors for exynos4 > and exynos5. While doing this patch does some consolidation also. > > CC: Russell King > CC: Thomas Abraham > Signed-off-by: Pan

Re: [PATCH v3 4/6] ARM: EXYNOS: Remove unused header inclusion from hotplug.c

2014-06-10 Thread Tomasz Figa
Hi Pankaj, On 10.05.2014 09:20, Pankaj Dubey wrote: > This patch removed "plat/cpu.h" inclusion from hotplug.c as it > is not required. > > Signed-off-by: Pankaj Dubey > --- > arch/arm/mach-exynos/hotplug.c |2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/hotpl

Re: [PATCH v3 3/6] ARM: EXYNOS: Remove soc_is_exynos4/5 from exynos.c

2014-06-10 Thread Arnd Bergmann
On Tuesday 10 June 2014 15:55:09 Tomasz Figa wrote: > On 10.05.2014 09:20, Pankaj Dubey wrote: > > This patch removes usage of soc_is_exynos4/5 from exynos.c. > > For this we need to separate machine descriptors for exynos4 > > and exynos5. While doing this patch does some consolidation also. > >

[PATCH 1/2] ARM: exynos: cleanup kconfig option display

2014-06-10 Thread Rob Herring
From: Rob Herring The addition of Exynos to multi-platform configs creates a mess of config options with options appearing before the Exynos config option. This is due to arch/arm/plat-samsung/Kconfig being included out of order with the other Samsung platform kconfig files. Reorder the kconfig f

Re: Problems booting exynos5420 with >1 CPU

2014-06-10 Thread Catalin Marinas
Hi Nico, Sorry, I can't stay away from this thread ;) On Tue, Jun 10, 2014 at 12:25:47AM -0400, Nicolas Pitre wrote: > On Mon, 9 Jun 2014, Lorenzo Pieralisi wrote: > > 4) When I am talking about firmware I am talking about sequences that > >are very close to HW (disabling C bit, cleaning cach

Re: [PATCH v3 5/6] soc: samsung: exynos-chipid: Add Exynos Chipid driver support

2014-06-10 Thread Tomasz Figa
Hi Pankaj, On 10.05.2014 09:20, Pankaj Dubey wrote: > Exynos SoCs have Chipid, for identification of product IDs > and SoC revistions. Till now we are using static macros > such as soc_is_exynos and #ifdefs for run time identification > of SoCs and their revisions. This is leading to add new K

Re: [PATCH v3 6/6] ARM: EXYNOS: Refactoring to remove soc_is_exynos macros from exynos

2014-06-10 Thread Tomasz Figa
Hi Pankaj, On 10.05.2014 09:20, Pankaj Dubey wrote: > This patch enables chipid driver for ARCH_EXYNOS and refactors > machine code as well as exynos cpufreq driver code for using > chipid driver for identification of SoC ID and SoC rev. > > This patch also updates DT binding information in exyno

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-10 Thread Doug Anderson
Chander, On Tue, Jun 10, 2014 at 1:12 AM, Chander Kashyap wrote: > On 10 June 2014 04:08, Lorenzo Pieralisi wrote: >> On Mon, Jun 09, 2014 at 06:03:31PM +0100, Doug Anderson wrote: >> >> [...] >> >>> Cold boot and resume from suspend are detected via various special >>> flags in various special

Re: [RESEND PATCH v2 1/2] ASoC: samsung: s3c24{xx,12}-i2s: port to use generic dmaengine API

2014-06-10 Thread Tomasz Figa
Hi, On 01.06.2014 19:15, Vasily Khoruzhick wrote: > Use dmaengine instead of legacy s3c24xx DMA API for s3c24xx and s3c2412 > > Signed-off-by: Vasily Khoruzhick > --- > v2: use hardcoded dma channel number > > sound/soc/samsung/Kconfig | 9 +++ > sound/soc/samsung/dmaengine.c | 3

Re: [RESEND PATCH v2 2/2] ASoC: samsung: drop support for legacy S3C24XX DMA API

2014-06-10 Thread Tomasz Figa
Hi, On 01.06.2014 19:15, Vasily Khoruzhick wrote: > Signed-off-by: Vasily Khoruzhick > --- > v2: No changes > > sound/soc/samsung/Kconfig | 3 - > sound/soc/samsung/Makefile | 2 - > sound/soc/samsung/dma.c| 460 > - > 3 files changed, 465 d

Re: [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC

2014-06-10 Thread Tomasz Figa
Hi Kukjin, On 30.05.2014 20:18, Kukjin Kim wrote: > On 05/30/14 20:41, Tomasz Figa wrote: >> Hi, >> >> On 23.05.2014 16:39, Tomasz Figa wrote: >>> This patch fixes reg entry sizes in GIC node that were not large enough >>> to cover whole regions. >>> >>> Signed-off-by: Tomasz Figa >>> --- >>> ar

Re: [PATCH v2 1/3] ARM: EXYNOS: Add support for clock handling in power domain

2014-06-10 Thread Tomasz Figa
Hi, On 26.05.2014 13:56, Shaik Ameer Basha wrote: > From: Prathyush K > > While powering on/off a local powerdomain in exynos5 chipsets, the input > clocks to each device gets modified. This behaviour is based on the > SYSCLK_SYS_PWR_REG registers. > E.g. SYSCLK_MFC_SYS_PWR_REG = 0x0, the parent

Re: [PATCH v2 2/3] clk: exynos5420: Add IDs for clocks used in PD mfc

2014-06-10 Thread Tomasz Figa
Hi, On 26.05.2014 13:56, Shaik Ameer Basha wrote: > From: Arun Kumar K > > Adds IDs for MUX clocks to be used by power domain for MFC > for doing re-parenting while pd on/off. > > Signed-off-by: Arun Kumar K > Signed-off-by: Shaik Ameer Basha > --- > drivers/clk/samsung/clk-exynos5420.c |

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-10 Thread Nicolas Pitre
On Tue, 10 Jun 2014, Doug Anderson wrote: > My S-state knowledge is not strong, but I believe that Lorenzo's > questions matter if we're using S2 for CPUidle (where we actually turn > off power and hot unplug CPUs) but not when we're using S1 for CPUidle > (where we just enter WFI/WFE). > > I bel

Re: Problems booting exynos5420 with >1 CPU

2014-06-10 Thread Nicolas Pitre
On Tue, 10 Jun 2014, Catalin Marinas wrote: > Hi Nico, > > Sorry, I can't stay away from this thread ;) ;-) > On Tue, Jun 10, 2014 at 12:25:47AM -0400, Nicolas Pitre wrote: > > On Mon, 9 Jun 2014, Lorenzo Pieralisi wrote: > > > 4) When I am talking about firmware I am talking about sequences th

Re: [PATCH v4 06/11] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-06-10 Thread Tomasz Figa
Hi, On 10.05.2014 08:56, Pankaj Dubey wrote: > From: Young-Gun Jang > > Add support for mapping Samsung Power Management Unit (PMU) > base address from device tree. This patch also adds helper > function as "get_exynos_pmuregmap". This function can be used > by other machine files such as "pm.c"

Re: exynos5420-peach-pi: linux-next boot fails unless mau_epll left enabled?

2014-06-10 Thread Doug Anderson
Hi, On Mon, Jun 9, 2014 at 11:48 PM, Shaik Ameer Basha wrote: > Hi Kevin, > > We tested on 3 "peach-pi" boards. We are not observing this issue. > > Even I tried with the below defconfig mentioned by you. No issues observed. > https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overl

Re: Problems booting exynos5420 with >1 CPU

2014-06-10 Thread Catalin Marinas
On Tue, Jun 10, 2014 at 05:49:01PM +0100, Nicolas Pitre wrote: > On Tue, 10 Jun 2014, Catalin Marinas wrote: > > On Tue, Jun 10, 2014 at 12:25:47AM -0400, Nicolas Pitre wrote: > > > On Mon, 9 Jun 2014, Lorenzo Pieralisi wrote: > > > > 4) When I am talking about firmware I am talking about sequences

linux-next on Chromebook2: DRM failing to allocate

2014-06-10 Thread Kevin Hilman
I'm trying to get the latest linux-next working on my Chromebook2 (it's booting to a serial console) and am now trying to get the display working (at least for a frambuffer console.) Since the display nodes seem to be present in the exynos5800-peach-pi DTS, I tried enabling DRM and it's failing to

Re: linux-next on Chromebook2: DRM failing to allocate

2014-06-10 Thread Stéphane Marchesin
On Tue, Jun 10, 2014 at 10:56 AM, Kevin Hilman wrote: > I'm trying to get the latest linux-next working on my Chromebook2 > (it's booting to a serial console) and am now trying to get the > display working (at least for a frambuffer console.) > > Since the display nodes seem to be present in the e

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Doug Anderson
Naveen / Sylwester, On Tue, Jun 10, 2014 at 4:00 AM, Naveen Krishna Ch wrote: >> Can we support both "cs-gpio" and "cs-gpios" for backward compatibility ? >> After your change all DTBs using the original pattern will not work with >> new kernels any more. At least I would expect such backward com

Re: linux-next on Chromebook2: DRM failing to allocate

2014-06-10 Thread Kevin Hilman
On Tue, Jun 10, 2014 at 11:04 AM, Stéphane Marchesin wrote: > On Tue, Jun 10, 2014 at 10:56 AM, Kevin Hilman wrote: >> I'm trying to get the latest linux-next working on my Chromebook2 >> (it's booting to a serial console) and am now trying to get the >> display working (at least for a frambuffer

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Doug Anderson
Naveen, Not a full review, but a few quick things I happened to notice: On Tue, Jun 10, 2014 at 3:08 AM, Naveen Krishna Chatradhi wrote: > @@ -94,7 +93,6 @@ Example: > spi-max-frequency = <1>; > > controller-data { > -

Re: linux-next on Chromebook2: DRM failing to allocate

2014-06-10 Thread Kevin Hilman
On Tue, Jun 10, 2014 at 11:24 AM, Kevin Hilman wrote: > On Tue, Jun 10, 2014 at 11:04 AM, Stéphane Marchesin > wrote: >> On Tue, Jun 10, 2014 at 10:56 AM, Kevin Hilman wrote: >>> I'm trying to get the latest linux-next working on my Chromebook2 >>> (it's booting to a serial console) and am now t

Re: linux-next on Chromebook2: DRM failing to allocate

2014-06-10 Thread Tomasz Figa
On 10.06.2014 20:04, Stéphane Marchesin wrote: > On Tue, Jun 10, 2014 at 10:56 AM, Kevin Hilman wrote: >> I'm trying to get the latest linux-next working on my Chromebook2 >> (it's booting to a serial console) and am now trying to get the >> display working (at least for a frambuffer console.) >>

Re: Problems booting exynos5420 with >1 CPU

2014-06-10 Thread Nicolas Pitre
On Tue, 10 Jun 2014, Catalin Marinas wrote: > On Tue, Jun 10, 2014 at 05:49:01PM +0100, Nicolas Pitre wrote: > > The M-class processor should be treated the same way as firmware. It > > ought to be flexible (certainly more than hardwired hardware), but it > > shares all the same downsides as fir

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Tomasz Figa
On 10.06.2014 20:26, Doug Anderson wrote: > Naveen, > > Not a full review, but a few quick things I happened to notice: > > On Tue, Jun 10, 2014 at 3:08 AM, Naveen Krishna Chatradhi > wrote: >> @@ -94,7 +93,6 @@ Example: >> spi-max-frequency = <1>; >> >>

Re: linux-next on Chromebook2: DRM failing to allocate

2014-06-10 Thread Kevin Hilman
On Tue, Jun 10, 2014 at 11:04 AM, Stéphane Marchesin wrote: > On Tue, Jun 10, 2014 at 10:56 AM, Kevin Hilman wrote: >> I'm trying to get the latest linux-next working on my Chromebook2 >> (it's booting to a serial console) and am now trying to get the >> display working (at least for a frambuffer

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Tomasz Figa
On 10.06.2014 20:09, Doug Anderson wrote: > Naveen / Sylwester, > > On Tue, Jun 10, 2014 at 4:00 AM, Naveen Krishna Ch > wrote: >>> Can we support both "cs-gpio" and "cs-gpios" for backward compatibility ? >>> After your change all DTBs using the original pattern will not work with >>> new kernel

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Tomasz Figa
Hi Naveen, On 10.06.2014 12:08, Naveen Krishna Chatradhi wrote: > Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be > defined under "controller-data" node under each slave node. [snip] > @@ -85,6 +83,7 @@ Example: > #size-cells = <0>; > pinctrl-names = "

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Doug Anderson
Tomasz, On Tue, Jun 10, 2014 at 12:49 PM, Tomasz Figa wrote: > This is wrong. The "cs-gpios" property is supposed to be an array, > indexed by chip select number of SPI devices (indicated by their "reg" > properties). > > Moreover, is there a need to parse this manually in this driver? I can > se

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Tomasz Figa
On 10.06.2014 21:58, Doug Anderson wrote: > Tomasz, > > On Tue, Jun 10, 2014 at 12:49 PM, Tomasz Figa wrote: >> This is wrong. The "cs-gpios" property is supposed to be an array, >> indexed by chip select number of SPI devices (indicated by their "reg" >> properties). >> >> Moreover, is there a n

Re: exynos5420-peach-pi: linux-next boot fails unless mau_epll left enabled?

2014-06-10 Thread Javier Martinez Canillas
Hello Doug, On 06/10/2014 07:39 PM, Doug Anderson wrote: > Hi, > > On Mon, Jun 9, 2014 at 11:48 PM, Shaik Ameer Basha > wrote: >> Hi Kevin, >> >> We tested on 3 "peach-pi" boards. We are not observing this issue. >> >> Even I tried with the below defconfig mentioned by you. No issues observed. >

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Doug Anderson
Tomasz, On Tue, Jun 10, 2014 at 12:59 PM, Tomasz Figa wrote: > On 10.06.2014 21:58, Doug Anderson wrote: >> Tomasz, >> >> On Tue, Jun 10, 2014 at 12:49 PM, Tomasz Figa wrote: >>> This is wrong. The "cs-gpios" property is supposed to be an array, >>> indexed by chip select number of SPI devices (

Re: exynos5420-peach-pi: linux-next boot fails unless mau_epll left enabled?

2014-06-10 Thread Doug Anderson
Javier, On Tue, Jun 10, 2014 at 1:03 PM, Javier Martinez Canillas wrote: > Yes, I did not have this issue before. However... I installed the latest Peach > pit recovery image you provided me and mainline kernel started to hang on > boot. > I remembered this thread so tested Kevin's patch which m

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Rob Herring
On Tue, Jun 10, 2014 at 1:09 PM, Doug Anderson wrote: > Naveen / Sylwester, > > On Tue, Jun 10, 2014 at 4:00 AM, Naveen Krishna Ch > wrote: >>> Can we support both "cs-gpio" and "cs-gpios" for backward compatibility ? >>> After your change all DTBs using the original pattern will not work with >>

Re: linux-next on Chromebook2: DRM failing to allocate

2014-06-10 Thread Ajay kumar
Hi, On 6/11/14, Kevin Hilman wrote: > On Tue, Jun 10, 2014 at 11:04 AM, Stéphane Marchesin > wrote: >> On Tue, Jun 10, 2014 at 10:56 AM, Kevin Hilman >> wrote: >>> I'm trying to get the latest linux-next working on my Chromebook2 >>> (it's booting to a serial console) and am now trying to get t

[PATCH] drm/exynos: dpi: Fix NULL pointer dereference with legacy bindings

2014-06-10 Thread Tomasz Figa
If there is no panel node in DT and instead display timings are provided directly in FIMD node, there is no panel object created and ctx->panel becomes NULL. However during Exynos DRM initialization drm_helper_hpd_irq_event() is called, which in turns calls exynos_dpi_detect(), which dereferences c

Re: linux-next on Chromebook2: DRM failing to allocate

2014-06-10 Thread Kevin Hilman
Hi Ajay, On Tue, Jun 10, 2014 at 1:51 PM, Ajay kumar wrote: > Hi, > > On 6/11/14, Kevin Hilman wrote: >> On Tue, Jun 10, 2014 at 11:04 AM, Stéphane Marchesin >> wrote: >>> On Tue, Jun 10, 2014 at 10:56 AM, Kevin Hilman >>> wrote: I'm trying to get the latest linux-next working on my Chrom

[RESEND PATCH] ARM: EXYNOS: Fix the sequence of secondary CPU boot for Exynos3250

2014-06-10 Thread Chanwoo Choi
This patch set AUTOWAKEUP_EN bit to ARM_CORE_CONFIGURATION register because Exynos3250 removes WFE in secure mode so that turn on automatically after setting CORE_LOCAL_PWR_EN. Also, This patch use dbs_sev() macro to guarantee the data synchronization of command instead of IPI_WAKEUP because Exynos

Re: [RESEND PATCH] ARM: EXYNOS: Fix the sequence of secondary CPU boot for Exynos3250

2014-06-10 Thread Tomasz Figa
Hi Chanwoo, On 11.06.2014 01:27, Chanwoo Choi wrote: > This patch set AUTOWAKEUP_EN bit to ARM_CORE_CONFIGURATION register > because Exynos3250 removes WFE in secure mode so that turn on automatically > after setting CORE_LOCAL_PWR_EN. Also, This patch use dbs_sev() macro > to guarantee the data s

Re: [RESEND PATCH] ARM: EXYNOS: Fix the sequence of secondary CPU boot for Exynos3250

2014-06-10 Thread Chanwoo Choi
On 06/11/2014 08:35 AM, Tomasz Figa wrote: > Hi Chanwoo, > > On 11.06.2014 01:27, Chanwoo Choi wrote: >> This patch set AUTOWAKEUP_EN bit to ARM_CORE_CONFIGURATION register >> because Exynos3250 removes WFE in secure mode so that turn on automatically >> after setting CORE_LOCAL_PWR_EN. Also, This

Re: [RESEND PATCH] ARM: EXYNOS: Fix the sequence of secondary CPU boot for Exynos3250

2014-06-10 Thread Tomasz Figa
On 11.06.2014 01:44, Chanwoo Choi wrote: > On 06/11/2014 08:35 AM, Tomasz Figa wrote: >> Hi Chanwoo, >> >> On 11.06.2014 01:27, Chanwoo Choi wrote: >>> This patch set AUTOWAKEUP_EN bit to ARM_CORE_CONFIGURATION register >>> because Exynos3250 removes WFE in secure mode so that turn on automatically

[RESEND PATCH v2] clk: exynos4: Add PPMU IP block source clocks.

2014-06-10 Thread Jonghwa Lee
Exynos4 has saveral PPMUs and each of them has operation clock which can be gated through CMU's SFR control. New clocks are listed below. All clocks are added as a gate-typed clock. CLK_PPMULEFT, CLK_PPMURIGHT, CLK_PPMUCAMIF, CLK_PPMUTV, CLK_PPMUMFC_L, CLK_PPMUMFC_R, CLK_G3D, CLK_PPMUIMAGE, CLK_P

Re: [RESEND PATCH v2] clk: exynos4: Add PPMU IP block source clocks.

2014-06-10 Thread Tomasz Figa
Hi Jonghwa, On 11.06.2014 02:22, Jonghwa Lee wrote: > Exynos4 has saveral PPMUs and each of them has operation clock which > can be gated through CMU's SFR control. > > New clocks are listed below. All clocks are added as a gate-typed clock. > > CLK_PPMULEFT, CLK_PPMURIGHT, CLK_PPMUCAMIF, CLK_PP

Re: linux-next on Chromebook2: DRM failing to allocate

2014-06-10 Thread Rahul Sharma
On 11 June 2014 03:48, Kevin Hilman wrote: > Hi Ajay, > > On Tue, Jun 10, 2014 at 1:51 PM, Ajay kumar wrote: >> Hi, >> >> On 6/11/14, Kevin Hilman wrote: >>> On Tue, Jun 10, 2014 at 11:04 AM, Stéphane Marchesin >>> wrote: On Tue, Jun 10, 2014 at 10:56 AM, Kevin Hilman wrote: > I'

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-10 Thread Chander Kashyap
Hi Doug, On Tue, Jun 10, 2014 at 9:19 PM, Nicolas Pitre wrote: > On Tue, 10 Jun 2014, Doug Anderson wrote: > >> My S-state knowledge is not strong, but I believe that Lorenzo's >> questions matter if we're using S2 for CPUidle (where we actually turn >> off power and hot unplug CPUs) but not when

[PATCH 0/3] Fix boot-hang on Peach-pit and Enable audio

2014-06-10 Thread Tushar Behera
With next-20140610, Peach-pit/Peach-pi board hangs during boot if we run 'sound init' during u-boot. The issue is fixed in following patches. While at it, also enable audio support for Peach-pi board. How to test audio on Peach-pi: * On top of exynos_defconfig, enable SND_SOC_SNOW and

[PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-10 Thread Tushar Behera
When the output clock of AUDSS mux is disabled, we are getting kernel oops while doing a clk_get() on other clocks provided by AUDSS. Though user manual doesn't specify this dependency, we came across this issue while disabling the parent of AUDSS mux clocks. Keeping the parents of AUDSS mux alway

[PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-06-10 Thread Tushar Behera
Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. As per the user manual, it should be CLK_MAU_EPLL. The problem surfaced when the bootloader in Peach-pit board set the EPLL clock as the parent of AUDSS mux. While booting the kernel, we used to get a system hang during late boot

[PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-10 Thread Tushar Behera
Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. Signed-off-by: Tushar Behera --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 31 + 1 file changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5

Re: exynos5420-peach-pi: linux-next boot fails unless mau_epll left enabled?

2014-06-10 Thread Tushar Behera
On 06/11/2014 01:56 AM, Doug Anderson wrote: > Javier, > > On Tue, Jun 10, 2014 at 1:03 PM, Javier Martinez Canillas > wrote: >> Yes, I did not have this issue before. However... I installed the latest >> Peach >> pit recovery image you provided me and mainline kernel started to hang on >> boot

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Naveen Krishna Ch
Hello Doug, On 10 June 2014 23:56, Doug Anderson wrote: > Naveen, > > Not a full review, but a few quick things I happened to notice: > > On Tue, Jun 10, 2014 at 3:08 AM, Naveen Krishna Chatradhi > wrote: >> @@ -94,7 +93,6 @@ Example: >> spi-max-frequency = <1>; >> >>

Re: drm/exynos: consider deferred probe case

2014-06-10 Thread Inki Dae
Hello Dan, On 2014년 06월 10일 21:38, Dan Carpenter wrote: > Hello Inki Dae, > > The patch df5225bc9a87: "drm/exynos: consider deferred probe case" > from May 29, 2014, leads to the following static checker warning: > > drivers/gpu/drm/exynos/exynos_drm_fimd.c:996 fimd_probe() > warn:

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Naveen Krishna Ch
Hello Tomasz, On 11 June 2014 01:19, Tomasz Figa wrote: > Hi Naveen, > > On 10.06.2014 12:08, Naveen Krishna Chatradhi wrote: >> Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be >> defined under "controller-data" node under each slave node. > > [snip] > >> @@ -85,6 +83,7 @@ Example

[PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Naveen Krishna Chatradhi
Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be defined under "controller-data" node under each slave node. &spi_x { cs-gpios <>; ... slave_node { controller-data { cs-gpio = <>; ...

[PATCH 2/2 v3] ARM: DTS: move "cs-gpio" from "controller-data" to under spi node

2014-06-10 Thread Naveen Krishna Chatradhi
This patch moves the "cs-gpio" field from "controller-data" child node to under the spi device node. Respective changes are preposed to spi-s3c64xx.c driver. Signed-off-by: Naveen Krishna Chatradhi Acked-by: Rob Herring Cc: Javier Martinez Canillas Cc: Doug Anderson Cc: Tomasz Figa --- Chang

[patch] drm/exynos: change zero to NULL for sparse

2014-06-10 Thread Dan Carpenter
We recently changed this function to return a pointer instead of an int so we need to change this zero to a NULL or Sparse complains: drivers/gpu/drm/exynos/exynos_drm_drv.h:346:47: warning: Using plain integer as NULL pointer Signed-off-by: Dan Carpenter diff --git a/drivers/gp