RE: [PATCH V5 01/17] scsi: fixing the "type" for well known LUs

2014-09-24 Thread Subhash Jadavani
>> > + * some devices may respond with wrong type for >> > + * well-known logical units. Force well-known type >> > + * to enumerate them correctly. >> > + */ >> > + if (scsi_is_wlun(sdev->lun)) >> > + sdev->type = TYPE_WLUN; >> >

RE: [PATCH V5 02/17] scsi: sysfs: don't add scsi_device if its already added

2014-09-24 Thread Subhash Jadavani
> Ok. Can you move the is_visible check to scsi_sysfs_add_devices, should be fine to place it just after the sdev_state check. Sure, will move it in next patch. -Original Message- From: 'Christoph Hellwig' [mailto:h...@infradead.org] Sent: Wednesday, September 24, 2014 9:38 AM To: Subh

Re: [PATCH 31/35] qla2xxx: Disable PCI device in shutdown handler.

2014-09-24 Thread Chad Dupuis
On Wed, 24 Sep 2014, Joe Lawrence wrote: On Wed, 24 Sep 2014 11:37:55 -0400 Chad Dupuis wrote: On Wed, 24 Sep 2014, Joe Lawrence wrote: On Wed, 24 Sep 2014 03:08:34 -0400 Saurav Kashyap wrote: From: Chad Dupuis Disable the PCI device during shutdown to prevent any races with other

Re: [PATCH V5 11/17] scsi: ufs: add UFS power management support

2014-09-24 Thread Akinobu Mita
2014-09-25 0:14 GMT+09:00 Dolev Raviv : > +int ufshcd_uic_pwr_ctrl(struct ufs_hba *hba, struct uic_command *cmd) > { > - struct uic_command uic_cmd = {0}; > - struct completion pwr_done; > + struct completion uic_async_done; > unsigned long flags; > u8 status; >

[Bug 85101] hpsa + P410 does not show connected HP SAS port expanders

2014-09-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=85101 --- Comment #3 from Robert Elliott --- Controller lockup means the firmware crashed (e.g. an ASSERT statement triggered). That can be due to hardware problems or firmware bugs. You might see if it boots with nothing attached; then with one expan

[PATCH 0/1] Error are logged when application issues illegal request

2014-09-24 Thread wenxiong
Hi all, Failing Device information are logged when IOA firmware detected these illegal request such as IOA firmware doesn't support inquiry with page code 2. The patch fixes the issue. Thanks for your help! Wendy -- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

[PATCH 1/1] ipr: Errors are logged when application issues illegal request

2014-09-24 Thread wenxiong
Failing Device information are logged when IOA firmware detected these illegal request such as IOA firmware doesn't support inquiry with page code 2. The patch fixes the issue. Signed-off-by: Brian King Tested-by: Wen Xiong --- drivers/scsi/ipr.c | 10 ++ drivers/scsi/ipr.h |1 +

[Bug 85101] hpsa + P410 does not show connected HP SAS port expanders

2014-09-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=85101 --- Comment #2 from linux-...@crashplan.pro --- In this case the hardware seems broken. The P410 controller is only used for upgrading the HP SAS expander firmware. This time we started with upgrading the controller firmware: === ./ccissflash

RE: [PATCH V5 01/17] scsi: fixing the "type" for well known LUs

2014-09-24 Thread Elliott, Robert (Server Storage)
> From: Christoph Hellwig [mailto:h...@infradead.org] ... > On Wed, Sep 24, 2014 at 06:13:57PM +0300, Dolev Raviv wrote: > > From: Subhash Jadavani > > > > Some devices may respond with wrong type for well-known logical units. > > This patch forces well-known type for devices which doesn't report

Re: [PATCH 31/35] qla2xxx: Disable PCI device in shutdown handler.

2014-09-24 Thread Joe Lawrence
On Wed, 24 Sep 2014 11:37:55 -0400 Chad Dupuis wrote: > > > On Wed, 24 Sep 2014, Joe Lawrence wrote: > > > On Wed, 24 Sep 2014 03:08:34 -0400 > > Saurav Kashyap wrote: > > > >> From: Chad Dupuis > >> > >> Disable the PCI device during shutdown to prevent any races with > >> other PCI code su

[Bug 85101] hpsa + P410 does not show connected HP SAS port expanders

2014-09-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=85101 Robert Elliott changed: What|Removed |Added CC||elli...@hp.com --- Comment #1 from Rober

[PATCH percpu/for-3.18] blk-mq, percpu_ref: start q->mq_usage_counter in atomic mode

2014-09-24 Thread Tejun Heo
FYI, I added a paragraph explaining what happened to the temp fix at the end. The following is the applied version. Thanks. - 8< - >From 17497acbdce9506fd6a75115dee4ab80c3cc5ee5 Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Wed, 24 Sep 2014 13:31:50 -0400 blk-mq uses percpu_ref for its

Re: [PATCH block/for-3.18/core] blk-mq: start q->mq_usage_counter in atomic mode

2014-09-24 Thread Tejun Heo
On Tue, Sep 23, 2014 at 02:08:12AM -0400, Tejun Heo wrote: > From 83b06f4fc6ca2f7f3d706a168b71c248bdada668 Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Tue, 23 Sep 2014 01:58:34 -0400 > > blk-mq uses percpu_ref for its usage counter which tracks the number > of in-flight commands and used t

[PATCH percpu/for-3.18] Revert "blk-mq, percpu_ref: implement a kludge for SCSI blk-mq stall during probe"

2014-09-24 Thread Tejun Heo
>From 9eca80461a45177e456219a9cd944c27675d6512 Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Wed, 24 Sep 2014 13:07:33 -0400 This reverts commit 0a30288da1aec914e158c2d7a3482a85f632750f, which was a temporary fix for SCSI blk-mq stall issue. The following patches will fix the issue properly by

RE: [PATCH V5 10/17] scsi: ufs: manually add well known logical units

2014-09-24 Thread Subhash Jadavani
> Just after the call to scsi_remove_host sounds right to me. > scsi_remove_host already removes all regularly scanned devices, but because __scsi_add_device keeps and additional reference it doesn't free those that you added manually. Ok, we are calling scsi_remove_host() as part of ufs driver re

[Bug 85101] New: hpsa + P410 does not show connected HP SAS port expanders

2014-09-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=85101 Bug ID: 85101 Summary: hpsa + P410 does not show connected HP SAS port expanders Product: SCSI Drivers Version: 2.5 Kernel Version: 3.17 Hardware: x86-64

Re: [PATCH V5 10/17] scsi: ufs: manually add well known logical units

2014-09-24 Thread 'Christoph Hellwig'
On Wed, Sep 24, 2014 at 09:36:37AM -0700, Subhash Jadavani wrote: > Where do you release these references again? It seems like they are never > released on the device removal path. > > [Subhash] That's because these are embedded/non-removable UFS devices which > are always present on the board an

Re: [PATCH V5 02/17] scsi: sysfs: don't add scsi_device if its already added

2014-09-24 Thread 'Christoph Hellwig'
On Wed, Sep 24, 2014 at 09:27:47AM -0700, Subhash Jadavani wrote: > No, It happens in this sequence of events: > 1. LLD calls the __scsi_add_device() for well known logical units before > scsi_scan_host() (This is done as part of [PATCH V5 10/17] scsi: ufs: > manually add well known logical units).

RE: [PATCH V5 10/17] scsi: ufs: manually add well known logical units

2014-09-24 Thread Subhash Jadavani
Comments inline: -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Wednesday, September 24, 2014 9:25 AM To: Dolev Raviv Cc: james.bottom...@hansenpartnership.com; h...@infradead.org; linux-scsi@vger.kernel.org; linux-scsi-ow...@vger.kernel.org; linux-arm-...@vg

RE: [PATCH V5 02/17] scsi: sysfs: don't add scsi_device if its already added

2014-09-24 Thread Subhash Jadavani
>> If LLD has added scsi device (by calling scsi_add_device) before >> scheduling async scsi_scan_host then scsi_finish_async_scan() will end >> up calling scsi_sysfs_add_sdev for scsi device which was already added by LLD. >> This patch fixes this issue by adding a check at the start of >> scsi_

Re: [PATCH V5 10/17] scsi: ufs: manually add well known logical units

2014-09-24 Thread Christoph Hellwig
> /** > + * ufshcd_set_queue_depth - set lun queue depth > + * @sdev: pointer to SCSI device > + * > + * Read bLUQueueDepth value and activate scsi tagged command > + * queueing. For WLUN, queue depth is set to 1. For best-effort > + * cases (bLUQueueDepth = 0) the queue depth is set to a maximum

Re: [PATCH V5 02/17] scsi: sysfs: don't add scsi_device if its already added

2014-09-24 Thread Christoph Hellwig
On Wed, Sep 24, 2014 at 06:13:58PM +0300, Dolev Raviv wrote: > From: Subhash Jadavani > > If LLD has added scsi device (by calling scsi_add_device) before scheduling > async scsi_scan_host then scsi_finish_async_scan() will end up calling > scsi_sysfs_add_sdev for scsi device which was already ad

Re: [PATCH V5 01/17] scsi: fixing the "type" for well known LUs

2014-09-24 Thread Christoph Hellwig
On Wed, Sep 24, 2014 at 06:13:57PM +0300, Dolev Raviv wrote: > From: Subhash Jadavani > > Some devices may respond with wrong type for well-known logical units. > This patch forces well-known type for devices which doesn't report it > correct. This looks fine to me, as the well known LUN address

Re: [PATCH v5 1/2] arcmsr: simplify ioctl data read/write

2014-09-24 Thread Tomas Henzl
On 09/24/2014 11:33 AM, Ching Huang wrote: > From: Ching Huang > > This patch is relative to: > http://git.infradead.org/users/hch/scsi-queue.git/tree/drivers-for-3.18:/drivers/scsi/arcmsr > > change in v5: > 1. rename firstindex to getIndex, lastindex to putIndex for readability > 2. define ARCMS

Re: [PATCH 31/35] qla2xxx: Disable PCI device in shutdown handler.

2014-09-24 Thread Chad Dupuis
On Wed, 24 Sep 2014, Joe Lawrence wrote: On Wed, 24 Sep 2014 03:08:34 -0400 Saurav Kashyap wrote: From: Chad Dupuis Disable the PCI device during shutdown to prevent any races with other PCI code such as the AER handling code. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --

[PATCH/RESEND V5 07/17] scsi: ufs: refactor query descriptor API support

2014-09-24 Thread Dolev Raviv
From: Subhash Jadavani Currently reading query descriptor is more tightened to each descriptor type. This patch generalize the approach and allows reading any parameter from any query descriptor. Signed-off-by: Subhash Jadavani Signed-off-by: Dolev Raviv diff --git a/drivers/scsi/ufs/ufs.h b/

[PATCH/RESEND V5 04/17] scsi: ufs: Add regulator enable support

2014-09-24 Thread Dolev Raviv
From: Sujit Reddy Thumma UFS devices are powered by at most three external power supplies - - VCC - The flash memory core power supply, 2.7V to 3.6V or 1.70V to 1.95V - VCCQ - The controller and I/O power supply, 1.1V to 1.3V - VCCQ2 - Secondary controller and/or I/O power supply, 1.65V to 1.95V

[PATCH/RESEND V5 05/17] scsi: ufs: Add clock initialization support

2014-09-24 Thread Dolev Raviv
From: Sujit Reddy Thumma Add generic clock initialization support for UFSHCD platform driver. The clock info is read from device tree using standard clock bindings. A generic max-clock-frequency-hz property is defined to save information on maximum operating clock frequency the h/w supports. Sig

[PATCH/RESEND V5 09/17] scsi: ufs: Active Power Mode - configuring bActiveICCLevel

2014-09-24 Thread Dolev Raviv
From: Yaniv Gardi The maximum power consumption in active is determined by bActiveICCLevel. The configuration is done by reading max current supported by the regulators connected to VCC, VCCQ and VCCQ2 rails on the boards, and reading the current consumption levels from the device for each rails

[PATCH V5 02/17] scsi: sysfs: don't add scsi_device if its already added

2014-09-24 Thread Dolev Raviv
From: Subhash Jadavani If LLD has added scsi device (by calling scsi_add_device) before scheduling async scsi_scan_host then scsi_finish_async_scan() will end up calling scsi_sysfs_add_sdev for scsi device which was already added by LLD. This patch fixes this issue by adding a check at the start

[PATCH/RESEND V5 03/17] scsi: ufs: Allow vendor specific initialization

2014-09-24 Thread Dolev Raviv
From: Sujit Reddy Thumma Some vendor specific controller versions might need to configure vendor specific - registers, clocks, voltage regulators etc. to initialize the host controller UTP layer and Uni-Pro stack. Provide some common initialization operations that can be used to configure vendor

[PATCH V5 10/17] scsi: ufs: manually add well known logical units

2014-09-24 Thread Dolev Raviv
From: Subhash Jadavani UFS device specification requires the UFS devices to support 4 well known logical units: "REPORT_LUNS" (address: 01h) "UFS Device" (address: 50h) "RPMB" (address: 44h) "BOOT" (address: 30h) UFS device may have standard LUs and LUN id could b

[PATCH/RESEND V5 12/17] scsi: ufs: refactor configuring power mode

2014-09-24 Thread Dolev Raviv
Sometimes, the device shall report its maximum power and speed capabilities, but we might not wish to configure it to use those maximum capabilities. This change adds support for the vendor specific host driver to implement power change notify callback. To enable configuring different power modes

[PATCH V5 01/17] scsi: fixing the "type" for well known LUs

2014-09-24 Thread Dolev Raviv
From: Subhash Jadavani Some devices may respond with wrong type for well-known logical units. This patch forces well-known type for devices which doesn't report it correct. Signed-off-by: Subhash Jadavani Signed-off-by: Sujit Reddy Thumma Signed-off-by: Dolev Raviv diff --git a/drivers/scsi/

[PATCH/RESEND V5 13/17] scsi: ufs: Add support for clock gating

2014-09-24 Thread Dolev Raviv
From: Sahitya Tummala The UFS controller clocks can be gated after certain period of inactivity, which is typically less than runtime suspend timeout. In addition to clocks the link will also be put into Hibern8 mode to save more power. The clock gating can be turned on by enabling the capabilit

[PATCH/RESEND V5 17/17] scsi: ufs: definitions for phy interface

2014-09-24 Thread Dolev Raviv
- Adding some of the definitions missing in unipro.h, including power enumeration. - Read Modify Write Line helper function - Indication for the type of suspend Signed-off-by: Dolev Raviv Signed-off-by: Subhash Jadavani Signed-off-by: Yaniv Gardi diff --git a/drivers/scsi/ufs/ufshcd.c b/driv

[PATCH/RESEND V5 15/17] scsi: ufs: Add support for clock scaling using devfreq framework

2014-09-24 Thread Dolev Raviv
From: Sahitya Tummala The clocks for UFS device will be managed by generic DVFS (Dynamic Voltage and Frequency Scaling) framework within kernel. This devfreq framework works with different governors to scale the clocks. By default, UFS devices uses simple_ondemand governor which scales the clocks

[PATCH/RESEND V5 06/17] scsi: ufs: add voting support for host controller power

2014-09-24 Thread Dolev Raviv
From: Raviv Shvili Add the support for voting of the regulator powering the host controller logic. Signed-off-by: Raviv Shvili Signed-off-by: Subhash Jadavani Signed-off-by: Dolev Raviv diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/

[PATCH/RESEND V5 00/17] UFS: Power management support

2014-09-24 Thread Dolev Raviv
This patch seies introduces support for power management in the driver as well as vendor specific initialization - registers, clocks, voltage regulators etc. It includes also a rework for the init sequence and other PM pre-requisite such as write protection support, handling well-known LUN, erro

[PATCH/RESEND V5 08/17] scsi: ufs: improve init sequence

2014-09-24 Thread Dolev Raviv
From: Sujit Reddy Thumma In ->hce_enable_notify() callback the vendor specific initialization may carry out additional DME configuration using UIC commands and hence the UIC command completion interrupt enable bit should be set before the post reset notification. Add retries if the link-startup f

[PATCH V5 11/17] scsi: ufs: add UFS power management support

2014-09-24 Thread Dolev Raviv
From: Subhash Jadavani This patch adds support for UFS device and UniPro link power management during runtime/system PM. Main idea is to define multiple UFS low power levels based on UFS device and UFS link power states. This would allow any specific platform or pci driver to choose the best sui

[PATCH/RESEND V5 16/17] scsi: ufs: tune bkops while power managment events

2014-09-24 Thread Dolev Raviv
From: Subhash Jadavani Add capability to control the auto bkops during suspend. If host explicitly enables the auto bkops (background operation) on device then only device would perform the bkops on its own. If auto bkops is not enabled explicitly and if the device reaches to state where it must

Re: [PATCH v3] mptfusion: enable no_write_same for vmware scsi disks

2014-09-24 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> I'd like to add Chris latests patch and Cc it to stable. Christoph> Martin, given that you're ok with it can you give me a Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this

[PATCH/RESEND V5 14/17] scsi: ufs: Add freq-table-hz property for UFS device

2014-09-24 Thread Dolev Raviv
From: Sahitya Tummala Add freq-table-hz propery for UFS device to keep track of frequencies supported by UFS clocks. Signed-off-by: Sahitya Tummala Signed-off-by: Dolev Raviv diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-

Re: [PATCH block/for-3.17-fixes/core] blk-mq, percpu_ref: implement a kludge for SCSI blk-mq stall during probe

2014-09-24 Thread Jens Axboe
On 09/24/2014 08:33 AM, Tejun Heo wrote: > On Wed, Sep 24, 2014 at 08:30:33AM -0600, Jens Axboe wrote: >> On 09/24/2014 02:23 AM, Christoph Hellwig wrote: >>> Thanks, this fixes the boot stall for me. >>> >>> Tested-by: Christoph Hellwig >> >> Sweet, I'll shove this off today, so we are done for 3

Re: [PATCH block/for-3.17-fixes/core] blk-mq, percpu_ref: implement a kludge for SCSI blk-mq stall during probe

2014-09-24 Thread Tejun Heo
On Wed, Sep 24, 2014 at 08:30:33AM -0600, Jens Axboe wrote: > On 09/24/2014 02:23 AM, Christoph Hellwig wrote: > > Thanks, this fixes the boot stall for me. > > > > Tested-by: Christoph Hellwig > > Sweet, I'll shove this off today, so we are done for 3.17 release. Cool, once it hits the block b

Re: [PATCH block/for-3.17-fixes/core] blk-mq, percpu_ref: implement a kludge for SCSI blk-mq stall during probe

2014-09-24 Thread Jens Axboe
On 09/24/2014 02:23 AM, Christoph Hellwig wrote: > Thanks, this fixes the boot stall for me. > > Tested-by: Christoph Hellwig Sweet, I'll shove this off today, so we are done for 3.17 release. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body o

Re: [PATCH] hpsa: add missing pci_set_master in kdump path

2014-09-24 Thread Christoph Hellwig
On Wed, Sep 24, 2014 at 01:59:04PM +, Elliott, Robert (Server Storage) wrote: > Sorry for the delay - that is fine to go in directly, or will be part > of a larger hpsa series if HP or PMC is able to post one for 3.18. Thanks. For a fix like this I'd prefer to take it ASAP instead of waiting

RE: [PATCH] hpsa: add missing pci_set_master in kdump path

2014-09-24 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Wednesday, September 24, 2014 5:32 AM > To: 'linux-scsi@vger.kernel.org' > Cc: Elliott, Robert (Server Storage); steve.came...@hp.com; Christoph > Hellwig; Handzik, Joe > Subject: Re: [PATCH] hpsa: add missing pci

Re: [PATCH] hpsa: add missing pci_set_master in kdump path

2014-09-24 Thread Christoph Hellwig
Robert or Webb: can you give me a review on this? Given that Robert helped finding it that should be easy.. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.

Re: [PATCH 31/35] qla2xxx: Disable PCI device in shutdown handler.

2014-09-24 Thread Joe Lawrence
On Wed, 24 Sep 2014 03:08:34 -0400 Saurav Kashyap wrote: > From: Chad Dupuis > > Disable the PCI device during shutdown to prevent any races with > other PCI code such as the AER handling code. > > Signed-off-by: Chad Dupuis > Signed-off-by: Saurav Kashyap > --- > drivers/scsi/qla2xxx/qla_o

Re: [PATCH 8/8] IB/srp: Add multichannel support

2014-09-24 Thread Sagi Grimberg
On 9/24/2014 4:38 PM, Sagi Grimberg wrote: On 9/24/2014 4:13 PM, Bart Van Assche wrote: On 24/09/2014 6:22, Sagi Grimberg wrote: Since SRP_LOGIN_REQ/RESP has some free bits why not declare it and activate it when both sides *says* they support it? I'd be much calmer knowing we're on the safe si

Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.

2014-09-24 Thread Joe Lawrence
Hi Saurav, Will these changes conflict with those submitted in August [1] to Christoph's drivers-for-3.18 branch? In particular, "qla2xxx: Fix shost use-after-free on device removal" [2] fixed this same driver unload issue in a slightly different manner. That change was marked for stable as the

Re: [PATCH 8/8] IB/srp: Add multichannel support

2014-09-24 Thread Sagi Grimberg
On 9/24/2014 4:13 PM, Bart Van Assche wrote: On 24/09/2014 6:22, Sagi Grimberg wrote: Since SRP_LOGIN_REQ/RESP has some free bits why not declare it and activate it when both sides *says* they support it? I'd be much calmer knowing we're on the safe side on this... Hello Sagi, Since more than

Re: [PATCH 8/8] IB/srp: Add multichannel support

2014-09-24 Thread Bart Van Assche
On 24/09/2014 6:22, Sagi Grimberg wrote: Since SRP_LOGIN_REQ/RESP has some free bits why not declare it and activate it when both sides *says* they support it? I'd be much calmer knowing we're on the safe side on this... Hello Sagi, Since more than ten years the SRP protocol is an official ANS

Re: [PATCH 8/8] IB/srp: Add multichannel support

2014-09-24 Thread Sagi Grimberg
On 9/23/2014 10:02 PM, Bart Van Assche wrote: On 23/09/2014 10:32, Sagi Grimberg wrote: On 9/19/2014 4:00 PM, Bart Van Assche wrote: Improve performance by using multiple RDMA/RC channels per SCSI host for communicating with an SRP target. Hey Bart, Since you don't seem to negotiate/declare

Re: [PATCH] hpsa: add missing pci_set_master in kdump path

2014-09-24 Thread Tomas Henzl
Christoph, this is a fix for 132aa220b45d60e9b20def1e9d8be9422eed9616 hpsa: refine the pci enable/disable handling which is in 'for-3.18'. If this patch will not be reviewed and added to 3.18 the aforementioned patch needs to be reverted. Tomas On 09/12/2014 02:44 PM, Tomas Henzl wrote: > Ad

[PATCH v5 1/2] arcmsr: simplify ioctl data read/write

2014-09-24 Thread Ching Huang
From: Ching Huang This patch is relative to: http://git.infradead.org/users/hch/scsi-queue.git/tree/drivers-for-3.18:/drivers/scsi/arcmsr change in v5: 1. rename firstindex to getIndex, lastindex to putIndex for readability 2. define ARCMSR_API_DATA_BUFLEN as 1032 3. simplify ioctl data read by

Re: [PATCH block/for-3.17-fixes/core] blk-mq, percpu_ref: implement a kludge for SCSI blk-mq stall during probe

2014-09-24 Thread Christoph Hellwig
Thanks, this fixes the boot stall for me. Tested-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] mptfusion: enable no_write_same for vmware scsi disks

2014-09-24 Thread Christoph Hellwig
On Tue, Sep 23, 2014 at 07:28:04PM -0400, Martin K. Petersen wrote: > > "Chris" == Chris J Arges writes: > > Chris> 1) Does this workaround make sense? Perhaps there is an easier > Chris>way? > > One option is to ship a udev rule that disables write same on VMware > disks. However, I don

Re: [PATCH fix for 3.17 v5] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-24 Thread Greg Kroah-Hartman
On Mon, Sep 15, 2014 at 04:13:52PM +0200, Hans de Goede wrote: > Hi, > > On 09/15/2014 04:08 PM, Greg Kroah-Hartman wrote: > > On Mon, Sep 15, 2014 at 04:04:12PM +0200, Hans de Goede wrote: > >> And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one > >> seems to hang upon rece

[PATCH 02/35] qla2xxx: ISP27xx optimize fwdump entry table lookup.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Since the entry call array is sorted in order of entry type opcode, the search can be terminated as soon as the search key is exceeded. Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_tmpl.c | 10 ++ 1 files changed, 6 inse

[PATCH 04/35] qla2xxx: ISP27xx fwdump template fix insertbuf() routine.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_tmpl.c | 12 ++-- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c index 6da9dd2..6f2f7b2 10064

[PATCH 23/35] qla2xxx: Enable diagnostic port using NVRAM parameters.

2014-09-24 Thread Saurav Kashyap
From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_init.c |4 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/q

[PATCH 17/35] qla2xxx: Add diagnostic port functionality.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Add support for the D-port (diagnostic port) fabric switch feature. (Fabric Switch initiates loopback style port testing) Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c |6 +++--- drivers/scsi/qla2xxx/qla_dbg.c |2 +

[PATCH 28/35] qla2xxx: Honor FCP_RSP retry delay timer field.

2014-09-24 Thread Saurav Kashyap
From: Chad Dupuis Parse the retry delay timer field from the FCP response data and if: - It is not zero - The SCSI status is busy or queue full return SCSI_MLQUEUE_TARGET_BUSY for the number of milliseconds specified in the retry delay timer field. Signed-off-by: Chad Dupuis Signed-off-by: Sa

[PATCH 07/35] qla2xxx: Add endianizer to max_payload_size modifier.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_fw.h |2 +- drivers/scsi/qla2xxx/qla_init.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_fw.h b/drivers/scsi/qla2xxx

[PATCH 21/35] qla2xxx: Add fix in driver unload for pending activity.

2014-09-24 Thread Saurav Kashyap
From: Sawan Chandak Signed-off-by: Sawan Chandak Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 6539513..b9523dc 100644 --- a/drive

[PATCH 31/35] qla2xxx: Disable PCI device in shutdown handler.

2014-09-24 Thread Saurav Kashyap
From: Chad Dupuis Disable the PCI device during shutdown to prevent any races with other PCI code such as the AER handling code. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH 05/35] qla2xxx: Add ISP27xx fwdump template entry T275 (insert buffer).

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |7 +++ drivers/scsi/qla2xxx/qla_tmpl.c | 27 +++ drivers/scsi/qla2xxx/qla_tmpl.h |6 ++ 3 files changed, 36 insertions(+), 4 deletions(-

[PATCH 11/35] qla2xxx: ISPFX00 avoid writing semaphore register in request_irqs().

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Semaphore register does not exist for ISPFx00. Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_isr.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/q

[PATCH 16/35] qla2xxx: Add FA-WWN functionality.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Add support for the FA-WWN (fabric assigned wwn) fabric switch feature. (Fabric Assigned World Wide Port Name) Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |7 ++- drivers/scsi/qla2xxx/qla_fw.h |2 +- drivers/s

[PATCH 03/35] qla2xxx: ISP27xx fwdump template remove high frequency debug logs.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_tmpl.c | 17 - 2 files changed, 1 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/

[PATCH 33/35] qla2xxx: Move warning message to debug level.

2014-09-24 Thread Saurav Kashyap
From: Sawan Chandak Signed-off-by: Sawan Chandak Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_nx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c index 58f3c91..dc763c5 100644 --- a/drivers/s

[PATCH 19/35] qla2xxx: Allow user to change ql2xfdmienable value.

2014-09-24 Thread Saurav Kashyap
From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index c4513e2..8846883 100644 --- a/dri

[PATCH 29/35] qla2xxx: Restore WWPN in case of Loop Dead.

2014-09-24 Thread Saurav Kashyap
From: Himanshu Madhani For FA-WWPN capable device, ISP2031 and ISP27XX, when loop dead is detected by a driver, restore WWPN from NVRAM. Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |3 +-- drivers/scsi/qla2xxx/qla_def.h |3 ++- dr

[PATCH 26/35] qla2xxx: Force use of mailbox interface for flash access commands for ISP27xx.

2014-09-24 Thread Saurav Kashyap
From: Chad Dupuis Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_init.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 1b91771..51cabb9 100644 --- a/drive

[PATCH 22/35] qla2xxx: Declaration error cause stack corruption.

2014-09-24 Thread Saurav Kashyap
From: Quinn Tran Declaration error of mb array in qla2x00_iidma_fcport cause data to be written beyond the array. This ends up causing stack corruption. Signed-off-by: Quinn Tran Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_init.c |2 +- 1 files changed, 1 insertions(+), 1 d

[PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.

2014-09-24 Thread Saurav Kashyap
From: Arun Easi Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 8846883..6539513 100644 --- a/drivers/scsi/ql

[PATCH 15/35] qla2xxx: Add FDMI-2 functionality.

2014-09-24 Thread Saurav Kashyap
From: Himanshu Madhani Add support for the FDMI-2 fabric switch feature. Since FDMI-2 uses code from FDMI-1, some of the existing code needed to be repaired to prevent fields from being overflowed. Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_att

[PATCH 06/35] qla2xxx: Enable fast flash access for ISP83xx.

2014-09-24 Thread Saurav Kashyap
From: Chad Dupuis Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_sup.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_sup.c b/drivers/scsi/qla2xxx/qla_sup.c index bca173e..04b3701 100644 --- a/drivers/s

[PATCH 12/35] qla2xxx: Incorrect debug level on mailbox command print 0x1111.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mbx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index d9aafc0..365cc7c 100644 --- a/driver

[PATCH 30/35] qla2xxx: Mark port lost when we receive an RSCN for it.

2014-09-24 Thread Saurav Kashyap
From: Chad Dupuis Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_isr.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index cc49157..1ac420e 100644

[PATCH 14/35] qla2xxx: ISPFx00 unexpected resets during adapter boot sequence.

2014-09-24 Thread Saurav Kashyap
From: Jan Kulich Signed-off-by: Jan Kulich Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index 274707d..698be01 100644 --- a/drivers/scsi

[PATCH 27/35] qla2xxx: Add missing ISP27xx checks to optrom code.

2014-09-24 Thread Saurav Kashyap
From: Alex Vechersky Signed-off-by: Alex Vechersky Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c |3 ++- drivers/scsi/qla2xxx/qla_bsg.c |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_

[PATCH 18/35] qla2xxx: Fix driver version string message.

2014-09-24 Thread Saurav Kashyap
From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_sup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_sup.c b/drivers/scsi/qla2xxx/qla_sup.c index 4788ecd0..b656a05 100644 --- a

[PATCH 32/35] qla2xxx: Fail adapter initialization on load ram failure.

2014-09-24 Thread Saurav Kashyap
From: Chad Dupuis If we fail to load one of the segments of firmware fail the operation instead of trying to continue which will lead to a system crash since the pointers to the next segment will not be updated correctly. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/sc

[PATCH 25/35] qla2xxx: Free sysfs attributes for ISP27xx.

2014-09-24 Thread Saurav Kashyap
From: Nigel Kirkland Signed-off-by: Nigel Kirkland Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 677239f..9391e4b 100644 --- a/d

[PATCH 24/35] qla2xxx: Disable laser for ISP2031 while unloading driver.

2014-09-24 Thread Saurav Kashyap
From: Himanshu Madhani Nameserver data on FC switch is not refreshed when qla2xxx driver is unloaded. Disabling laser for ISP2031 will force FC switch to rescan ports and clear fdmi entries from Nameserver. Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx

[PATCH 01/35] qla2xxx: ISP27xx add tests for incomplete template.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_tmpl.c |9 + 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/

[PATCH 34/35] qla2xxx: Fix sparse warning in qla_iocb.c file.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_iocb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 150529d..6a6867d 100644 --- a/dri

[PATCH 10/35] qla2xxx: Fix potential return count bug in qla2xxx_get_vpd_field().

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Call scnprintf() instead of snprintf() since the latter may return an incorrect count in cases where the write is truncated to fit. scnprintf() returns the count of what was actually written; snprintf() returns the count of what would have been written. Signed-off-by: Joe Ca

[PATCH 35/35] qla2xxx: Update the driver version to 8.07.00.16-k.

2014-09-24 Thread Saurav Kashyap
Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 4d2c98c..d88b862 100644 --- a/drivers/scs

[PATCH 09/35] qla2xxx: ISP27xx fwdump template error print simplification.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |3 +++ drivers/scsi/qla2xxx/qla_tmpl.c | 31 --- drivers/scsi/qla2xxx/qla_tmpl.h |2 ++ 3 files changed, 9 insertions(+), 27 deletions(-) d

[PATCH 00/35] qla2xxx: Patches for 3.18 scsi "misc" branch.

2014-09-24 Thread Saurav Kashyap
Hi James, Christoph, Please apply the following patches to the scsi tree, misc branch at your earliest convenience. Thanks, ~Saurav Alex Vechersky (1): qla2xxx: Add missing ISP27xx checks to optrom code. Arun Easi (1): qla2xxx: Unload of qla2xxx driver crashes the machine. Chad Dupuis

[PATCH 13/35] qla2xxx: Incorrect linked list semantic in qlafx00_get_fcport().

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index 4775baa..274707d 100644 --- a/driver

[PATCH 08/35] qla2xxx: ISP25xx multiqueue shadow register crash fix.

2014-09-24 Thread Saurav Kashyap
From: Joe Carnuccio When creating request/response queues from qla25xx_setup_mode(), the shadow index register pointers were not being initialized to point at the registers. Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mid.c |2 ++ 1 files change