95K
8 1311k 2187K
Signed-off-by: Mike Christie
---
drivers/scsi/virtio_scsi.c | 78 +++---
1 file changed, 73 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 9d1bdcdc1331..4cf20be668a6 100644
--- a/dr
On 08/20/2019 10:43 AM, Bart Van Assche wrote:
> On 8/20/19 8:27 AM, Mike Christie wrote:
>> tcm loop does not take a reference to the scsi_device at creation/link
>> time then need to release at removal/unlink time. The above
>> scsi_device_put is for the successful scsi_de
On 08/20/2019 09:02 AM, Bart Van Assche wrote:
> On 8/20/19 2:04 AM, Naohiro Aota wrote:
>> If there is no corresponding scsi_device for a LUN,
>> tcm_loop_port_unlink() complains that it "Unable to locate struct
>> scsi_device for " the device and keep %tl_tpg_port_count as is. However,
>> such si
se_cmd at the time when the
> TCMU_CMD_BIT_EXPIRED flag is set because it is going to become invalid
> after calling target_complete_cmd() later in the same function,
> tcmu_check_expired_cmd().
>
> Signed-off-by: Dmitry Fomichev
> ---
Acked-by: Mike Christie
On 08/10/2019 04:19 PM, Dmitry Fomichev wrote:
> In tcmu_handle_completion() function, the variable called read_len is
> always initialized with a value taken from se_cmd structure. If this
> function is called to complete an expired (timed out) out command, the
> session command pointed by se_cmd
On 08/08/2019 03:42 AM, Naohiro Aota wrote:
> On Tue, Aug 06, 2019 at 12:42:20PM -0500, Mike Christie wrote:
>> On 08/05/2019 09:45 PM, Naohiro Aota wrote:
>>> On Mon, Aug 05, 2019 at 11:33:26AM -0500, Mike Christie wrote:
>>>> On 08/05/2019 01:23 AM, Naohiro Aota wro
On 08/05/2019 09:45 PM, Naohiro Aota wrote:
> On Mon, Aug 05, 2019 at 11:33:26AM -0500, Mike Christie wrote:
>> On 08/05/2019 01:23 AM, Naohiro Aota wrote:
>>> targetcli-fb (or its library: rtslib-fb) allows us to create LUN up to
>>> 65535. On the other hand, the kernel
list, and not get
> deleted.
>
> This patch removes the nl_cmd from the list, and clear its data if
> it is not sent successfully.
>
> Signed-off-by: Li Zhong
Acked-by: Mike Christie
On 08/05/2019 01:23 AM, Naohiro Aota wrote:
> targetcli-fb (or its library: rtslib-fb) allows us to create LUN up to
> 65535. On the other hand, the kernel driver is limiting max_lun to 0.
>
> This limitation causes an actual problem when you delete a loopback device
> (using /sys/class/scsi_devic
On 08/02/2019 05:38 AM, Li Zhong wrote:
> If the userspace process crashes while we send the nl msg, it is possible
> that the cmd in curr_nl_cmd of tcmu_dev never gets reset to 0, and
> and returns busy for other commands after the userspace process is
> restartd.
>
> More details below:
>
> /ba
ad of CHAP.
Signed-off-by: Mike Christie
---
drivers/target/iscsi/iscsi_target_nego.c | 41 +++-
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/drivers/target/iscsi/iscsi_target_nego.c
b/drivers/target/iscsi/iscsi_target_nego.c
index 7d794be..055c1cc 1
The following patches fix login negotiation when the user has disabled
authentication, and the initiator is presenting CHAP,None. The problem
is that the target initializes AuthMethod to CHAP (normal session) or
CHAP,None (discovery session), but when the user does authentication=0/
enforce_discove
Move the code to go from iscsi conn to iscsi node auth to a helper
function which will also be used in the next patch.
Signed-off-by: Mike Christie
---
drivers/target/iscsi/iscsi_target_nego.c | 35 +---
1 file changed, 23 insertions(+), 12 deletions(-)
diff --git a
Martin, Do not merge this patch. I am going to self nack it. It could
add a regression where CHAP is not used if an app initializes this file
to 0 during loading before it has setup CHAP then later sets up CHAP
assuming we would use CHAP,None.
On 04/23/2019 08:52 PM, Mike Christie wrote:
> If
target sees CHAP and will try to do that, but it will
always fail since there are no CHAP settings setup.
This has us use CHAP,None if CHAP is setup when writing 0 to
enforce_discovery_auth file and None if CHAP is not setup.
Signed-off-by: Mike Christie
---
drivers/target/iscsi
;cmdr_lock);
> if (!udev->data_bitmap) {
> ret = -ENOMEM;
> @@ -1959,7 +1957,7 @@ static int tcmu_configure_device(struct se_device *dev)
> vfree(udev->mb_addr);
> udev->mb_addr = NULL;
> err_vzalloc:
> - kfree(udev->data_bitmap);
> + bitmap_free(udev->data_bitmap);
> udev->data_bitmap = NULL;
> err_bitmap_alloc:
> kfree(info->name);
>
Looks nice to me. Thanks.
Acked-by: Mike Christie
p yet */
> + if (ret == 0 ||
> +(ret == -ESRCH && cmd == TCMU_CMD_ADDED_DEVICE))
> + return tcmu_wait_genl_cmd_reply(udev);
> +
> return ret;
> }
Looks ok to me.
Acked-by: Mike Christie
Martin, I am self nacking this patch for now.
On 02/01/2019 09:01 PM, Mike Christie wrote:
> genlmsg_multicast_allns used to return -ESRCH even if the message was
> successfully sent to a listener. With commit:
>
> commit cb9f7a9a5c96a773bbc9c70660dc600cfff82f82
> Author:
()
it now will return success if the message was sent to a listener. With
that patch, tcmu can now immediately fail if -ESRCH is returned because
we know there will be no reply.
Signed-off-by: Mike Christie
---
drivers/target/target_core_user.c | 3 ---
1 file changed, 3 deletions(-)
diff
On 01/22/2019 04:10 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> Fixes: 4147ebb3 ("scsi: tcmu: avoid cmd/qfull timers updated whenever a new
> cmd comes")
>
> Reported-by: Dan Carpenter
> Cc: Mike Christie
> Signed-off-by: Xiubo Li
> ---
>
On 01/11/2019 11:31 PM, Kangjie Lu wrote:
> When match_int fails, "arg" is left uninitialized and may contain random
> value, thus should not be used.
> The fix checks if match_int fails, and if so, returns its error code.
>
> Signed-off-by: Kangjie Lu
> ---
> drivers/target/target_core_rd.c | 1
On 12/26/2018 12:48 AM, Kangjie Lu wrote:
> When match_int fails, "arg" is left uninitialized and may contain random
> value, thus should not be used.
> The fix checks if match_int fails, and if so, break.
>
> Signed-off-by: Kangjie Lu
> ---
> drivers/target/target_core_rd.c | 3 ++-
> 1 file ch
gt; cmd in ringbuffer and full queue, and will update them with the next
> cmd's deadline only when the old cmd's deadline is reached or removed
> from the ringbuffer and full queue.
>
> Signed-off-by: Xiubo Li
Work ok for me.
Acked-by: Mike Christie
On 11/20/2018 11:37 PM, Xiubo Li wrote:
> [...]
>>> -is_running = list_empty(&cmd->cmdr_queue_entry);
>>> +is_running = test_bit(TCMU_CMD_BIT_INFLIGHT, &cmd->flags);
>>> se_cmd = cmd->se_cmd;
>>> if (is_running) {
>>> @@ -1289,7 +1319,6 @@ static int tcmu_check_expired_cmd(int
cent VMware ESXi initiators.
> - Allowing clustered (e.g. tcm-user) backends to block such requests,
> avoiding the multi-node reservation state propagation.
>
> When explicitly disabled, PR and RESERVE/RELEASE requests receive
> Invalid Command Operation Code response sense data.
>
Reviewed-by: Mike Christie
On 10/17/2018 02:54 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> Currently there has one cmd timeout timer and one qfull timer for
> each udev, and whenever there has any new coming cmd it will update
> the cmd timer or qfull timer. And for some corner case the timers
> are always working on
On 10/30/2018 09:26 AM, David Disseldorp wrote:
> The new emulate_pr backstore attribute allows for Persistent Reservation
> and SCSI2 RESERVE/RELEASE support to be completely disabled. This can be
> useful for scenarios such as:
> - Ensuring ATS (Compare & Write) usage on recent VMware ESXi initia
On 10/29/2018 06:00 PM, David Disseldorp wrote:
> On Wed, 17 Oct 2018 17:48:17 +0200, David Disseldorp wrote:
>
>> This patchset removes a couple of unused error stat counters and a
>> redundant cumulative counter.
>> I've tagged this patchset RFC, as it may be considered a kernel<->user
>> (confi
rop_nexus(struct ibmvscsis_tport
> *tport)
> /*
>* Release the SCSI I_T Nexus to the emulated ibmvscsis Target Port
>*/
> - target_wait_for_sess_cmds(se_sess);
> target_remove_session(se_sess);
> tport->ibmv_nexus = NULL;
> kfree(nexus);
>
Reviewed-by: Mike Christie
se_sess->cmd_list_wq only when shutdown has actually
> been triggered via se_sess->sess_tearing_down.
>
> Fixes: 00d909a107 ("scsi: target: Make the session shutdown code also wait
> for commands that are being aborted")
> Cc: Bart Van Assche
> Cc: Mike Christie
On 09/18/2018 05:32 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> Currently there has one cmd timeout timer for each udev, and whenever
> there has any new coming cmd it will update the timer. And for some
> corner case the timer is always working only for the ringbuffer's
> newest cmd. That'
m v1
>
> Changes from v1:
> * expand commit message
> * use an sg_mapping_iter to track where we are in the PI SGL
>
Looks ok to me.
Reviewed-by: Mike Christie
On 09/04/2018 11:21 AM, Greg Edwards wrote:
> static int
> -iblock_alloc_bip(struct se_cmd *cmd, struct bio *bio)
> +iblock_alloc_bip(struct se_cmd *cmd, struct bio *bio,
> + struct sg_mapping_iter *miter)
> {
> struct se_device *dev = cmd->se_dev;
> struct blk_integrity
->dev_attrib.pi_prot_type) {
> + rc = iblock_alloc_bip(cmd, bio, &prot_miter);
> + if (rc)
> + goto fail_put_bios;
> + }
> +
> if (bio_cnt >= IBLOCK_MAX_BIO_PER_TASK) {
> iblock_submit_bios(&list);
> bio_cnt = 0;
> @@ -762,7 +782,7 @@ iblock_execute_rw(struct se_cmd *cmd, struct scatterlist
> *sgl, u32 sgl_nents,
> }
>
> if (cmd->prot_type && dev->dev_attrib.pi_prot_type) {
> - int rc = iblock_alloc_bip(cmd, bio_start);
> + rc = iblock_alloc_bip(cmd, bio, &prot_miter);
> if (rc)
> goto fail_put_bios;
> }
>
Seems ok to me.
Reviewed-by: Mike Christie
On 08/29/2018 03:36 PM, Greg Edwards wrote:
> When T10 PI is enabled on a backing device for the iblock backstore, the
> PI SGL for the entire command is attached to the first bio only. This
> works fine if the command is covered by a single bio, but can result in
> ref tag errors in the client fo
00 00 00
==
Signed-off-by: Vincent Pelletier
[rebased against idr/ida changes and to handle ret review comments from Matthew]
Signed-off-by: Mike Christie
Cc: Matthew Wilcox
---
v2:
- Rebase against Linus's tree with idr/ida changes.
- Always return -ENOMEM on failure becau
The following patches are login fixes from the list. The set has been rebased
against Linus's current tree so they apply over the idr/ida patches that have
been merged.
that are only needed during login.
Signed-off-by: Mike Christie
---
drivers/target/iscsi/iscsi_target.c | 9 +-
drivers/target/iscsi/iscsi_target_login.c | 141 --
drivers/target/iscsi/iscsi_target_login.h | 2 +-
3 files changed, 77 insertions(+), 75
On 08/27/2018 12:03 AM, Matthew Wilcox wrote:
> On Fri, Aug 24, 2018 at 01:37:10PM -0500, Mike Christie wrote:
>> The following patchset is a round up of login fixes that have been
>> on the list and in Mathew's tree. They fix a couple of bugs in the
>> iscsi login failur
that are only needed during login.
Signed-off-by: Mike Christie
---
drivers/target/iscsi/iscsi_target.c | 9 +-
drivers/target/iscsi/iscsi_target_login.c | 141 --
drivers/target/iscsi/iscsi_target_login.h | 2 +-
3 files changed, 77 insertions(+), 75
The following patchset is a round up of login fixes that have been
on the list and in Mathew's tree. They fix a couple of bugs in the
iscsi login failure handling path.
The patches were made against Martin's 4.19/scsi-queue branch.
Matthew, the first patch is one that I had sent to you that had a
00 00 00
==
Also, let idr_alloc return value through instead of replacing it with -ENOMEM,
as it is already a negative value and caller checks sign, not exact value.
Signed-off-by: Vincent Pelletier
Signed-off-by: Mike Christie
---
drivers/target/iscsi/iscsi_target_log
ion leak in...")
Signed-off-by: Mike Christie
Cc: Matthew Wilcox
---
drivers/target/iscsi/iscsi_target_login.c | 35 ++-
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_login.c
b/drivers/target/iscsi/iscsi_targ
On 08/23/2018 09:11 PM, Martin K. Petersen wrote:
>
> Mike,
>
>> this was made over that patch that was going through Mathew's tree. I
>> do not know exactly which one though. It is in next here
>
> Doesn't look like Linus will pull Matthew's tree for 4.19.
>
It looks like there is also going t
On 08/08/2018 02:31 PM, Greg Edwards wrote:
> When T10 PI is enabled on a backing device for the iblock backstore, the
> PI SGL for the entire command is attached to the first bio only. This
> works fine if the command is covered by a single bio, but results in
> integrity verification errors for
On 08/15/2018 07:08 AM, Vincent Pelletier wrote:
> Do not fail authentication after target is happy with initiator's
> credentials, when target is configured to authenticate itself to an
> initiator but current initiator did not provide required values.
> Also, downgrade "Could not find CHAP_I." to
ENOMEM;
> goto remove_idr;
> }
>
> @@ -356,6 +355,7 @@ static int iscsi_login_zero_tsih_s1(
> if (IS_ERR(sess->se_sess)) {
> iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
> ISCSI_LOGIN_STATUS_NO_
On 08/15/2018 10:59 AM, Mike Christie wrote:
> On 08/15/2018 05:19 AM, Vincent Pelletier wrote:
>> Fixes a use-after-free reported by KASAN when later
>> iscsi_target_login_sess_out gets called and it tries to access
>> conn->sess->se_sess:
>>
>> Disab
login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
> ISCSI_LOGIN_STATUS_NO_RESOURCES);
> + ret = -ENOMEM;
> goto free_sess;
> }
>
> @@ -370,7 +369,7 @@ static int iscsi_login_zero_tsih_s1(
> free_sess:
> kfree(sess);
On 08/15/2018 10:44 AM, Mike Christie wrote:
> On 08/15/2018 05:19 AM, Vincent Pelletier wrote:
>> Fixes a use-after-free reported by KASAN when later
>> iscsi_target_login_sess_out gets called and it tries to access
>> conn->sess->se_sess:
>>
>> Disab
On 08/15/2018 05:19 AM, Vincent Pelletier wrote:
> Fixes a use-after-free reported by KASAN when later
> iscsi_target_login_sess_out gets called and it tries to access
> conn->sess->se_sess:
>
> Disabling lock debugging due to kernel taint
> iSCSI Login timeout on Network Portal [::]:3260
> iSCSI
On 08/13/2018 04:42 PM, Mike Christie wrote:
> On 08/13/2018 02:48 PM, Mike Christie wrote:
>> On 08/11/2018 10:51 PM, Vincent Pelletier wrote:
>>> On Sun, 12 Aug 2018 02:55:31 +, Vincent Pelletier
>>> wrote:
>>>> Aug 12 04:44:53 boke kernel: [ 6
On 08/13/2018 02:48 PM, Mike Christie wrote:
> On 08/11/2018 10:51 PM, Vincent Pelletier wrote:
>> On Sun, 12 Aug 2018 02:55:31 +, Vincent Pelletier
>> wrote:
>>> Aug 12 04:44:53 boke kernel: [ 64.737069] BUG: KASAN: use-after-free in
>>> iscsi_target_
On 08/11/2018 10:51 PM, Vincent Pelletier wrote:
> On Sun, 12 Aug 2018 02:55:31 +, Vincent Pelletier
> wrote:
>> Aug 12 04:44:53 boke kernel: [ 64.737069] BUG: KASAN: use-after-free in
>> iscsi_target_login_sess_out.cold.11+0x58/0x123 [iscsi_target_mod]
>> Aug 12 04:44:53 boke kernel: [ 6
On 08/03/2018 03:48 AM, Maurizio Lombardi wrote:
> When HeaderDigest is enabled on aarch64 machines, target triggers
> a lot of failed crc checksum errors:
>
> example of output in dmesg:
> [ 154.495031] HeaderDigest CRC32C failed, received 0x60571c8d, computed
> 0x288c3ab9
> [ 154.583821] Got
The following patches were made over Martin's for-next branch. They are
the patches from my session RFC patchset that were reviewed by Bart and
Christoph and are fixes/cleanups that I think are ok changes in general.
save/restore call.
Signed-off-by: Mike Christie
Reviewed-by: Bart Van Assche
Reviewed-by: Christoph Hellwig
---
drivers/target/target_core_transport.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/target/target_core_transport.c
b/drivers/target
This adds a function to remove a session which should be used by drivers
that use target_setup_session. The next patches will convert the target
drivers to use this new function.
Signed-off-by: Mike Christie
Reviewed-by: Bart Van Assche
Reviewed-by: Christoph Hellwig
Cc: Chris Boot
Cc: Bryant
will then add a remove function to match the setup in
this one, so it should make sense for all drivers, except iscsi, to just
call those 2 functions to setup and remove a session.
iscsi will continue to be the odd driver.
Signed-off-by: Mike Christie
Reviewed-by: Bart Van Assche
Reviewed-by
Just have iscsit_start_nopin_timer grab the lock and call
__iscsit_start_nopin_timer.
Signed-off-by: Mike Christie
Reviewed-by: Christoph Hellwig
---
drivers/target/iscsi/iscsi_target_util.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/target
This converts the drivers that called transport_deregister_session_configfs
and then immediately called transport_deregister_session to use
target_remove_session.
Signed-off-by: Mike Christie
Reviewed-by: Bart Van Assche
Reviewed-by: Christoph Hellwig
Cc: Chris Boot
Cc: Bryant G. Ly
Cc
transport_init_session_tags is only called from target_core_transport.c
so make it static.
Signed-off-by: Mike Christie
Reviewed-by: Bart Van Assche
Reviewed-by: Christoph Hellwig
---
drivers/target/target_core_transport.c | 7 +++
include/target/target_core_fabric.h| 2 --
2 files
tpg and sess->fabric_sess_ptr from configfs
accessible functions, so they will see no difference.
Signed-off-by: Mike Christie
Reviewed-by: Bart Van Assche
Reviewed-by: Christoph Hellwig
Cc: Felipe Balbi
Cc: Sebastian Andrzej Siewior
Cc: Andrzej Pietrasiewicz
Cc: Michael S. Tsirkin
Cc: J
transport_deregister_session_configfs
only prevents access from configfs via tpg removal and its call to the
close_session callback for that driver, and this is already protected by
the ft_lport_lock and its port lookup handling.
Signed-off-by: Mike Christie
Reviewed-by: Bart Van Assche
Reviewed-by
On 08/01/2018 11:44 AM, Mike Christie wrote:
> 1. Create a file named "acl" in the session's dir.
> 2. For dynamic_node_acl=0 the acl file will return a empty string or
Miswrote this.
Above should be dynamic_node_acl=1
> "generate_node_acls=1" or "demo mod
On 07/19/2018 12:07 PM, Bart Van Assche wrote:
> On Thu, 2018-07-19 at 11:38 -0500, Mike Christie wrote:
>> On 07/19/2018 10:37 AM, Bart Van Assche wrote:
>>> The general recommendation for configfs is that each attribute contains a
>>> single value, just like for sys
We use unsigned long, size_t and u64 for dev_size. This has us
standardize on u64.
Signed-off-by: Mike Christie
---
drivers/target/target_core_user.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/target/target_core_user.c
b/drivers/target
Do not allow userspace to block or reset the ring until the device has
been configured. This will prevent the bug where userspace can write to
those files and access mb_addr before it has been setup.
Signed-off-by: Mike Christie
---
drivers/target/target_core_user.c | 10 ++
1 file
Use the lio core helper to check if the device is configured.
Signed-off-by: Mike Christie
---
drivers/target/target_core_user.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/target/target_core_user.c
b/drivers/target/target_core_user.c
index b010ed7
-off-by: Mike Christie
---
drivers/target/target_core_user.c | 37 ++---
1 file changed, 14 insertions(+), 23 deletions(-)
diff --git a/drivers/target/target_core_user.c
b/drivers/target/target_core_user.c
index 969ccba..cfe4f4b 100644
--- a/drivers/target
data_bitmap has been setup. If it has
then we fail the max_blocks update operation.
Signed-off-by: Mike Christie
---
drivers/target/target_core_user.c | 73 +--
1 file changed, 40 insertions(+), 33 deletions(-)
diff --git a/drivers/target/target_core_user.c
b
The following patches were made over Martin's for-next branch.
The first patch fixes a locking bug in the command setup path. The rest
of the patches fix several bugs and cleanup the setup and configuration
code paths.
Use INIT_LIST_HEAD to initialize node list head.
Signed-off-by: Mike Christie
---
drivers/target/target_core_user.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/target/target_core_user.c
b/drivers/target/target_core_user.c
index fafe65f..b010ed7 100644
--- a/drivers/target
The caller of queue_cmd_ring grabs and releases the lock, so
the tcmu_setup_cmd_timer failure handling inside queue_cmd_ring
should not call mutex_unlock.
Signed-off-by: Mike Christie
---
drivers/target/target_core_user.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/target
The tcmu dev is added to the list of tcmu devices during configuration.
At this time the tcmu setup has completed, but lio core has not
completed its setup. The device is not yet usable so do not try to unmap
blocks from it
Signed-off-by: Mike Christie
---
drivers/target/target_core_user.c | 5
This just adds a helper function to check if a device is configured and
it converts the target users to use it. The next patch will add a
backend module user so those types of modules do not have to know the
lio core details.
Signed-off-by: Mike Christie
---
drivers/target
On 07/20/2018 04:08 PM, Mike Christie wrote:
> On 07/19/2018 11:13 AM, Mike Christie wrote:
>> > On 07/19/2018 10:15 AM, Bart Van Assche wrote:
>>> >> On Wed, 2018-07-18 at 20:02 -0500, Mike Christie wrote:
>>>> >>> On 07/18/2018 07:03 PM, Mike C
On 07/19/2018 11:13 AM, Mike Christie wrote:
> On 07/19/2018 10:15 AM, Bart Van Assche wrote:
>> On Wed, 2018-07-18 at 20:02 -0500, Mike Christie wrote:
>>> On 07/18/2018 07:03 PM, Mike Christie wrote:
>>>> On 07/18/2018 05:09 PM, Bart Van Assche wrote:
>>>&
On 07/19/2018 07:34 PM, Xiubo Li wrote:
> On 2018/7/19 23:49, Mike Christie wrote:
>> On 07/19/2018 09:30 AM, xiu...@redhat.com wrote:
>>> From: Xiubo Li
>>>
>>> The logs are:
>>>
>>> BUG: unable to handle kernel NULL pointer dereference at 0
On 07/19/2018 03:47 PM, Christoph Hellwig wrote:
> On Thu, Jul 19, 2018 at 05:07:59PM +, Bart Van Assche wrote:
>> Initially configfs did not support creation of a directory from the kernel
>> side. Last time I brought this up with Christoph he replied that this
>> functionality has been added
On 07/19/2018 10:37 AM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> +if (se_sess->se_tpg->se_tpg_tfo->sess_get_initiator_sid) {
>> +len = snprintf(page, PAGE_SIZE, "%s 0x%6phN\n",
>> +
On 07/19/2018 10:15 AM, Bart Van Assche wrote:
> On Wed, 2018-07-18 at 20:02 -0500, Mike Christie wrote:
>> On 07/18/2018 07:03 PM, Mike Christie wrote:
>>> On 07/18/2018 05:09 PM, Bart Van Assche wrote:
>>>> [ ... ]
>>>> is that these involve a transpo
On 07/19/2018 09:30 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> The logs are:
>
> BUG: unable to handle kernel NULL pointer dereference at 0040
> IP: [] tcmu_reset_ring_store+0x149/0x240 [target_core_user]
> PGD 8e254067 PUD e255067 PMD 0
> Oops: 0002 [#1] SMP
> [...]
>
On 07/18/2018 07:15 PM, Mike Christie wrote:
> On 07/18/2018 05:19 PM, Bart Van Assche wrote:
>> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>>> diff --git a/drivers/target/target_core_transport.c
>>> b/drivers/target/target_core_transport.c
>>> ind
On 07/18/2018 06:04 PM, Mike Christie wrote:
> On 07/18/2018 05:41 PM, Bart Van Assche wrote:
>> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>>> Export the initiator port info in configfs
>>
>> Does configfs support soft links? Can this information be e
On 07/18/2018 07:03 PM, Mike Christie wrote:
> On 07/18/2018 05:09 PM, Bart Van Assche wrote:
>> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>>> The isid is 48 bits, and in hex string format it's 12 bytes.
>>> We are currently copying the 12 byte h
On 07/18/2018 05:46 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> + int (*test_session)(struct se_session *, u8 timeout);
>
> Does any of the patches in this series define a test_session callback
> function?
Patch 14 does.
>
On 07/18/2018 05:19 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> diff --git a/drivers/target/target_core_transport.c
>> b/drivers/target/target_core_transport.c
>> index 75ddbbb..97a1ee5 100644
>> --- a/drivers/target/targe
On 07/18/2018 05:09 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> The isid is 48 bits, and in hex string format it's 12 bytes.
>> We are currently copying the 12 byte hex string to a u64
>> so we can easily compare it, but this ha
On 07/18/2018 05:41 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> Export the initiator port info in configfs
>
> Does configfs support soft links? Can this information be exported as a
> soft link from the session directory to the stru
On 07/15/2018 06:16 PM, Mike Christie wrote:
> TODO:
> 1. handle target_fabric_register_session failure in iscsi target.
>
I fixed this in the updated attached patch. So Bodo and reviewers please
use that instead.
>From 895edd5d20df208c3dfae8d826a3c3fcbd68 Mon Sep 17 00:00:00 200
Export the initiator port info in configfs
Signed-off-by: Mike Christie
---
drivers/target/target_core_fabric_configfs.c | 48
1 file changed, 48 insertions(+)
diff --git a/drivers/target/target_core_fabric_configfs.c
b/drivers/target/target_core_fabric_configfs.c
port.
Signed-off-by: Mike Christie
---
drivers/target/iscsi/iscsi_target_login.c| 2 +-
drivers/target/target_core_fabric_configfs.c | 71 ++--
drivers/target/target_core_transport.c | 20 +---
include/target/target_core_base.h| 1 +
include
Send a iscsi nop as a ping for the test_session callout.
Signed-off-by: Mike Christie
---
drivers/target/iscsi/iscsi_target.c | 8 ++--
drivers/target/iscsi/iscsi_target_configfs.c | 47 ++
drivers/target/iscsi/iscsi_target_util.c | 60
Just have iscsit_start_nopin_timer grab the lock and
call __iscsit_start_nopin_timer.
Signed-off-by: Mike Christie
---
drivers/target/iscsi/iscsi_target_util.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_util.c
b
e set
the session has been full registered.
Signed-off-by: Mike Christie
---
drivers/target/target_core_transport.c | 13 +++--
include/target/target_core_base.h | 1 +
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/target/target_core_transport.c
b/drivers/t
on for the
user initiated test nop.
Signed-off-by: Mike Christie
---
drivers/target/iscsi/iscsi_target_util.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_util.c
b/drivers/target/iscsi/iscsi_target_util.c
index 5a645b5..c51c14e
ssion
dir under the tpg. We can then export info like initiator
name and if needed isid. These patches will then also add
some files to test sessions.
TODO:
1. handle target_fabric_register_session failure in iscsi target.
Signed-off-by: Mike Christie
---
drivers/target/iscsi/iscsi_tar
transport_init_session_tags is only called from target_core_transport.c
so make it static.
Signed-off-by: Mike Christie
---
drivers/target/target_core_transport.c | 7 +++
include/target/target_core_fabric.h| 2 --
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers
out.
Signed-off-by: Mike Christie
---
Documentation/target/tcm_mod_builder.py | 8
drivers/infiniband/ulp/srpt/ib_srpt.c| 15 ---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 6 --
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 7 ---
drivers/target/is
1 - 100 of 677 matches
Mail list logo