RE: [PATCH v1 0/2] scsi: ufs: Fix broken hba->outstanding_tasks

2019-07-24 Thread Avri Altman
Stanley, > > Hi Avri, > > On Mon, 2019-07-22 at 06:10 +, Avri Altman wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > > > Currently bits in hba->outstanding_tasks are cleared only after their > > > > > corresponding task management commands are successfully done > by > > > > > __ufsh

[PATCH 3/3] fcoe: pass in fcoe_rport structure instead of fc_rport_priv

2019-07-24 Thread Hannes Reinecke
Instead of using the generic 'fc_rport_priv' structure as argument and then having to painstakingly outcast this to fcoe_rport we should be passing the fcoe_rport structure itself and reduce complexity. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/scsi/fcoe/fcoe_ctl

[PATCH 2/3] fcoe: Embed fc_rport_priv in fcoe_rport structure

2019-07-24 Thread Hannes Reinecke
Gcc-9 complains for a memset across pointer boundaries, which happens as the code tries to allocate a flexible array on the stack. Turns out we cannot do this without relying on gcc-isms, so with this patch we'll embed the fc_rport_priv structure into fcoe_rport, can use the normal 'container_of' o

[PATCH 1/3] libfc: Whitespqce cleanup in libfc.h

2019-07-24 Thread Hannes Reinecke
No functional change. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- include/scsi/libfc.h | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/include/scsi/libfc.h b/include/scsi/libfc.h index 76cb9192319a.

[PATCHv3 0/3] fcoe: cleanup fc_rport_priv usage

2019-07-24 Thread Hannes Reinecke
Hi all, the fcoe vn2vn code is using the 'fc_rport_priv' structure as argument to its internal function, but is really expecting a struct fcoe_rport to immediately follow this one. This is not only confusing but also an error for new compilers. So clean up the usage by embedding fc_rport_priv into

LOANS !!!

2019-07-24 Thread DIAL DIRECT LOANS SA
Dial Direct Loan SA Consolidate your debts with Dial Direct Loan SA for your peace of mind at a fixed interest rate of 4.75%,personal and business loans are also welcome.For details file in your applications by sending an email to:dialdirectloan...@mail2consultant.com. Yours in Service, Sus

[PATCH 0/2] hpsa updates

2019-07-24 Thread Don Brace
These patches are based on Linus's tree The changes are: hpsa-correct-scsi-command-status-issue-after-reset . ensure command status is 0 for submitted commands. hpsa-remove-printing-internal-cdb-on-tag-collision . remove racy call to print an scsi command from our internal submission queue.

[PATCH 1/2] hpsa: correct scsi command status issue after reset

2019-07-24 Thread Don Brace
Reviewed-by: Bader Ali - Saleh Reviewed-by: Scott Teel Reviewed-by: Scott Benesh Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 43a6b

[PATCH 2/2] hpsa: remove printing internal cdb on tag collision

2019-07-24 Thread Don Brace
- remove racy printing of internal commands. . completion thread can be cleaning up the command in parallel Reviewed-by: Bader Ali - Saleh Reviewed-by: Scott Teel Reviewed-by: Scott Benesh Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 -- 1 file changed

[PATCH] scsi: qla2xxx: replace snprintf with strscpy

2019-07-24 Thread Wang Xiayang
As commit a86028f8e3ee ("staging: most: sound: replace snprintf with strscpy") suggested, using snprintf without a format specifier is potentially risky if a0->vendor_name or a0->vendor_pn mistakenly contain format specifiers. In addition, as compared in the implementation, strscpy looks more light