From: Jitendra
OS not responding when running 2 port traffic on 72 CPUs system.
be2iscsi IRQs gets affined to CPU0 when irqbalancer is disabled.
be_iopoll processing completions in BLOCK_IOPOLL_SOFTIRQ hogged CPU0.
1. Use budget to exit the polling loop.
: Hannes Reinecke [mailto:h...@suse.de]
Sent: Monday, December 14, 2015 8:54 PM
To: Jitendra Bhivare; linux-scsi@vger.kernel.org; micha...@cs.wisc.edu
Subject: Re: [PATCH 6/9] be2iscsi: Fix IOPOLL implementation
On 12/14/2015 07:11 AM, Jitendra Bhivare wrote:
> From: Jitendra <jitendr
Message-
From: Hannes Reinecke [mailto:h...@suse.de]
Sent: Monday, December 14, 2015 8:34 PM
To: Jitendra Bhivare; linux-scsi@vger.kernel.org; micha...@cs.wisc.edu
Subject: Re: [PATCH 1/9] be2iscsi: Fix soft lockup in mgmt_get_all_if_id
path using bmbx
On 12/14/2015 07:10 AM, Jitendra Bhivare
From: Jitendra
Change return value of completed MCC EBUSY to EINVAL.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_cmds.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
From: Jitendra
System crash in I+T card personality
Fix to add validation for ULP in initiator mode, physical port number,
and supported queue, icd, cid counts.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_main.c |2
From: Jitendra
Configuring VLAN parameters through IPv6 interface was not supported in driver.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_iscsi.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git
From: Jitendra
Log messages for misconfigured transceivers reported by FW.
Register async events that driver handles using MCC_CREATE_EXT ioctl.
Errors messages for faulted/uncertified/unqualified optics are logged.
Added IOCTL to get port_name to be displayed in
From: Jitendra
FW recommended timeout for all mbox command is 30s.
Use msleep instead mdelay to relinquish CPU when polling for
mbox completion.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_cmds.c |5 +++--
1 files
From: Jitendra
alloc_mcc_tag/free_mcc_tag is now done under mcc_lock spin_lock
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_cmds.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git
From: Jitendra
We are taking mbox_lock spinlock which disables pre-emption before we poll
for mbox completion. Waiting there with spinlock held in excess of 20s will
cause soft lockup.
Actual fix is to change mbox_lock to mutex.
The changes are done in phases.
From: Jitendra
Use of mutex_lock_interruptible can return -EINTR, handle and log
the error.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_iscsi.c |7 ---
drivers/scsi/be2iscsi/be_mgmt.c | 10 ++
2 files
From: Jitendra
This is second part of actual fix for soft lockup.
All mbox cmds issued using BMBX and MCC are synchronized using mutex
mbox_lock instead of spin_lock. Used mutex_lock_interruptible where
ever possible.
Signed-off-by: Jitendra
From: Jitendra
Replace lock based tag_state manipulations with atomic operations.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be.h |2 +-
drivers/scsi/be2iscsi/be_cmds.c | 26 --
2 files
From: Jitendra
Null pointer dereference in shutdown path after taking dump.
Shutdown path is not needed as FW comes up clean every time during probe
after issuing FUNCTION reset MBOX command.
Signed-off-by: Jitendra
---
From: Jitendra
This patch is generated against for-next branch.
Jitendra (15):
be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx
be2iscsi: Fix mbox synchronization replacing spinlock with mutex
be2iscsi: Fix to use atomic operations for
From: Jitendra
Async link event provides port_speed info. Use the same to report in
ISCSI_HOST_PARAM_PORT_SPEED query. Removed link status query IOCTL used
to do the same.
25G and 40G are defined in kernel enum iscsi_port_speed.
Fixed get_nic_conf structure
From: Jitendra
Login/Logout loop was hanging after few hours. /var/log/message showed
that alloc_wrb_handle() function was not able to allocate any new WRB.
Sep 11 11:25:22 Jhelum10 kernel: connection32513:0: Could not send nopout
Sep 11 11:25:22 Jhelum10 kernel:
so sure what you are suggesting.
port_name IOCTL is needed to display the error message.
Will split FW config validation.
Thanks,
JB
-Original Message-
From: Hannes Reinecke [mailto:h...@suse.de]
Sent: Monday, December 14, 2015 8:49 PM
To: Jitendra Bhivare; linux-scsi@vger.kernel.
From: Jitendra
Log messages for misconfigured transceivers reported by FW.
Register async events that driver handles using MCC_CREATE_EXT ioctl.
Errors messages for faulted/uncertified/unqualified optics are logged.
Added FW config validation.
Signed-off-by:
From: Jitendra
Null pointer dereference in shutdown path after taking dump.
Shutdown path is not needed as FW comes up clean every time during probe
after issuing FUNCTION reset MBOX command.
Signed-off-by: Jitendra
---
From: Jitendra
Async link event provides port_speed info. Use the same to report in
ISCSI_HOST_PARAM_PORT_SPEED query. Removed link status query IOCTL used
to do the same.
25G and 40G are defined in kernel enum iscsi_port_speed.
Fixed get_nic_conf structure
From: Jitendra
This is second part of actual fix for soft lockup.
All mbox cmds issued using BMBX and MCC are synchronized using mbox_lock.
alloc_mcc_tag/free_mcc_tag is done under mcc_lock and tag_state is
accessed using atomic operations.
Mailbox command time
From: Jitendra
This patch is generated against for-next branch.
Jitendra (9):
be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx
be2iscsi: Fix mbox synchronization replacing spinlock with mutex
be2iscsi: Fix to remove shutdown entry point
From: Jitendra
Added VLAN operations in set IPv6 address for interface.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_iscsi.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git
From: Jitendra
Login/Logout loop was hanging after few hours. /var/log/message showed
that alloc_wrb_handle() function was not able to allocate any new WRB.
Sep 11 11:25:22 Jhelum10 kernel: connection32513:0: Could not send nopout
Sep 11 11:25:22 Jhelum10 kernel:
From: Jitendra
OS not responding when running 2 port traffic on 72 CPUs system.
be2iscsi IRQs gets affined to CPU0 when irqbalancer is disabled.
be_iopoll processing completions in BLOCK_IOPOLL_SOFTIRQ hogged CPU0.
1. Use budget to exit the polling loop in
From: Jitendra
Driver version: 11.0.0.0
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_main.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h
It stands for Dual ULP Aware. Will add a comment explaining that.
Thanks,
JB
-Original Message-
From: Hannes Reinecke [mailto:h...@suse.de]
Sent: Friday, December 18, 2015 2:34 PM
To: Jitendra Bhivare; linux-scsi@vger.kernel.org; micha...@cs.wisc.edu
Subject: Re: [PATCH 10/15] be2iscsi
Yes, the faults are not being used, it just adds to the confusion, we just
intend to get the link state change - UP or DOWN.
-Original Message-
From: Hannes Reinecke [mailto:h...@suse.de]
Sent: Friday, December 18, 2015 2:34 PM
To: Jitendra Bhivare; linux-scsi@vger.kernel.org; micha
:44 PM
To: Jitendra Bhivare; linux-scsi@vger.kernel.org
Subject: Re: [PATCH 03/15] be2iscsi: Fix to use atomic operations for
tag_state
On 12/20/15 3:01 AM, Mike Christie wrote:
> On 12/20/2015 01:44 AM, Mike Christie wrote:
>
>>> diff --git a/drivers/scsi/be2iscsi/be_cmds.c
>
Change return value of completed MCC EBUSY to EINVAL.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
System crash in I+T card personality
Fix to add validation for ULP in initiator mode, physical port number,
and supported queue, icd, cid counts.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
drivers/scsi/be2iscsi/be_main.h
alloc_mcc_tag/free_mcc_tag is now done under mcc_lock spin_lock
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/
Log messages for misconfigured transceivers reported by FW.
Register async events that driver handles using MCC_CREATE_EXT ioctl.
Errors messages for faulted/uncertified/unqualified optics are logged.
Added IOCTL to get port_name to be displayed in error message.
Signed-off-by: Jitendra Bhivare
Async link event provides port_speed info. Cache the port_speed info
and use the same to report in ISCSI_HOST_PARAM_PORT_SPEED query.
Removed link status query IOCTL used to do the same.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_cmds.c
Driver version: 11.0.0.0
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index 41c708c..16a6fd0
iscsi_port_speed and iscsi_port_speed_names have new entries for
25Gbps and 40Gbps link speeds.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/scsi_transport_iscsi.c | 2 ++
include/scsi/iscsi_if.h | 2 ++
2 files changed, 4 insertions(+)
Configuring VLAN parameters through IPv6 interface was not supported in driver.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_iscsi.c | 4
1 file changed, 4 insertions(+)
diff --git a/
is done only after iopoll completes.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 2 +-
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
drivers/scsi/be2iscsi/be_
Null pointer dereference in shutdown path after taking dump.
Shutdown path is not needed as FW comes up clean every time during probe
after issuing FUNCTION reset MBOX command.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...
This is second part of actual fix for soft lockup.
All mbox cmds issued using BMBX and MCC are synchronized using mutex
mbox_lock instead of spin_lock. Used mutex_lock_interruptible where
ever possible.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be
This patch is generated against for-next branch.
Jitendra Bhivare (17):
be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx
be2iscsi: Fix mbox synchronization replacing spinlock with mutex
be2iscsi: Fix to synchronize tag allocation using spin_lock
be2iscsi: Set mbox timeout
-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 60 -
drivers/scsi/be2iscsi/be_mgmt.c | 32 +++---
2 files changed, 51 insertions(+), 41 deleti
Use of mutex_lock_interruptible can return -EINTR, handle and log
the error.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_iscsi.c | 7 ---
drivers/scsi/be2iscsi/be_mgmt.c | 10 ++-
-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 48 +++-
drivers/scsi/be2iscsi/be_cmds.h | 32 +--
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
3 files changed, 34 insertions(+), 48 del
FW recommended timeout for all mbox command is 30s.
Use msleep instead mdelay to relinquish CPU when polling for
mbox completion.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 5 +
for posting the login-negotiated parameters back in pool.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_main.c | 72 -
1 file changed, 49 insertions(+),
Change return value of completed MCC EBUSY to EINVAL.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
Null pointer dereference in shutdown path after taking dump.
Shutdown path is not needed as FW comes up clean every time during probe
after issuing FUNCTION reset MBOX command.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...
System crash in I+T card personality
Fix to add validation for ULP in initiator mode, physical port number,
and supported queue, icd, cid counts.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
drivers/scsi/be2iscsi/be_main.h
Async link event provides port_speed info. Cache the port_speed info
and use the same to report in ISCSI_HOST_PARAM_PORT_SPEED query.
Removed link status query IOCTL used to do the same.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_cmds.c
This is second part of actual fix for soft lockup.
All mbox cmds issued using BMBX and MCC are synchronized using mutex
mbox_lock instead of spin_lock. Used mutex_lock_interruptible where
ever possible.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be
.
Removed MCC_TAG_STATE_COMPLETED. When posted its in running state and
the running state is cleared in be_mcc_compl_process_isr.
be_mcc_notify now takes tag argument to set it to running state.
Use bit operations for tag_state. Use barriers before setting the state.
Signed-off-by: Jitendra Bhivare
Log messages for misconfigured transceivers reported by FW.
Register async events that driver handles using MCC_CREATE_EXT ioctl.
Errors messages for faulted/uncertified/unqualified optics are logged.
Added IOCTL to get port_name to be displayed in error message.
Signed-off-by: Jitendra Bhivare
Use of mutex_lock_interruptible can return -EINTR, handle and log
the error.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_iscsi.c | 7 ---
drivers/scsi/be2iscsi/be_mgmt.c | 10 ++-
Configuring VLAN parameters through IPv6 interface was not supported in driver.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_iscsi.c | 4
1 file changed, 4 insertions(+)
diff --git a/
is done only after iopoll completes.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 2 +-
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
drivers/scsi/be2iscsi/be_
Driver version: 11.0.0.0
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index 41c708c..16a6fd0
iscsi_port_speed and iscsi_port_speed_names have new entries for
25Gbps and 40Gbps link speeds.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/scsi_transport_iscsi.c | 2 ++
include/scsi/iscsi_if.h | 2 ++
2 files changed, 4 insertions(+)
-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 48 +++-
drivers/scsi/be2iscsi/be_cmds.h | 32 +--
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
3 files changed, 34 insertions(+), 48 del
for posting the login-negotiated parameters back in pool.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_main.c | 72 -
1 file changed, 49 insertions(+),
-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 60 -
drivers/scsi/be2iscsi/be_mgmt.c | 32 +++---
2 files changed, 51 insertions(+), 41 deleti
This patch is generated against for-next branch.
Jitendra Bhivare (17):
be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx
be2iscsi: Fix mbox synchronization replacing spinlock with mutex
be2iscsi: Fix to use atomic bit operations for tag_state
be2iscsi: Fix to synchronize
alloc_mcc_tag/free_mcc_tag is now done under mcc_lock spin_lock
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be
FW recommended timeout for all mbox command is 30s.
Use msleep instead mdelay to relinquish CPU when polling for
mbox completion.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 5 +
Please ignore patch v2 set sending v3 shortly.
-Original Message-
From: Jitendra Bhivare [mailto:jitendra.bhiv...@avagotech.com]
Sent: Tuesday, December 22, 2015 10:46 PM
To: linux-scsi@vger.kernel.org; micha...@cs.wisc.edu
Cc: Jitendra Bhivare
Subject: [PATCH v2 17/17] be2iscsi: Update
llocation and freeing of WRB and tags for MCC is now done in one place.
This helps to achieve proper accounting of WRB indices and MCC tags.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/be2iscsi/be.h |
.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/be2iscsi/be_main.c | 5 +
drivers/scsi/be2iscsi/be_main.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/
In open with IP of unknown address family, only tag is freed and error
returned. MCC WRB allocated for the operation is not freed.
Added check for supported family of IP in the beginning before
allocating the tag and WRB.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
Re
Processing of mgmt and IO tasks are done in process context and sofitrqs.
Allocation and freeing of sgl_handles needs to be done under
spin_lock_bh/spin_unlock_bh and move the locks to the routines.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
Reviewed-by: Johannes Thu
be_mbox_notify_wait does exactly same thing as be_mbox_notify.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/be2iscsi/be_cmds.c | 79 +++--
1 file changed,
and
wrong offset'ed ExpStatSn is seen in the wire trace.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/be2iscsi/be_main.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/
Remove confusingly named be_mcc_compl_is_new and be_mcc_compl_use functions
in processing of BMBX. Rearrange beiscsi_process_mbox_compl function.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/s
e BMBX compl.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/be2iscsi/be_cmds.c | 38 +++---
drivers/scsi/be2iscsi/be_cmds.h | 6 +++---
drivers/scsi/be2iscsi/be_iscsi.
be_mcc_compl_process_isr is removed.
MCC CQ processing is done only in beiscsi_process_mcc_cq and MCC CQE
processing is done only in beiscsi_process_mcc_compl.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
---
mcc_cq_lock spin_lock is used only in beiscsi_process_mcc which is called
only when all interrupts are disabled from mgmt_epfw_cleanup during
unloading of driver. There is no other context where there can be
contention for the processing of CQ.
Signed-off-by: Jitendra Bhivare <jitendra.b
alloc(SE_MEM_MAX, sizeof(*mem_descr),
GFP_KERNEL);
--
Maurizio Lombardi
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordom
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Wednesday, January 27, 2016 7:15 AM
> To: Jitendra Bhivare
> Cc: linux-scsi@vger.kernel.org; micha...@cs.wisc.edu
> Subject: Re: [PATCH v4 00/17] be2iscsi: driver update 11.0.0.0
&
Processing of mgmt and IO tasks are done in process context and sofitrqs.
Allocation and freeing of sgl_handles needs to be done under
spin_lock_bh/spin_unlock_bh and move the locks to the routines.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be
mcc_cq_lock spin_lock is used only in beiscsi_process_mcc which is called
only when all interrupts are disabled from mgmt_epfw_cleanup during
unloading of driver. There is no other context where there can be
contention for the processing of CQ.
Signed-off-by: Jitendra Bhivare <jitendra.b
In open with IP of unknown address family, only tag is freed and error
returned. MCC WRB allocated for the operation is not freed.
Added check for supported family of IP in the beginning before
allocating the tag and WRB.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.
This driver update has critical fixes for following issues:
- Management tasks with incorrect ExpStatSn
- WRB allocation failures in IO path
- MCC WRB leak
Jitendra Bhivare (12):
be2iscsi: Remove unused mcc_cq_lock
be2iscsi: Use macros for MCC WRB and CQE fields
be2iscsi: Remove redundant
llocation and freeing of WRB and tags for MCC is now done in one place.
This helps to achieve proper accounting of WRB indices and MCC tags.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be.h | 2 +-
drivers/scsi/be2iscsi/
be_mbox_notify_wait does exactly same thing as be_mbox_notify.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 79 +++--
1 file changed, 4 insertions(+), 75 deletions(-)
diff --git a/drivers/scsi/be
.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_main.c | 5 +
drivers/scsi/be2iscsi/be_main.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index fa2b589..0892ee2
be_mcc_compl_process_isr is removed.
MCC CQ processing is done only in beiscsi_process_mcc_cq and MCC CQE
processing is done only in beiscsi_process_mcc_compl.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_cmds.c
Rename mcc_numtag to mcc_tag_status.
MCC CQE status is processed using macros already defined in be_cmds.h.
Add MCC_Q_WRB_ and MCC_Q_CMD_TAG_MASK macros to map to already defined
CQE_STATUS_ macros to be consistent when posting MCC.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.
Remove confusingly named be_mcc_compl_is_new and be_mcc_compl_use functions
in processing of BMBX. Rearrange beiscsi_process_mbox_compl function.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 75 --
e BMBX compl.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 35 +--
drivers/scsi/be2iscsi/be_cmds.h | 6 +++---
drivers/scsi/be2iscsi/be_iscsi.c | 8
drivers/scsi/be2iscsi/be_main.c | 8
be_mcc_compl_poll waits till 'used' count of MCC WRBQ is zero. This is to
determine the completion of an MCC sent.
Change function to poll for the tag of MCC sent, instead, and wait till
its tag_state is cleared.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
driver
and
wrong offset'ed ExpStatSn is seen in the wire trace.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@avagotech.com>
---
drivers/scsi/be2iscsi/be_main.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_
ba->msi_name[i]);
> }
> } else
>- if (phba->pcidev->irq) {
>- synchronize_irq(phba->pcidev->irq);
>+ if (phba->pcidev->irq)
> free_irq(phba->pcidev->irq, phba);
&
bardi
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of
>a message to majord...@vger.kernel.org More majordomo info at
>http://vger.kernel.org/majordomo-info.html
Reviewed-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
Than
> -Original Message-
> From: Mike Christie [mailto:mchri...@redhat.com]
> Sent: Tuesday, August 09, 2016 11:19 PM
> To: Jitendra Bhivare; Martin K. Petersen
> Cc: linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 02/28] be2iscsi: Replace _bh with _irqsave/irqrestore
>
> -Original Message-
> From: Jitendra Bhivare [mailto:jitendra.bhiv...@broadcom.com]
> Sent: Friday, August 12, 2016 1:26 PM
> To: 'Mike Christie'; 'Martin K. Petersen'
> Cc: 'linux-scsi@vger.kernel.org'
> Subject: RE: [PATCH 02/28] be2iscsi: Replace _bh with _
> -Original Message-
> From: Jitendra Bhivare [mailto:jitendra.bhiv...@broadcom.com]
> Sent: Thursday, August 11, 2016 11:12 AM
> To: 'Mike Christie'; 'Martin K. Petersen'
> Cc: 'linux-scsi@vger.kernel.org'
> Subject: RE: [PATCH 02/28] be2iscsi: Replace _bh with _
> -Original Message-
> From: Jitendra Bhivare [mailto:jitendra.bhiv...@broadcom.com]
> Sent: Wednesday, August 10, 2016 6:16 PM
> To: 'Mike Christie'; 'Martin K. Petersen'
> Cc: 'linux-scsi@vger.kernel.org'
> Subject: RE: [PATCH 02/28] be2iscsi: Replace _bh with _
as beiscsi_cmd_special_wrb.
Rearrange and rename few functions in init and cleanup path.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 250 +++-
drivers/scsi/be2iscsi/be_cmds.h | 38 +++---
drivers/scsi/be2iscsi/be_
Driver unload should call COMMON_FUNCTION_RESET. For TPE feature, this
ensures that FW has knowledge about driver getting unloaded and can
reset its bit vector.
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 2 +-
drivers/scsi/be
Driver version: 11.2.0.0
Signed-off-by: Jitendra Bhivare <jitendra.bhiv...@broadcom.com>
---
drivers/scsi/be2iscsi/be_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index 7173c03..6376657
1 - 100 of 256 matches
Mail list logo