Dear Kishon,
Could you please review this patch?
After that, I'll make the immutable brand and then send the pull request
for power_supply, mfd, phy, usb and extcon framework.
On 2017년 10월 10일 19:17, Chanwoo Choi wrote:
> The extcon has two type of extcon devices as following.
> - 'extcon provide
From: Manu Gautam
commit 40d829fb2ec636b6b4b0cc95e2546ab9aca04cc9 upstream.
The PIDs for Isochronous data transfers are incorrect
for high bandwidth IN endpoints when the request length
is less than EP wMaxPacketSize.
As per spec correct PIDs for ISOC data transfers are:
1) For request length
From: Mathias Nyman
> Sent: 11 October 2017 15:41
..
> If possible I'd like to try and find some other solution before chopping the
> Segment
> size to smaller than 256.
> I think that your first proposal of adding the guard page to the segment pool
> could be an option.
Would be a waste of a pa
This is a followup patch for:
https://patchwork.kernel.org/patch/649/
Make these structures const as they are only passed to the const
argument of the functions config_{group/item}_init_type_name.
Done using Coccinelle:
@rule1 disable optional_qualifier @
identifier x;
@@
static struct confi
On Wed, 11 Oct 2017 16:49:10 +0200,
Johan Hovold wrote:
>
> On Wed, Oct 11, 2017 at 04:40:36PM +0200, Takashi Iwai wrote:
> > On Wed, 11 Oct 2017 16:20:31 +0200,
> > Johan Hovold wrote:
>
> > > Unrelated to this patch, but this driver fails to kill the ep1_in_urb
> > > (which is submitted in this
On Wed, 11 Oct 2017, Daniel Drake wrote:
> From: Chris Chiu
>
> When going into S3 suspend, the Acer TravelMate P648-M and P648-G3
> laptops immediately wake up 3-4 seconds later for no obvious reason.
>
> Unbinding the integrated Huawei 4G LTE modem before suspend avoids
> the issue, even thou
On Wed, 11 Oct 2017 16:52:09 +0200,
Johan Hovold wrote:
>
> On Wed, Oct 11, 2017 at 04:45:16PM +0200, Takashi Iwai wrote:
> > On Wed, 11 Oct 2017 16:28:37 +0200,
> > Johan Hovold wrote:
> > >
> > > On Wed, Oct 11, 2017 at 12:36:41PM +0200, Takashi Iwai wrote:
> > > > As syzkaller spotted, current
On Wed, Oct 11, 2017 at 04:31:07PM +0200, Takashi Iwai wrote:
> On Wed, 11 Oct 2017 16:14:55 +0200,
> Johan Hovold wrote:
> >
> > On Wed, Oct 11, 2017 at 12:36:38PM +0200, Takashi Iwai wrote:
> > > This patch adds a new helper function to perform a sanity check of the
> > > given URB to see whethe
On Wed, Oct 11, 2017 at 04:45:16PM +0200, Takashi Iwai wrote:
> On Wed, 11 Oct 2017 16:28:37 +0200,
> Johan Hovold wrote:
> >
> > On Wed, Oct 11, 2017 at 12:36:41PM +0200, Takashi Iwai wrote:
> > > As syzkaller spotted, currently line6 drivers submit a URB with the
> > > fixed EP without checking
On Wed, Oct 11, 2017 at 04:40:36PM +0200, Takashi Iwai wrote:
> On Wed, 11 Oct 2017 16:20:31 +0200,
> Johan Hovold wrote:
> > Unrelated to this patch, but this driver fails to kill the ep1_in_urb
> > (which is submitted in this function) in case of later probe errors.
> > This can lead to use-afte
On Wed, 11 Oct 2017 16:39:52 +0200,
Johan Hovold wrote:
>
> On Wed, Oct 11, 2017 at 12:36:46PM +0200, Takashi Iwai wrote:
> > There are a few other places calling usb_submit_urb() with the URB
> > composed from the fixed endpoint without validation. For avoiding the
> > spurious kernel warnings,
On Wed, 11 Oct 2017 16:28:37 +0200,
Johan Hovold wrote:
>
> On Wed, Oct 11, 2017 at 12:36:41PM +0200, Takashi Iwai wrote:
> > As syzkaller spotted, currently line6 drivers submit a URB with the
> > fixed EP without checking whether it's actually available, which may
> > result in a kernel warning
On Wed, 11 Oct 2017 16:33:37 +0200,
Johan Hovold wrote:
>
> On Wed, Oct 11, 2017 at 12:36:43PM +0200, Takashi Iwai wrote:
> > usx2y driver sets up URBs containing the fixed endpoints without
> > validation. This may end up with an oops-like kernel warning when
> > submitted.
> >
> > For avoiding
On Wed, 11 Oct 2017 16:20:31 +0200,
Johan Hovold wrote:
>
> On Wed, Oct 11, 2017 at 12:36:40PM +0200, Takashi Iwai wrote:
> > As syzkaller spotted, currently caiaq driver submits a URB with the
> > fixed EP without checking whether it's actually available, which may
> > result in a kernel warning
On Wed, Oct 11, 2017 at 12:36:46PM +0200, Takashi Iwai wrote:
> There are a few other places calling usb_submit_urb() with the URB
> composed from the fixed endpoint without validation. For avoiding the
> spurious kernel warnings, add the sanity checks to appropriate
> places.
>
> Signed-off-by:
On 10/11/2017 03:26 PM, Felipe Balbi wrote:
Hi,
Alexandre Torgue writes:
Hi
On 10/11/2017 01:50 PM, Felipe Balbi wrote:
Hi,
Alexandre Torgue writes:
Hi Felip
On 10/11/2017 12:04 PM, Felipe Balbi wrote:
Hi,
Amelie Delaunay writes:
The STM32F7 MCU family embeds two DWC2 USB OTG co
On 10.10.2017 21:09, Robin Murphy wrote:
The VIA VL805 host controller is well-known for causing problems on
systems with IOMMUs enabled, ranging from triggering endless streams of
fault messages to locking itself up completely. It appears that the root
of the problem might be an over-aggressive
On Wed, Oct 11, 2017 at 12:36:43PM +0200, Takashi Iwai wrote:
> usx2y driver sets up URBs containing the fixed endpoints without
> validation. This may end up with an oops-like kernel warning when
> submitted.
>
> For avoiding it, this patch adds the calls of the new sanity-check
> helper for URB
On Wed, 11 Oct 2017 16:14:55 +0200,
Johan Hovold wrote:
>
> On Wed, Oct 11, 2017 at 12:36:38PM +0200, Takashi Iwai wrote:
> > This patch adds a new helper function to perform a sanity check of the
> > given URB to see whether it contains a valid endpoint. It's a light-
> > weight version of what
On Wed, Oct 11, 2017 at 12:36:41PM +0200, Takashi Iwai wrote:
> As syzkaller spotted, currently line6 drivers submit a URB with the
> fixed EP without checking whether it's actually available, which may
> result in a kernel warning like:
> usb 1-1: BOGUS urb xfer, pipe 3 != type 1
> ---
On Wed, Oct 11, 2017 at 12:36:40PM +0200, Takashi Iwai wrote:
> As syzkaller spotted, currently caiaq driver submits a URB with the
> fixed EP without checking whether it's actually available, which may
> result in a kernel warning like:
> usb 1-1: BOGUS urb xfer, pipe 3 != type 1
> ---
On Wed, Oct 11, 2017 at 12:36:38PM +0200, Takashi Iwai wrote:
> This patch adds a new helper function to perform a sanity check of the
> given URB to see whether it contains a valid endpoint. It's a light-
> weight version of what usb_submit_urb() does, but without the kernel
> warning followed by
xHCI requires that data buffers do not cross 64KB boundaries (and are
thus at most 64KB long as well) - whilst xhci_queue_{bulk,isoc}_tx()
already split their input buffers into individual TRBs as necessary,
it's still a good idea to advertise the limitations via the standard DMA
API mechanism, so
On Wed, Oct 11, 2017 at 02:51:53PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 11, 2017 at 02:02:57PM +0200, Johan Hovold wrote:
> > Make sure to stop any submitted interrupt and bulk-out URBs before
> > returning after failed probe and when the port is being unbound to avoid
> > later NULL-poin
Hi,
Alexandre Torgue writes:
> Hi
>
> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Alexandre Torgue writes:
>>> Hi Felip
>>>
>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
Hi,
Amelie Delaunay writes:
> The STM32F7 MCU family embeds two DWC2 USB OTG cor
On Wed, 4 Oct 2017, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly. Adds pointer back to hid_device for
> multitouch.
Applied, thank
On Wed, 11 Oct 2017 15:03:29 +0200,
Greg KH wrote:
>
> On Wed, Oct 11, 2017 at 12:36:37PM +0200, Takashi Iwai wrote:
> > Hi,
> >
> > this is a revised patch set to cover the codes that may submit URBs
> > containing invalid EPs without validation, which result in the kernel
> > warning from the U
On Thu, 28 Sep 2017, Jaejoong Kim wrote:
> The hid descriptor identifies the length and type of subordinate
> descriptors for a device. If the received hid descriptor is smaller than
> the size of the struct hid_descriptor, it is possible to cause
> out-of-bounds.
>
> In addition, if bNumDescript
On Wed, Oct 11, 2017 at 12:36:37PM +0200, Takashi Iwai wrote:
> Hi,
>
> this is a revised patch set to cover the codes that may submit URBs
> containing invalid EPs without validation, which result in the kernel
> warning from the USB core. The first patch adds a new helper for
> simplifying the
On Wed, Oct 11, 2017 at 02:03:01PM +0200, Johan Hovold wrote:
> Clean up the somewhat convoluted init-session logic to improve
> readability.
>
> Signed-off-by: Johan Hovold
Reviewed-by: Greg Kroah-Hartman
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a
On Wed, Oct 11, 2017 at 02:03:00PM +0200, Johan Hovold wrote:
> Use the port device for any init-session error and debug messages,
> remove one redundant debug message and simplify one error message.
>
> Signed-off-by: Johan Hovold
Reviewed-by: Greg Kroah-Hartman
--
To unsubscribe from this lis
On Wed, Oct 11, 2017 at 02:02:59PM +0200, Johan Hovold wrote:
> Drop out-commented timer expiry initialisation which would not even
> compile anymore.
>
> Signed-off-by: Johan Hovold
Reviewed-by: Greg Kroah-Hartman
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the b
On Wed, Oct 11, 2017 at 02:02:58PM +0200, Johan Hovold wrote:
> Make sure to free the port private data before returning after a failed
> probe attempt.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable
> Signed-off-by: Johan Hovold
Reviewed-by: Greg Kroah-Hartman
--
To unsubscribe fro
On Wed, Oct 11, 2017 at 02:02:57PM +0200, Johan Hovold wrote:
> Make sure to stop any submitted interrupt and bulk-out URBs before
> returning after failed probe and when the port is being unbound to avoid
> later NULL-pointer dereferences in the completion callbacks.
>
> Also fix up the related a
Hi
On 10/11/2017 01:50 PM, Felipe Balbi wrote:
Hi,
Alexandre Torgue writes:
Hi Felip
On 10/11/2017 12:04 PM, Felipe Balbi wrote:
Hi,
Amelie Delaunay writes:
The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
OTG FS and the other is USB OTG HS. The USB FS core only wo
Drop out-commented timer expiry initialisation which would not even
compile anymore.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/garmin_gps.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
index 677558c99a97..d22a84c95c
Make sure to free the port private data before returning after a failed
probe attempt.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/usb/serial/garmin_gps.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/serial/garmin_gps.c b/
A recent timer API change brought my attention to this old gem of a
driver which has been suffering from some error-handling bugs that would
allow a malicious device to trigger a crash.
Given the nature of the problem and the fact that it's been around since
forever (i.e. pre-git), I don't think t
Make sure to stop any submitted interrupt and bulk-out URBs before
returning after failed probe and when the port is being unbound to avoid
later NULL-pointer dereferences in the completion callbacks.
Also fix up the related and broken I/O cancellation on failed open and
on close. (Note that port-
Clean up the somewhat convoluted init-session logic to improve
readability.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/garmin_gps.c | 41 -
1 file changed, 16 insertions(+), 25 deletions(-)
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/us
Use the port device for any init-session error and debug messages,
remove one redundant debug message and simplify one error message.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/garmin_gps.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/seri
Hi,
Alexandre Torgue writes:
> Hi Felip
>
> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Amelie Delaunay writes:
>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>> internal ph
Hi Felip
On 10/11/2017 12:04 PM, Felipe Balbi wrote:
Hi,
Amelie Delaunay writes:
The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
OTG FS and the other is USB OTG HS. The USB FS core only works with its
internal phy whilst the USB HS core can work in HS with external ULPI
usx2y driver sets up URBs containing the fixed endpoints without
validation. This may end up with an oops-like kernel warning when
submitted.
For avoiding it, this patch adds the calls of the new sanity-check
helper for URBs.
Signed-off-by: Takashi Iwai
---
sound/usb/usx2y/usbusx2y.c | 8
hiface usb-audio driver sets up URBs containing the fixed endpoints
without validation. This may end up with an oops-like kernel warning
when submitted.
For avoiding it, this patch adds the calls of the new sanity-check
helper for URBs.
Signed-off-by: Takashi Iwai
---
sound/usb/hiface/pcm.c |
USB-audio driver may set up a URB containing the fixed EP without
validating its presence for some non-class-compliant devices. This
may end up with an oops-like kernel warning when submitted.
For avoiding it, this patch adds the call of the new sanity-check
helper for URBs. The checks are neede
As syzkaller spotted, currently bcd2000 driver submits a URB with the
fixed EP without checking whether it's actually available, which may
result in a kernel warning like:
usb 1-1: BOGUS urb xfer, pipe 1 != type 3
[ cut here ]
WARNING: CPU: 0 PID: 1846 at drivers/usb/c
As syzkaller spotted, currently line6 drivers submit a URB with the
fixed EP without checking whether it's actually available, which may
result in a kernel warning like:
usb 1-1: BOGUS urb xfer, pipe 3 != type 1
[ cut here ]
WARNING: CPU: 0 PID: 24 at drivers/usb/core/
Hi,
this is a revised patch set to cover the codes that may submit URBs
containing invalid EPs without validation, which result in the kernel
warning from the USB core. The first patch adds a new helper for
simplifying the EP check, and the rest applies it at needed places.
The original issues w
There are a few other places calling usb_submit_urb() with the URB
composed from the fixed endpoint without validation. For avoiding the
spurious kernel warnings, add the sanity checks to appropriate
places.
Signed-off-by: Takashi Iwai
---
sound/usb/line6/driver.c | 23 +++
This patch adds a new helper function to perform a sanity check of the
given URB to see whether it contains a valid endpoint. It's a light-
weight version of what usb_submit_urb() does, but without the kernel
warning followed by the stack trace, just returns an error code.
Especially for a driver
A few other places in caiaq driver have the URB handling with the
fixed endpoints without checking the validity, too. Add the sanity
check with the new helper function at each appropriate place for
avoiding the spurious kernel warnings due to invalid EPs.
Signed-off-by: Takashi Iwai
---
sound/u
As syzkaller spotted, currently caiaq driver submits a URB with the
fixed EP without checking whether it's actually available, which may
result in a kernel warning like:
usb 1-1: BOGUS urb xfer, pipe 3 != type 1
[ cut here ]
WARNING: CPU: 1 PID: 1150 at drivers/usb/cor
On 10/10/2017 01:38, Bjorn Helgaas wrote:
> On Mon, Oct 09, 2017 at 10:45:39PM +0200, Mason wrote:
>> On 09/10/2017 19:01, Bjorn Helgaas wrote:
>> ...
>
>>> In that thread, Mason reported a regression that looks similar, but as
>>> far as I can tell, we never identified a root cause.
>>>
>>> 1)
On Wed, Oct 11, 2017 at 10:09:57AM +0100, Colin King wrote:
> From: Colin Ian King
>
> Calls to regmap_read may fail with an -EINVAL return without setting
> usbc_irq1 and usbc_irq2. The error handling clean up expects these
> to have been set (or zero on a failure) and currently may try to
> cl
Hi,
John Stultz writes:
> On Thu, Aug 17, 2017 at 12:03 PM, John Stultz wrote:
>> In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we
>> disconnect the gadget state"), I was trying to fix up the
>> fact that we somehow weren't disconnecting the gadget state,
>> so that when the OTG por
Allen Pais writes:
>Use setup_timer function instead of initializing timer with the
>function and data fields.
why the extra spaces here? This time I'll fix it myself. Next time make
sure to send patches in correct formatting.
--
balbi
signature.asc
Description: PGP signature
Hi,
Amelie Delaunay writes:
> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
> OTG FS and the other is USB OTG HS. The USB FS core only works with its
> internal phy whilst the USB HS core can work in HS with external ULPI phy
> or in FS/LS with the on-chip FS phy.
>
> Ame
From: Robin Murphy
> Sent: 10 October 2017 19:09
>
> The VIA VL805 host controller is well-known for causing problems on
> systems with IOMMUs enabled, ranging from triggering endless streams of
> fault messages to locking itself up completely. It appears that the root
> of the problem might be an
From: Colin Ian King
Calls to regmap_read may fail with an -EINVAL return without setting
usbc_irq1 and usbc_irq2. The error handling clean up expects these
to have been set (or zero on a failure) and currently may try to
clear the wrong IRQs if the uninitalized garbage values in usbc_irq1
or us
Elatec TWN3 has the union descriptor on data interface. This results in
failure to bind the device to the driver with the following log:
usb 1-1.2: new full speed USB device using streamplug-ehci and address 4
usb 1-1.2: New USB device found, idVendor=09d8, idProduct=0320
usb 1-1.2: New USB d
On Tue, Oct 10, 2017 at 11:25:22AM -0700, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> Cc: Johan Hovold
> Cc: Allen Pais
> C
62 matches
Mail list logo