On Thu, Jan 12, 2017 at 05:25:00PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Jan 12, 2017 at 04:54:38PM +0100, Nicholas Mc Guire wrote:
> > Signed-off-by: Nicholas Mc Guire
> > ---
> > Problem reported by sparse
> > drivers/usb/dwc2/hcd.c: In function 'dwc2_dum
Uninitialized char* causes a sparse build-warning, fix it up by
initializing it to NULL.
Signed-off-by: Nicholas Mc Guire
---
V2: add missing change-log as requested by Greg Kroah-Hartman
Problem reported by sparse
drivers/usb/dwc2/hcd.c: In function 'dwc2_dump_urb_info':
ulseep_range() uses hrtimers and provides no advantage over msleep()
for larger delays. Fix up the 20+ ms delays here passing the adjusted "min"
value to msleep(). This helps reduce the load on the hrtimer subsystem.
Signed-off-by: Nicholas Mc Guire
---
Patch was compile t
For boolean variables true/false is preferred over 1/0 for readability.
Signed-off-by: Nicholas Mc Guire
---
Problem reported by scripts/coccinelle/misc/boolinit.cocci:
./drivers/usb/dwc2/hcd.c:5003:2-24: WARNING: Assignment of bool to 0/1
./drivers/usb/dwc2/hcd.c:3397:1-21: WARNING: Assignment
Signed-off-by: Nicholas Mc Guire
---
Problem reported by sparse
drivers/usb/dwc2/hcd.c: In function 'dwc2_dump_urb_info':
./include/linux/dynamic_debug.h:134:3: warning: 'pipetype' may be used
uninitialized in this function [-Wmaybe-uninitialized]
__dynamic_dev_dbg(&
"usb: dwc2: Properly account for the force mode
delays")
Signed-off-by: Nicholas Mc Guire
---
Problem was found by cocinelle script.
Note that this originally was an msleep(25) then commit 2938fc63e0c2
("usb: dwc2: Properly account for the force mode delays") changed this
On Tue, Nov 08, 2016 at 12:26:45PM +0900, Masahiro Yamada wrote:
> >> Fixes: 6acb95d4e070 ("usb: renesas_usbhs: modify packet queue control
> >> method")
>
>
> This is not a fix, but a clean-up patch.
true - I´ve been using it incorrectly to basically just record
the origin of the issue found -
The current code is effectively equivalent to list_first_entry_or_null()
so simply switch and simplify the code.
Fixes: 9c39ddc60ee9 ("USB: s3c-hsotg: Fix stall condition processing")
Signed-off-by: Nicholas Mc Guire
---
Found by simple coccinelle scanner
Compile tested with: x86_64
Return type of wait_for_completion_timeout is unsigned long not int.
As time_left is exclusively used for wait_for_completion_timeout here its
type is simply changed to unsigned long.
Signed-off-by: Nicholas Mc Guire
---
Patch was only compile tested with x86_64_defconfig + CONFIG_USB_XHCI_HCD
On Fri, 06 Feb 2015, Sergei Shtylyov wrote:
> Hello.
>
> On 2/6/2015 12:50 PM, Nicholas Mc Guire wrote:
>
>> This is only an API consolidation and should make things more readable
>> it replaces var * HZ / 1000 by msecs_to_jiffies(var).
>
>> Signed-off-by: Nichola
This is only an API consolidation and should make things more readable
it replaces var * HZ / 1000 by msecs_to_jiffies(var).
Signed-off-by: Nicholas Mc Guire
---
Patch was only compile tested with x86_64_defconfig + CONFIG_USB_ISP1760=m
Patch is against 3.19.0-rc7 (localversion-next is -next
This is only an API consolidation and should make things more readable
it replaces var * HZ / 1000 by msecs_to_jiffies(var).
Signed-off-by: Nicholas Mc Guire
---
Patch was only compile tested with x86_64_defconfig + CONFIG_USB_LEGOTOWER=m
Patch is against 3.19.0-rc7 (localversion-next is -next
This is only an API consolidation and should make things more readable
it replaces var * HZ / 1000 by msecs_to_jiffies(var).
Signed-off-by: Nicholas Mc Guire
---
Note that the indentation is not aligned with the correct ( here due to
lines going over 80 char - not sure if this is the right way
Signed-off-by: Nicholas Mc Guire
---
The return value of wait_for_completion_timeout is unsigned long,
as it is used here for wait_for_completion_timeout only the type
of commretval was changed to unsigned long.
As wait_for_completion_timeout does not return negative values
the commretval <
fixups for incorrect use of DECLARE_COMPLETION. see also commit
6e9a4738 ("completions: lockdep annotate on stack completions")
patch is against 3.18.0 linux-next
This was only code reviewed and compile tested
Signed-off-by: Nicholas Mc Guire
---
drivers/usb/gadget/udc/fsl_qe_udc.
viewed and compile tested
Signed-off-by: Nicholas Mc Guire
---
drivers/macintosh/ams/ams-pmu.c |4 ++--
drivers/misc/sgi-gru/grukservices.c |2 +-
drivers/scsi/aha152x.c|2 +-
drivers/usb/gadget/udc/fsl_qe_udc.c |2 +-
drivers/usb/gadget/udc/fsl_udc_core.c |
16 matches
Mail list logo