RE: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-30 Thread Jun Li
chtek.com; Peter Chen ; > devicet...@vger.kernel.org; linux-usb@vger.kernel.org; dl-linux-imx > ; de...@driverdev.osuosl.org > Subject: Re: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach > > On Thu, Mar 29, 2018 at 12:06:15AM +0800, Li Jun wrote: > > In case of drp

RE: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-30 Thread Jun Li
ek.com; Peter Chen > ; devicet...@vger.kernel.org; > linux-usb@vger.kernel.org; dl-linux-imx ; > de...@driverdev.osuosl.org > Subject: Re: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach > > Hi Li, > > On 03/28/2018 06:06 PM, Li Jun wrote: > > > In case of

Re: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-29 Thread Guenter Roeck
On Thu, Mar 29, 2018 at 12:06:15AM +0800, Li Jun wrote: > In case of drp toggling, we may need set correct cc value for role control > after attach as it may never been set. > Isn't CC set by the lower level driver in this case ? In other words, is it ever necessary to call back into the low leve

Re: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-29 Thread Mats Karrman
Hi Li, On 03/28/2018 06:06 PM, Li Jun wrote: > In case of drp toggling, we may need set correct cc value for role control > after attach as it may never been set. > > Signed-off-by: Li Jun > --- > drivers/usb/typec/tcpm.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb

[PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-28 Thread Li Jun
In case of drp toggling, we may need set correct cc value for role control after attach as it may never been set. Signed-off-by: Li Jun --- drivers/usb/typec/tcpm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c index 218c230..72d4232