[PATCH] usb: dwc2: pci: Fix an error code in probe

2018-10-18 Thread Dan Carpenter
We added some error handling to this function but forgot to set the error code on this path. Fixes: ecd29dabb2ba ("usb: dwc2: pci: Handle error cleanup in probe") Signed-off-by: Dan Carpenter --- drivers/usb/dwc2/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/pci.c b/

Re: [PATCH 0/4] usb: chipidea: imx: add HSIC support

2018-10-18 Thread Frieder Schrempf
On 18.10.18 03:22, Peter Chen wrote: - System suspend/resume 1. Enable USB wakeup for i in $(find /sys -name wakeup | grep usb);do echo enabled  > $i;echo "echo enabled > $i";done; 2. Let the system enter suspend using below command echo mem > /sys/power/state 3. And see if there is a wakeup b

Re: [PATCH] usb: dwc2: pci: Fix an error code in probe

2018-10-18 Thread Minas Harutyunyan
On 10/18/2018 11:37 AM, Dan Carpenter wrote: > We added some error handling to this function but forgot to set the > error code on this path. > > Fixes: ecd29dabb2ba ("usb: dwc2: pci: Handle error cleanup in probe") > Signed-off-by: Dan Carpenter Acked-by: Minas Harutyunyan > --- > drivers/u

[PATCH 1/2] usb: phy: ab8500: silence some uninitialized variable warnings

2018-10-18 Thread Dan Carpenter
Smatch complains that "reg" can be uninitialized if the abx500_get_register_interruptible() call fails. It's an interruptable function, so we should check if the user presses CTRL-C. Signed-off-by: Dan Carpenter --- drivers/usb/phy/phy-ab8500-usb.c | 8 ++-- 1 file changed, 6 insertions(+),

RE: [PATCH 0/4] usb: chipidea: imx: add HSIC support

2018-10-18 Thread Peter Chen
> > > > Thanks, Frieder, no more tests are needed. > > You could send me your dts changes as patches, I will append it at my v2 > > patch > series. > > My board is currently off-tree so I can't send any patch for the pinmux > settings in > devicetree. But I will send a patch with the changes t

Re: [PATCH 0/4] usb: chipidea: imx: add HSIC support

2018-10-18 Thread Frieder Schrempf
On 18.10.18 10:48, Peter Chen wrote: Thanks, Frieder, no more tests are needed. You could send me your dts changes as patches, I will append it at my v2 patch series. My board is currently off-tree so I can't send any patch for the pinmux settings in devicetree. But I will send a patch wit

RE: [PATCH 0/4] usb: chipidea: imx: add HSIC support

2018-10-18 Thread Peter Chen
> >> My board is currently off-tree so I can't send any patch for the > >> pinmux settings in devicetree. But I will send a patch with the > >> changes that should go to imx6qdl.dtsi, imx6sl.dtsi and imx6sx.dtsi. > >> Though I > only tested on i.MX6S. > >> > > > > No, the changes are board level

[GIT PULL] USB-serial updates for v4.20-rc1

2018-10-18 Thread Johan Hovold
The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8: Linux 4.19-rc4 (2018-09-16 11:52:37 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-4.20-rc1 for you to fetch changes up to 17c42

Re: [GIT PULL] USB-serial updates for v4.20-rc1

2018-10-18 Thread Greg Kroah-Hartman
On Thu, Oct 18, 2018 at 12:55:42PM +0200, Johan Hovold wrote: > The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8: > > Linux 4.19-rc4 (2018-09-16 11:52:37 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/us

Re: Query on usb/core/devio.c

2018-10-18 Thread Mayuresh Kulkarni
On Tue, 16 Oct 2018 10:35:47 -0400 Alan Stern wrote: > On Tue, 16 Oct 2018, Mayuresh Kulkarni wrote: > > > > How about instead having a mechanism whereby your usrspace driver can > > > tell when the device does a remote wakeup? At that point it could > > > submit an URB via usbfs and receive

Re: Query on usb/core/devio.c

2018-10-18 Thread Mayuresh Kulkarni
On Wed, 17 Oct 2018 10:32:14 -0400 Alan Stern wrote: > On Wed, 17 Oct 2018, Oliver Neukum wrote: > > > On Di, 2018-10-16 at 10:46 -0400, Alan Stern wrote: > > > On Tue, 16 Oct 2018, Mayuresh Kulkarni wrote: > > > > > > > 1. User space decides when it is time to suspend the device and calls > >

Re: [PATCH] HID: hiddev: fix potential Spectre v1

2018-10-18 Thread Breno Leitao
Hi Gustavo, On 10/17/2018 05:30 PM, Gustavo A. R. Silva wrote: > > Hi Breno, > > On 10/17/18 9:47 PM, Breno Leitao wrote: >> uref->usage_index can be indirectly controlled by userspace, hence leading >> to a potential exploitation of the Spectre variant 1 vulnerability. >> >> This problem might

Re: [PATCH] HID: hiddev: fix potential Spectre v1

2018-10-18 Thread Greg KH
On Thu, Oct 18, 2018 at 01:50:26PM -0300, Breno Leitao wrote: > Hi Gustavo, > > On 10/17/2018 05:30 PM, Gustavo A. R. Silva wrote: > > > > Hi Breno, > > > > On 10/17/18 9:47 PM, Breno Leitao wrote: > >> uref->usage_index can be indirectly controlled by userspace, hence leading > >> to a potentia

Re: Query on usb/core/devio.c

2018-10-18 Thread Alan Stern
On Thu, 18 Oct 2018, Mayuresh Kulkarni wrote: > As I understand, you seem to mention - user-space to tell the USB > device when to remote-wake. > But in our case, we cannot tell the device when to remote-wake as the > USB device needs to detect an "activity" by end user (after link goes > into L2)

Re: Query on usb/core/devio.c

2018-10-18 Thread Alan Stern
On Thu, 18 Oct 2018, Mayuresh Kulkarni wrote: > > The only way to make the ioctl work properly is to have it do a > > runtime-PM put at the start and then a runtime-PM get before it > > returns. This is true regardless of the reason for returning: normal > > termination, timeout, signal, whate

Error reading USB camera in BeagleBone with ARM Debian

2018-10-18 Thread Josep M. Mirats Tur
Hi I've recently acquired a BeagleBone Green with AM335x processor. I 'm connecting a USB device (actually a 3D camera from ORBBEC) to the Beagle USB host port. It recognizes well as I can see at the dmesg output: [12411.643517] usb 1-1: new high-speed USB device number 2 using musb-hdrc [12411.7

Re: Error reading USB camera in BeagleBone with ARM Debian

2018-10-18 Thread Alan Stern
On Thu, 18 Oct 2018, Josep M. Mirats Tur wrote: > Hi > > I've recently acquired a BeagleBone Green with AM335x processor. I 'm > connecting a USB device (actually a 3D camera from ORBBEC) to the > Beagle USB host port. It recognizes well as I can see at the dmesg > output: > > [12411.643517] usb

[PATCH] USB: Wait for extra delay time after USB_PORT_FEAT_RESET for quirky hub

2018-10-18 Thread Kai-Heng Feng
Devices connected under Terminus Technology Inc. Hub (1a40:0101) may fail to work after the system resumes from suspend: [ 206.063325] usb 3-2.4: reset full-speed USB device number 4 using xhci_hcd [ 206.143691] usb 3-2.4: device descriptor read/64, error -32 [ 206.351671] usb 3-2.4: device desc

Re: [PATCH 0/6] usb: gadget: add mechanism to asynchronously validate data stage of ctrl out request

2018-10-18 Thread Bin Liu
Hi Laurent, On Thu, Oct 18, 2018 at 02:42:29AM +0300, Laurent Pinchart wrote: > Hi Bin, > > On Thursday, 11 October 2018 22:31:42 EEST Bin Liu wrote: > > On Tue, Oct 09, 2018 at 10:48:57PM -0400, Paul Elder wrote: > > > This patch series adds a mechanism to allow asynchronously validating > > > t

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-10-18 Thread Bin Liu
Laurent, On Thu, Oct 18, 2018 at 02:45:32AM +0300, Laurent Pinchart wrote: > Hi Bin, > > On Thursday, 11 October 2018 19:10:21 EEST Bin Liu wrote: > > On Tue, Oct 09, 2018 at 10:49:01PM -0400, Paul Elder wrote: > > > A usb gadget function driver may or may not want to delay the status > > > stage

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-10-18 Thread Alan Stern
On Thu, 18 Oct 2018, Laurent Pinchart wrote: > Hi Bin, > > On Thursday, 11 October 2018 19:10:21 EEST Bin Liu wrote: > > On Tue, Oct 09, 2018 at 10:49:01PM -0400, Paul Elder wrote: > > > A usb gadget function driver may or may not want to delay the status > > > stage of a control OUT request. An

Re: [PATCH] USB: Wait for extra delay time after USB_PORT_FEAT_RESET for quirky hub

2018-10-18 Thread Alan Stern
On Thu, 18 Oct 2018, Kai-Heng Feng wrote: > Devices connected under Terminus Technology Inc. Hub (1a40:0101) may > fail to work after the system resumes from suspend: > [ 206.063325] usb 3-2.4: reset full-speed USB device number 4 using xhci_hcd > [ 206.143691] usb 3-2.4: device descriptor read/

Re: [PATCH V2 6/6] usb: host: Add ability to build new Broadcom STB USB drivers

2018-10-18 Thread Alan Stern
On Wed, 17 Oct 2018, Al Cooper wrote: > Add the build system changes needed to get the Broadcom STB XHCI, > EHCI and OHCI functionality working. The link order for XHCI was > changed in the Makefile because of the way STB XHCI, EHCI and OHCI > controllers share a port which requires that the XHCI

[PATCH] usbip:vudc: BUG kmalloc-2048 (Not tainted): Poison overwritten

2018-10-18 Thread Shuah Khan (Samsung OSG)
In rmmod path, usbip_vudc does platform_device_put() twice once from platform_device_unregister() and then from put_vudc_device(). The second put results in: BUG kmalloc-2048 (Not tainted): Poison overwritten error or BUG: KASAN: use-after-free in kobject_put+0x1e/0x230 if KASAN is enabled. [ 1

Re: [PATCH V2 3/6] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's

2018-10-18 Thread kbuild test robot
Hi Al, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.19-rc8 next-20181018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH] Add support of TI ICDI to USB simple serial device

2018-10-18 Thread Greg KH
On Sat, Oct 13, 2018 at 05:10:50PM +0800, Da Shi Cao wrote: > In-Circuit Debug Interface is a debugging interface for TI ARM > microcontrollers. It has three USB interfaces and two of them are > presented as standard ACM serial device. The 3rd interface is the > debugging interface and it can be dr

Re: [PATCH V2 1/6] dt-bindings: Add Broadcom STB OHCI, EHCI and XHCI binding document

2018-10-18 Thread Rob Herring
On Wed, 17 Oct 2018 18:29:04 -0400, Al Cooper wrote: > Add DT bindings document for Broadcom STB USB OHCI, EHCI and > XHCI drivers. > > Signed-off-by: Al Cooper > --- > .../devicetree/bindings/usb/brcm,bcm7445-ehci.txt | 22 + > .../devicetree/bindings/usb/brcm,bcm7445-ohci.

Re: [PATCH] usbip:vudc: BUG kmalloc-2048 (Not tainted): Poison overwritten

2018-10-18 Thread Randy Dunlap
On 10/18/18 9:19 AM, Shuah Khan (Samsung OSG) wrote: > In rmmod path, usbip_vudc does platform_device_put() twice once from > platform_device_unregister() and then from put_vudc_device(). > > The second put results in: > > BUG kmalloc-2048 (Not tainted): Poison overwritten error or > BUG: KASAN:

Re: [PATCH V2 3/6] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's

2018-10-18 Thread kbuild test robot
Hi Al, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.19-rc8 next-20181018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits