Hi all,
I do agree that udc-core's uevents can potentially be used here.
I will check the complete list of uevents sent by the udc-core's
usb_gadget_set_state function and see if the userspace is happy to work with it.
Now that Android is starting to use the configfs driver, it might be
much easie
Hi,
At present I am using the uevent in the userspace to infer
the Presence of a port on the remote end through the
appearance of usbc*-partner.
Userspace uses this info to decide on when to show a USB
notification on the screen and what should be the options
provided in the dialog.
I was assumi
> IMHO the uevent is cheaper. User space cannot just poll without further
> infrastructure. A task needs to run to poll. A uevent can be handled
> through established infrastructure.
Thanks Oliver for stating this. This is exactly what I was facing.
> OK, I'll add KOBJ_CHANGE for those.
>
> So is
> Yes, though I don't KOBJ_ADD separately with the partners and cables.
> That uevent is sent when the device for them is registered, so it's
> already there
Makes sense. Thanks Heikki.
Regards,
Badhri
On Wed, Nov 16, 2016 at 7:20 AM, Heikki Krogerus
wrote:
> Hi Greg,
>
> On Mon, Nov 14, 2016 a
Added a safety net to make sure that
composite_disconnect does not end up disconneting
a NULL device. Prevents NULL pointer crash.
Signed-off-by: Badhri Jagan Sridharan
---
drivers/usb/gadget/composite.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/usb/gadget/composite.c b
sn't printing a WARN/ERROR msg and
returning not the preferable approach ?
On 03/22/2015 12:43 AM, Peter Chen wrote:
On Fri, Mar 20, 2015 at 04:40:52PM -0700, Badhri Jagan Sridharan wrote:
Added a safety net to make sure that
composite_disconnect does not end up disconneting
a NULL device. P
Hi,
With the advent of USB PD over type-C connector, the data_roles and
the power_roles can be swapped independently. i.e. now the host for
the data need not have to be powering VBUS. Going through the phy
code(drivers/usb/phy/phy.c) makes me think that the phy layer assumes
that both the DATA_ROL
the Object position field.
This enables the Sink to indicate that it requires more current/power
than is being offered. If the Sink requires a different voltage this
will be indicated by its Sink Capabilities message.
Signed-off-by: Badhri Jagan Sridharan
---
Changelog since v1:
- rebased on top d
.
Errors in source/sink_caps of the local port will prevent
the port registration. Whereas, errors in source caps of partner
device would only log them.
Signed-off-by: Badhri Jagan Sridharan
---
Changelog since v1:
- Rebased the patch on top of drivers/usb/type/tcpm.c
- Added duplicate pdo check
.
Errors in source/sink_caps of the local port will prevent
the port registration. Whereas, errors in source caps of partner
device would only log them.
Signed-off-by: Badhri Jagan Sridharan
---
Changelog since v1:
- rebased on top drivers/usb/typec/tcpm.c as suggested by
gre
the Object position field.
This enables the Sink to indicate that it requires more current/power
than is being offered. If the Sink requires a different voltage this
will be indicated by its Sink Capabilities message.
Signed-off-by: Badhri Jagan Sridharan
---
Changelog since v1:
- Rebased the patch
On Thu, Nov 2, 2017 at 4:00 AM, Heikki Krogerus
wrote:
> Hi,
>
> +Dan and Guenter
>
> I'm sorry for the late reply. These slipped under my radar. I do
> have a one more proposal below, and a few nits..
>
> On Wed, Oct 18, 2017 at 01:22:48PM -0700, Badhri Jagan Sridhar
the Object position field.
This enables the Sink to indicate that it requires more current/power
than is being offered. If the Sink requires a different voltage this
will be indicated by its Sink Capabilities message.
Signed-off-by: Badhri Jagan Sridharan
---
Changelog since v1:
- Rebased the patch
.
Errors in source/sink_caps of the local port will prevent
the port registration. Whereas, errors in source caps of partner
device would only log them.
Signed-off-by: Badhri Jagan Sridharan
---
Changelog since v1:
- rebased on top drivers/usb/typec/tcpm.c as suggested by
gre
Please disregard v4. Going to send another version again.
On Sat, Nov 4, 2017 at 11:59 AM, Badhri Jagan Sridharan
wrote:
> At present, TCPM code assumes that local device supports
> variable/batt pdos and always selects the pdo with highest
> possible power within the board li
Please disregard v4. Going to send another version again.
On Sat, Nov 4, 2017 at 11:59 AM, Badhri Jagan Sridharan
wrote:
> The source and sink caps should follow the following rules.
> This patch validates whether the src_caps/snk_caps adheres
> to it.
>
> 6.4.1 Capabilit
the Object position field.
This enables the Sink to indicate that it requires more current/power
than is being offered. If the Sink requires a different voltage this
will be indicated by its Sink Capabilities message.
Signed-off-by: Badhri Jagan Sridharan
---
Changelog since v1:
- Rebased the patch
.
Errors in source/sink_caps of the local port will prevent
the port registration. Whereas, errors in source caps of partner
device would only log them.
Signed-off-by: Badhri Jagan Sridharan
---
hangelog since v1:
- rebased on top drivers/usb/typec/tcpm.c as suggested by
gre
Thanks Heikki !
I am making another version addressing your nits as well.
Guenter, Are you fine with the patch as well ?
Regards,
Badhri
On Tue, Nov 7, 2017 at 3:00 AM, Heikki Krogerus
wrote:
> On Sat, Nov 04, 2017 at 12:22:12PM -0700, Badhri Jagan Sridharan wrote:
>> The source and
On Tue, Nov 7, 2017 at 4:07 AM, Heikki Krogerus
wrote:
> On Sat, Nov 04, 2017 at 12:22:13PM -0700, Badhri Jagan Sridharan wrote:
>> At present, TCPM code assumes that local device supports
>> variable/batt pdos and always selects the pdo with highest
>> possible power within
.
Errors in source/sink_caps of the local port will prevent
the port registration. Whereas, errors in source caps of partner
device would only log them.
Signed-off-by: Badhri Jagan Sridharan
Acked-by: Heikki Krogerus
---
Changelog since v1:
- rebased on top drivers/usb/typec/tcpm.c as suggested
the Object position field.
This enables the Sink to indicate that it requires more current/power
than is being offered. If the Sink requires a different voltage this
will be indicated by its Sink Capabilities message.
Signed-off-by: Badhri Jagan Sridharan
Acked-by: Heikki Krogerus
---
Changelo
On Tue, Nov 14, 2017 at 9:05 AM, Guenter Roeck wrote:
> On Sun, Nov 12, 2017 at 04:23:17PM -0800, Badhri Jagan Sridharan wrote:
>> At present, TCPM code assumes that local device supports
>> variable/batt pdos and always selects the pdo with highest
>> possible power within
.
Errors in source/sink_caps of the local port will prevent
the port registration. Whereas, errors in source caps of partner
device would only log them.
Signed-off-by: Badhri Jagan Sridharan
Acked-by: Heikki Krogerus
Reviewed-by: Guenter Roeck
---
Changelog since v1:
- rebased on top drivers
the Object position field.
This enables the Sink to indicate that it requires more current/power
than is being offered. If the Sink requires a different voltage this
will be indicated by its Sink Capabilities message.
Signed-off-by: Badhri Jagan Sridharan
Acked-by: Heikki Krogerus
Reviewed-by: Gue
On Thu, Nov 23, 2017 at 3:10 AM, Adam Thomson
wrote:
> On 16 November 2017 01:02, Badhri Jagan Sridharan wrote:
>
>> At present, TCPM code assumes that local device supports
>> variable/batt pdos and always selects the pdo with highest
>> possible power within the boar
Hi Heikki,
I have a question regarding the preferred_role node.
+What: /sys/class/typec//preferred_role
+Date: March 2017
+Contact: Heikki Krogerus
+Description:
+ The user space can notify the driver about the preferred role.
+ It should be ha
On Wed, Apr 19, 2017 at 4:23 AM, Heikki Krogerus
wrote:
> Hi,
>
> On Tue, Apr 18, 2017 at 11:52:33AM -0700, Badhri Jagan Sridharan wrote:
>> Hi Heikki,
>>
>> I have a question regarding the preferred_role node.
>>
>> +What: /sys/class/typec//prefe
On Wed, Apr 19, 2017 at 8:14 AM, Guenter Roeck wrote:
> On Wed, Apr 19, 2017 at 07:45:00AM -0700, Badhri Jagan Sridharan wrote:
>> On Wed, Apr 19, 2017 at 4:23 AM, Heikki Krogerus
>> wrote:
>> > Hi,
>> >
>> > On Tue, Apr 18, 2017 at 11:52:33AM -0700, Bad
them ?
Thanks for the support !!
Badhri.
On Thu, Apr 20, 2017 at 5:24 AM, Heikki Krogerus
wrote:
> On Wed, Apr 19, 2017 at 10:22:47AM -0700, Badhri Jagan Sridharan wrote:
>> On Wed, Apr 19, 2017 at 8:14 AM, Guenter Roeck wrote:
>> > On Wed, Apr 19, 2017 at 07:45:00AM -
On Sat, Apr 22, 2017 at 2:23 AM, Rajaram R wrote:
> On Fri, Apr 21, 2017 at 10:13 PM, Guenter Roeck wrote:
>> On Fri, Apr 21, 2017 at 07:57:52PM +0530, Rajaram R wrote:
>>> On Fri, Apr 21, 2017 at 1:16 AM, Badhri Jagan Sridharan
>>> wrote:
>>> > Thanks fo
on-PD implementations,
power/data role swapping can optionally be dealt with as part of the initial
connection process."
Signed-off-by: Badhri Jagan Sridharan
---
Documentation/ABI/testing/sysfs-class-typec | 7 +--
drivers/usb/typec/typec.c | 10 --
2 files
017 12:34 AM, Oliver Neukum wrote:
> > > > > Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan
> > > > > Sridharan:
> > > > >
> > > > > Hi,
> > > > >
> > > > > > "Two independent set of me
; Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan
>> > > Sridharan:
>> > >
>> > > Hi,
>> > >
>> > > >
>> > > > "Two independent set of mechanisms are defined to allow a USB Type-C
>> > > >
Not Sure whether my previous response was sent properly.
So re-sending.
On Thu, May 18, 2017 at 2:08 PM, Badhri Jagan Sridharan
wrote:
> On Thu, May 18, 2017 at 9:51 AM, Guenter Roeck wrote:
>> On Thu, May 18, 2017 at 11:13:51AM +0200, Oliver Neukum wrote:
>>> Am Mittwoch, den
User space applications in some cases have the need to enforce a
specific port type(DFP/UFP/DRP). This change allows userspace to
attempt setting the desired port type. Low level drivers can
however reject the request if the specific port type is not supported.
Signed-off-by: Badhri Jagan
User space applications in some cases have the need to enforce a
specific port type(DFP/UFP/DRP). This change allows userspace to
attempt setting the desired port type. Low level drivers can
however reject the request if the specific port type is not supported.
Signed-off-by: Badhri Jagan
Thanks comments inline.
On Tue, May 23, 2017 at 7:38 PM, Guenter Roeck wrote:
> On 05/23/2017 06:28 PM, Badhri Jagan Sridharan wrote:
>>
>> User space applications in some cases have the need to enforce a
>> specific port type(DFP/UFP/DRP). This change allows userspace to
&
On Thu, May 25, 2017 at 12:48 AM, Guenter Roeck wrote:
> On 05/24/2017 08:10 PM, Badhri Jagan Sridharan wrote:
>>
>> Thanks comments inline.
>>
>> On Tue, May 23, 2017 at 7:38 PM, Guenter Roeck wrote:
>>>
>>> On 05/23/2017 06:28 PM, Badhri Jag
User space applications in some cases have the need to enforce a
specific port type(DFP/UFP/DRP). This change allows userspace to
attempt setting the desired port type. Low level drivers can
however reject the request if the specific port type is not supported.
Signed-off-by: Badhri Jagan
On Fri, May 26, 2017 at 11:00 AM, Guenter Roeck wrote:
> On Fri, May 26, 2017 at 10:45:59AM -0700, Badhri Jagan Sridharan wrote:
>> User space applications in some cases have the need to enforce a
>> specific port type(DFP/UFP/DRP). This change allows userspace to
>> attemp
User space applications in some cases have the need to enforce a
specific port type(DFP/UFP/DRP). This change allows userspace to
attempt setting the desired port type. Low level drivers can
however reject the request if the specific port type is not supported.
Signed-off-by: Badhri Jagan
On Fri, May 26, 2017 at 11:31 AM, Greg Kroah-Hartman
wrote:
> On Fri, May 26, 2017 at 10:45:59AM -0700, Badhri Jagan Sridharan wrote:
>> User space applications in some cases have the need to enforce a
>> specific port type(DFP/UFP/DRP). This change allows userspace to
>>
User space applications in some cases have the need to enforce a
specific port type(DFP/UFP/DRP). This change allows userspace to
attempt setting the desired port type. Low level drivers can
however reject the request if the specific port type is not supported.
Signed-off-by: Badhri Jagan
Thanks Geunter for comments. Will fix them in my next patch.
On Fri, May 26, 2017 at 7:24 PM, Guenter Roeck wrote:
> On 05/26/2017 04:07 PM, Badhri Jagan Sridharan wrote:
>>
>> User space applications in some cases have the need to enforce a
>> specific port type(DFP/UFP/DRP
On Fri, May 26, 2017 at 10:43 PM, Greg Kroah-Hartman
wrote:
> On Fri, May 26, 2017 at 01:42:57PM -0700, Badhri Jagan Sridharan wrote:
>> User space applications in some cases have the need to enforce a
>> specific port type(DFP/UFP/DRP). This change allows userspace to
>>
User space applications in some cases have the need to enforce a
specific port type(DFP/UFP/DRP). This change allows userspace to
attempt setting the desired port type. Low level drivers can
however reject the request if the specific port type is not supported.
Signed-off-by: Badhri Jagan
User space applications in some cases have the need to enforce a
specific port type(DFP/UFP/DRP). This change allows userspace to
attempt setting the desired port type. Low level drivers can
however reject the request if the specific port type is not supported.
Signed-off-by: Badhri Jagan
Thanks for all the reviews Guenter & Heikki.
Heikki, Is there anything else that I need to address in this patch ?
Or is the patch ready to be merged ?
Thanks,
Badhri
On Mon, May 29, 2017 at 12:56 PM, Badhri Jagan Sridharan
wrote:
> User space applications in some cases have the need to
,21 @@ Description:
Valid values: source, sink
+What: /sys/class/typec//port_type
+Date: May 2017
+Contact: Badhri Jagan Sridharan
+Description:
+ Indicates the type of the port. This attribute can be used for
+ requesting a change in
Noticed that I accidentally dropped the ABI documentation for the new
port_type node during patchset revision.
Adding that back and resubmitting the patch.
Thanks,
Badhri.
On Mon, May 29, 2017 at 1:07 PM, Badhri Jagan Sridharan
wrote:
> Thanks for all the reviews Guenter & Heikki.
>
are good with the CL as well :)
Thanks,
Badhri.
On Mon, Jun 5, 2017 at 2:56 AM, Heikki Krogerus
wrote:
> Hi,
>
> Sorry for the late reply. I was unable to follow my email last week.
>
> On Tue, May 30, 2017 at 12:39:53PM -0700, Badhri Jagan Sridharan wrote:
>> User space a
Hi Heikki,
While testing with different type-c phones available in the market,
With some phones, I noticed that supports_usb_power_delivery
reports "no" eventhough an explicit pd contract has been
established. After spending sometime debugging, I noticed that
the root cause of this is that the par
Add super speed descriptors for f_midi.
Signed-off-by: Badhri Jagan Sridharan
---
drivers/usb/gadget/function/f_midi.c | 42 +---
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/function/f_midi.c
b/drivers/usb/gadget/function
On Tue, Aug 15, 2017 at 6:36 AM, Heikki Krogerus
wrote:
> Hi,
>
> On Mon, Aug 14, 2017 at 11:57:15AM -0700, Badhri Jagan Sridharan wrote:
>> Hi Heikki,
>>
>> While testing with different type-c phones available in the market,
>> With some phones, I noticed
AM, Badhri Jagan Sridharan
wrote:
> On Tue, Aug 15, 2017 at 6:36 AM, Heikki Krogerus
> wrote:
>> Hi,
>>
>> On Mon, Aug 14, 2017 at 11:57:15AM -0700, Badhri Jagan Sridharan wrote:
>>> Hi Heikki,
>>>
>>> While testing with different type-c phones
the enumeration time when connected to Type-A ports.
Signed-off-by: Badhri Jagan Sridharan
---
drivers/usb/typec/tcpm.c | 6 +-
include/linux/usb/tcpm.h | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
index 4f1f4215f
oft Reset but also returns the power supply to
USB Default Operation (vSafe0V or vSafe5V output) in order to protect the
Sink.
Add a config option to tcpc_dev and let the device specific driver decide
what needs to be done.
Signed-off-by: Badhri Jagan Sridharan
---
drivers/usb/typec/tcpm.c
+ Guenter
On Thu, Sep 13, 2018 at 6:43 AM Badhri Jagan Sridharan
wrote:
>
> On Wed, Sep 12, 2018 at 11:39 PM Jack Pham wrote:
> >
> > Hello Badhri,
> >
> > On Wed, Sep 12, 2018 at 07:11:13PM -0700, Badhri Jagan Sridharan wrote:
> > > During hard reset, TCPM
On Wed, Sep 12, 2018 at 11:39 PM Jack Pham wrote:
>
> Hello Badhri,
>
> On Wed, Sep 12, 2018 at 07:11:13PM -0700, Badhri Jagan Sridharan wrote:
> > During hard reset, TCPM turns off the charging path.
> > The spec provides an option for Sink to either drop to vSafe5V or v
On Thu, Sep 13, 2018 at 10:51 AM Guenter Roeck wrote:
>
> On Thu, Sep 13, 2018 at 04:24:08PM +0300, Heikki Krogerus wrote:
> > +Guenter
> >
> > On Wed, Sep 12, 2018 at 07:11:12PM -0700, Badhri Jagan Sridharan wrote:
> > > During HARD_RESET the data link is dis
On Thu, Sep 13, 2018 at 10:07 AM Jack Pham wrote:
>
> On Thu, Sep 13, 2018 at 6:43 AM Badhri Jagan Sridharan
> wrote:
> >
> > On Wed, Sep 12, 2018 at 11:39 PM Jack Pham wrote:
> > >
> > > Hello Badhri,
> > >
> > > On Wed, Sep 1
On Fri, Sep 14, 2018 at 11:42 AM Jack Pham wrote:
>
> Hi Badhri,
>
> On Thu, Sep 13, 2018 at 04:38:10PM -0700, Badhri Jagan Sridharan wrote:
> > On Thu, Sep 13, 2018 at 10:07 AM Jack Pham wrote:
> > > On Thu, Sep 13, 2018 at 6:43 AM Badhri Jagan Sridharan
> > &
enters
SNK_HARD_RESET_SINK_ON.
Signed-off-by: Badhri Jagan Sridharan
Changes in V2:
Based on feedback of ja...@codeaurora.org
- vsafe_5v_hard_reset flag from tcpc_config is removed
- Patch only differentiates between pd port partner and non-pd port
partner
V1 version of the patch is here
ed usb device.
Signed-off-by: Badhri Jagan Sridharan
---
Documentation/devicetree/bindings/connector/usb-connector.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt
b/Documentation/devicetree/bindings/connector/usb-connec
the enumeration time when connected to Type-A ports.
Signed-off-by: Badhri Jagan Sridharan
-
Version history:
V2:
Based on feedback from heikki.kroge...@linux.intel.com
- self_powered added to the struct tcpm_port which is populated from
a. "connector" node of the device tree in tcp
+ ja...@codeaurora.org
On Fri, Sep 28, 2018 at 4:47 PM Badhri Jagan Sridharan
wrote:
>
> During the initial connect to a non-pd port, sink would hard reset
> twice before deeming that the port partner is non-pd. TCPM sets the
> the charge path to false during the hard reset.
the enumeration time when connected to Type-A ports.
Signed-off-by: Badhri Jagan Sridharan
-
Version history:
V3:
Rebase on top of usb-next
V2:
Based on feedback from heikki.kroge...@linux.intel.com
- self_powered added to the struct tcpm_port which is populated from
a. "connector"
enters
SNK_HARD_RESET_SINK_ON.
Signed-off-by: Badhri Jagan Sridharan
Changes in V3:
Rebase on top of usb-next
Changes in V2:
Based on feedback of ja...@codeaurora.org
- vsafe_5v_hard_reset flag from tcpc_config is removed
- Patch only differentiates between pd port partner and non-pd port
ed usb device.
Signed-off-by: Badhri Jagan Sridharan
---
Changes is v3:
- Rebase on top of usb-next
- no change w.r.t to this patch. Same as previous versions.
No v2 version as the patch was introduced there.
---
Documentation/devicetree/bindings/connector/usb-connector.txt | 2 ++
1 fi
Sure. Just resent the patch stack !
On Mon, Oct 1, 2018 at 2:54 AM Heikki Krogerus
wrote:
>
> On Fri, Sep 28, 2018 at 04:47:02PM -0700, Badhri Jagan Sridharan wrote:
> > During HARD_RESET the data link is disconnected.
> > For self powered device, the spec is advising
Hi Heikki, Rob,
Thanks for reviewing !
Should I update the patchset with the Reviewed-by tag and bumpup the
patchset version ?
Or is that not necessary?
Thanks,
Badhri.
On Fri, Nov 2, 2018 at 6:28 AM Heikki Krogerus
wrote:
>
> On Mon, Oct 01, 2018 at 12:45:01PM -0700, Badhri Jagan Sri
72 matches
Mail list logo
