Re: [PATCH] iwlwifi: Document missing module options

2016-01-07 Thread Grumbach, Emmanuel
Hi, On 01/07/2016 12:24 AM, Rodrigo Freire wrote: > This patch documents two missing module options in the internal > code comment block. > > Signed-off-by: Rodrigo Freire > --- > drivers/net/wireless/iwlwifi/iwl-modparams.h |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff

pull request: iwlwifi-next 2016-01-07

2016-01-07 Thread Grumbach, Emmanuel
Hi Kalle, Here is the last round of patches for 4.5. Most of them are small and / or fixes. Let me know if you have issues. FYI - I scripted a few checks so that I hope that the internal tags that leaked in the previous pull request won't leak any more. The following changes since commit e5d15cb

Re: [PATCH RESEND] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd

2015-12-30 Thread Grumbach, Emmanuel
Hi, On 12/30/2015 07:15 PM, Nicholas Krause wrote: > This fixes error handling in the function iwl_pcie_enqueue_hcmd > by checking if all calls to the function wl_pcie_txq_build_tfd > have failed by returning a error code and if so jump to the goto > label out from the cleaning up of acquired res

Re: [PATCH 44/45] iwlwifi: fix printf specifier

2015-12-22 Thread Grumbach, Emmanuel
On 12/23/2015 06:08 AM, Joe Perches wrote: > On Mon, 2015-12-21 at 22:50 +0200, Emmanuel Grumbach wrote: >> Smatch warned about a bad specifier being used. Fix that. > I see nothing here other than a signed/unsigned > issue that shouldn't need fixing. The conversion > from hex to decimal may not

Re: pull request: iwlwifi-next-2015-12-21

2015-12-21 Thread Grumbach, Emmanuel
On 12/21/2015 10:49 PM, Grumbach, Emmanuel wrote: > Hi Kalle, > > here is a pull request for 4.5. I guess there will be one more after that > depending on when Linus will open the merge window I guess. > The diffstat look awful and I have no clue why. It looks as if I had done th

pull request: iwlwifi-next-2015-12-21

2015-12-21 Thread Grumbach, Emmanuel
Hi Kalle, here is a pull request for 4.5. I guess there will be one more after that depending on when Linus will open the merge window I guess. The diffstat look awful and I have no clue why. It looks as if I had done the whole code reorganisation... So we have a pretty large pull request here.

pull request: iwlwifi-2015-12-21

2015-12-20 Thread Grumbach, Emmanuel
Hi guys, We seem to have problem with iwlwifi-7265D-10.ucode which can be replaced by iwlwifi-7265-10.ucode without affecting anyone. As a bonus, the size on disk is a bit reduced. The following changes since commit bbe4917c054eb0a73e250c6363341e3bf6725839: WHENCE: use https://linuxtv.org for

RE: [PATCH] mac80211: fix PS-Poll handling

2015-12-20 Thread Grumbach, Emmanuel
> > My commit below broken PS-Poll handling. In case the driver > has no frames buffered, driver_release_tids will be 0, but > calling find_highest_prio_tid() with 0 as a parameter is > not a good idea: > fls(0) - 1 = -1. > This bug caused mac80211 to think that frames were buffered > in the drive

RE: pull request: iwlwifi 2015-12-16

2015-12-16 Thread Grumbach, Emmanuel
> > "Grumbach, Emmanuel" writes: > > > This is a pull request with small fixes for 4.4. Note that due to the > > large number of files being renamed, you need to set merge.renameLimit > > to a big number to merge wl-drv into wl-drv-next but you probably >

pull request: iwlwifi 2015-12-16

2015-12-16 Thread Grumbach, Emmanuel
Hi Kalle, This is a pull request with small fixes for 4.4. Note that due to the large number of files being renamed, you need to set merge.renameLimit to a big number to merge wl-drv into wl-drv-next but you probably noticed that already :) The following changes since commit 9513c5e18a0dc55a1fc9c

Re: iwlwifi - L1 Enabled - LTR Enabled loop

2015-12-13 Thread Grumbach, Emmanuel
On 12/14/2015 01:04 AM, Arend van Spriel wrote: > On 12/12/2015 12:32 AM, Johannes Berg wrote: >> On Fri, 2015-12-11 at 15:17 -0800, Luis R. Rodriguez wrote: >>> I just tried a base config from opensuse, then localmodconfig, then >>> 'make xenconfig' (which I need) and that worked. I can't debug

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Grumbach, Emmanuel
On 12/08/2015 09:11 PM, Krishna Chaitanya wrote: > > > On Dec 9, 2015 12:37 AM, "Grumbach, Emmanuel" > mailto:emmanuel.grumb...@intel.com>> wrote: > > > > > > > > On 12/08/2015 07:49 PM, Krishna Chaitanya wrote: > >

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Grumbach, Emmanuel
On 12/08/2015 07:49 PM, Krishna Chaitanya wrote: > > > On Dec 8, 2015 10:13 PM, "Grumbach, Emmanuel" > mailto:emmanuel.grumb...@intel.com>> wrote: > > > > > > > > On 12/08/2015 06:35 PM, Krishna Chaitanya wrote: > >

Re: [PATCH 2/2] mac80211: support hw managing reorder logic

2015-12-08 Thread Grumbach, Emmanuel
On 12/08/2015 07:09 PM, Grumbach, Emmanuel wrote: > From: Sara Sharon > > Enable driver to manage the reordering logic itself. > This is needed for example for the iwlwifi driver that > supports hardware based reordering. > > type=feature Ouch - sorry for that. I guess you

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Grumbach, Emmanuel
On 12/08/2015 06:35 PM, Krishna Chaitanya wrote: > > > On Dec 8, 2015 10:01 PM, "Grumbach, Emmanuel" > mailto:emmanuel.grumb...@intel.com>> wrote: > > > > > > > > On 12/08/2015 06:03 PM, Krishna Chaitanya wrote: > > > On Tue, Dec 8, 2

Re: [PATCH 2/9] mac80211: limit the A-MSDU Tx based on peer's capabilities

2015-12-08 Thread Grumbach, Emmanuel
On 12/08/2015 06:03 PM, Krishna Chaitanya wrote: > On Tue, Dec 8, 2015 at 7:34 PM, Emmanuel Grumbach > wrote: >> index 7a76ce6..f4a5287 100644 >> --- a/net/mac80211/ht.c >> +++ b/net/mac80211/ht.c >> @@ -230,6 +230,11 @@ bool ieee80211_ht_cap_ie_to_sta_ht_cap(struct >> ieee80211_sub_if_data *sd

Re: [PATCH 24/41] iwlwifi: mvm: move fw-dbg code to separate file

2015-12-01 Thread Grumbach, Emmanuel
On 12/01/2015 08:53 PM, Kalle Valo wrote: > Emmanuel Grumbach writes: > >> From: Golan Ben-Ami >> >> The fw debug functionality is big enough to warrant >> a separate file. Move existing related functions to the new file. >> >> Signed-off-by: Golan Ben-Ami >> Signed-off-by: Emmanuel Grumbach

pull request: iwlwifi-next 2015-12-01

2015-12-01 Thread Grumbach, Emmanuel
Hi Kalle, This is a pull request for -next. It is based on your tree after the reorganisation. Details in the tag. Let me know if you have issues. Please pull. Thanks. The following changes since commit 6d808eba602b00f77f26191f45328774ff057cc0: mac80211_hwsim: move Kconfig entry for sorting

Re: [PATCH] iwlwifi: fix compare_const_fl.cocci warnings

2015-11-28 Thread Grumbach, Emmanuel
Hi Julia, On 11/27/2015 06:11 PM, Julia Lawall wrote: > Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- > > This looks a bit nicer around the other way, in my opi

RE: [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE()

2015-11-25 Thread Grumbach, Emmanuel
> > WARN_ON_ONCE() takes a condition rather than a format string. This patch > converted WARN_ON_ONCE() to WARN_ONCE() instead. > > Signed-off-by: Geliang Tang > --- > drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Already fixed. Thanks. >

Re: [patch] iwlwifi: mvm: rs: fix a warning message

2015-11-21 Thread Grumbach, Emmanuel
On 11/21/2015 12:33 PM, Dan Carpenter wrote: > WARN_ON_ONCE() doesn't take a message, it only takes a condition. I > have changed this to WARN(1, ...). > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/wireless/iwlwifi/mvm/rs.c > b/drivers/net/wireless/iwlwifi/mvm/rs.c > index d1ad

Re: [PATCH 0/8] various mac80211 patches

2015-11-20 Thread Grumbach, Emmanuel
On 11/20/2015 12:42 PM, Johannes Berg wrote: > I'm ignoring patches 1-3 since I already have them pending. > > I've applied 6-8 to mac80211 now. > > I'll leave 4 and 5 pending for now and apply them to mac80211-next, > unless you speak up now and tell me you really want those driver fixes > they

RE: State of indoor navigation (11MC) in wireless core API

2015-11-18 Thread Grumbach, Emmanuel
Hi Anatol, > > Hi > > There is huge interest both from hardwire and software vendors in using > Indoor Navigation at mobile devices. We are interested in making the > ChromeOS ecosystem using this feature as well. > > I checked how Android implements indoor navigation where it is used for a > w

pull request: iwlwifi firmware for iwlmvm devices

2015-11-18 Thread Grumbach, Emmanuel
Hi, This is a release of the -16.ucode firmware for Intel Wireless devices driven by iwlmvm. This firmware is supported by kernel 4.3 and newer. Please pull. Thanks! The following changes since commit 1406ec112423c8f70d503d3cd44c6f8e147f7ac3: linux-firmware: Update firmware patch for Intel B

pull request: iwlwifi 2015-11-15

2015-11-15 Thread Grumbach, Emmanuel
Hi Kalle, Here is the first pull request for 4.4. I admit that the FW API is borderline but since we are very early in the cycle, I think it is fine. The firmware is far from being released yet (so that this patch doesn't change much now), but having this patch in will allow me to provide the new

Re: Intel 7260 - limited in 5GHz spectrum

2015-10-31 Thread Grumbach, Emmanuel
Hi, On 10/30/2015 06:37 PM, Pushpal Sidhu wrote: > Hi, > > I've been working with the Intel 7260 card which advertises itself as > dual band wireless AC card. However, I cannot get it working in AP > mode in the 5GHz range. An $(iw list) shows that the entire 5GHz band > has 'no IR' next to it so

Re: pull request: iwlwifi-next 2015-10-25

2015-10-28 Thread Grumbach, Emmanuel
On 10/28/2015 02:45 PM, Kalle Valo wrote: > "Grumbach, Emmanuel" writes: > >> Last (obviously) pull request for 4.4. >> I came back from a long vacation and took maintenance over back from Luca. >> Please note that you'll have to merge mac80211-next/maste

Re: [linuxwifi] [-next] WARNING at iwl_mvm_time_event_send_add+0x72/0x1b6

2015-10-26 Thread Grumbach, Emmanuel
On 10/26/2015 10:30 AM, Sergey Senozhatsky wrote: > On (10/26/15 07:51), Grumbach, Emmanuel wrote: >>> On 10/26/2015 08:41 AM, Sergey Senozhatsky wrote: >>>> Hi, >>>> >>>> linux-next 20151022 >>>> >>>> >>> >

Re: [PATCH v2] net: tso: add support for IPv6

2015-10-26 Thread Grumbach, Emmanuel
On 10/26/2015 10:14 AM, Toshiaki Makita wrote: > On 2015/10/26 16:47, Grumbach, Emmanuel wrote: >> On 10/26/2015 06:03 AM, Toshiaki Makita wrote: >>> On 2015/10/26 5:02, Emmanuel Grumbach wrote: >>>> Adding IPv6 for the TSO helper API is trivial: >>>&g

Re: [linuxwifi] [-next] WARNING at iwl_mvm_time_event_send_add+0x72/0x1b6

2015-10-26 Thread Grumbach, Emmanuel
On 10/26/2015 09:23 AM, Grumbach, Emmanuel wrote: > Hi, > > On 10/26/2015 08:41 AM, Sergey Senozhatsky wrote: >> Hi, >> >> linux-next 20151022 >> >> > > Can be reproduced reliably? > Seems like a bad race between the end of session protecti

Re: [PATCH v2] net: tso: add support for IPv6

2015-10-26 Thread Grumbach, Emmanuel
On 10/26/2015 06:03 AM, Toshiaki Makita wrote: > On 2015/10/26 5:02, Emmanuel Grumbach wrote: >> Adding IPv6 for the TSO helper API is trivial: >> * Don't play with the id (which doesn't exist in IPv6) >> * Correctly update the payload_len (don't include the >> length of the IP header itself) >

Re: [linuxwifi] [-next] WARNING at iwl_mvm_time_event_send_add+0x72/0x1b6

2015-10-26 Thread Grumbach, Emmanuel
Hi, On 10/26/2015 08:41 AM, Sergey Senozhatsky wrote: > Hi, > > linux-next 20151022 > > Can be reproduced reliably? Seems like a bad race between the end of session protection for the authentication and the start of the session protection for the deauth. I think I found the hole in the locks i

pull request: iwlwifi-next 2015-10-25

2015-10-25 Thread Grumbach, Emmanuel
Hi Kalle, Last (obviously) pull request for 4.4. I came back from a long vacation and took maintenance over back from Luca. Please note that you'll have to merge mac80211-next/master (or net-next) before you pull from me. I created this pull request giving mac80211-next/master as the start point t

Re: [RFC v4 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

2015-10-22 Thread Grumbach, Emmanuel
On 10/22/2015 04:08 PM, Grumbach, Emmanuel wrote: > When the op_mode sends an skb whose payload is bigger than > MSS, PCIe will create an A-MSDU out of it. PCIe assumes > that the skb that is coming from the op_mode can fit in one > A-MSDU. It is the op_mode's responsibility to

RE: [RFC v3 2/2] iwlwifi: mvm: send large SKBs to the transport

2015-10-22 Thread Grumbach, Emmanuel
> > On Wed, 2015-10-21 at 21:34 +0300, Emmanuel Grumbach wrote: > > + > > + if (skb->protocol == htons(ETH_P_IP)) { > > + ip_hdr(tmp)->id = ip_hdr(skb)->id; > > Too late, you already called consume_skb(skb). > So this is a potential use after free. Ouch - thanks for c

Re: [RFC v3 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

2015-10-21 Thread Grumbach, Emmanuel
On 10/22/2015 05:27 AM, Eric Dumazet wrote: > On Thu, 2015-10-22 at 00:14 +0000, Grumbach, Emmanuel wrote: > >> >> Well. I guess I should at least check, but even with very small MSS, our >> device supports up to 20 pointers for the same 802.11 packet: 2 are for >&

Re: [RFC v3 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

2015-10-21 Thread Grumbach, Emmanuel
Hi Eric, On 10/22/2015 02:30 AM, Eric Dumazet wrote: > On Wed, 2015-10-21 at 21:34 +0300, Emmanuel Grumbach wrote: >> When the op_mode sends an skb whose payload is bigger than >> MSS, PCIe will create an A-MSDU out of it. PCIe assumes >> that the skb that is coming from the op_mode can fit in one

Re: [PATCH] iwlwifi: Fix module firmware information for 3160

2015-10-18 Thread Grumbach, Emmanuel
Hi, On 10/18/2015 09:33 PM, Ben Hutchings wrote: > On Sun, 2015-10-18 at 18:47 +0100, Ben Hutchings wrote: >> IWL3160_UCODE_API_OK is no longer defined, so we end up with this >> in the module information: >> >> firmware: iwlwifi-3160-IWL3160_UCODE_API_OK.ucode >> >> It looks like IWL7260_UC

Re: [linuxwifi] Wireless card not working

2015-10-17 Thread Grumbach, Emmanuel
Hi, On 10/18/2015 01:38 AM, Helmut Heubel wrote: > > Hi, I have an Asus UX305FA notebook and I am facing some problems with > the Intel 7265 wireless card, sometimes it works and sometimes not > (lately it is more frequent that it does not work at all what forces > me to always use the ethernet U

Re: pull request: iwlwifi-next 2015-08-23

2015-08-24 Thread Grumbach, Emmanuel
On 08/24/2015 10:53 PM, Kalle Valo wrote: > "Grumbach, Emmanuel" writes: > >> one very last pull request for 4.3 before the merge windows opens. I >> hope it will make it. Let me know if you have issues with it. > > We got lucky as Linus released rc8 s

pull request: iwlwifi-next 2015-08-23

2015-08-23 Thread Grumbach, Emmanuel
Hi Kalle, one very last pull request for 4.3 before the merge windows opens. I hope it will make it. Let me know if you have issues with it. Thanks! The following changes since commit ecc7c518b3017821a6b26fb5fdaa548afa8ee236: iwlwifi: mvm: fix a race in D0i3 vs. Tx path (2015-08-18 10:25:26 +

Re: [patch] iwlwifi: mvm: catch underflow error earlier

2015-08-22 Thread Grumbach, Emmanuel
Hi Dan, On 08/21/2015 11:49 AM, Dan Carpenter wrote: > My static checker complains that we don't check for underflows in > iwl_dbgfs_fw_dbg_conf_write(). This is harmless because we have a > sanity check in iwl_mvm_start_fw_dbg_conf(), but we may as well make > this unsigned and silence the under

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Grumbach, Emmanuel
On 08/20/2015 04:53 PM, Grumbach, Emmanuel wrote: > > > On 08/20/2015 04:11 PM, Eric Dumazet wrote: >> On Thu, 2015-08-20 at 06:21 +0000, Grumbach, Emmanuel wrote: >>> >>> On 08/19/2015 11:39 PM, Eric Dumazet wrote: >>>> On Wed, 2015-0

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Grumbach, Emmanuel
On 08/20/2015 04:11 PM, Eric Dumazet wrote: > On Thu, 2015-08-20 at 06:21 +0000, Grumbach, Emmanuel wrote: >> >> On 08/19/2015 11:39 PM, Eric Dumazet wrote: >>> On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote: >>> >>>> Hm.. how would

Re: [RFC v3 1/3] iwlwifi: mvm: add real TSO implementation

2015-08-20 Thread Grumbach, Emmanuel
On 08/20/2015 04:13 PM, Eric Dumazet wrote: > On Thu, 2015-08-20 at 11:15 +0300, Emmanuel Grumbach wrote: >> The segmentation is done completely in software. The >> driver creates several MPDUs out of a single large send. >> Each MPDU is a newly allocated SKB. >> A page is allocated to create the

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Grumbach, Emmanuel
On 08/20/2015 10:21 AM, Grumbach, Emmanuel wrote: > > > On 08/19/2015 11:39 PM, Eric Dumazet wrote: >> On Wed, 2015-08-19 at 19:17 +0000, Grumbach, Emmanuel wrote: >> >>> Hm.. how would net/core/tso.c avoid this? >> >> Because a driver using these h

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-20 Thread Grumbach, Emmanuel
On 08/19/2015 11:39 PM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 19:17 +0000, Grumbach, Emmanuel wrote: > >> Hm.. how would net/core/tso.c avoid this? > > Because a driver using these helpers keep around the original LSO packet > and frees it normally at TX completio

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 11:39 PM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 19:17 +0000, Grumbach, Emmanuel wrote: > >> Hm.. how would net/core/tso.c avoid this? > > Because a driver using these helpers keep around the original LSO packet > and frees it normally at TX completion t

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 05:24 PM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: >> This allows to release the backpressure on the socket only >> when the last segment is released. >> Now the truesize looks like this: >> if the truesize of the original skb is 65420, all t

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

2015-08-19 Thread Grumbach, Emmanuel
Hi, On 08/19/2015 10:10 PM, Sergei Shtylyov wrote: > Hello. > > On 08/19/2015 03:59 PM, Emmanuel Grumbach wrote: > >> This allows to release the backpressure on the socket only >> when the last segment is released. >> Now the truesize looks like this: >> if the truesize of the original skb is 65

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 09:02 PM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 17:56 +0000, Grumbach, Emmanuel wrote: >> > >> So I feel that making net/core/tso.c more complicated just because of >> our craziness seems an overkill to me. >> I'll try a bit harder to see

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 08:20 PM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 17:00 +0000, Grumbach, Emmanuel wrote: >> >> On 08/19/2015 07:08 PM, Eric Dumazet wrote: >>> On Wed, 2015-08-19 at 15:07 +, Grumbach, Emmanuel wrote: >>> >>>> I'll look at it

Re: [RFC v2 1/3] iwlwifi: mvm: add real TSO implementation

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 05:18 PM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: >> The segmentation is done completely in software. The >> driver creates several MPDUs out of a single large send. >> Each MPDU is a newly allocated SKB. >> A page is allocated to create the

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Grumbach, Emmanuel
On 08/19/2015 07:08 PM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 15:07 +0000, Grumbach, Emmanuel wrote: > >> I'll look at it. >> I was almost starting to implement that but then I thought with another >> (good?) reason to use LSO. LSO gives me the guarantee that

Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

2015-08-19 Thread Grumbach, Emmanuel
Hi Eric, First, thank you a lot for your comments. On 08/19/2015 05:14 PM, Eric Dumazet wrote: > On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote: > >> We could have enabled A-MSDU based on xmit-more, but the >> rationale of using LSO is that when using pfifo-fast, >> the Qdisc gets on

pull request: iwlwifi-next 2015-08-18

2015-08-18 Thread Grumbach, Emmanuel
Hi Kalle, This is another pull request for 4.3. As usual, details in the tag. As announced, this needs patches from mac80211-next, so I merged Johanne's tag and you did so as well upon my request (thank you for that). Please pull and let me know if you have issues. The following changes since co

Re: [PATCH] iwlwifi: out-of-bounds access in iwl_init_sband_channels

2015-08-13 Thread Grumbach, Emmanuel
Hi, On 08/14/2015 03:36 AM, Adrien Schildknecht wrote: > Both loops of this function compare data from the 'chan' array and then > check if the index is valid. > > The 2 conditions should be inverted to avoid an out-of-bounds access. > Was that found by a static analyzer or any other automated

pull request: iwlwifi-next 2015-08-04

2015-08-04 Thread Grumbach, Emmanuel
Hi Kalle, It comes late, but this is the first pull request for 4.3. I have quite a bit for the next one that will come after this one. Please pull - thanks! emmanuel The following changes since commit e0456717e483bb8a9431b80a5bdc99a928b9b003: Merge git://git.kernel.org/pub/scm/linux/kernel/

pull request: iwlwifi 2015-07-30

2015-07-30 Thread Grumbach, Emmanuel
Hi Kalle, Here is another pull request for 4.2. Three small fixes this time. Let me know if you have any issues. Note that my availability will be limited next week, and the week after I'll be completely offline. Thanks! The following changes since commit be88a1ada9b97bb016196b7f4a1fc2fe2f798529

[no subject]

2015-07-30 Thread Grumbach, Emmanuel
ds dsa -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [linuxwifi] Random connection loss

2015-07-29 Thread Grumbach, Emmanuel
Hi, On 07/29/2015 10:57 PM, a...@keemail.me wrote: > I'm not quite sure how to trace the problem to its roots. > > My wireless connection is disconnected and reconnects again. I can't > reproduce this nor can I tell at what rate it disconnects. > > I didn't experience it before upgrading the ker

Re: [RFC 02/10] mac80211: allow to transmit A-MSDU within A-MPDU

2015-07-28 Thread Grumbach, Emmanuel
On 07/28/2015 08:27 PM, Krishna Chaitanya wrote: > On Tue, Jul 28, 2015 at 10:42 PM, Grumbach, Emmanuel > wrote: >> >> On 07/28/2015 02:35 PM, Grumbach, Emmanuel wrote: >>>> On Tue, Jul 21, 2015 at 1:12 AM, Emmanuel Grumbach >>>> wrote: >>>&

Re: [RFC 02/10] mac80211: allow to transmit A-MSDU within A-MPDU

2015-07-28 Thread Grumbach, Emmanuel
On 07/28/2015 02:35 PM, Grumbach, Emmanuel wrote: >> On Tue, Jul 21, 2015 at 1:12 AM, Emmanuel Grumbach >> wrote: >>> diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index >>> c8ba2e7..a758eb84 100644 >>> --- a/net/mac80211/agg-tx.c >>>

RE: [RFC 02/10] mac80211: allow to transmit A-MSDU within A-MPDU

2015-07-28 Thread Grumbach, Emmanuel
> > On Tue, Jul 21, 2015 at 1:12 AM, Emmanuel Grumbach > wrote: > > > > diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index > > c8ba2e7..a758eb84 100644 > > --- a/net/mac80211/agg-tx.c > > +++ b/net/mac80211/agg-tx.c > > @@ -97,7 +97,8 @@ static void ieee80211_send_addba_request(stru

Re: [linuxwifi] [PATCH] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd

2015-07-22 Thread Grumbach, Emmanuel
On 07/22/2015 08:30 PM, nick wrote: > > > On 2015-07-22 01:28 PM, Grumbach, Emmanuel wrote: >> >> >> On 07/22/2015 07:39 PM, Nicholas Krause wrote: >>> This fixes error handling in the function iwl_pcie_enqueue_hcmd >>> by checking if all calls t

Re: [PATCH] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd

2015-07-22 Thread Grumbach, Emmanuel
On 07/22/2015 07:39 PM, Nicholas Krause wrote: > This fixes error handling in the function iwl_pcie_enqueue_hcmd > by checking if all calls to the function wl_pcie_txq_build_tfd > have failed by returning a error code and if so jump to the goto > label out from the cleaning up of acquired resourc

pull request: iwlwifi 2015-06-15

2015-07-12 Thread Grumbach, Emmanuel
Hi Kalle, This is the first pull request of fixes for 4.2. A few of the patches here are CCed to stable. Besides fix for (hard to hit) crashes there are a bunch of fixes for 8000 devices which are now undergoing the final round of tests. Let me know if you have issues! emmanuel The following ch

Re: [linuxwifi] [PATCH] iwlwifi:Make various functions void in the file rs.c

2015-07-08 Thread Grumbach, Emmanuel
Hi, On 07/08/2015 06:03 PM, Nicholas Krause wrote: > This makes various functions in the file rs.c void due to these > functions never returning a error code to signal to their callers > if and how they have failed to complete their intended work. > > Signed-off-by: Nicholas Krause I picked it

Re: pull request: add -13.ucode firmware for Intel Wireless

2015-07-05 Thread Grumbach, Emmanuel
On Thu, 2015-06-18 at 21:30 +0300, Emmanuel Grumbach wrote: > Hi, > > This is a pull request for a new version of the firmware for Intel > wireless devices. Note that with this new firmware, we are now adding > support for 3 new devices: 3165, 8260 and 4165. > > I had sent a pull request a while

Re: [RFC 0/5] cfg80211 / mac80211: add support for Neighbor Awareness Networking

2015-06-26 Thread Grumbach, Emmanuel
On Fri, 2015-06-26 at 06:06 +, Amitkumar Karwar wrote: > Hi Emmanuel, > > > From: Emmanuel Grumbach > > Date: Mon, Mar 30, 2015 at 7:44 PM > > Subject: [RFC 0/5] cfg80211 / mac80211: add support for Neighbor > > Awareness Networking > > To: linux-wireless@vger.kernel.org > > Cc: Emmanuel Grum

pull request: add -13.ucode firmware for Intel Wireless

2015-06-18 Thread Grumbach, Emmanuel
Hi, This is a pull request for a new version of the firmware for Intel wireless devices. Note that with this new firmware, we are now adding support for 3 new devices: 3165, 8260 and 4165. I had sent a pull request a while ago, this one replaces the older one. Since then, we have added bug fixes

[ANN] Support for a new Intel Wireless device: 8260 / 4165

2015-06-18 Thread Grumbach, Emmanuel
Intel just released the firmware for the new Wireless devices: 8260 and 4165. As mentioned in iwlwifi's wiki page [1], these devices are supported starting from kernel 4.1. The firmware is available on that same wiki page [2]. It is also available on Intel wireless's clone of linux-firmware.git [3

Re: [PATCH] iwlwifi:dvm:Return false if resume command data is not same size as received packet for the function iwl_resume_status_fn

2015-06-10 Thread Grumbach, Emmanuel
On Wed, 2015-06-10 at 12:58 -0400, Nicholas Krause wrote: > > On June 10, 2015 12:50:45 PM EDT, "Grumbach, Emmanuel" > wrote: > >On Wed, 2015-06-10 at 12:33 -0400, Nicholas Krause wrote: > >> This makes the function iwl_resume_status_fn return false now i

Re: [PATCH] iwlwifi:dvm:Return false if resume command data is not same size as received packet for the function iwl_resume_status_fn

2015-06-10 Thread Grumbach, Emmanuel
On Wed, 2015-06-10 at 12:33 -0400, Nicholas Krause wrote: > This makes the function iwl_resume_status_fn return false now if > the received packet of type iwl_rx_packet is not the same size > as the structure pointer, iwl_resume_data's cmd element in order > to signal callers about this error and a

Re: [BUG 4.1.0-rc6] iwlwifi: "Error sending REPLY_TXFIFO_FLUSH: time out after 2000ms"

2015-06-04 Thread Grumbach, Emmanuel
On Thu, 2015-06-04 at 22:32 +0300, Kirill A. Shutemov wrote: > On Thu, Jun 04, 2015 at 06:13:22PM +0000, Grumbach, Emmanuel wrote: > > On Thu, 2015-06-04 at 20:37 +0300, Kirill A. Shutemov wrote: > > > Hi, > > > > > > I've trigered the bug few

Re: pull request: iwlwifi-next 2015-06-03

2015-06-03 Thread Grumbach, Emmanuel
On Wed, 2015-06-03 at 10:24 +0300, Emmanuel Grumbach wrote: > Hi Kalle, > > As promised, here is the enlarged pull request for 4.2. I double checked > that the tag is signed this time. > I also signed this email, just in case... > > I'll reply to this pull request with the diff between the previo

pull request: iwlwifi-next 2015-06-03

2015-06-03 Thread Grumbach, Emmanuel
Hi Kalle, As promised, here is the enlarged pull request for 4.2. I double checked that the tag is signed this time. I also signed this email, just in case... I'll reply to this pull request with the diff between the previous one and this one. All the other patches have been sent to the ML alread

RE: pull request: iwlwifi-next 2015-05-28

2015-06-03 Thread Grumbach, Emmanuel
> > "Grumbach, Emmanuel" writes: > > > Hi Kalle, > > > > this is the same pull request for 4.2 with the typo fixed and without > > the patches that are now targeted to 4.1 > > > > Thanks > > > > > > The

Re: iwlwifi/iwlmvm dies on resume when rfkill is set

2015-06-01 Thread Grumbach, Emmanuel
On Mon, 2015-06-01 at 15:51 -0700, Andy Lutomirski wrote: > If I switch my laptop into airplane mode (hardware switch) and then > suspend and resume, my wireless is dead on resume and it spews all > over the kernel log (see below). I can rescue it by switching > airplane mode off and then suspendi

[ANN] -14.ucode is available

2015-05-31 Thread Grumbach, Emmanuel
The new -14.ucode is already available in [1]. Since you'll need iwlwifi-next tree [2] to use it, I still don't send the pull request to mainline linux-firmware.git. -14.ucode just finished its validation cycle, but experience shows that lots of fixes still get merged after the validation cycle b

Re: pull request: iwlmvm firmware -13.ucode

2015-05-28 Thread Grumbach, Emmanuel
and now with linux-wireless :) On Thu, 2015-05-28 at 20:53 +0300, Emmanuel Grumbach wrote: > Signed this time. > > > On Thu, 2015-05-28 at 20:53 +0300, Emmanuel Grumbach wrote: > > Hello, > > > > This is a pull request to include -13.ucode into mainline. > > This firmware can run on 7260, 3160,

pull request: iwlwifi 2015-05-28

2015-05-28 Thread Grumbach, Emmanuel
Hi Kalle, as we talked, here is the pull request for 4.1. Thanks. The following changes since commit 292208914d8ca5a41cf68c2f1d2810a2ea2044e9: iwlwifi: mvm: avoid use-after-free on iwl_mvm_d0i3_enable_tx() (2015-05-21 22:36:46 +0300) are available in the git repository at: https://git.ke

pull request: iwlwifi-next 2015-05-28

2015-05-28 Thread Grumbach, Emmanuel
Hi Kalle, this is the same pull request for 4.2 with the typo fixed and without the patches that are now targeted to 4.1 Thanks The following changes since commit bbbe8c8c596b3784a2ed08772900e827f8ba72c5: mac80211: add missing documentation for rate_ctrl_lock (2015-05-06 16:00:32 +0200) ar

RE: pull request: iwlwifi-next 2015-05-26

2015-05-28 Thread Grumbach, Emmanuel
> > "Grumbach, Emmanuel" writes: > > >> > Note that there are fixes here that didn't make it to my previous > >> > pull request for 4.1. I tagged them for stable since the wording of > >> > your last pull request for 4.1 to Dave hint

RE: pull request: iwlwifi-next 2015-05-26

2015-05-28 Thread Grumbach, Emmanuel
> > "Grumbach, Emmanuel" writes: > > > this is a pull request for 4.2. Nothing really stands out besides what > > I wrote in the tag. Even the diffstat hints what is the biggest part > > of this pull request :) > > I see there was a minor comment t

Re: [PATCH 07/39] iwlwifi: dump API to 14

2015-05-27 Thread Grumbach, Emmanuel
On Tue, 2015-05-26 at 21:39 +0200, Rafał Miłecki wrote: > On 26 May 2015 at 21:17, Emmanuel Grumbach > wrote: > > The iwlmvm driver is now able to handle -14.ucode. > > Dump? Bump? ;) Ha! Someone actually looking at the patches. Good thing. No, it was not on purpose ;)

pull request: iwlwifi-next 2015-05-26

2015-05-26 Thread Grumbach, Emmanuel
Hi Kalle, this is a pull request for 4.2. Nothing really stands out besides what I wrote in the tag. Even the diffstat hints what is the biggest part of this pull request :) Note that there are fixes here that didn't make it to my previous pull request for 4.1. I tagged them for stable since the w

Re: [linuxwifi] [PATCH] iwlwifi: Remove use of the deprecacted marco, PTR_RET for the function, iwl_mvm_get_regdomain

2015-05-24 Thread Grumbach, Emmanuel
On Sat, 2015-05-23 at 20:53 -0400, Nicholas Krause wrote: > This removes the use of the two deprecated calls to the > marco, PTR_RET in the function, iwl_mvm_get_regdomain > and replaces them both with a call to the function, > PTR_ERR_OR_ZERO. > > Signed-off-by: Nicholas Krause Applied in our i

pull request: iwlwifi 2015-05-21

2015-05-21 Thread Grumbach, Emmanuel
Hi Kalle, I am aware that this pull request is quite large for 4.1, but I really think that all these patches are really justified. A few of them fix 3165 and 8260 which will be supported starting from 4.1. Other patches fix random bugs that were discovered just now. Note that my availability is

Re: pull request: update for -12.ucode firmware for Intel WiFi devices driven by iwlmvm

2015-05-05 Thread Grumbach, Emmanuel
On Tue, 2015-05-05 at 12:16 -0400, Kyle McMartin wrote: > On Sun, May 03, 2015 at 12:32:05PM +0000, Grumbach, Emmanuel wrote: > > > > > > > > > > Dear linux-firmware maintainers, > > > > > > Intel released a new version of the firmwa

pull request: iwlwifi 2015-04-28

2015-04-28 Thread Grumbach, Emmanuel
Hi Kalle, Here is the first round of fixes for 4.1. As usual, this first round is slightly big. I hope things will settle down later. Please pull. Thanks! The following changes since commit 6c373ca89399c5a3f7ef210ad8f63dc3437da345: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

Re: iwlwifi getting stuck with current Linus' tree (646da63172)

2015-04-23 Thread Grumbach, Emmanuel
On Thu, 2015-04-23 at 14:48 +0200, Piotr Karbowski wrote: > Hello, > > On Thu, Apr 23, 2015 at 11:15 AM, Jiri Kosina wrote: > > On Thu, 23 Apr 2015, Grumbach, Emmanuel wrote: > > > >> > I will try it, but I expect the result to be bogus because of this, >

Re: iwlwifi getting stuck with current Linus' tree (646da63172)

2015-04-23 Thread Grumbach, Emmanuel
On Thu, 2015-04-23 at 10:15 +0200, Jiri Kosina wrote: > On Thu, 23 Apr 2015, Grumbach, Emmanuel wrote: > > > > I've been running current Linus' tree and have been getting system > > > lockups > > > frequently. After a few "silent" lockups, I

Re: iwlwifi getting stuck with current Linus' tree (646da63172)

2015-04-22 Thread Grumbach, Emmanuel
Hi, On Wed, 2015-04-22 at 22:42 +0200, Jiri Kosina wrote: > Hi, > > I've been running current Linus' tree and have been getting system lockups > frequently. After a few "silent" lockups, I was able to obtain a dmesg > before the machine turned dead again (wifi stopped working shortly before >

pull request: iwlwifi-next 2015-04-02

2015-04-01 Thread Grumbach, Emmanuel
Hi Kalle, This is for 4.1. A bunch of work all over from the team. I'll be away for a week or so, but I'll monitor email, but I hope you won't have issues with this. Let me know. Thanks! The following changes since commit 2c44be81f0fc147eed9dc63e2601318b2c007aeb: mac80211: set QoS capability

pull request: iwlwifi 2015-03-30

2015-03-29 Thread Grumbach, Emmanuel
Hi Kalle, My last pull request for 4.0. This is a fix for a memory leak courtesy of Larry Finger (thanks to him). This patch has already been sent to the ML, so I won't reply to this pull request with git-send-email as I usually do. Please pull. Thanks. The following changes since commit 1f16ea2

Re: [PATCH] iwlwifi: Fix memory leak in iwl_req_fw_callback()

2015-03-24 Thread Grumbach, Emmanuel
On Mon, 2015-03-23 at 14:07 -0500, Larry Finger wrote: > In this routine, kzalloc allocates a memory block. This allocation is > freed in the error paths, but not in the normal exit, thus the allocation > is leaked. > > The kmemleak facility was used to find the leak. > Picked up - thanks. > Si

pull request: iwlwifi 2015-03-22

2015-03-22 Thread Grumbach, Emmanuel
Hi Kalle, A new round of fixes for 4.0. Most of the patches are also CCed to stable. Details in the tag. Thanks! The following changes since commit 4cd4b50cc2429294c23a1998c33fdfd804db0f37: iwlwifi: mvm: BT Coex - fix a NULL pointer exception (2015-03-05 14:13:20 +0200) are available in the

pull request: iwlwifi-next 2013-03-12

2015-03-12 Thread Grumbach, Emmanuel
Hi Kalle, Here is a pull request for 4.1. Details in the tag. Note that this includes the patches that were pulled by davem. You may want to FF your tree before you pull my bits. The following changes since commit 190f1029757346b72f297729cf8e5c562f2e9d8c: iwlwifi: mvm: don't override passive d

pull request: iwlwifi 2013-03-12

2015-03-12 Thread Grumbach, Emmanuel
Hi Kalle, 2 more fixes for 4.0. Details in the tag. Please pull - thanks! The following changes since commit 4cd4b50cc2429294c23a1998c33fdfd804db0f37: iwlwifi: mvm: BT Coex - fix a NULL pointer exception (2015-03-05 14:13:20 +0200) are available in the git repository at: https://git.kerne

<    1   2   3   >