Re: [PATCH] iwlwifi: pcie: off by one in iwl_trans_pcie_dyn_txq_alloc()

2017-04-22 Thread Dan Carpenter
On Sat, Apr 22, 2017 at 07:02:23AM +, Coelho, Luciano wrote: > On Fri, 2017-04-21 at 23:12 +0300, Dan Carpenter wrote: > > Heh. I raced this one through to see if I could beat you to the punch. > > Yeah, this patch is in our internal tree. But maybe we can take Dan's > for upstream for his e

Re: [PATCH] iwlwifi: pcie: off by one in iwl_trans_pcie_dyn_txq_alloc()

2017-04-22 Thread Coelho, Luciano
On Fri, 2017-04-21 at 23:12 +0300, Dan Carpenter wrote: > Heh. I raced this one through to see if I could beat you to the punch. Yeah, this patch is in our internal tree. But maybe we can take Dan's for upstream for his efforts? :) -- Cheers, Luca.

Re: [PATCH] iwlwifi: pcie: off by one in iwl_trans_pcie_dyn_txq_alloc()

2017-04-21 Thread Dan Carpenter
Heh. I raced this one through to see if I could beat you to the punch. regards, dan carpenter

Re: [PATCH] iwlwifi: pcie: off by one in iwl_trans_pcie_dyn_txq_alloc()

2017-04-21 Thread Johannes Berg
On Fri, 2017-04-21 at 22:46 +0300, Dan Carpenter wrote: > The > should be >= or we are writing one space beyond the end of the > array. I think I just did the same fixes you did - after running smatch :) This is on its way already (in our local tree), but since nobody can actually run the code ye

[PATCH] iwlwifi: pcie: off by one in iwl_trans_pcie_dyn_txq_alloc()

2017-04-21 Thread Dan Carpenter
The > should be >= or we are writing one space beyond the end of the array. Fixes: 310181ec34e2 ("iwlwifi: move to TVQM mode") Signed-off-by: Dan Carpenter diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c b/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c index 9fb46a6f47cf..2953