Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Fri, Mar 31, 2017 at 10:45 AM, Joe Perches wrote: > On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote: >> On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote: >> > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: >> > > On Thu, Mar 30, 2017 at

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Joe Perches
On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote: > On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote: > > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: > > > On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote: > > > > Fix fallout too. > >

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote: > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: >> On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote: >> > Fix fallout too. > [] >> My only question is why bother doing a format check on

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Joe Perches
On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: > On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote: > > Fix fallout too. [] > My only question is why bother doing a format check on something > that's going to be compiled out anyway? To avoid introducing defects when

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote: > Fix fallout too. > > Signed-off-by: Joe Perches > --- > drivers/net/wireless/ath/ath6kl/debug.h| 2 ++ > drivers/net/wireless/ath/ath6kl/htc_pipe.c | 2 +- > drivers/net/wireless/ath/ath6kl/wmi.c

[PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-30 Thread Joe Perches
Fix fallout too. Signed-off-by: Joe Perches --- drivers/net/wireless/ath/ath6kl/debug.h| 2 ++ drivers/net/wireless/ath/ath6kl/htc_pipe.c | 2 +- drivers/net/wireless/ath/ath6kl/wmi.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git