Re: [Linux-zigbee-devel] [PATCH 5/7] 6lowpan: allow to skip bytes in lowpan_fetch_skb

2013-09-29 Thread Alexander Aring
Hi, On Sun, Sep 29, 2013 at 02:03:14AM -0300, Werner Almesberger wrote: > Alexander Aring wrote: > > This is necessary for upcomming patches. > > Hmm, I didn't spot any case where you'd pass NULL, but maybe I didn't > search hard enough. Is this for patchs in this set or in a future > set ? If it

Re: [Linux-zigbee-devel] [PATCH 2/7] 6lowpan: clean lowpan netdev setup

2013-09-29 Thread Alexander Aring
Hi, On Sun, Sep 29, 2013 at 01:57:18AM -0300, Werner Almesberger wrote: > Alexander Aring wrote: > > This patch removes some magic number. > > Instead of magic numbers we use some defines. > > This may be misunderstood. When I read it, my first question was in > which other patch you defined MAC8

Re: [Linux-zigbee-devel] [PATCH 3/7] 6lowpan: remove several copies of sk_buff

2013-09-29 Thread Alexander Aring
On Sat, Sep 28, 2013 at 11:15:43PM +0200, Alexander Aring wrote: > The current implementation does many copies of the sk_buff for > increasing headroom which are not necessary. > > This patch increases the headroom in the maclayer for a worst case > scenario of (sizeof(struct ipv6hdr) + sizeof(str

Re: [Linux-zigbee-devel] [PATCH 6/7] 6lowpan: fix fragmentation on receiving side

2013-09-29 Thread Alexander Aring
On Sat, Sep 28, 2013 at 11:15:46PM +0200, Alexander Aring wrote: > diff --git a/net/ieee802154/6lowpan.h b/net/ieee802154/6lowpan.h > index 1b1b5db..05a2a37 100644 > --- a/net/ieee802154/6lowpan.h > +++ b/net/ieee802154/6lowpan.h > @@ -246,4 +246,32 @@ static inline bool lowpan_fetch_skb(struct sk_