Re: [PATCH v3 02/12] powerpc/ptrace: Add missing include

2023-05-22 Thread Andrew Donnellan
On Fri, 2023-05-19 at 15:02 +1000, Benjamin Gray wrote: > ptrace-decl.h uses user_regset_get2_fn (among other things) from > regset.h. While all current users of ptrace-decl.h include regset.h > before it anyway, it adds an implicit ordering dependency and breaks > source tooling that tries to insp

Re: [PATCH v3 01/12] powerpc/book3s: Add missing include

2023-05-22 Thread Andrew Donnellan
On Fri, 2023-05-19 at 15:02 +1000, Benjamin Gray wrote: > The functions here use struct thread_struct fields, so need to import > the full definition from . The header > that defines current only forward declares struct thread_struct. AFAICT, struct thread_struct is defined in arch/powerpc/includ

Re: [PATCH v2 0/3] Remove iommu_group_remove_device() from fsl

2023-05-22 Thread Joerg Roedel
On Tue, May 16, 2023 at 09:35:25PM -0300, Jason Gunthorpe wrote: > With POWER SPAPR now having a real iommu driver and using the normal group > lifecycle stuff fixing FSL will leave only VFIO's no-iommu support as a > user for the iommu_group_add/remove_device() calls. This will help > simplify the

Re: [PATCH v2 03/11] asm-generic/mmiowb: Mark accesses to fix KCSAN warnings

2023-05-22 Thread Rohan McLure
On Wed May 10, 2023 at 1:31 PM AEST, Rohan McLure wrote: > Prior to this patch, data races are detectable by KCSAN of the following > forms: > > [1] Asynchronous calls to mmiowb_set_pending() from an interrupt context >or otherwise outside of a critical section > [2] Interrupted critical secti

[PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-05-22 Thread Azeem Shaikh
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No re

Re: [PATCH v2 03/11] asm-generic/mmiowb: Mark accesses to fix KCSAN warnings

2023-05-22 Thread Rohan McLure
On 23 May 2023, at 10:28 am, Rohan McLure wrote: > > On Wed May 10, 2023 at 1:31 PM AEST, Rohan McLure wrote: >> Prior to this patch, data races are detectable by KCSAN of the following >> forms: >> >> [1] Asynchronous calls to mmiowb_set_pending() from an interrupt context >>or otherwise ou

Re: [PATCH] scsi: ibmvscsi: Replace all non-returning strlcpy with strscpy

2023-05-22 Thread Kees Cook
On Wed, 17 May 2023 14:34:09 +, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to remove strl

Re: [PATCH] powerpc/iommu: limit number of TCEs to 512 for H_STUFF_TCE hcall

2023-05-22 Thread Gaurav Batra
On 5/17/23 7:19 AM, Michael Ellerman wrote: Gaurav Batra writes: Hello Michael, System test hit the crash. I believe, it was PHYP that resulted in it due to number of TCEs passed in to be >512. OK. It's always good to spell out in the change log whether it's a theoretical/unlikely bug, or on

Re: [PATCH v14 00/15] phy: Add support for Lynx 10G SerDes

2023-05-22 Thread Vladimir Oltean
On Mon, May 22, 2023 at 10:42:04AM -0400, Sean Anderson wrote: > Have you had a chance to review this driver? Partially / too little (and no, I don't have an answer yet). I am debugging a SERDES protocol change procedure from XFI to SGMII.

Re: [PATCH v14 00/15] phy: Add support for Lynx 10G SerDes

2023-05-22 Thread Sean Anderson
Hi Vladmir, On 5/1/23 11:03, Sean Anderson wrote: > On 4/29/23 13:24, Vladimir Oltean wrote: >> On Wed, Apr 26, 2023 at 10:50:17AM -0400, Sean Anderson wrote: >>> > I need to catch up with 14 rounds of patches from you and with the >>> > discussions that took place on each version, and understand

Re: [PATCH v2] powerpc/iommu: DMA address offset is incorrectly calculated with 2MB TCEs

2023-05-22 Thread Gaurav Batra
Hello Alexey, No worries. I resolved the issue with Michael's help. The patch is merged upstream and it fixes the issue. Here is the link https://lore.kernel.org/all/20230504175913.83844-1-gba...@linux.vnet.ibm.com/ Thanks, Gaurav On 5/21/23 7:08 PM, Alexey Kardashevskiy wrote: Hi Gaurav,

Re: Probing nvme disks fails on Upstream kernels on powerpc Maxconfig

2023-05-22 Thread Srikar Dronamraju
* Michael Ellerman [2023-05-22 17:41:22]: > Srikar Dronamraju writes: > > * Alexey Kardashevskiy [2023-04-13 22:09:22]: > > > >> > > On 23.03.23 10:53, Srikar Dronamraju wrote: > >> > > > > > Hi Alexey, Michael > > > > Sorry for the late reply, but I didnt have access to this large system. > >

Re: [PATCH v8 1/3] riscv: Introduce CONFIG_RELOCATABLE

2023-05-22 Thread Alexandre Ghiti
On 19/05/2023 23:55, Palmer Dabbelt wrote: On Fri, 19 May 2023 14:48:59 PDT (-0700), sch...@linux-m68k.org wrote: On Mai 19 2023, Alexandre Ghiti wrote: I have tested the following patch successfully, can you give it a try while I make sure this is the only place I forgot to add the -fno-pie

[PATCH 2/2] serial: cpm_uart: Fix a COMPILE_TEST dependency

2023-05-22 Thread Herve Codina
In a COMPILE_TEST configuration, the cpm_uart driver uses symbols from the cpm_uart_cpm2.c file. This file is compiled only when CONFIG_CPM2 is set. Without this dependency, the linker fails with some missing symbols for COMPILE_TEST configuration that needs SERIAL_CPM without enabling CPM2. Sign

[PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC

2023-05-22 Thread Herve Codina
This series fixes issues raised by the kernel test robot https://lore.kernel.org/oe-kbuild-all/202305160221.9xgweobz-...@intel.com/ In COMPILE_TEST configurations, TSA and QMC need CONFIG_CPM to be set in order to compile and CPM uart needs CONFIG_CPM2. Best regards, Hervé Herve Codina (2):

[PATCH 1/2] soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST

2023-05-22 Thread Herve Codina
In order to compile tsa.c and qmc.c, CONFIG_CPM must be set. Without this dependency, the linker fails with some missing symbols for COMPILE_TEST configurations that need QMC without enabling CPM. Signed-off-by: Herve Codina Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild

Re: Probing nvme disks fails on Upstream kernels on powerpc Maxconfig

2023-05-22 Thread Michael Ellerman
Srikar Dronamraju writes: > * Alexey Kardashevskiy [2023-04-13 22:09:22]: > >> > > On 23.03.23 10:53, Srikar Dronamraju wrote: >> > > > >> > > > I am unable to boot upstream kernels from v5.16 to the latest upstream >> > > > kernel on a maxconfig system. (Machine config details given below) >> >

Re: [PATCH v3] powerpc/iommu: DMA address offset is incorrectly calculated with 2MB TCEs

2023-05-22 Thread Srikar Dronamraju
* Gaurav Batra [2023-05-04 12:59:13]: > When DMA window is backed by 2MB TCEs, the DMA address for the mapped > page should be the offset of the page relative to the 2MB TCE. The code > was incorrectly setting the DMA address to the beginning of the TCE > range. > > Mellanox driver is reporting

Re: Probing nvme disks fails on Upstream kernels on powerpc Maxconfig

2023-05-22 Thread Srikar Dronamraju
* Alexey Kardashevskiy [2023-04-13 22:09:22]: > > > On 23.03.23 10:53, Srikar Dronamraju wrote: > > > > > > > > I am unable to boot upstream kernels from v5.16 to the latest upstream > > > > kernel on a maxconfig system. (Machine config details given below) > > > > > > > > At boot, we see a ser