Re: [PATCH 00/40] soc: Convert to platform remove callback returning void

2023-09-26 Thread Joel Stanley
On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König wrote: > > Hello, > > this series converts all platform drivers below drivers/soc to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver

Re: [PATCH] powerpc: Hide empty pt_regs at base of the stack

2023-08-30 Thread Joel Stanley
0111b0] kernel_init+0x30/0x1a0 > [c3aabe50] [c000debc] ret_from_kernel_user_thread+0x14/0x1c > --- interrupt: 0 at 0x0 > > To avoid ever suppressing a valid pt_regs make sure the pt_regs has a > zero MSR and TRAP value, and is located at the very base of the sta

Re: [PATCH 4/4] powerpc/64s: Use POWER10 stsync barrier for wmb()

2023-08-24 Thread Joel Stanley
On Thu, 24 Aug 2023 at 12:12, Michael Ellerman wrote: > > Michael Ellerman writes: > > Michael Ellerman writes: > >> "Nicholas Piggin" writes: > >>> On Wed Jun 14, 2023 at 3:56 PM AEST, Michael Ellerman wrote: > Michael Ellerman writes: > > Nicholas Piggin writes: > >> The

Re: [PATCH v2] powernv/opal-prd: Silence memcpy() run-time false positive warnings

2023-08-11 Thread Joel Stanley
On Fri, 7 Jul 2023 at 05:11, Mahesh Salgaonkar wrote: > > opal_prd_msg_notifier extracts the opal prd message size from the message > header and uses it for allocating opal_prd_msg_queue_item that includes > the correct message size to be copied. However, while running under >

[PATCH] powerpc/config: Disable SLAB_DEBUG_ON in skiroot

2023-07-04 Thread Joel Stanley
AULT_FLAGS, but it's not clear that these should have been always-on anyway. Signed-off-by: Joel Stanley --- arch/powerpc/configs/skiroot_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/configs/skiroot_defconfig b/arch/powerpc/configs/skiroot_defconfig index 71cfb990a74f..8d3eacb5

Re: [kvm-unit-tests v4 00/12] powerpc: updates, P10, PNV support

2023-06-15 Thread Joel Stanley
On Thu, 15 Jun 2023 at 03:02, Nicholas Piggin wrote: > > On Wed Jun 14, 2023 at 11:09 AM AEST, Joel Stanley wrote: > > On Thu, 8 Jun 2023 at 07:58, Nicholas Piggin wrote: > > > > > > Posting again, a couple of patches were merged and accounted for review > >

Re: [kvm-unit-tests v4 00/12] powerpc: updates, P10, PNV support

2023-06-13 Thread Joel Stanley
On Thu, 8 Jun 2023 at 07:58, Nicholas Piggin wrote: > > Posting again, a couple of patches were merged and accounted for review > comments from last time. I saw some failures in the spr tests running on a power9 powernv system: $ TESTNAME=sprs TIMEOUT=90s ACCEL= ./powerpc/run powerpc/sprs.elf

Re: [PATCH 2/4] powerpc/64s: Add POWER10 store sync mnemonics

2023-06-12 Thread Joel Stanley
WSYNC for callers that want the > plain old sync (aka hwsync). I checked these against the ISA and they seem correct. Did you consider changing LWSYNC to be defined in terms of your new PPC_RAW_SYNC? Reviewed-by: Joel Stanley . > > Signed-off-by: Nicholas Piggin > --- >

[RFC PATCH 3/3] powernv/pci: Remove last IODA1 defines

2023-06-12 Thread Joel Stanley
Signed-off-by: Joel Stanley --- arch/powerpc/platforms/powernv/pci-ioda.c | 5 +++-- arch/powerpc/platforms/powernv/pci.h | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c index

[RFC PATCH 2/3] powerpc/pci: Remove MVE code

2023-06-12 Thread Joel Stanley
With IODA1 support gone the OPAL calls to set MVE are dead code. Remove them. TODO: Do we have rules for removing unused OPAL APIs? Should we leave it in opal.h? opal-call.c? Signed-off-by: Joel Stanley --- arch/powerpc/include/asm/opal.h| 3 --- arch/powerpc/platforms/powernv

[RFC PATCH 1/3] powernv/pci: Remove ioda1 support

2023-06-12 Thread Joel Stanley
The final "VPL" Power7 boxes that were used for powernv bringup have been scrapped, meaning there are no machines with ioda1 left. This patch removes the obvious unused code. Signed-off-by: Joel Stanley --- arch/powerpc/platforms/powernv/pci-ioda.c | 448 +- ar

[RFC PATCH 0/3] powernv/pci: Remove unused IODA1 support

2023-06-12 Thread Joel Stanley
Oliver mentioned this code was only kept around to support the VPL Power7 boxes. Now that they are all gone, remove the code. Build and boot tested in qemu only. Joel Stanley (3): powernv/pci: Remove ioda1 support powerpc/pci: Remove MVE code powernv/pci: Remove last IODA1 defines arch

Re: [PATCH] powerpc/crypto: Fix aes-gcm-p10 build when VSX=n

2023-05-16 Thread Joel Stanley
depend on VSX. > > Signed-off-by: Michael Ellerman Reviewed-by: Joel Stanley > --- > arch/powerpc/crypto/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig > index 7113f9355165..ad

[PATCH] KVM: PPC: Fix documentation for ppc mmu caps

2023-04-11 Thread Joel Stanley
The documentation mentions KVM_CAP_PPC_RADIX_MMU, but the defines in the kvm headers spell it KVM_CAP_PPC_MMU_RADIX. Similarly with KVM_CAP_PPC_MMU_HASH_V3. Fixes: c92701322711 ("KVM: PPC: Book3S HV: Add userspace interfaces for POWER9 MMU") Signed-off-by: Joel Stanley --- The

Re: [PATCH v2 0/4] KVM: selftests: add powerpc support

2023-04-10 Thread Joel Stanley
On Sat, 8 Apr 2023 at 04:01, Nicholas Piggin wrote: > > This series adds initial KVM selftests support for powerpc > (64-bit, BookS, radix MMU). This means the tests won't work on power8. Perhaps you could add something like this? --- a/tools/testing/selftests/kvm/lib/powerpc/processor.c +++

Re: [kvm-unit-tests v3 10/13] powerpc: Add support for more interrupts including HV interrupts

2023-04-05 Thread Joel Stanley
Hi Nick, On Mon, 27 Mar 2023 at 12:55, Nicholas Piggin wrote: > > Interrupt vectors were not being populated for all architected > interrupt types, which could lead to crashes rather than a message for > unhandled interrupts. > > 0x20 sized vectors require some reworking of the code to fit. This

[PATCH] powerpc: Remove duplicate SPRN_HSRR definitions

2023-04-04 Thread Joel Stanley
There are two copies of these defines. Keep the older ones as they have associated bit definitions. Signed-off-by: Joel Stanley --- Today I learnt that if you have two copies of the define, but they are the same value, the compiler won't warn. arch/powerpc/include/asm/reg.h | 2 -- 1 file

Re: [PATCH] powerpc: remove checks for binutils older than 2.25

2023-01-19 Thread Joel Stanley
On Thu, 19 Jan 2023 at 08:24, Masahiro Yamada wrote: > > Commit e4412739472b ("Documentation: raise minimum supported version of > binutils to 2.25") allows us to remove the checks for old binutils. > > There is no more user for ld-ifversion. Remove it as well. ppc kernels fail to link with 2.27

Re: [PATCH v6 0/4] Option to build big-endian with ELFv2 ABI

2022-11-28 Thread Joel Stanley
> > Since v5, I cleaned up patch 2 as per Christophe's review. And patch > 4 I removed the EXPERT depends so it's easier to test. It's marked as > experimental, but we should soon make it default and try to deprecate > the v1 ABI so we can eventually remove it. Reviewed-by: Joel Stanle

[PATCH] powerpc: Fix 85xx build

2022-10-10 Thread Joel Stanley
The merge of the kbuild tree dropped the renaming of the FSL_BOOKE kconfig option. Fixes: 8afc66e8d43b ("Merge tag 'kbuild-v6.1' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild") Signed-off-by: Joel Stanley --- arch/powerpc/kernel/Makefile | 2 +- 1 file

[PATCH] powerpc: Implement slightly better 64-bit LE non-VMX memory copy

2022-10-03 Thread Joel Stanley
the dumb loop a little less dumb. It now does 16 bytes per iteration, using 'ld' and 'std' instructions. If the number of bytes to copy is not a multiple of 16, the one-byte-per-iteration loop is used for the last 1--15 bytes. Signed-off-by: Paul Mackerras Signed-off-by: Joel Stanley --- arch/powerpc

[PATCH v2] powerpc/microwatt: Add litesd

2022-09-30 Thread Joel Stanley
This is the register layout of the litesd peripheral for the fusesoc based Microwatt SoC. It requires a description of the system clock, which is hardcoded to 100MHz. Signed-off-by: Joel Stanley --- v2: * remove non-removable property * Remove status=disabled * Add clock --- arch/powerpc

[PATCH] powerpc/microwatt: Add litesd

2022-09-28 Thread Joel Stanley
This is the register layout of the litesd peripheral for the fusesoc based Microwatt SoC. Signed-off-by: Joel Stanley --- arch/powerpc/boot/dts/microwatt.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/powerpc/boot/dts/microwatt.dts b/arch/powerpc/boot/dts

Re: [PATCH] powerpc/microwatt: Remove unused early debug code

2022-09-26 Thread Joel Stanley
On Mon, 19 Sept 2022 at 05:28, Michael Ellerman wrote: > > The original microwatt submission[1] included some early debug code for > using the Microwatt "potato" UART. The potato is indeed dead. > > The series that was eventually merged switched to using a standard UART, > and so doesn't need

[PATCH] powerpc/microwatt: Add LiteX MMC driver

2022-08-03 Thread Joel Stanley
Enable the LiteX MMC device and it's dependency the common clock framework. Signed-off-by: Joel Stanley --- arch/powerpc/configs/microwatt_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc/configs/microwatt_defconfig b/arch/powerpc/configs/microwatt_defconfig

[PATCH v2] powerpc/perf: Give generic PMU a nice name

2022-06-09 Thread Joel Stanley
When booting on a machine that uses the compat pmu driver we see this: [0.071192] GENERIC_COMPAT performance monitor hardware support registered Which is a bit shouty. Give it a nicer name. Signed-off-by: Joel Stanley --- v2: Go with ISAv3 arch/powerpc/perf/generic-compat-pmu.c | 2

Re: [PATCH] powerpc/perf: Give generic PMU a nice name

2022-06-09 Thread Joel Stanley
On Tue, 31 May 2022 at 08:53, Madhavan Srinivasan wrote: > > > On 5/26/22 12:07 PM, Joel Stanley wrote: > > When booting on a machine that uses the compat pmu driver we see this: > > > > [0.071192] GENERIC_COMPAT performance monitor hardware support > &g

[PATCH] powerpc/perf: Give generic PMU a nice name

2022-05-26 Thread Joel Stanley
When booting on a machine that uses the compat pmu driver we see this: [0.071192] GENERIC_COMPAT performance monitor hardware support registered Which is a bit shouty. Give it a nicer name. Signed-off-by: Joel Stanley --- Other options: - ISAv3 (because it is relevant for PowerISA 3.0B

Re: [PATCH] powerpc/microwatt: Add mmu bits to device tree

2022-05-23 Thread Joel Stanley
id value is the only one required, but add both for completeness. > > > > Fixes: 5402e239d09f ("powerpc/64s: Get LPID bit width from device tree") > > Signed-off-by: Joel Stanley > > LGTM... does Microwatt actually need 12 lpid bits, or does it just need > the LPID 0 partit

[PATCH] powerpc/microwatt: Add mmu bits to device tree

2022-05-19 Thread Joel Stanley
etal. Set the values in the device tree to avoid having to add a special case. The lpid value is the only one required, but add both for completeness. Fixes: 5402e239d09f ("powerpc/64s: Get LPID bit width from device tree") Signed-off-by: Joel Stanley --- arch/powerpc/boot/dts/microwat

Re: [PATCH] powerpc: fix typos in comments

2022-05-04 Thread Joel Stanley
e that one mega patch is the right way to go or not, so I'll leave that to mpe. Reviewed-by: Joel Stanley > > --- > arch/powerpc/boot/cuboot-hotfoot.c |2 +- > arch/powerpc/crypto/aes-spe-glue.c |2 +- > arch/powerpc/kernel/cputable.c

Re: [PATCH] powerpc/boot: Build wrapper for an appropriate CPU

2022-04-06 Thread Joel Stanley
On Thu, 31 Mar 2022 at 23:46, Segher Boessenkool wrote: > > On Thu, Mar 31, 2022 at 12:19:52PM -0300, Murilo Opsfelder Araújo wrote: > > My understanding is that the default cpu type for -mcpu=powerpc64 can > > change. > > Different subtargets (Linux, AIX, Darwin, the various BSDs, bare ELF, >

Re: [PATCH v2 1/2] powerpc/powernv: Get L1D flush requirements from device-tree

2022-04-05 Thread Joel Stanley
On Tue, 5 Apr 2022 at 06:13, Michael Ellerman wrote: > > Joel Stanley writes: > > On Mon, 4 Apr 2022 at 10:15, Russell Currey wrote: > >> > >> The device-tree properties no-need-l1d-flush-msr-pr-1-to-0 and > >> no-need-l1d-flush-ke

Re: [PATCH v2 1/2] powerpc/powernv: Get L1D flush requirements from device-tree

2022-04-04 Thread Joel Stanley
king P7 and P8. Without the appropriate device-tree > checks for newer processors on powernv, these flushes are unnecessarily > enabled on those systems. This patch corrects this. > > Fixes: d02fa40d759f ("powerpc/powernv: Remove POWER9 PVR version check for > entry and

Re: [PATCH] powerpc/boot: Build wrapper for an appropriate CPU

2022-03-30 Thread Joel Stanley
On Thu, 31 Mar 2022 at 02:05, Murilo Opsfelder Araújo wrote: > > Hi, Joel. > > On 3/30/22 08:24, Joel Stanley wrote: > > Currently the boot wrapper lacks a -mcpu option, so it will be built for > > the toolchain's default cpu. This is a problem if the toolchain defaults

Re: [PATCH] powerpc/boot: Build wrapper for an appropriate CPU

2022-03-30 Thread Joel Stanley
On Wed, 30 Mar 2022 at 11:33, Christophe Leroy wrote: > > > > Le 30/03/2022 à 13:24, Joel Stanley a écrit : > > Currently the boot wrapper lacks a -mcpu option, so it will be built for > > the toolchain's default cpu. This is a problem if the toolchain defaults

[PATCH] powerpc/boot: Build wrapper for an appropriate CPU

2022-03-30 Thread Joel Stanley
: 9001 [7.131733687,3] DSISR: DAR : [7.131905162,3] LR : 20010280 CTR : [7.132068356,3] CR : 44002004 XER : Link: https://github.com/linuxppc/issues/issues/400 Signed-off-by: Joel Stanley --- Tested

Re: [PATCH] recordmcount: Support empty section from recent binutils

2022-03-28 Thread Joel Stanley
On Mon, 29 Nov 2021 at 22:43, Christophe Leroy wrote: > > > > Le 29/11/2021 à 18:43, Steven Rostedt a écrit : > > On Fri, 26 Nov 2021 08:43:23 + > > LEROY Christophe wrote: > > > >> Le 24/11/2021 à 15:43, Christophe Leroy a écrit : > >>> Looks like recent binutils (2.36 and over ?) may empty

Re: No Linux logs when doing `ppc64_cpu --smt=off/8`

2022-02-16 Thread Joel Stanley
On Thu, 17 Feb 2022 at 01:07, Michael Ellerman wrote: > > Michal Suchánek writes: > > On Mon, Feb 14, 2022 at 01:33:24PM +0100, Paul Menzel wrote: > >> Yes, simple `nproc` suffice, but I was more thinking about, that the Linux > >> log is often used for debugging and the changes of amount of

[RFC PATCH] powerpc: Implement hotplug smt control

2022-02-16 Thread Joel Stanley
64_cpu --info Core 0:0*1 2 3 4 5 6 7 Core 1:8*9101112131415 # grep . /sys/devices/system/cpu/smt/* /sys/devices/system/cpu/smt/active:0 /sys/devices/system/cpu/smt/control:off Signed-off-by: Joel Stanley ---

Re: [PATCH v2 16/16] powerpc/microwatt: Don't select the hash MMU code

2021-10-20 Thread Joel Stanley
On Thu, 21 Oct 2021 at 04:04, Nicholas Piggin wrote: > > Microwatt is radix-only, so it does not require hash MMU support. > > This saves 20kB compressed dtbImage and 56kB vmlinux size. > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/configs/microwatt_defconfig | 1 - >

[PATCH v2] powerpc/64s: Default to 64K pages for 64 bit book3s

2021-10-14 Thread Joel Stanley
the defconfig, as it is now the default. The defconfigs that now need to set CONFIG_PPC_4K_PAGES to maintain their existing behaviour are: g5_defconfig maple_defconfig microwatt_defconfig ps3_defconfig Link: https://github.com/linuxppc/issues/issues/109 Signed-off-by: Joel Stanley --- v2: remove

Re: [PATCH] powerpc/64s: Default to 64K pages for 64 bit book3s

2021-10-14 Thread Joel Stanley
On Thu, 14 Oct 2021 at 07:03, LEROY Christophe wrote: > > > > Le 14/10/2021 à 01:31, Joel Stanley a écrit : > > For 64-bit book3s the default should be 64K as that's what modern CPUs > > are designed for. > > > > The following defconfigs already set CONFIG_PPC

[PATCH] powerpc/64s: Default to 64K pages for 64 bit book3s

2021-10-13 Thread Joel Stanley
the defconfig, as it is now the default. The defconfigs that now need to set CONFIG_PPC_4K_PAGES to maintain their existing behaviour are: g5_defconfig maple_defconfig microwatt_defconfig ps3_defconfig Link: https://github.com/linuxppc/issues/issues/109 Signed-off-by: Joel Stanley --- arch

[PATCH v2] powerpc/s64: Clarify that radix lacks DEBUG_PAGEALLOC

2021-10-13 Thread Joel Stanley
without doing any damage. There are no other platforms that determine if they support debug_pagealloc at runtime. Instead of adding code to mm/page_alloc.c to do that, this change turns the map/unmap into a noop when in radix mode and prints a warning once. Signed-off-by: Joel Stanley --- v2: Put

[PATCH] powerpc/s64: Clarify that radix lacks DEBUG_PAGEALLOC

2021-10-11 Thread Joel Stanley
without doing any damage. There are no other platforms that determine if they support debug_pagealloc at runtime. Instead of adding code to mm/page_alloc.c to do that, this change turns the map/unmap into a noop when in radix mode and prints a warning once. Signed-off-by: Joel Stanley --- I noticed

Re: [PATCH] powerpc/boot: Use CONFIG_PPC_POWERNV to compile OPAL support

2021-10-11 Thread Joel Stanley
On Mon, 11 Oct 2021 at 07:42, Cédric Le Goater wrote: > > CONFIG_PPC64_BOOT_WRAPPER is selected by CPU_LITTLE_ENDIAN which is > used to compile support for other platforms such as Microwatt. There > is no need for OPAL calls on these. > > Signed-off-by: Cédric Le Goater

Re: [RFC 5/5] ipmi:bt-bmc: Add Microwatt

2021-10-05 Thread Joel Stanley
Hi Anton, On Wed, 6 Oct 2021 at 02:12, Anton Blanchard wrote: > > This adds the Microwatt specific bits, including interrupt support. The series looks good. I've got a couple of patches on the ipmi list that this will conflict with:

Re: [PATCH 1/4] crypto: nintendo-aes - add a new AES driver

2021-09-21 Thread Joel Stanley
On Tue, 21 Sept 2021 at 21:47, Emmanuel Gil Peyrot wrote: > > This engine implements AES in CBC mode, using 128-bit keys only. It is > present on both the Wii and the Wii U, and is apparently identical in > both consoles. > > The hardware is capable of firing an interrupt when the operation is >

Re: [PATCH] mm: Remove HARDENED_USERCOPY_FALLBACK

2021-09-21 Thread Joel Stanley
PP/linux/issues/153 > Signed-off-by: Stephen Kitt > Suggested-by: Kees Cook > --- > arch/powerpc/configs/skiroot_defconfig | 1 - For the defconfig change: Reviewed-by: Joel Stanley Cheers, Joel > include/linux/slab.h | 2 -- > mm/slab.c

Re: [PATCH trivial v2] powerpc/powernv/dump: Fix typo in comment

2021-09-15 Thread Joel Stanley
On Tue, 14 Sept 2021 at 14:38, Vasant Hegde wrote: > > Signed-off-by: Vasant Hegde Reviewed-by: Joel Stanley > --- > arch/powerpc/platforms/powernv/opal-dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/

Re: [PATCH trivial] powerpc/powernv/dump: Fix typo is comment

2021-09-14 Thread Joel Stanley
On Tue, 14 Sept 2021 at 10:17, Vasant Hegde wrote: > > Signed-off-by: Vasant Hegde There's a typo in your commit message :) > --- > arch/powerpc/platforms/powernv/opal-dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/opal-dump.c >

Re: [PATCH] powerpc/xics: Set the IRQ chip data for the ICS native backend

2021-09-13 Thread Joel Stanley
ndler"). > Revert this change to fix the Microwatt SoC platform. > > Fixes: 248af248a8f4 ("powerpc/xics: Rename the map handler in a check > handler") > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley Thanks Cédric. > --- > arch/powerpc/sysdev/xics/xics-co

[PATCH 3/3] powerpc/configs/microwatt: Enable options for systemd

2021-08-26 Thread Joel Stanley
When booting with systemd these options are required. This increases the image by about 50KB, or 2%. Signed-off-by: Joel Stanley --- arch/powerpc/configs/microwatt_defconfig | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/configs/microwatt_defconfig b/arch

[PATCH 2/3] powerpc/configs/microwattt: Enable Liteeth

2021-08-26 Thread Joel Stanley
Liteeth is the network device used by Microwatt. Signed-off-by: Joel Stanley --- arch/powerpc/configs/microwatt_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/configs/microwatt_defconfig b/arch/powerpc/configs/microwatt_defconfig index a08b739123da..2f8b1fec9a16

[PATCH 1/3] powerpc/microwatt: Add Ethernet to device tree

2021-08-26 Thread Joel Stanley
The liteeth network device is used in the Microwatt soc. Signed-off-by: Joel Stanley --- arch/powerpc/boot/dts/microwatt.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/powerpc/boot/dts/microwatt.dts b/arch/powerpc/boot/dts/microwatt.dts index 974abbdda249

[PATCH 0/3] powerpc/microwatt: Device tree and config updates

2021-08-26 Thread Joel Stanley
This enables the liteeth network device for microwatt which will be merged in v5.15. It also turns on some options so the microwatt defconfig can be used to boot a userspace with systemd. Joel Stanley (3): powerpc/microwatt: Add Ethernet to device tree powerpc/configs/microwattt: Enable

[PATCH v2 3/3] powerpc/configs: Regenerate mpc885_ads_defconfig

2021-08-16 Thread Joel Stanley
Regenerate atop v5.14-rc6 by doing a make savedefconfig. The changes a re-ordering except for the following (which are still set indirectly): - CONFIG_DEBUG_KERNEL=y selected by EXPERT - CONFIG_PPC_EARLY_DEBUG_CPM_ADDR=0xff002008 which is the default setting Signed-off-by: Joel Stanley

[PATCH v2 2/3] powerpc/config: Renable MTD_PHYSMAP_OF

2021-08-16 Thread Joel Stanley
Christophe said it is useful for build coverage. Fixes: 642b1e8dbed7 ("mtd: maps: Merge physmap_of.c into physmap-core.c") Signed-off-by: Joel Stanley --- arch/powerpc/configs/mpc885_ads_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/configs/mpc885_ads_defco

[PATCH v2 1/3] powerpc/config: Fix IPV6 warning in mpc855_ads

2021-08-16 Thread Joel Stanley
the build. Acked-by: Christophe Leroy Fixes: 9a1762a4a4ff ("powerpc/8xx: Update mpc885_ads_defconfig to improve CI") Signed-off-by: Joel Stanley --- arch/powerpc/configs/mpc885_ads_defconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/

[PATCH v2 0/3] powerpc: mpc855_ads defconfig fixes

2021-08-16 Thread Joel Stanley
. The third patch is the result of doing a make savedefconfig with the first two patches applied. Joel Stanley (3): powerpc/config: Fix IPV6 warning in mpc855_ads powerpc/config: Renable MTD_PHYSMAP_OF powerpc/configs: Regenerate mpc885_ads_defconfig arch/powerpc/configs/mpc885_ads_defconfig

Re: [PATCH 2/2] powerpc/configs: Regenerate mpc885_ads_defconfig

2021-08-16 Thread Joel Stanley
On Mon, 16 Aug 2021 at 08:49, Christophe Leroy wrote: > > > > Le 16/08/2021 à 10:31, Joel Stanley a écrit : > > Regenrate atop v5.14-rc6. > > Typos. > > You mean you did redo a "make savedefconfig" ? Yes, I did.

Re: [PATCH 2/3] powerpc: Fix undefined static key

2021-08-16 Thread Joel Stanley
On Mon, 16 Aug 2021 at 08:39, Christophe Leroy wrote: > > > > Le 16/08/2021 à 10:24, Joel Stanley a écrit : > > When CONFIG_PPC_BARRIER_NOSPEC=n, security.c is not built leading to a > > missing definition of uaccess_flush_key. > > > >LD vmli

[PATCH 2/2] powerpc/configs: Regenerate mpc885_ads_defconfig

2021-08-16 Thread Joel Stanley
, as it depends on MTD_PHYSMAP which is not enabled. This is a regression from commit 642b1e8dbed7 ("mtd: maps: Merge physmap_of.c into physmap-core.c"), which added the extra dependency. Add CONFIG_MTD_PHYSMAP=y so this stays in the config. Signed-off-by: Joel Stanley --- arch/power

[PATCH 1/2] powerpc/config: Fix IPV6 warning in mpc855_ads

2021-08-16 Thread Joel Stanley
the build. Signed-off-by: Joel Stanley --- arch/powerpc/configs/mpc885_ads_defconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs/mpc885_ads_defconfig index d21f266cea9a..5cd17adf903f 100644 --- a/arch/power

[PATCH 0/2] powerpc: mpc855_ads defconfig fixes

2021-08-16 Thread Joel Stanley
of the config. Given noone noticed the regression since v4.20 was released, perhaps it could be left disabled? Joel Stanley (2): powerpc/config: Fix IPV6 warning in mpc855_ads powerpc/configs: Regenerate mpc885_ads_defconfig arch/powerpc/configs/mpc885_ads_defconfig | 49 +++ 1 file

[PATCH 3/3] powerpc/microwatt: CPU doesn't (yet) have speculation bugs

2021-08-16 Thread Joel Stanley
Signed-off-by: Joel Stanley --- arch/powerpc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 663766fbf505..d5af6667c206 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -279,6 +279,7 @@ config PPC_BARRIER_NOSPEC

[PATCH 2/3] powerpc: Fix undefined static key

2021-08-16 Thread Joel Stanley
+0x0): more undefined references to `uaccess_flush_key' follow make[1]: *** [Makefile:1176: vmlinux] Error 1 Hack one in to fix the build. Signed-off-by: Joel Stanley --- arch/powerpc/include/asm/security_features.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/include/asm

[PATCH 1/3] powerpc/64s: Fix build when !PPC_BARRIER_NOSPEC

2021-08-16 Thread Joel Stanley
RRIER_NOSPEC). This makes PPC_BOOK3S_64 match how the PPC_FSL_BOOK3E build works. Signed-off-by: Joel Stanley --- arch/powerpc/include/asm/setup.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/include/asm/setup.h b/arch/powerpc/include/asm/setup.h index 6c1a7d217d1a..7101228

[PATCH 0/3] powerpc/64s: Fix PPC_BARRIER_NOSPEC=n

2021-08-16 Thread Joel Stanley
, as it doesn't seem to change boot speed with the current Microwatt design on an Arty. Joel Stanley (3): powerpc/64s: Fix build when !PPC_BARRIER_NOSPEC powerpc: Fix undefined static key powerpc/microwatt: CPU doesn't (yet) have speculation bugs arch/powerpc/Kconfig | 1

Re: [PATCH] usb: gadget: fsl: properly remove remnant of MXC support

2021-06-14 Thread Joel Stanley
ts. > > Signed-off-by: Li Yang Reviewed-by: Joel Stanley Will you re-submit the kconfig change once this is merged? Cheers, Joel

Re: [PATCH 4/4] powerpc/powernv: Remove POWER9 PVR version check for entry and uaccess flushes

2021-05-04 Thread Joel Stanley
he right bits > yet. Not urgent at the moment but wouldn't hurt to specify them and > add the Linux code for them. Thanks for the explanation. This could go in the commit message if you re-spin. Reviewed-by: Joel Stanley

Re: [PATCH 4/4] powerpc/powernv: Remove POWER9 PVR version check for entry and uaccess flushes

2021-05-03 Thread Joel Stanley
On Mon, 3 May 2021 at 13:04, Nicholas Piggin wrote: > > These aren't necessarily POWER9 only, and it's not to say some new > vulnerability may not get discovered on other processors for which > we would like the flexibility of having the workaround enabled by > firmware. > > Remove the

Re: [PATCH] asm-generic: Force inlining of get_order() to work around gcc10 poor decision

2020-10-18 Thread Joel Stanley
30138 186468 11888444 b5673c vmlinux After: 9069886 2630126 186468 11886480 b55f90 vmlinux 1952 bytes smaller with your patch applied. Did you raise this with anyone from GCC? Reviewed-by: Joel Stanley > Signed-off-by: Christophe Leroy > --- > include/asm-generic/

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

2020-10-05 Thread Joel Stanley
On Thu, 1 Oct 2020 at 20:19, Joe Perches wrote: > > On Thu, 2020-10-01 at 14:39 -0500, Segher Boessenkool wrch/ote: > > Hi! > > > > On Thu, Oct 01, 2020 at 12:15:39PM +0200, Miguel Ojeda wrote: > > > > So it looks like the best option is to exclude these > > > > 2 files from conversion. > > > > >

Re: [PATCH] linux: configure CONFIG_I2C_OPAL as in-built.

2020-09-29 Thread Joel Stanley
On Fri, 25 Sep 2020 at 18:19, Mimi Zohar wrote: > > Hi Nayna, > > On Wed, 2020-09-23 at 14:25 -0400, Nayna Jain wrote: > > Currently, skiroot_defconfig CONFIG_I2C_OPAL is built as a loadable > > module rather than builtin, even if CONFIG_I2C=y is defined. This > > results in a delay in the TPM

Re: [PATCH] cpuidle-pseries: Fix CEDE latency conversion from tb to us

2020-09-01 Thread Joel Stanley
gt; > Fixes: commit d947fb4c965c ("cpuidle: pseries: Fixup exit latency for > CEDE(0)") > > Signed-off-by: Gautham R. Shenoy Reviewed-by: Joel Stanley Should you check for the zero case and print a warning? > --- > drivers/cpuidle/cpuidle-pseries.c | 2 +- > 1 file

[PATCH v3] powerpc: Warn about use of smt_snooze_delay

2020-09-01 Thread Joel Stanley
/offline loop is slow. Fixes: 3fa8cad82b94 ("powerpc/pseries/cpuidle: smt-snooze-delay cleanup.") Cc: sta...@vger.kernel.org # v3.14 Acked-by: Gautham R. Shenoy Signed-off-by: Joel Stanley -- v3: pr_warn_once instead of pr_warn_ratelimited Update meessages with mpe's suggestions v2: U

Re: [PATCH v2] powerpc: Warn about use of smt_snooze_delay

2020-08-05 Thread Joel Stanley
On Tue, 4 Aug 2020 at 11:59, Michael Ellerman wrote: > > Joel Stanley writes: > > It's not done anything for a long time. Save the percpu variable, and > > emit a warning to remind users to not expect it to do anything. > > > > Fixes: 3fa8cad82b94 ("powerp

Re: [PATCH 5/6] powerpc/powernv/pci: Drop unused parent variable

2020-08-03 Thread Joel Stanley
On Tue, 4 Aug 2020 at 01:06, Oliver O'Halloran wrote: > > The "parent" variable in pnv_pci_ioda_configure_pe() isn't used for > anything anymore and can be dropped. > > Signed-off-by: Oliver O'Halloran Reviewed-by: Joel Stanley

Re: [PATCH 4/6] powerpc/powernv: Fix spurious kerneldoc warnings in opal-prd.c

2020-08-03 Thread Joel Stanley
on prototype: 'struct opal_prd_msg_queue_item ' > > opal_prd_mesg_queue_item is an internal data structure so there's no real > need for it to be documented at all. Fix up the comment to squash the > warning. > > Signed-off-by: Oliver O'Halloran Reviewed-by: Joel Stanley

Re: [PATCH 3/6] powerpc/powernv: Staticify functions without prototypes

2020-08-03 Thread Joel Stanley
oid pnv_pcibios_bus_add_device(struct pci_dev *pdev) > +static void pnv_pcibios_bus_add_device(struct pci_dev *pdev) > { > dev_dbg(>dev, "EEH: Setting up device\n"); > eeh_probe_device(pdev); This one could even be deleted as eeh_probe_device has it's own dev_dbg. Reviewed-by: Joel Stanley

Re: [PATCH 1/6] powerpc/powernv/smp: Fix spurious DBG() warning

2020-08-03 Thread Joel Stanley
> We could add the braces too. That might even be better since it's a multi-line > if block even though it's only a single statement. Or you could put it all on one line, now that our 120 line overlords have taken over. Reviewed-by: Joel Stanley Messy: $ git grep "define DBG(" arch

[PATCH v2] powerpc: Warn about use of smt_snooze_delay

2020-06-29 Thread Joel Stanley
It's not done anything for a long time. Save the percpu variable, and emit a warning to remind users to not expect it to do anything. Fixes: 3fa8cad82b94 ("powerpc/pseries/cpuidle: smt-snooze-delay cleanup.") Cc: sta...@vger.kernel.org # v3.14 Signed-off-by: Joel Stanley -- v2: U

Re: [PATCH] powerpc: Warn about use of smt_snooze_delay

2020-06-29 Thread Joel Stanley
On Mon, 29 Jun 2020 at 10:42, Gautham R Shenoy wrote: > > On Thu, Jun 25, 2020 at 07:33:49PM +0930, Joel Stanley wrote: > > It's not done anything for a long time. Save the percpu variable, and > > emit a warning to remind users to not expect it to do anything. > > > &g

[PATCH] powerpc: Warn about use of smt_snooze_delay

2020-06-25 Thread Joel Stanley
It's not done anything for a long time. Save the percpu variable, and emit a warning to remind users to not expect it to do anything. Signed-off-by: Joel Stanley --- arch/powerpc/kernel/sysfs.c | 41 + 1 file changed, 14 insertions(+), 27 deletions(-) diff

Re: [PATCH v5 01/13] powerpc: Remove Xilinx PPC405/PPC440 support

2020-06-25 Thread Joel Stanley
the zImage: > > > > https://github.com/ClangBuiltLinux/continuous-integration/pull/282 > > https://github.com/ClangBuiltLinux/boot-utils/pull/22 > > Great. > > > We were only using the zImage because that is what Joel Stanley intially > > set us up with when Powe

Re: [PATCH 1/4] powerpc: Add a ppc_inst_as_str() helper

2020-06-02 Thread Joel Stanley
gt; declare a buffer. To make it more convenient to use __ppc_inst_as_str(), > wrap it in a macro that uses a compound statement to allocate a buffer > on the caller's stack before calling it. > > Signed-off-by: Jordan Niethe Reviewed-by: Joel Stanley > --- > arch/powerpc/inclu

Re: [PATCH RFC 1/4] powerpc/radix: Fix compilation for radix with CONFIG_SMP=n

2020-05-14 Thread Joel Stanley
On Sat, 9 May 2020 at 07:52, Nicholas Piggin wrote: > > Excerpts from Paul Mackerras's message of May 9, 2020 3:02 pm: > > This fixes the compile errors we currently get with CONFIG_SMP=n and > > CONFIG_PPC_RADIX_MMU=y. > > Did I already fix this, or does it keep getting broken?! :( > > Anyway

Re: [PATCH 4/5] powerpc: Replace _ALIGN() by ALIGN()

2020-04-20 Thread Joel Stanley
On Mon, 20 Apr 2020 at 18:39, Christophe Leroy wrote: > > _ALIGN() is specific to powerpc > ALIGN() is generic and does the same > > Replace _ALIGN() by ALIGN() > > Signed-off-by: Christophe Leroy Reviewed-by: Joel Stanley > --- > arch/powerpc/include/asm/book3s/

Re: [PATCH 5/5] powerpc: Remove _ALIGN_UP(), _ALIGN_DOWN() and _ALIGN()

2020-04-20 Thread Joel Stanley
On Mon, 20 Apr 2020 at 18:39, Christophe Leroy wrote: > > These three powerpc macros have been replaced by > equivalent generic macros and are not used anymore. > > Remove them. > > Signed-off-by: Christophe Leroy Reviewed-By: Joel Stanley riscv has a copy of these to

Re: [PATCH 3/5] powerpc: Replace _ALIGN_UP() by ALIGN()

2020-04-20 Thread Joel Stanley
On Mon, 20 Apr 2020 at 18:39, Christophe Leroy wrote: > > _ALIGN_UP() is specific to powerpc > ALIGN() is generic and does the same > > Replace _ALIGN_UP() by ALIGN() > > Signed-off-by: Christophe Leroy Reviewed-by: Joel Stanley > --- > arch/powerpc/include/a

Re: [PATCH 2/5] powerpc: Replace _ALIGN_DOWN() by ALIGN_DOWN()

2020-04-20 Thread Joel Stanley
amp;(~((typeof(addr))(size)-1))) +addr) - ((size) - 1)) + ((typeof(addr))(size) - 1)) & ~((typeof(addr))(size)-1)) Which I assume the compiler will sort out? Reviewed-by: Joel Stanley > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/book3s/32/pgtable.h

Re: [PATCH 1/5] drivers/powerpc: Replace _ALIGN_UP() by ALIGN()

2020-04-20 Thread Joel Stanley
- (((addr)+((size)-1))&(~((typeof(addr))(size)-1))) + (((addr)+((typeof(addr))(size) - 1))&~((typeof(addr))(size)-1)) So it adds a cast, but aside from that it's the same. Reviewed-by: Joel Stanley > --- > drivers/ps3/ps3-lpm.c | 6 +++--- > drivers/vfio/pci/vfio

Re: [PATCH] powerpc/boot: Delete unneeded .globl _zimage_start

2020-03-24 Thread Joel Stanley
d assembler let the last win. > > Fixes: cd197ffcf10b "[POWERPC] zImage: Cleanup and improve zImage entry point" > Fixes: ee9d21b3b358 "powerpc/boot: Ensure _zimage_start is a weak symbol" > Link: https://github.com/ClangBuiltLinux/linux/issues/937 > Signed-off-b

Re: [PATCH v2 07/10] powerpc/configs/skiroot: Enable security features

2020-01-23 Thread Joel Stanley
On Tue, 21 Jan 2020 at 04:30, Michael Ellerman wrote: > > From: Joel Stanley > > This turns on HARDENED_USERCOPY with HARDENED_USERCOPY_PAGESPAN, and > FORTIFY_SOURCE. > > It also enables SECURITY_LOCKDOWN_LSM with _EARLY and > LOCK_DOWN_KERNEL_FORCE_INTEGRITY options en

Re: [PATCH 7/9] powerpc/configs/skiroot: Enable security features

2020-01-15 Thread Joel Stanley
On Thu, 16 Jan 2020 at 07:10, Oliver O'Halloran wrote: > > On Thu, Jan 16, 2020 at 4:00 PM Daniel Axtens wrote: > > > > Michael Ellerman writes: > > > > > From: Joel Stanley > > > > > > This turns on HARDENED_USERCOPY with H

Re: [PATCH 5/9] powerpc/configs/skiroot: Drop default n CONFIG_CRYPTO_ECHAINIV

2020-01-15 Thread Joel Stanley
On Thu, 16 Jan 2020 at 01:48, Michael Ellerman wrote: > > It's default n so we don't need to disable it. > > Signed-off-by: Michael Ellerman Acked-by: Joel Stanley

Re: [PATCH 4/9] powerpc/configs/skiroot: Drop HID_LOGITECH

2020-01-15 Thread Joel Stanley
any more. > > The Kconfig help text suggests USB HID compliant Logictech devices > will continue to work without HID_LOGITECH, so just drop it. > > Signed-off-by: Michael Ellerman Acked-by: Joel Stanley

Re: [PATCH 3/9] powerpc/configs: Drop NET_VENDOR_HP which moved to staging

2020-01-15 Thread Joel Stanley
On Thu, 16 Jan 2020 at 01:48, Michael Ellerman wrote: > > The HP network driver moved to staging in commit 52340b82cf1a ("hp100: > Move 100BaseVG AnyLAN driver to staging") meaning we don't need to > disable it any more in our defconfigs. > > Signed-off-by: Micha

  1   2   3   >