Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-28 Thread Christoph Hellwig
On Sun, Jul 27, 2008 at 12:56:04PM -0700, David Miller wrote: > Yes, please. > > IMHO, this driver was really rushed in and that was a huge mistake. > If it had gone through linux-next we could have tidied all of this > stuff up in a less "rushed" manner. Or just reviewed in at least some way.. _

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread Stephen Rothwell
Hi Sean, On Sun, 27 Jul 2008 13:39:18 -0400 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > On Mon, 28 Jul 2008 02:37:32 +1000 > "Stephen Rothwell" <[EMAIL PROTECTED]> wrote: > > > On powerpc (allyesconfig build) we get this error: > > > > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread Stephen Rothwell
Hi Dave, On Sun, 27 Jul 2008 16:14:32 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > > The driver went directly into Linus's tree. > > Stephen hit the build problem once he synced linux-next up with > Linus's current tree. It didn't even get as far as linux-next, I was just browsing the b

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread Stephen Rothwell
Hi Sam, On Sun, 27 Jul 2008 22:43:55 +0200 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > On Sun, Jul 27, 2008 at 01:33:49PM -0700, Roland Dreier wrote: > > > IMHO, this driver was really rushed in and that was a huge mistake. > > > If it had gone through linux-next we could have tidied all of this

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread Stephen Rothwell
Hi Roland, On Sun, 27 Jul 2008 13:33:49 -0700 Roland Dreier <[EMAIL PROTECTED]> wrote: > > > IMHO, this driver was really rushed in and that was a huge mistake. > > If it had gone through linux-next we could have tidied all of this > > stuff up in a less "rushed" manner. > > ?? This thread *i

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread Stephen Rothwell
On Sun, 27 Jul 2008 18:27:09 +0100 Alan Cox <[EMAIL PROTECTED]> wrote: > > On Mon, 28 Jul 2008 02:37:32 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > > > On powerpc (allyesconfig build) we get this error: > > > > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of > >

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Sun, 27 Jul 2008 13:33:49 -0700 > > IMHO, this driver was really rushed in and that was a huge mistake. > > If it had gone through linux-next we could have tidied all of this > > stuff up in a less "rushed" manner. > > ?? This thread *is* about a

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread Sam Ravnborg
On Sun, Jul 27, 2008 at 01:33:49PM -0700, Roland Dreier wrote: > > IMHO, this driver was really rushed in and that was a huge mistake. > > If it had gone through linux-next we could have tidied all of this > > stuff up in a less "rushed" manner. > > ?? This thread *is* about a build failure in

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread Roland Dreier
> IMHO, this driver was really rushed in and that was a huge mistake. > If it had gone through linux-next we could have tidied all of this > stuff up in a less "rushed" manner. ?? This thread *is* about a build failure in linux-next. - R. ___ Linux

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread David Miller
From: Alan Cox <[EMAIL PROTECTED]> Date: Sun, 27 Jul 2008 18:27:09 +0100 > On Mon, 28 Jul 2008 02:37:32 +1000 > Stephen Rothwell <[EMAIL PROTECTED]> wrote: > > > On powerpc (allyesconfig build) we get this error: > > > > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread Alan Cox
On Mon, 28 Jul 2008 02:37:32 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > On powerpc (allyesconfig build) we get this error: > > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of > function 'virt_to_bus' > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> Can

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

2008-07-27 Thread Sean MacLennan
On Mon, 28 Jul 2008 02:37:32 +1000 "Stephen Rothwell" <[EMAIL PROTECTED]> wrote: > On powerpc (allyesconfig build) we get this error: > > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit > declaration of function 'virt_to_bus' When did mISDN make it into the kernel? And which kernel tr