Re: [Lldb-commits] [PATCH] Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.

2015-06-25 Thread Oleksiy Vyalov
AFFECTED FILES /lldb/trunk/include/lldb/API/SBFrame.h /lldb/trunk/scripts/interface/SBFrame.i /lldb/trunk/source/API/SBFrame.cpp USERS ovyalov (Author) http://reviews.llvm.org/rL240660 http://reviews.llvm.org/D10711 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpref

Re: [Lldb-commits] [PATCH] Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.

2015-06-25 Thread Pavel Labath
lgtm. Potentially we can leave a note to the future maintainer to remove the non-const versions, when/if we decide to make a breaking API change. http://reviews.llvm.org/D10711 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ __

Re: [Lldb-commits] [PATCH] Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.

2015-06-24 Thread Jim Ingham
That seems fine. Jim http://reviews.llvm.org/D10711 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.

2015-06-24 Thread Jim Ingham
That seems fine. Jim > On Jun 24, 2015, at 2:05 PM, Oleksiy Vyalov wrote: > > Hi jingham, labath, > > Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined. > > http://reviews.llvm.org/D10711 > > Files: > include/lldb/API/SBFrame.h > scripts/interface/SBFrame.i > source/AP