labath wrote:
Ah yes, of course, I've kept the mutex thinking that its sufficient to make it
run only once, but of course that's only true if the critical section actually
contains a "run once" check. I'll create a patch for that tomorrow. Feel free
to revert in the mean time if this is
kusmour wrote:
> > I can't remember: does terminate come before disconnecting? Or is it the
> > other way around?
>
> Disconnect docs say "The disconnect request asks the debug adapter to
> disconnect from the debuggee (thus ending the debug session) and then to shut
> down itself (the debug
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/91591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
Sounds good, thanks for the clarification.
https://github.com/llvm/llvm-project/pull/91591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath wrote:
> I can't remember: does terminate come before disconnecting? Or is it the
> other way around?
Disconnect docs say "The disconnect request asks the debug adapter to
disconnect from the debuggee (thus ending the debug session) and then to shut
down itself (the debug adapter).",
https://github.com/clayborg commented:
I can't remember: does terminate come before disconnecting? Or is it the other
way around?
https://github.com/llvm/llvm-project/pull/91591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/walter-erquinigo approved this pull request.
This all makes sense to me. Thank you!
https://github.com/llvm/llvm-project/pull/91591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/91591
lldb-dap was setting a flag which was meant to shut it down as soon as it sent
a terminated event. The problem with this flag is two-fold:
- as far as I can tell (definitely not an expert here), there's no
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
lldb-dap was setting a flag which was meant to shut it down as soon as it sent
a terminated event. The problem with this flag is two-fold:
- as far as I can tell (definitely not an expert here), there's no
labath wrote:
https://lab.llvm.org/buildbot/#/builders/68/builds/73871 is an example of such
a failure.
https://github.com/llvm/llvm-project/pull/91591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
10 matches
Mail list logo