[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

teemperor added a comment. Yes, the `writeSocketIdToPipe(unnamed_pipe_fd, socket_id);` fails in this method/file. https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

teemperor added a comment. Posting my mail here for the record: I was more hoping it would at least turn the deadlock into a fail, this way I could at least run the test suit. Anyway, the actual issue is related Python 3: Arch Linux (and probably some other distributions that "already" upgraded

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

teemperor added subscribers: aprantl, apolyakov. teemperor added a comment. > AFAIR, adding an exit(...) to ConnectToRemote won't solve this problem. The > test will still be failing on Arch. I was more hoping it would at least turn the deadlock into a fail, this way I could at least run the tes

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

teemperor added a comment. Yeah, explicitly typing python2 is what I did to fix it. Not sure if that breaks other OSs though (e.g. if a system has no `python2` binary, but only `python`). Also, that fix should be its own revision. It's not connected to the idea behind this revision from what I

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

teemperor added a comment. Hmmm, maybe I mixing up something here, but the docs state `pass_fds` was added in 3.2: > New in version 3.2: The pass_fds parameter was added. https://reviews.llvm.org/D52498 _

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Looks good and fixes the tests for me, so I think this is good to go. Thanks for the patch! https://reviews.llvm.org/D52498 ___ lldb-commi

[Lldb-commits] [PATCH] D52561: Refactor ClangUserExpression::GetLanguageForExpr

teemperor created this revision. teemperor added a reviewer: xbolva00. Herald added a subscriber: lldb-commits. The `ClangUserExpression::GetLanguageForExpr` method is currently a big source of sadness, as it's name implies that it's an accessor method, but it actually is also initializing some v

[Lldb-commits] [PATCH] D52561: Refactor ClangUserExpression::GetLanguageForExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343191: Refactor ClangUserExpression::GetLanguageForExpr (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D52561 Files: source/Plugins/ExpressionParser/Clan

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Runnings `settings export` crashes LLDB: (lldb) down ❲ 8❳ CommandObjectSettingsExport::DoExecute(this=0x55652a80, args=0x7fffd6b8, result=0x7fffdd80

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

teemperor added a comment. - Running `settings export /home/teemperor/foobar1 /home/teemperor/foobar2` will actually just create foobar1, but will not report any error that foobar2 is silently ignored. - Do we actually have a way to have file completion for the argument? (This doesn't have to

[Lldb-commits] [PATCH] D52884: Fix typos.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This looks all good to me. I'm a bit worried about the changes to AppleObjCTrampolineHandler.cpp, but from what I can see we don't actually rely on this specific field name anywhere in o

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry, this somehow didn't show up in my review queue. I think this can land after two minor things are fixed: - I think unknown arguments to write/read shouldn't be silently i

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Woops, I wanted to accept in my previous comment. https://reviews.llvm.org/D52651 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54003: Refactor ClangASTContext::AddEnumerationValueToEnumerationType() to remove redundant parameter which can be calculated from other parameter

teemperor added a comment. This looks nice, just added some minor comments below. Otherwise LGTM after Davide's point is addressed. Comment at: include/lldb/Symbol/ClangASTContext.h:909 clang::EnumConstantDecl *AddEnumerationValueToEnumerationType( - lldb::opaque_compi

[Lldb-commits] [PATCH] D54059: Remove Java debugger plugin

teemperor added a comment. Minor detail: The revision title only mentions Java, but this revision removes both Go and Java. Did anyone actually went through with Jim's proposal and posted this proposal to some Go mailing list or so? https://reviews.llvm.org/D54059 _

[Lldb-commits] [PATCH] D54072: Add a command to dump a module's clang ast.

teemperor added a comment. I think Pavel's point is to call the `dump` overload which allows specifying our own custom raw_ostream: https://clang.llvm.org/doxygen/classclang_1_1Decl.html#a278b3b87b6f9d3b20ed566a8684341a6 And our raw_ostream is configured by LLDB to correctly choose if we want c

[Lldb-commits] [PATCH] D54072: Add a command to dump a module's clang ast.

teemperor added a comment. Yeah it uses the color settings of the diagnostic engine which are probably set to false in LLDB. I think activating colors there should fix the issue. https://reviews.llvm.org/D54072 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D54335: [CMake] Fix: add_host_subdirectory source/Host/macosx

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, sorry for that! https://reviews.llvm.org/D54335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D54385: Remove comments after header includes.

teemperor added a comment. Do we also want to get rid of the `// C Includes` comments that are in some files? LLVM isn't using them either and just removing lines doesn't make git blame more complicated. Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:3

[Lldb-commits] [PATCH] D55361: Move Broadcaster+Listener+Event combo from Core into Utility

teemperor added a comment. LGTM modulo the unrelated clang-format changes. Feel free to commit them separately (even though the `m_event_names` fix looks a bit strange). Comment at: include/lldb/Utility/Broadcaster.h:551 -Broadcaster &m_broadcaster;///< The broadcast

[Lldb-commits] [PATCH] D56458: Fix unused private field warning.

teemperor created this revision. Herald added a subscriber: lldb-commits. The member is private and unused if HAVE_LIBCOMPRESSION is undefined, which triggers Clang's -Wunused-private-field warning. Repository: rLLDB LLDB https://reviews.llvm.org/D56458 Files: source/Plugins/Process/gdb-r

[Lldb-commits] [PATCH] D56458: Fix unused private field warning.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL350675: Fix unused private field warning. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

teemperor added inline comments. Comment at: lit/Minidump/Windows/Sigsegv/sigsegv.test:6 +CHECK: * thread #1, stop reason = Exception 0xc005 encountered at address 0x7ff7a13110d9 +CHECK: * frame #0: 0x7ff7a13110d9 sigsegv.exe`crash at sigsegv.cpp:22 +

[Lldb-commits] [PATCH] D47409: Forward declare DumpValueObjectOptions in ValueObject.h

teemperor created this revision. This resolves unnecessary the header dependency from Core to DataFormatters. Patch is necessary for the introduction of C++ modules to the LLDB build system. https://reviews.llvm.org/D47409 Files: include/lldb/Core/ValueObject.h source/Core/ValueObject.cpp

[Lldb-commits] [PATCH] D47409: Forward declare DumpValueObjectOptions in ValueObject.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL42: Forward declare DumpValueObjectOptions in ValueObject.h (authored by teemperor, committed by ). Herald added a sub

[Lldb-commits] [PATCH] D47410: Don't include headers from inside a namespace in MIUtilSingletonHelper.h

teemperor created this revision. Herald added a subscriber: ki.stfu. https://reviews.llvm.org/D47410 Files: tools/lldb-mi/MIUtilSingletonHelper.h Index: tools/lldb-mi/MIUtilSingletonHelper.h === --- tools/lldb-mi/MIUtilSingletonH

[Lldb-commits] [PATCH] D47410: Don't include headers from inside a namespace in MIUtilSingletonHelper.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL43: Don't include headers from inside a namespace in MIUtilSingletonHelper.h (authored by teemperor, committed by ). H

[Lldb-commits] [PATCH] D47411: Mute some compiler warnings in the generated python wrapper code.

teemperor created this revision. teemperor added a reviewer: zturner. Herald added a subscriber: mgorny. With SWIG 3.0.12 I get the following compiler warnings when compiling LLDB: tools/lldb/scripts/LLDBWrapPython.cpp:23699:52: warning: format string is not a string literal (potentially insec

[Lldb-commits] [PATCH] D47412: Add missing includes to some LLDB headers.

teemperor created this revision. Herald added a subscriber: ki.stfu. When compiling with modules, these missing includes cause the build to fail (as the header can't be compiled into a module). https://reviews.llvm.org/D47412 Files: source/Plugins/DynamicLoader/Hexagon-DYLD/HexagonDYLDRendez

[Lldb-commits] [PATCH] D47412: Add missing includes to some LLDB headers.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL45: Add missing includes to some LLDB headers. (authored by teemperor, committed by ). Herald added a subscriber: llvm

[Lldb-commits] [PATCH] D47418: Fix memory leak in SubsPrimitiveParmItanium

teemperor created this revision. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. FastDemangle gives us a C-string that we own (which is allocated in SymbolDemangler::GetDemangledCopy). As we are not deleting the string, we leak memory whenever we call SubsPr

[Lldb-commits] [PATCH] D47418: Fix memory leak in SubsPrimitiveParmItanium

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL53: Fix memory leak in SubsPrimitiveParmItanium (authored by teemperor, committed by ). Herald added a subscriber: llv

[Lldb-commits] [PATCH] D47923: Added missing include to LoadedModuleInfoList.h

teemperor created this revision. https://reviews.llvm.org/D47923 Files: include/lldb/Core/LoadedModuleInfoList.h Index: include/lldb/Core/LoadedModuleInfoList.h === --- include/lldb/Core/LoadedModuleInfoList.h +++ include/lldb/Co

[Lldb-commits] [PATCH] D47923: Added missing include to LoadedModuleInfoList.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL334259: Added missing include to LoadedModuleInfoList.h (authored by teemperor, committed by ). Herald added a subscriber:

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor created this revision. teemperor added a reviewer: aprantl. This patch adds a modulemap which allows compiling the lldb headers into C++ modules (for example in builds with LLVM_ENABLE_MODULES=On). Even though most of the affected code has been cleaned up to work with the more strict

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor added a comment. I generated a report for the remaining cyclic dependencies in the `lldb` module here . Note that I'll provide a modulemap for the `source/` headers in another patch, so this is out of scope for this review.

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor added a comment. @aprantl It's good for build times and more importantly it's consistent with the way Clang/LLVM are naming/organizing their modules. But I actually don't have a strong opinion on how the modules are named/organized. @bruno Breaking up the lldb module in the future is

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor updated this revision to Diff 150604. teemperor added a comment. - Removed some inconsistent white space. https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap Index: include/lldb/module.modulemap === --

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor planned changes to this revision. teemperor added a comment. It seems the compilation fails on OS X with this modulemap (or any modulemap). The reason seems to be that on OS X we compile Obj-C++ as part of lldb which assumes that Clang/LLVM is valid Obj-C++. However, the Obj-C parsing

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor updated this revision to Diff 151004. teemperor retitled this revision from "Add modulemap to lldb include directory" to "Add modules support for lldb headers in include/". teemperor edited the summary of this revision. teemperor added a comment. This revision is now accepted and ready t

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor added inline comments. Comment at: include/lldb/module.modulemap:66 +// This big module is necessary to work around the cyclic dependencies +// between its submodules. +module lldb { teemperor wrote: > bruno wrote: > > Will this trick be enough for loca

[Lldb-commits] [PATCH] D47411: Mute some compiler warnings in the generated python wrapper code.

teemperor abandoned this revision. teemperor added a comment. It seems people are also in favor of completely disabling the warnings, so that patch will replace this one. https://reviews.llvm.org/D47411 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor updated this revision to Diff 151023. teemperor added a comment. - Obj-C -> Obj-C++ https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap source/Host/CMakeLists.txt source/Host/common/Terminal.cpp source/Host/macosx/Host.mm source/Host/macosx/HostInfoMacOSX.mm

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor updated this revision to Diff 151025. teemperor marked an inline comment as done. teemperor added a comment. - Fixed a typo. https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap source/Host/CMakeLists.txt source/Host/common/Terminal.cpp source/Host/macosx/Host.

[Lldb-commits] [PATCH] D48096: Disable warnings for the generated LLDB wrapper source

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added a subscriber: mgorny. This source files emits all kind of compiler warnings on different platforms. As the source code in the file is generated and we therefore can't actually fix the warnings, we might as well di

[Lldb-commits] [PATCH] D47996: Added modulemap for lldb-mi

teemperor edited subscribers, added: lldb-commits; removed: cfe-commits. teemperor added a comment. - Fixed mailing list subscriber. https://reviews.llvm.org/D47996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D47996: Added modulemap for lldb-mi

This revision was automatically updated to reflect the committed changes. Closed by commit rL334549: Added modulemap for lldb-mi (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47996?vs=150663&id=151033#toc Rep

[Lldb-commits] [PATCH] D48096: Disable warnings for the generated LLDB wrapper source

This revision was automatically updated to reflect the committed changes. Closed by commit rL334557: Disable warnings for the generated LLDB wrapper source (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48096?v

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor updated this revision to Diff 151077. teemperor added a comment. - The regex that removes the modules cache now actually removes the whole flag + path. - Fixed more typos. https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap source/Host/CMakeLists.txt source/Hos

[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

teemperor updated this revision to Diff 151181. teemperor added a comment. - Finally found the one and only way to spell "Objective-C++" https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap source/Host/CMakeLists.txt source/Host/common/Terminal.cpp source/Host/macosx/Hos

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor created this revision. If we have an xvalue here, we will always hit the `err_typecheck_invalid_lvalue_addrof` error in 'Sema::CheckAddressOfOperand' when trying to take the address of the result. This patch uses the fallback code path where we store the result in a local variable ins

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor planned changes to this revision. teemperor added a comment. - Needs a test https://reviews.llvm.org/D48303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor updated this revision to Diff 151827. teemperor added a comment. - Added test case https://reviews.llvm.org/D48303 Files: packages/Python/lldbsuite/test/expression_command/xvalue/Makefile packages/Python/lldbsuite/test/expression_command/xvalue/TestXValuePrinting.py packages/Pyt

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor updated this revision to Diff 151828. teemperor added a comment. - Removed now unnecessary brackets. https://reviews.llvm.org/D48303 Files: packages/Python/lldbsuite/test/expression_command/xvalue/Makefile packages/Python/lldbsuite/test/expression_command/xvalue/TestXValuePrinting

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor updated this revision to Diff 151967. teemperor added a comment. - Generalized test case a bit more and no longer checking only for 0. https://reviews.llvm.org/D48303 Files: packages/Python/lldbsuite/test/expression_command/xvalue/Makefile packages/Python/lldbsuite/test/expression

[Lldb-commits] [PATCH] D48337: Refactor OnExit utility class in ClangUserExpression

teemperor created this revision. OnExit ensures we call `ResetDeclMap` before this method ends. However, we also have a few manual calls to ResetDeclMap in there that are actually unnecessary because of this (calling the method multiple times has no effect). This patch also moves the class out o

[Lldb-commits] [PATCH] D48337: Refactor OnExit utility class in ClangUserExpression

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL335078: Refactor OnExit utility class in ClangUserExpression (authored by teemperor, committed by ). Herald added a subscr

[Lldb-commits] [PATCH] D48339: Refactor ClangUserExpression::Parse [NFC]

teemperor created this revision. This patch splits out functionality from the `Parse` method into different methods. This benefits the code completion work (which should reuse those methods) and makes the code a bit more readable. Note that this patch is as minimal as possible. Some of the code

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor created this revision. While working on the `expr` completion, I've encountered the issue that sometimes lldb deadlocks when doing input/output. The underlying cause for this is that we seem to expect that we can always call `Debugger::PrintAsync` from any point of lldb and that this

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor added subscribers: friss, jingham. teemperor added a comment. Not sure who should review this, but maybe Fred or Jim know :) https://reviews.llvm.org/D48463 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor updated this revision to Diff 152402. teemperor added a comment. - Small code style adjustment. https://reviews.llvm.org/D48463 Files: include/lldb/Core/Debugger.h source/Core/Debugger.cpp source/Core/IOHandler.cpp Index: source/Core/IOHandler.cpp ==

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor created this revision. teemperor added a reviewer: jingham. Herald added subscribers: JDevlieghere, aprantl. This patch adds initial code completion support for the `expr` command. We now have a completion handler in the expression CommandObject that essentially just attempts to parse t

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor added a comment. Note that there are two parent revisions. One is just refactoring because I needed to reuse some of the parsing setup code. The other patch (the AsyncPrint one) fixes a deadlock that affected this patch. The deadlock can be reproduces by starting lldb, going to a rand

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor added a reviewer: labath. teemperor added a subscriber: labath. teemperor added a comment. Adding Pavel because he wrote the PrintAsync code. Also @labath: Can you tell me what variables/functionality the `m_output_mutex` in Editline.cpp is supposed to shield? I don't see any documenta

[Lldb-commits] [PATCH] D48659: Allow specifying an exit code for the 'quit' command

teemperor created this revision. teemperor added a reviewer: davide. This patch adds the possibility to specify an exit code when calling quit. We accept any int, even though it depends on the user what happens if the int is out of the range of what the operating system supports as exit codes. Fi

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor updated this revision to Diff 153126. teemperor added a comment. - We now also handle the case where a guarded mutex is manually unlocked from a nested call. - Refactoring based on review comments. https://reviews.llvm.org/D48463 Files: include/lldb/Core/Debugger.h include/lldb/H

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor updated this revision to Diff 153129. teemperor edited the summary of this revision. teemperor added a comment. - Fixed that we only pass a nullptr as a debugger to the real editline object (which now fixes the deadlock in the code completion patch). https://reviews.llvm.org/D48463 F

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor marked 2 inline comments as done. teemperor added a comment. @labath Thanks for the explanation! Well in theory we could poke more holes in our guard from some nested function, but this only fixes the deadlock symptom. PrintAsync would still be blocking whenever the mutex is hold by so

[Lldb-commits] [PATCH] D48665: Added test case for: r334978 - Fixed file completion for paths that start with '~'

teemperor created this revision. teemperor added a reviewer: labath. https://reviews.llvm.org/D48665 Files: unittests/Interpreter/TestCompletion.cpp Index: unittests/Interpreter/TestCompletion.cpp === --- unittests/Interpreter/Te

[Lldb-commits] [PATCH] D48665: Added test case for: r334978 - Fixed file completion for paths that start with '~'

This revision was automatically updated to reflect the committed changes. Closed by commit rL335905: Added test case for: r334978 - Fixed file completion for paths that start with… (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [PATCH] D48746: Fix path completion test case added in rL335905 on Windows

teemperor created this revision. teemperor added a reviewer: stella.stamenova. The test fails because we don't rewrite the slash behind `foo` to the OS specific separator (as the completion API doesn't support this kind of rewriting). However, we assume that this part of the string is rewritten

[Lldb-commits] [PATCH] D48746: Fix path completion test case added in rL335905 on Windows

teemperor added a comment. @stella.stamenova I don't have access to a Windows machine. Would you mind testing if this fixes the issue? https://reviews.llvm.org/D48746 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D48746: Fix path completion test case added in rL335905 on Windows

teemperor updated this revision to Diff 153408. teemperor added a comment. - Fixed an syntax error. Should work now. https://reviews.llvm.org/D48746 Files: unittests/Interpreter/TestCompletion.cpp Index: unittests/Interpreter/TestCompletion.cpp ==

[Lldb-commits] [PATCH] D48746: Fix path completion test case added in rL335905 on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL335934: Fix path completion test case added in rL335905 on Windows (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D487

[Lldb-commits] [PATCH] D48796: Refactoring for for the internal command line completion API (NFC)

teemperor created this revision. teemperor added reviewers: davide, jingham, labath. Herald added a subscriber: mgorny. This patch refactors the internal completion API. It now takes (as far as possible) a single CompletionRequest object instead o half a dozen in/out/in-out parameters. The Compl

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor updated this revision to Diff 153748. teemperor marked 13 inline comments as done. teemperor added a comment. - Addresses the problems pointed out by Adrian and Pavel (Thanks!) - Now using the completion API patch to get rid of the code that rebuilds the command line string from the arg

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/expr_completion/TestExprCompletion.py:177-215 +def generate_random_expr(self, run_index): +""" +Generates a random expression. run_index seeds the rng, so +the

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor planned changes to this revision. teemperor added a comment. Actually, because both @labath and @jingham requested refactoring to get rid of the `--` search (even though Phabricator couldn't parse Jim's comment), I'll first also refactor this one. Thanks for the feedback! https://rev

[Lldb-commits] [PATCH] D48796: Refactoring for for the internal command line completion API (NFC)

teemperor added a comment. @jingham Just trying to keep this patch as minimal/NFC as possible because we can't revert it once the expr completion patch is merged. I'll open reviews for all these other refactorings once this is in. https://reviews.llvm.org/D48796

[Lldb-commits] [PATCH] D48796: Refactoring for for the internal command line completion API (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL336146: Refactoring for for the internal command line completion API (NFC) (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D48855: Fixed compilation failure after the code completion refactor patch

teemperor created this revision. https://reviews.llvm.org/D48855 Files: include/lldb/Interpreter/CommandObject.h include/lldb/Utility/CompletionRequest.h Index: include/lldb/Utility/CompletionRequest.h === --- include/lldb/Util

[Lldb-commits] [PATCH] D48855: Fixed compilation failure after the code completion refactor patch

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336149: Fixed compilation failure after the code completion refactor patch (authored by teemperor, committed by ). Herald

[Lldb-commits] [PATCH] D48858: FIx XCode project files for lldb

teemperor created this revision. Herald added a subscriber: srhines. Fixes the XCode builds that started failing when i added CompletionRequest.cpp/.h. The patch is so large because XCode decided to write the lines back in its own order, but essentially we only added on e file. https://review

[Lldb-commits] [PATCH] D48858: FIx XCode project files for lldb

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336154: FIx XCode project files for lldb (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D48976: Replaced more boilerplate code with CompletionRequest (NFC)

teemperor created this revision. teemperor added a reviewer: jingham. As suggested in https://reviews.llvm.org/D48796, this patch replaces even more internal calls that were using the old completion API style with a single CompletionRequest. In some cases we also pass an option vector/index, but

[Lldb-commits] [PATCH] D48977: Fixed redefinition warnings with LLVM_ENABLE_MODULES

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added a subscriber: mgorny. It seems we both have the HAVE_LIBCOMPRESSION define in the config header and in the source files definitions of some files. This causes that the Config.h header emits the following warning whe

[Lldb-commits] [PATCH] D48977: Fixed redefinition warnings with LLVM_ENABLE_MODULES

This revision was automatically updated to reflect the committed changes. Closed by commit rL336377: Fixed redefinition warnings with LLVM_ENABLE_MODULES (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48977?vs=

[Lldb-commits] [PATCH] D48659: Allow specifying an exit code for the 'quit' command

teemperor updated this revision to Diff 154318. teemperor added a comment. - Client now has to explicitly allow the acceptance of exit codes. - Moved logic to the CommandInterpreter. - Added more tests. Thanks for the feedback Jim and Greg, very much appreciated! https://reviews.llvm.org/D48659

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

teemperor updated this revision to Diff 154656. teemperor edited the summary of this revision. teemperor added a subscriber: vsk. teemperor added a comment. - Removed unnecessary include from the test. https://reviews.llvm.org/D48303 Files: packages/Python/lldbsuite/test/expression_command/xv

[Lldb-commits] [PATCH] D48303: Don't take the address of an xvalue when printing an expr result

This revision was automatically updated to reflect the committed changes. Closed by commit rL336582: Don't take the address of an xvalue when printing an expr result (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [PATCH] D49106: Refactor parsing of argument lists with a raw string suffix.

teemperor created this revision. teemperor added a reviewer: jingham. Herald added a subscriber: mgorny. A subset of the LLDB commands follows this command line interface style: [arguments] -- The parsing code for this interface has been so far been duplicated into the different command obj

[Lldb-commits] [PATCH] D49106: Refactor parsing of option lists with a raw string suffix.

teemperor updated this revision to Diff 154862. teemperor retitled this revision from "Refactor parsing of argument lists with a raw string suffix." to "Refactor parsing of option lists with a raw string suffix.". teemperor edited the summary of this revision. teemperor added a comment. - Rename

[Lldb-commits] [PATCH] D49106: Refactor parsing of option lists with a raw string suffix.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336723: Refactor parsing of option lists with a raw string suffix. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D491

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor updated this revision to Diff 154885. teemperor added a comment. - Now using the new API for extracting the raw string from the option list. https://reviews.llvm.org/D48465 Files: include/lldb/Expression/ExpressionParser.h include/lldb/Expression/UserExpression.h packages/Python

[Lldb-commits] [PATCH] D48339: Refactor ClangUserExpression::Parse [NFC]

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336734: Refactor ClangUserExpression::Parse [NFC] (authored by teemperor, committed by ). Herald added a subscriber: llvm-

[Lldb-commits] [PATCH] D48659: Allow specifying an exit code for the 'quit' command

teemperor added a comment. @clayborg was quite specific about the requested changes (which are all applied now), so I assume this is good to go. https://reviews.llvm.org/D48659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

[Lldb-commits] [PATCH] D48659: Allow specifying an exit code for the 'quit' command

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336824: Allow specifying an exit code for the 'quit' command (authored by teemperor, committed by ). Herald added a subscr

[Lldb-commits] [PATCH] D49207: Get rid of the C-string parameter in DoExecute

teemperor created this revision. teemperor added a reviewer: davide. This patch gets rid of the C-string parameter in the RawCommandObject::DoExecute function, making the code simpler and less memory unsafe. There seems to be a assumption in some command objects that this parameter could be a n

[Lldb-commits] [PATCH] D49207: Get rid of the C-string parameter in DoExecute

teemperor added a comment. @jingham I thought the same at first, but giving an error `command.empty()` turns out to be a problem. The command string contains the arguments (but not the command name itself). So when calling for example `bt` we would hit this error (as there are no args, so `com

[Lldb-commits] [PATCH] D49207: Get rid of the C-string parameter in DoExecute

teemperor accepted this revision. teemperor added a comment. Davide also approved it offline (thx). https://reviews.llvm.org/D49207 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   3   4   5   6   7   8   9   10   >