Re: [llvm-commits] [llvm-gcc-4.2] r43909 - in /llvm-gcc-4.2/trunk/gcc: config/arm/arm.h llvm-convert.cpp

2007-11-16 Thread Lauro Ramos Venancio
> > It seems like there is two options: when lowering from GCC asm to > llvm asm, we can either change %@ (for example) into > ASM_COMMENT_START. Alternatively, we can lower it to "${:comment}", > which llvm asm already expands out to the right thing. Nowadays, LLVM doesn't expand this in inline

Re: [llvm-commits] [llvm-gcc-4.2] r43909 - in /llvm-gcc-4.2/trunk/gcc: config/arm/arm.h llvm-convert.cpp

2007-11-16 Thread Chris Lattner
On Nov 10, 2007, at 12:10 PM, Lauro Ramos Venancio wrote: >> >> Does it make sense to make this work? It seems much better than >> having to hack arm.h for every subtarget that doesn't use @ as a >> comment character. >> > > I'm afraid I didn't understand your point. I think the problem is > - T

Re: [llvm-commits] [llvm-gcc-4.2] r43909 - in /llvm-gcc-4.2/trunk/gcc: config/arm/arm.h llvm-convert.cpp

2007-11-10 Thread Lauro Ramos Venancio
> > Does it make sense to make this work? It seems much better than > having to hack arm.h for every subtarget that doesn't use @ as a > comment character. > I'm afraid I didn't understand your point. I think the problem is - Target can have inline asm extensions (not only comments - ARM target h

Re: [llvm-commits] [llvm-gcc-4.2] r43909 - in /llvm-gcc-4.2/trunk/gcc: config/arm/arm.h llvm-convert.cpp

2007-11-08 Thread Chris Lattner
On Nov 8, 2007, at 2:58 PM, Lauro Ramos Venancio wrote: > 2007/11/8, Chris Lattner <[EMAIL PROTECTED]>: >> On Nov 8, 2007, at 2:10 PM, Lauro Ramos Venancio wrote: >>> Author: laurov >>> Date: Thu Nov 8 16:10:12 2007 >>> New Revision: 43909 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=439

Re: [llvm-commits] [llvm-gcc-4.2] r43909 - in /llvm-gcc-4.2/trunk/gcc: config/arm/arm.h llvm-convert.cpp

2007-11-08 Thread Lauro Ramos Venancio
2007/11/8, Chris Lattner <[EMAIL PROTECTED]>: > On Nov 8, 2007, at 2:10 PM, Lauro Ramos Venancio wrote: > > Author: laurov > > Date: Thu Nov 8 16:10:12 2007 > > New Revision: 43909 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=43909&view=rev > > Log: > > Implement the '%@' inline asm ARM ex

Re: [llvm-commits] [llvm-gcc-4.2] r43909 - in /llvm-gcc-4.2/trunk/gcc: config/arm/arm.h llvm-convert.cpp

2007-11-08 Thread Chris Lattner
On Nov 8, 2007, at 2:10 PM, Lauro Ramos Venancio wrote: > Author: laurov > Date: Thu Nov 8 16:10:12 2007 > New Revision: 43909 > > URL: http://llvm.org/viewvc/llvm-project?rev=43909&view=rev > Log: > Implement the '%@' inline asm ARM extension. Hey Lauro, in .td files, you can use "${:comment}"

[llvm-commits] [llvm-gcc-4.2] r43909 - in /llvm-gcc-4.2/trunk/gcc: config/arm/arm.h llvm-convert.cpp

2007-11-08 Thread Lauro Ramos Venancio
Author: laurov Date: Thu Nov 8 16:10:12 2007 New Revision: 43909 URL: http://llvm.org/viewvc/llvm-project?rev=43909&view=rev Log: Implement the '%@' inline asm ARM extension. Modified: llvm-gcc-4.2/trunk/gcc/config/arm/arm.h llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp Modified: llvm-gcc-4.