joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
When the client supports v2 responses, the fallback to the legacy
response is undesirable. If the zlib is acceptable for the client,
it should have sa
On Thu, 11 Jan 2018 22:21:50 -0800
Gregory Szorc wrote:
> Mercurial's version numbers (currently 4.4, soon to be 4.5) mean little to
> nothing. Mercurial's existing .. version scheme
> doesn't honor semantic versioning in the traditional sense. API guarantees
> are that each quarterly X.Y release
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
https://phab.mercurial-scm.org/rHG265cd9e19d26dd7f684f660b6c267b45427284e8
introduced a comment in _filterederror that was not updated with
the latest iterati
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Introduce a filtered message table to ease translation of these messages.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1852
AF
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There is no reason to pass an unfiltered-repo to _getfilteredreason and
successorssets, so use a normal repo instead.
REPOSITORY
rHG Mercurial
REVISION DET
pulkit added a comment.
In https://phab.mercurial-scm.org/D1795#31282, @yuja wrote:
> `bytes()` or `"%d"` is preferred. Can you send a follow up?
I am not sure which one needs to be changed.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1795
To: pu
On Thu, 11 Jan 2018 11:13:57 -0500, Matt Harbison wrote:
>
> > On Jan 11, 2018, at 10:16 AM, Yuya Nishihara wrote:
> >
> >> On Thu, 11 Jan 2018 00:17:39 -0500, Matt Harbison wrote:
> >> # HG changeset patch
> >> # User Matt Harbison
> >> # Date 1515641014 18000
> >> # Wed Jan 10 22:23:34 2
On Thu, 11 Jan 2018 21:07:10 -0500, Matt Harbison wrote:
> On Thu, 11 Jan 2018 11:13:57 -0500, Matt Harbison
> wrote:
> >> Perhaps this could be 'path:'.
>
> I ended up needing to add this to avoid a parse error. The "*fileset*"
> tests run, but I'm not sure if this should be allowed for nor
yuja added a comment.
In https://phab.mercurial-scm.org/D1694#31044, @durin42 wrote:
> I think it's probably okay for debug commands, those are pretty rare to use
as a function aren't they?
Yeah, it's okay, but why do we apply a different rule to debug commands?
If we take th
yuja added inline comments.
INLINE COMMENTS
> subrepo.py:392
> if source.isabs():
> -return str(source)
> +return pycompat.bytestr(source)
> source.path = posixpath.normpath(source.path)
bytes()
> subrepo.py:399
> parent.path = posixpath.no
yuja added a comment.
Queued, thanks.
FWIW, it might be good idea to move `context._filterederror()` to obsutil.py
because context.py is painfully big.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1852
To: lothiraldan, #hg-reviewers, yuja
Cc: mercurial-
pulkit updated this revision to Diff 4803.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1813?vs=4754&id=4803
REVISION DETAIL
https://phab.mercurial-scm.org/D1813
AFFECTED FILES
mercurial/bookmarks.py
tests/test-directaccess.t
tests/test-log.t
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG49e073ea09d6: visibilty: fix a comment introduced before
which is not up-to-date (authored by lothiraldan, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-s
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGea9bd35529f2: visiblity: pass a normal repo to
_getfilteredreason (authored by lothiraldan, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1853?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0e0daf46a30c: visibility: make the filtered message
translatable (authored by lothiraldan, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1852?vs=
yuja added a comment.
Queued, thanks.
INLINE COMMENTS
> bookmarks.py:853
> +repo.ui.warn(_("bookmarking hidden changeset %s\n") % \
> + (', '.join(hiddenrevs)))
> marks.applychanges(repo, tr, changes)
FYI, it loops over bookmark names with the same `rev`, so
pulkit added inline comments.
INLINE COMMENTS
> yuja wrote in verify.py:110
> '%d', perhaps.
Looks like we cannot use "%d" here as None can be possible value also and
test-treemanifest.t has tests with None as a part of output.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercuri
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG53c0526b6484: bookmarks: add bookmarks to hidden revs if
directaccess config is set (authored by pulkit, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D1813?vs=4803&id=4807#toc
yuja added inline comments.
INLINE COMMENTS
> pulkit wrote in verify.py:110
> Looks like we cannot use "%d" here as None can be possible value also and
> test-treemanifest.t has tests with None as a part of output.
Ugh, it smells, but let's just leave it for now.
REPOSITORY
rHG Mercurial
RE
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Follow up for https://phab.mercurial-scm.org/D1795.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1854
AFFECTED FILES
mercurial/su
# HG changeset patch
# User Yuya Nishihara
# Date 1515763122 -32400
# Fri Jan 12 22:18:42 2018 +0900
# Node ID 4ca3b26ca272cf8c24b34deee8bc2530a8eccada
# Parent 44289d889542a3c559c424fa1f2d85cb7e16
rust: convert Unix path to CString transparently
On Unix, path is just a sequence of byte
# HG changeset patch
# User Yuya Nishihara
# Date 1515762574 -32400
# Fri Jan 12 22:09:34 2018 +0900
# Node ID 44289d889542a3c559c424fa1f2d85cb7e16
# Parent ea9bd35529f231c438630071119a309ba84dcc77
rust: extract function to convert Path to platform CString
It can be better on Unix.
dif
joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1855
AFFECTED FILES
tests/test-pull-r.t
CHANGE DETAILS
diff --git a/tests/test-pull-r.t b/
joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Pullbundles are similar to clonebundles, but served as normal inline
bundle streams. They are almost transparent to the client -- the only
visible eff
joerg.sonnenberger updated this revision to Diff 4811.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1856?vs=4810&id=4811
REVISION DETAIL
https://phab.mercurial-scm.org/D1856
AFFECTED FILES
mercurial/configitems.py
mercurial/help/config.txt
mercu
joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1857
AFFECTED FILES
mercurial/exchange.py
tests/test-pull-r.t
CHANGE DETAILS
diff --git
joerg.sonnenberger added a comment.
This is a proof-of-concept. There is an interaction with obsoletion that I am
still trying to understand (and fix).
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1857
To: joerg.sonnenberger, #hg-reviewers
Cc: mercurial-devel
joerg.sonnenberger updated this revision to Diff 4813.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1857?vs=4812&id=4813
REVISION DETAIL
https://phab.mercurial-scm.org/D1857
AFFECTED FILES
mercurial/exchange.py
tests/test-pull-r.t
CHANGE DETAILS
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5bda7bd29688: explicitly kill server processes (authored by
joerg.sonnenberger, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1855?vs=4809&id=481
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
We're not using the `Accept*` HTTP headers, so the use of HTTP `406` is not
appropriate. See https://tools.ietf.org/html/rfc7231#section-6.5.6. I believe
if you scour the mail
yuja added a comment.
Just for the record, explicit killdaemon isn't needed unless you want
to do something (e.g. checking server logs) after that. Daemons are
kill by the test runner.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1855
To: joerg.sonnenberge
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG991f0be9dc39: py3: use bytes instead of pycompat.bytestr
(authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1854?vs=4808&id=4815
# HG changeset patch
# User Matt Harbison
# Date 1515641708 18000
# Wed Jan 10 22:35:08 2018 -0500
# Node ID 2201fc4fd6d3d9dda72459c6642c16acbe6fc0a4
# Parent 24b5106e3e1e265cb60258b314ae2b774610de81
fileset: split the logic for matching a size expression to a separate method
This will be u
# HG changeset patch
# User Matt Harbison
# Date 1515641014 18000
# Wed Jan 10 22:23:34 2018 -0500
# Node ID b66e906f11f758eb3b3b0f5bc56cf66229f343b7
# Parent 2201fc4fd6d3d9dda72459c6642c16acbe6fc0a4
fileset: add a lightweight file filtering language
This patch was inspired by one that Jun
# HG changeset patch
# User Matt Harbison
# Date 1515816818 18000
# Fri Jan 12 23:13:38 2018 -0500
# Node ID a461399d0ac31e3c4ebc8dee10ea0ac46843fa07
# Parent b66e906f11f758eb3b3b0f5bc56cf66229f343b7
lfs: drop deprecated remote store config options
The last of these were removed from fb-exp
# HG changeset patch
# User Yuya Nishihara
# Date 1515817396 -32400
# Sat Jan 13 13:23:16 2018 +0900
# Node ID 2eeaf96c20fce19c8edccf4936aceee4ce651de9
# Parent 991f0be9dc39c402d63a4a8f19cde052095c4689
share: use context manager or utility function to write file
diff --git a/mercurial/hg.py
# HG changeset patch
# User Yuya Nishihara
# Date 1515817887 -32400
# Sat Jan 13 13:31:27 2018 +0900
# Node ID c4ecde5fbf1e40f0c918c9b4f6c1215b2cbebb7c
# Parent 41f5fc043698f6c8ff042ebb7d380f76a68a006b
share: convert EOL of hgrc before writing to bytes IO
Text IO is useless on Python 3 as i
# HG changeset patch
# User Yuya Nishihara
# Date 1515818471 -32400
# Sat Jan 13 13:41:11 2018 +0900
# Node ID 2a43867d18dfedd0708a6dfb87ab2fc80e5c
# Parent 6f68aa0c4c0aa59dd651e81e813c1a11e4761889
lfs: convert EOL of hgrc before appending to bytes IO
Text IO is useless on Python 3 as i
# HG changeset patch
# User Yuya Nishihara
# Date 1515817692 -32400
# Sat Jan 13 13:28:12 2018 +0900
# Node ID 41f5fc043698f6c8ff042ebb7d380f76a68a006b
# Parent f5558d75ef44a2db64131b4e5bca98102542f13b
subrepo: convert EOL of hgrc before writing to bytes IO
Follows up f2f0a777b2e2. Text IO
# HG changeset patch
# User Yuya Nishihara
# Date 1515818035 -32400
# Sat Jan 13 13:33:55 2018 +0900
# Node ID 6f68aa0c4c0aa59dd651e81e813c1a11e4761889
# Parent c4ecde5fbf1e40f0c918c9b4f6c1215b2cbebb7c
largefiles: convert EOL of hgrc before appending to bytes IO
Text IO is useless on Python
# HG changeset patch
# User Yuya Nishihara
# Date 1515818830 -32400
# Sat Jan 13 13:47:10 2018 +0900
# Node ID 1cd98d602f7a3d4dac3b1327278a29d50c2c0a3c
# Parent 2a43867d18dfedd0708a6dfb87ab2fc80e5c
vfs: drop text mode flag (API)
It's useless on Python 3.
.. api::
``text=False|True`
# HG changeset patch
# User Yuya Nishihara
# Date 1515817457 -32400
# Sat Jan 13 13:24:17 2018 +0900
# Node ID f5558d75ef44a2db64131b4e5bca98102542f13b
# Parent 2eeaf96c20fce19c8edccf4936aceee4ce651de9
clone: use utility function to write hgrc
diff --git a/mercurial/hg.py b/mercurial/hg.py
On Fri, 12 Jan 2018 23:28:41 -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1515816818 18000
> # Fri Jan 12 23:13:38 2018 -0500
> # Node ID a461399d0ac31e3c4ebc8dee10ea0ac46843fa07
> # Parent b66e906f11f758eb3b3b0f5bc56cf66229f343b7
> lfs: drop deprecated
On Fri, 12 Jan 2018 22:21:59 -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1515641014 18000
> # Wed Jan 10 22:23:34 2018 -0500
> # Node ID b66e906f11f758eb3b3b0f5bc56cf66229f343b7
> # Parent 2201fc4fd6d3d9dda72459c6642c16acbe6fc0a4
> fileset: add a lightw
# HG changeset patch
# User Yuya Nishihara
# Date 1515824009 -32400
# Sat Jan 13 15:13:29 2018 +0900
# Node ID ae8b3e1707597343265e2d2cbc99a665942a76df
# Parent 7a283960200aedf4461273ebc0c90f6f677c4a59
fileset: do not crash by unary negate operation
Backported from minifileset.py.
diff --g
# HG changeset patch
# User Yuya Nishihara
# Date 1515823657 -32400
# Sat Jan 13 15:07:37 2018 +0900
# Node ID 7a283960200aedf4461273ebc0c90f6f677c4a59
# Parent 706aa203b3961372f359df16214b4c10bc8a66fa
fileset: make it robust for bad function calls
Before, it could crash or show cryptic mes
# HG changeset patch
# User Matt Harbison
# Date 1514706889 18000
# Sun Dec 31 02:54:49 2017 -0500
# Node ID 66976f55793cced57929dedc8993204be340c717
# Parent 868cc63bfe9d7d7f5b40bc8cd70175cf1a608a95
lfs: migrate most file filtering from threshold to custom filter
Migrate `lfs.threshold` to
# HG changeset patch
# User Matt Harbison
# Date 1514742456 18000
# Sun Dec 31 12:47:36 2017 -0500
# Node ID 868cc63bfe9d7d7f5b40bc8cd70175cf1a608a95
# Parent 706aa203b3961372f359df16214b4c10bc8a66fa
test-lfs: bump the number on test repo11 and higher
This will allow a Facebook patch that c
48 matches
Mail list logo