Re: [Mesa-dev] [PATCH 1/7] dri: Remove dead comment.

2013-09-26 Thread Kenneth Graunke
On 09/26/2013 08:35 PM, Eric Anholt wrote: > The code it was referencing was removed in 2010. > --- > src/mesa/drivers/dri/common/dri_util.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/src/mesa/drivers/dri/common/dri_util.c > b/src/mesa/drivers/dri/common/dri_util.c > index fa520

Re: [Mesa-dev] [PATCH 6/7] i965: Clean up error handling for context creation.

2013-09-26 Thread Kenneth Graunke
On 09/26/2013 08:36 PM, Eric Anholt wrote: > The intel_screen.c used to be a dispatch to one of 3 driver functions, but > was down to 1, so it was kind of a waste. In addition, it was trying to > free all of the data that might have been partially freed in the kernel > 3.6 check (which comes after

Re: [Mesa-dev] [PATCH 5/7] intel: Remove silly check for !bufmgr.

2013-09-26 Thread Kenneth Graunke
On 09/26/2013 08:36 PM, Eric Anholt wrote: > If bufmgr didn't get created, then screen creation failed, and we never > should have got here in the first place. This was added by Chris Wilson > in 2010 with no explanation for why it would be needed. > --- > src/mesa/drivers/dri/i915/intel_context.

Re: [Mesa-dev] [PATCH 4/7] dri: Move API version validation into dri/common.

2013-09-26 Thread Kenneth Graunke
On 09/26/2013 08:35 PM, Eric Anholt wrote: > i965, i915, radeon, r200, swrast, and nouveau were mostly trying to do the > same logic, except where they failed to. Notably, swrast had code that > appeared to try to enable GLES1/2 but forgot to set api_mask (thus > preventing any gles context from b

Re: [Mesa-dev] [PATCH 2/4] i965/fs: Disable CSE on instructions writing to HW_REG.

2013-09-26 Thread Kenneth Graunke
On 09/26/2013 03:00 PM, Matt Turner wrote: > CSE would otherwise combine the two mul(8) emitted by [iu]mulExtended: > > mul(8) acc0 x y > mach(8) null x y > mov(8) lsb acc0 > ... > mul(8) acc0 x y > mach(8) msb x y > Into: > mul(8) temp x y > m

[Mesa-dev] [PATCH 5/7] intel: Remove silly check for !bufmgr.

2013-09-26 Thread Eric Anholt
If bufmgr didn't get created, then screen creation failed, and we never should have got here in the first place. This was added by Chris Wilson in 2010 with no explanation for why it would be needed. --- src/mesa/drivers/dri/i915/intel_context.c | 6 -- src/mesa/drivers/dri/i965/intel_context

[Mesa-dev] [PATCH 7/7] dri: Reference the global driver vtable once at screen init..

2013-09-26 Thread Eric Anholt
This is part of the prep for megadrivers, which won't allow using a single global symbol due to the fact that there will be multiple drivers built into the same dri.so file. For that, we'll need screen init to take a reference to the driver to set up this vtable. --- src/mesa/drivers/dri/common/d

[Mesa-dev] [PATCH 6/7] i965: Clean up error handling for context creation.

2013-09-26 Thread Eric Anholt
The intel_screen.c used to be a dispatch to one of 3 driver functions, but was down to 1, so it was kind of a waste. In addition, it was trying to free all of the data that might have been partially freed in the kernel 3.6 check (which comes after intelInitContext, and thus might have had driverPr

[Mesa-dev] [PATCH 4/7] dri: Move API version validation into dri/common.

2013-09-26 Thread Eric Anholt
i965, i915, radeon, r200, swrast, and nouveau were mostly trying to do the same logic, except where they failed to. Notably, swrast had code that appeared to try to enable GLES1/2 but forgot to set api_mask (thus preventing any gles context from being created), and the non-intel drivers didn't sup

[Mesa-dev] [PATCH 3/7] dri: Merge drisw_util.c into dri_util.c

2013-09-26 Thread Eric Anholt
The only important difference was not calling drmGetVersion, and making the swrast extension vtable. That doesn't justify duplicating the other 330 lines of code. XXX: The gallium scons copy of this isn't getting its cflags set, because I'm not sure what the right way is to set cflags on a s

[Mesa-dev] megadrivers prep series

2013-09-26 Thread Eric Anholt
In the process of doing the reworks necessary for the remaining megadrivers changes, I found a lot of duplicated code. Here's a series trying to reduce the insanity, though note that there's a missing piece in patch 3/7. Tested on i965 and softpipe, touch-tested classic swrast too. _

[Mesa-dev] [PATCH 1/7] dri: Remove dead comment.

2013-09-26 Thread Eric Anholt
The code it was referencing was removed in 2010. --- src/mesa/drivers/dri/common/dri_util.c | 4 1 file changed, 4 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index fa520ea..b95970d 100644 --- a/src/mesa/drivers/dri/common/dri_ut

[Mesa-dev] [PATCH 2/7] dri: Add an explanatory comment for an important driver entrypoint.

2013-09-26 Thread Eric Anholt
--- src/mesa/drivers/dri/common/dri_util.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index b95970d..fec05a0 100644 --- a/src/mesa/drivers/dri/common/dri_util.c +++ b/src/mesa/drivers/dri/common/dri_ut

Re: [Mesa-dev] [PATCH 2/4] i965/fs: Disable CSE on instructions writing to HW_REG.

2013-09-26 Thread Eric Anholt
Matt Turner writes: > CSE would otherwise combine the two mul(8) emitted by [iu]mulExtended: > > mul(8) acc0 x y > mach(8) null x y > mov(8) lsb acc0 > ... > mul(8) acc0 x y > mach(8) msb x y > Into: > mul(8) temp x y > mov(8) acc0 temp >

Re: [Mesa-dev] [PATCH 1/4] glsl: Implement [iu]mulExtended() built-ins for ARB_gpu_shader5.

2013-09-26 Thread Matt Turner
On Thu, Sep 26, 2013 at 3:00 PM, Matt Turner wrote: > These built-ins have two "out" parameters, which makes implementing them > efficiently with our current compiler infrastructure difficult. Instead, > implement them in terms of the existing ir_binop_mul IR (to return the > low 32-bits) and a ne

[Mesa-dev] [PATCH 4/4] i965: Generate code for ir_binop_imul_high.

2013-09-26 Thread Matt Turner
v2: Make accumulator's type match the type of the operation. Noticed by Ken. Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 1 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 10 ++ src/mesa/drivers/dri/i965/brw_vec4_visitor.c

[Mesa-dev] [PATCH 3/4] i965: Use the multiplication result's type for the accumulator.

2013-09-26 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index 7d9f605..c29703c 10064

[Mesa-dev] [PATCH 2/4] i965/fs: Disable CSE on instructions writing to HW_REG.

2013-09-26 Thread Matt Turner
CSE would otherwise combine the two mul(8) emitted by [iu]mulExtended: mul(8) acc0 x y mach(8) null x y mov(8) lsb acc0 ... mul(8) acc0 x y mach(8) msb x y Into: mul(8) temp x y mov(8) acc0 temp mach(8) null x y

[Mesa-dev] [PATCH 1/4] glsl: Implement [iu]mulExtended() built-ins for ARB_gpu_shader5.

2013-09-26 Thread Matt Turner
These built-ins have two "out" parameters, which makes implementing them efficiently with our current compiler infrastructure difficult. Instead, implement them in terms of the existing ir_binop_mul IR (to return the low 32-bits) and a new ir_binop_mul64 which returns the high 32-bits. v2: Rename

Re: [Mesa-dev] [PATCH 24/24] i965: Simplify the shader time code by using atomic counter helpers.

2013-09-26 Thread Paul Berry
On 15 September 2013 00:19, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_emit.c | 25 > --- > src/mesa/drivers/dri/i965/brw_state.h | 2 -- > src/mesa/drivers/dri/i965/brw_vs_surface_state.c | 4 +++- > src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH 22/24] i965/gen7: Handle atomic instructions from the VEC4 back-end.

2013-09-26 Thread Paul Berry
On 15 September 2013 00:19, Francisco Jerez wrote: > This can deal with all the 15 32-bit untyped atomic operations the > hardware supports, but only INC and PREDEC are going to be exposed > through the API for now. > --- > src/mesa/drivers/dri/i965/brw_vec4.h | 7 +++ > src/mesa/driv

Re: [Mesa-dev] [PATCH 21/24] i965/gen7: Handle atomic instructions from the FS back-end.

2013-09-26 Thread Paul Berry
On 15 September 2013 00:19, Francisco Jerez wrote: > This can deal with all the 15 32-bit untyped atomic operations the > hardware supports, but only INC and PREDEC are going to be exposed > through the API for now. > --- > src/mesa/drivers/dri/i965/brw_fs.h | 7 +++ > src/mesa/driver

Re: [Mesa-dev] Mesa 9.2 on windows

2013-09-26 Thread Brian Paul
On 09/26/2013 06:10 AM, Filip Arlet wrote: Hi, has anyone succeeded compiling Mesa 9.2 on Windows XP with MSVC ? No mather what msvc compiler I use. (2008, 2010, 2012 with XP support). Even tried patch MSVC 2010 with these patches: kb2820057, kb2836024 and kb2740362. But still no luck. Can you

Re: [Mesa-dev] [PATCH 2/2] i965: Use IVB specific formula for depthbuffer

2013-09-26 Thread Chad Versace
On 09/22/2013 10:37 AM, Ben Widawsky wrote: After the last patch, we can replace the region allocated in the miptree creation with a more straightforward (and hopefully smaller resulting) buffer based on the bspec's allocation formula. Since I am relatively new to this part of the bspec, I would

Re: [Mesa-dev] [PATCH 2/2] st/clover: Always flush the queue when waiting on an hard_event

2013-09-26 Thread Francisco Jerez
Niels Ole Salscheider writes: > The OpenCL spec says: > "Any blocking commands queued in a command-queue and clReleaseCommandQueue > perform an implicit flush of the command-queue. These blocking commands are > [...] or clWaitForEvents." > Are you sure we want to do this just to please the spec?

Re: [Mesa-dev] [PATCH 1/2] st/clover: Clear the complete queue

2013-09-26 Thread Francisco Jerez
Niels Ole Salscheider writes: > Events that are already signalled can be removed from the queue, too. > > Signed-off-by: Niels Ole Salscheider I don't think this is right, with this patch we remove *all* events from the command queue, signalled or not, every time the command queue is flushed.

Re: [Mesa-dev] [PATCH 1/2] i965: Extract region use from hiz depth buffer

2013-09-26 Thread Ben Widawsky
On Thu, Sep 26, 2013 at 11:16:52AM -0700, Chad Versace wrote: > On 09/26/2013 10:37 AM, Chad Versace wrote: > >On 09/22/2013 10:37 AM, Ben Widawsky wrote: > >>Starting with Ivybridge, the hierarchical had relaxed requirements for > >^^^ > >"the hierarchical"

Re: [Mesa-dev] [PATCH 1/2] i965: Extract region use from hiz depth buffer

2013-09-26 Thread Chad Versace
On 09/26/2013 10:37 AM, Chad Versace wrote: On 09/22/2013 10:37 AM, Ben Widawsky wrote: Starting with Ivybridge, the hierarchical had relaxed requirements for ^^^ "the hierarchical" doesn't make sense. Just call it "the HiZ buffer" or "the hiz buffer".

Re: [Mesa-dev] [PATCH 18/24] i965: Add a 'has_side_effects' back-end instruction predicate.

2013-09-26 Thread Paul Berry
On 15 September 2013 00:10, Francisco Jerez wrote: > Analogous to the GLSL IR predicate with the same name. This patch > fixes the three dead code elimination passes and the VEC4/FS > instruction scheduling passes so they leave instructions with side > effects alone. > > At some point it might b

Re: [Mesa-dev] [PATCH 2/2] i965: Generate code for ir_binop_mul64.

2013-09-26 Thread Kenneth Graunke
On 09/25/2013 11:09 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 1 + > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 10 ++ > src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 7 +++ > 3 files changed, 18 insertions(

Re: [Mesa-dev] [PATCH 1/2] i965: Extract region use from hiz depth buffer

2013-09-26 Thread Chad Versace
On 09/22/2013 10:37 AM, Ben Widawsky wrote: Starting with Ivybridge, the hierarchical had relaxed requirements for ^^^ "the hierarchical" doesn't make sense. Just call it "the HiZ buffer" or "the hiz buffer". its allocation. Following a "simple" formula i

Re: [Mesa-dev] [PATCH 1/2] glsl: Implement [iu]mulExtended() built-ins for ARB_gpu_shader5.

2013-09-26 Thread Kenneth Graunke
On 09/25/2013 11:09 PM, Matt Turner wrote: > These built-ins have two "out" parameters, which makes implementing them > efficiently with our current compiler infrastructure difficult. Instead, > implement them in terms of the existing ir_binop_mul IR (to return the > low 32-bits) and a new ir_binop

Re: [Mesa-dev] [PATCH 16/24] i965/gen7: Implement code generation for untyped atomic instructions.

2013-09-26 Thread Paul Berry
On 15 September 2013 00:10, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_defines.h | 2 + > src/mesa/drivers/dri/i965/brw_eu.h | 9 + > src/mesa/drivers/dri/i965/brw_eu_emit.c | 62 > + > src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 17/18] r600g,radeonsi: share r600_texture.c

2013-09-26 Thread Alex Deucher
On Thu, Sep 26, 2013 at 12:19 PM, Michel Dänzer wrote: > On Don, 2013-09-26 at 03:35 +0200, Marek Olšák wrote: >> From: Marek Olšák >> >> The function r600_choose_tiling is new and needs a review. >> >> The only change in functionality is that it enables 2D tiling for compressed >> textures on SI

Re: [Mesa-dev] [PATCH 17/18] r600g,radeonsi: share r600_texture.c

2013-09-26 Thread Michel Dänzer
On Don, 2013-09-26 at 03:35 +0200, Marek Olšák wrote: > From: Marek Olšák > > The function r600_choose_tiling is new and needs a review. > > The only change in functionality is that it enables 2D tiling for compressed > textures on SI. It was probably accidentally turned off. [...] > 19 files

[Mesa-dev] Mesa 9.2 on windows

2013-09-26 Thread Filip Arlet
Hi, has anyone succeeded compiling Mesa 9.2 on Windows XP with MSVC ? No mather what msvc compiler I use. (2008, 2010, 2012 with XP support). Even tried patch MSVC 2010 with these patches:  kb2820057, kb2836024 and kb 2740362. But still no luck. Filip

Re: [Mesa-dev] [PATCH 1/2] st/clover: Clear the complete queue

2013-09-26 Thread Niels Ole Salscheider
Ping ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] radeon/vdpau: only export necessary symbols

2013-09-26 Thread Christian König
From: Christian König Export only the absolutely necessary symbols in radeon vdpau targets. Signed-off-by: Christian König --- src/gallium/targets/r300/vdpau/Makefile.am | 3 +++ src/gallium/targets/r600/vdpau/Makefile.am | 3 +++ src/gallium/targets/radeonsi/vdpau/Makefile.am | 3 +++

[Mesa-dev] [PATCH 1/2] radeon/uvd: optimize message handling a bit

2013-09-26 Thread Christian König
From: Christian König No need to keep a copy of the message in system memory anymore, since it should now be in GART memory on newer chips. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 97 ++--- 1 file changed, 53 insertions(+), 44 de