Re: [Mesa-dev] [v2 PATCH 09/16] glsl: Optimize clamp(x, 0, 1) as saturate(x)

On Tue, Jul 8, 2014 at 8:22 AM, Matt Turner wrote: > On Mon, Jul 7, 2014 at 11:00 PM, Erik Faye-Lund wrote: >> On Mon, Jul 7, 2014 at 7:18 PM, Matt Turner wrote: >>> This comment tripped me up for a second. This really means that you've >>> found either >>> >>> - min(max(x, 0.0), 1.0); or >>>

Re: [Mesa-dev] [PATCH 2/3] i965: Avoid crashing while dumping vec4 insn operands

On Sun, Jul 6, 2014 at 1:11 AM, Chris Forbes wrote: > We'd otherwise go looking into virtual_grf_sizes for things that aren't > in there at all. > > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --gi

Re: [Mesa-dev] [v2 PATCH 09/16] glsl: Optimize clamp(x, 0, 1) as saturate(x)

On Mon, Jul 7, 2014 at 11:00 PM, Erik Faye-Lund wrote: > On Mon, Jul 7, 2014 at 7:18 PM, Matt Turner wrote: >> This comment tripped me up for a second. This really means that you've >> found either >> >> - min(max(x, 0.0), 1.0); or >> - max(min(x, 1.0), 0.0) > > Hmm, but are optimizing both o

Re: [Mesa-dev] [PATCH] i965: Extend compute-to-mrf pass to understand blocks of MOVs

On Mon, Jul 7, 2014 at 11:07 PM, Kristian Høgsberg wrote: > On Mon, Jun 30, 2014 at 3:14 PM, Matt Turner wrote: >> On Fri, Jun 27, 2014 at 12:00 PM, Kristian Høgsberg >> wrote: >>> From: Kristian Høgsberg >> >> With your email address fixed, > > Done, thanks for the review. I realized that th

Re: [Mesa-dev] [PATCH] i965: Extend compute-to-mrf pass to understand blocks of MOVs

On Mon, Jun 30, 2014 at 3:14 PM, Matt Turner wrote: > On Fri, Jun 27, 2014 at 12:00 PM, Kristian Høgsberg > wrote: >> From: Kristian Høgsberg > > With your email address fixed, Done, thanks for the review. I realized that this also applies to MRT shaders where we write the same value to two r

Re: [Mesa-dev] [v2 PATCH 09/16] glsl: Optimize clamp(x, 0, 1) as saturate(x)

On Mon, Jul 7, 2014 at 7:18 PM, Matt Turner wrote: > On Mon, Jul 7, 2014 at 6:57 AM, Abdiel Janulgue > wrote: >> v2: Check that the base type is float (Ian Romanick) >> >> Signed-off-by: Abdiel Janulgue >> --- >> src/glsl/opt_algebraic.cpp | 34 ++ >> 1 file chan

[Mesa-dev] Per-sample shading and its effect on interpolation

Hello, I've discussed this with Chris a bunch, but wanted to also get other people's take on this. The way I interpret things is that when ARB_sample_shading's provisions are met, it's as if each fragment input were to have been declared with a 'sample' attribute in an ARB_gpu_shader5 world. This

Re: [Mesa-dev] [PATCH] mesa: Fix regression introduced by commit "mesa: fix packing of float texels to GL_SHORT/GL_BYTE".

Hi Chris, I found your new piglit tests for arb_texture_view (format-consistency-get and format-consistency-render) and checked that all of them pass with my patch. Also I slightly modified test format-consistency-get and now it fails without patch and demonstrates the regression. The test and p

Re: [Mesa-dev] [PATCH] radeonsi: mark MSAA config state as dirty at the beginning of CS

On Mon, Jul 7, 2014 at 9:40 PM, Marek Olšák wrote: > From: Marek Olšák > You might want to mention the bug URL that this fixes when you push. Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_hw_context.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/dr

[Mesa-dev] [PATCH] radeonsi: mark MSAA config state as dirty at the beginning of CS

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_hw_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c b/src/gallium/drivers/radeonsi/si_hw_context.c index e4ce3af..56fa664 100644 --- a/src/gallium/drivers/radeonsi/si_hw_context.c +++

[Mesa-dev] [PATCH 2/5] radeonsi: assume LLVM 3.4.2 is always present

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 7 --- src/gallium/drivers/radeonsi/si_descriptors.c | 6 ++ src/gallium/drivers/radeonsi/si_pipe.c| 12 src/gallium/drivers/radeonsi/si_pipe.h| 4 src/gallium/drivers/radeonsi/si_s

[Mesa-dev] [PATCH 3/5] radeonsi: use an SGPR instead of VGT_INDX_OFFSET

From: Marek Olšák The draw indirect packets cannot set VGT_INDX_OFFSET, they can only set user data SGPRs. This is the only way to support start/index_bias with indirect drawing. --- src/gallium/drivers/radeonsi/si_shader.c | 11 +++ src/gallium/drivers/radeonsi/si_shader.h | 10

[Mesa-dev] [PATCH 4/5] radeonsi: don't add info->start to the index buffer offset

From: Marek Olšák info->start will be invalid once info->indirect isn't NULL, so it shouldn't be added to ib.offset. --- src/gallium/drivers/radeonsi/si_state_draw.c | 36 +++- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si

[Mesa-dev] [PATCH 5/5] radeonsi: implement ARB_draw_indirect

From: Marek Olšák --- docs/GL3.txt | 4 +- docs/relnotes/10.3.html | 2 + src/gallium/drivers/radeonsi/si_commands.c | 53 src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_state.h

[Mesa-dev] [PATCH 0/5] RadeonSI Draw Indirect re-spin

I'm re-sending what remains to be merged to get ARB_draw_indirect on radeonsi. They are patches 3-5. The first 2 patches bump the LLVM version requirement to 3.4.2, which contains a fix for the calling convention to allow one more user SGPR. Please review. Marek ___

[Mesa-dev] [PATCH 1/5] configure.ac: require LLVM 3.4.2 for radeon

From: Marek Olšák Needed by ARB_draw_indirect. --- configure.ac | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 4646212..9d5cd89 100644 --- a/configure.ac +++ b/configure.ac @@ -1888,8 +1888,9 @@ radeon_llvm_check() { AC_MSG_ERR

Re: [Mesa-dev] [PATCH 3/9] gallium: add PIPE_BIND_COMMAND_ARGS_BUFFER

Thanks for info. However, the home page of llvm.org doesn't seem to mention it. Marek On Wed, Jul 2, 2014 at 6:12 PM, Tom Stellard wrote: > On Sat, Jun 28, 2014 at 01:12:49PM +0200, Marek Olšák wrote: >> The one that increases the number of input SGPRs to 22 (16 user + 6 >> streamout) in the cal

[Mesa-dev] [PATCH 1/2] radeonsi: switch descriptors to i32 vectors

From: Marek Olšák This is a follow-up to the commit which adds texture fetches with offsets. --- src/gallium/drivers/radeonsi/si_shader.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/dr

[Mesa-dev] [PATCH 2/2] radeonsi: rename definitions of shader limits

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c| 2 +- src/gallium/drivers/radeonsi/si_descriptors.c | 12 +- src/gallium/drivers/radeonsi/si_pipe.c| 6 ++--- src/gallium/drivers/radeonsi/si_pipe.h| 4 +--- src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] Mesa 10.2.3

Mesa 10.2.3 has been released. Mesa 10.2.3 is a bug fix release which fixes bugs fixed since the 10.2.2 release, (see below for a list of changes). The tag in the git repository for Mesa 10.2.3 is 'mesa-10.2.3'. Mesa 10.2.3 is available for download at ftp://freedesktop.org/pub/mesa/10.2.3/ SHA-

Re: [Mesa-dev] [PATCH 2/2] i965: Remove artificial dependency between math instructions.

On Monday, July 07, 2014 01:39:17 PM Matt Turner wrote: > ... on Gen7+. I'm not actually sure which class Gen6 fits into. It looks like you actually did this for Gen6+, not Gen7+. I think that's correct. Gen6 is when we moved from the mathbox shared function to an actual MATH instruction. Ass

[Mesa-dev] [PATCH 1/2] i965/fs: Track dependencies in instruction scheduling per reg offset.

Previously instruction scheduling tracked dependencies on a per-register basis. This meant that there was an artificial dependency between interpolation instructions writing into the same virtual register. Instruction scheduling would insert a number of instructions between the two instructions in

[Mesa-dev] [PATCH 2/2] i965: Remove artificial dependency between math instructions.

... on Gen7+. I'm not actually sure which class Gen6 fits into. --- src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp b/src/mesa/drivers/dri/i965/brw_schedule_instru

Re: [Mesa-dev] i965: Turn off optimizations in i965 but not glsl-compiler?

On Mon, Jul 7, 2014 at 12:36 PM, Thomas Helland wrote: > Is it possible to turn off the optimizations in the backend, > while still leaving optimizations on in the glsl-compiler? Not via an environment variable or anything, but you can of course comment out the optimization loop in brw_fs.cpp/brw

[Mesa-dev] [Bug 21239] progs/tests/afsmultiarb : incorrect rendering

https://bugs.freedesktop.org/show_bug.cgi?id=21239 Andreas Boll changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 11/16] nvc0: use of new counter types

On Mon, Jul 7, 2014 at 3:45 PM, Samuel Pitoiset wrote: > On 07/07/2014 06:32 PM, Ilia Mirkin wrote: >> >> On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset >> wrote: >>> >>> Signed-off-by: Samuel Pitoiset >>> --- >>> src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 19 +-- >>> 1

Re: [Mesa-dev] [PATCH 11/16] nvc0: use of new counter types

On 07/07/2014 06:32 PM, Ilia Mirkin wrote: On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/no

[Mesa-dev] i965: Turn off optimizations in i965 but not glsl-compiler?

Hi, Is it possible to turn off the optimizations in the backend, while still leaving optimizations on in the glsl-compiler? I'm currently exploring different execution-orders of optimization-passes in the glsl-compiler. While I've found some room for improvement, my guess is a lot of the differen

Re: [Mesa-dev] [PATCH 02/16] gallium: add pipe_context::get_driver_query_group_info

On 07/07/2014 07:15 PM, Roland Scheidegger wrote: Oh and 2,5,6,7,8 have a somewhat bogus commit message - this is a pipe_screen function, not pipe_context. Oh my bad! I'm sorry... I fixed it locally, thanks. Roland Am 07.07.2014 18:42, schrieb Roland Scheidegger: You should also add docs b

Re: [Mesa-dev] Clamp/saturate optimizations V2

On Mon, Jul 7, 2014 at 6:56 AM, Abdiel Janulgue wrote: > V2 of clamp/saturate optimizations > > This patch series add the plumbing to support the GLSL IR instruction > saturate(). > Previously, saturate is implemented as min/max instructions. Most GPUs, > however, > can probably perform saturate

Re: [Mesa-dev] [PATCH] R600/SI: Use i32 vectors for resources and samplers

On Jul 7, 2014, at 8:28 AM, Marek Olšák wrote: > From: Marek Olšák > > This affects new intrinsics only. > > What surprises me is that v32i8 still works. > --- > lib/Target/R600/SIInstructions.td | 4 +- > lib/Target/R600/SIIntrinsics.td | 6 +-- > test/CodeGen/R600/llvm

Re: [Mesa-dev] [v2 PATCH 13/16] i965/vec4: Allow propagation of instructions with saturate flag to sel

On Mon, Jul 7, 2014 at 6:57 AM, Abdiel Janulgue wrote: > When sel conditon is bounded within 0 and 1.0. This allows code as: > mov.sat a b > sel.ge dst a 0.25F > > To be propagated as: > sel.ge.sat dst b 0.25F > > Signed-off-by: Abdiel Janulgue > --- > .../drivers/dri/i9

Re: [Mesa-dev] [v2 PATCH 12/16] i965/fs: Allow propagation of instructions with saturate flag to sel

On Mon, Jul 7, 2014 at 6:57 AM, Abdiel Janulgue wrote: > When sel conditon is bounded within 0 and 1.0. This allows code as: > mov.sat a b > sel.ge dst a 0.25F > > To be propagated as: > sel.ge.sat dst b 0.25F > > Signed-off-by: Abdiel Janulgue > --- > src/mesa/drivers/d

Re: [Mesa-dev] [PATCH 09/16] gallium: replace pipe_driver_query_info::max_value by a union

Am 07.07.2014 17:47, schrieb Samuel Pitoiset: > This allows to return different numeric types for queries. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/auxiliary/hud/hud_driver_query.c| 2 +- > src/gallium/drivers/freedreno/freedreno_query.c | 12 ++-- > src/gallium/driver

Re: [Mesa-dev] [v2 PATCH 11/16] glsl: Optimize clamp(x, b, 1.0), where b > 0.0 as max(saturate(x), b)

On Mon, Jul 7, 2014 at 6:57 AM, Abdiel Janulgue wrote: > v2: - Output max(saturate(x),b) instead of saturate(max(x,b)) > - Make sure we do component-wise comparison for vectors (Ian Romanick) > > Signed-off-by: Abdiel Janulgue > --- > src/glsl/opt_algebraic.cpp | 12 > 1 file ch

Re: [Mesa-dev] [v2 PATCH 10/16] glsl: Optimize clamp(x, 0.0, b), where b < 1.0 as min(saturate(x), b)

On Mon, Jul 7, 2014 at 6:57 AM, Abdiel Janulgue wrote: > v2: - Output min(saturate(x),b) instead of saturate(min(x,b)) suggested by > Ilia Mirkin > - Make sure we do component-wise comparison for vectors (Ian Romanick) > > Signed-off-by: Abdiel Janulgue > --- > src/glsl/opt_algebraic.cpp |

Re: [Mesa-dev] [v2 PATCH 09/16] glsl: Optimize clamp(x, 0, 1) as saturate(x)

On Mon, Jul 7, 2014 at 6:57 AM, Abdiel Janulgue wrote: > v2: Check that the base type is float (Ian Romanick) > > Signed-off-by: Abdiel Janulgue > --- > src/glsl/opt_algebraic.cpp | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git a/src/glsl/opt_algebraic.

Re: [Mesa-dev] [PATCH 02/16] gallium: add pipe_context::get_driver_query_group_info

Oh and 2,5,6,7,8 have a somewhat bogus commit message - this is a pipe_screen function, not pipe_context. Roland Am 07.07.2014 18:42, schrieb Roland Scheidegger: > You should also add docs bit in gallium/docs/source/screen.rst > > Otherwise looks ok to me. > > Roland > > Am 07.07.2014 17:47, s

[Mesa-dev] [Bug 29711] kwin crashes when changing font configuration(OpenGL desktop effects enabled)

https://bugs.freedesktop.org/show_bug.cgi?id=29711 Andreas Boll changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 11/13] i965: Make backend_instruction usable from C.

On Fri, Jul 04, 2014 at 09:43:08PM -0700, Matt Turner wrote: > On Wed, Jul 2, 2014 at 6:59 AM, Pohjolainen, Topi > wrote: > > On Mon, Jun 30, 2014 at 02:40:42PM -0700, Matt Turner wrote: > >> With a hack to place an exec_node in the struct in C to be at the same > >> location as the inherited exec

Re: [Mesa-dev] [PATCH 02/16] gallium: add pipe_context::get_driver_query_group_info

You should also add docs bit in gallium/docs/source/screen.rst Otherwise looks ok to me. Roland Am 07.07.2014 17:47, schrieb Samuel Pitoiset: > This will be used to sort counters per group for > GL_AMD_performance_monitor. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/include/pipe/p_

Re: [Mesa-dev] [PATCH 11/16] nvc0: use of new counter types

On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 19 +-- > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c > b/src/gall

[Mesa-dev] [Bug 21239] progs/tests/afsmultiarb : incorrect rendering

https://bugs.freedesktop.org/show_bug.cgi?id=21239 Andreas Boll changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

[Mesa-dev] [PATCH] r600g/compute: Try to use a temporary resource when growing the pool

Now, before moving everything to host memory, we try to create a new resource to use as a pool. I we succeed we just use this resource and delete the previous one. If we fail we fallback to using the shadow. This should make growing the pool faster, and we can also save 64KB of memory that were al

Re: [Mesa-dev] [PATCH 03/16] gallium: add a group_id field to pipe_driver_query_info v2

On Mon, Jul 7, 2014 at 11:20 AM, Samuel Pitoiset wrote: > On 07/07/2014 05:12 PM, Ilia Mirkin wrote: >> >> On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset >> wrote: >>> >>> V2: >>> - make group_id the last field of this struct, this fixes >>> drivers which use pipe_driver_query_info like rad

Re: [Mesa-dev] [PATCH 16/16] [RFC] mesa/st: enable GL_AMD_performance_monitor

On 07/07/2014 05:23 PM, Ilia Mirkin wrote: On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/s

Re: [Mesa-dev] [PATCH 09/16] gallium: replace pipe_driver_query_info::max_value by a union

On 07/07/2014 05:17 PM, Ilia Mirkin wrote: On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset wrote: This allows to return different numeric types for queries. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/hud/hud_driver_query.c| 2 +- src/gallium/drivers/freedreno/freedreno_

Re: [Mesa-dev] [PATCH 16/16] [RFC] mesa/st: enable GL_AMD_performance_monitor

On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/state_tracker/st_extensions.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/state_tracker/st_extensions.c > b/src/mesa/state_tracker/st_extensions.c > index 4207cb6..250

Re: [Mesa-dev] [PATCH 04/16] gallium: use of pipe_driver_query_info::group_id v2

On 07/07/2014 05:13 PM, Ilia Mirkin wrote: On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset wrote: This adds two groups of queries for nvc0. All other drivers which use pipe_driver_query_info (freedreno, svga and radeon) only define one group of queries. V2: - rewrite commit message Subject

Re: [Mesa-dev] [PATCH 03/16] gallium: add a group_id field to pipe_driver_query_info v2

On 07/07/2014 05:12 PM, Ilia Mirkin wrote: On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset wrote: V2: - make group_id the last field of this struct, this fixes drivers which use pipe_driver_query_info like radeon While I have no problem with this patch, how exactly would placing group_id

Re: [Mesa-dev] [PATCH 09/16] gallium: replace pipe_driver_query_info::max_value by a union

On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset wrote: > This allows to return different numeric types for queries. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/auxiliary/hud/hud_driver_query.c| 2 +- > src/gallium/drivers/freedreno/freedreno_query.c | 12 ++-- > src/gall

Re: [Mesa-dev] [PATCH 03/16] gallium: add a group_id field to pipe_driver_query_info v2

On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset wrote: > V2: > - make group_id the last field of this struct, this fixes > drivers which use pipe_driver_query_info like radeon While I have no problem with this patch, how exactly would placing group_id at some other locatoin break radeon? I be

Re: [Mesa-dev] [PATCH 04/16] gallium: use of pipe_driver_query_info::group_id v2

On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset wrote: > This adds two groups of queries for nvc0. All other drivers > which use pipe_driver_query_info (freedreno, svga and radeon) > only define one group of queries. > > V2: > - rewrite commit message Subject should just be nvc0 right? > > Sig

[Mesa-dev] [v2 PATCH 11/16] glsl: Optimize clamp(x, b, 1.0), where b > 0.0 as max(saturate(x), b)

v2: - Output max(saturate(x),b) instead of saturate(max(x,b)) - Make sure we do component-wise comparison for vectors (Ian Romanick) Signed-off-by: Abdiel Janulgue --- src/glsl/opt_algebraic.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/sr

[Mesa-dev] [v2 PATCH 16/16] i965/vec4: Remove try_emit_saturate

Now that saturate is implemented natively as an instruction, we can cut down on unneeded functionality. Reviewed-by: Matt Turner Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_vec4.h | 1 - src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 21 - 2

[Mesa-dev] [v2 PATCH 15/16] i965/fs: Remove try_emit_saturate

Now that saturate is implemented natively as instruction, we can cut down on unneeded functionality. Reviewed-by: Matt Turner Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_fs.h | 1 - src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 37 2

[Mesa-dev] Clamp/saturate optimizations V2

V2 of clamp/saturate optimizations This patch series add the plumbing to support the GLSL IR instruction saturate(). Previously, saturate is implemented as min/max instructions. Most GPUs, however, can probably perform saturate for free. With these changes, we can allow saturate to be optimized

[Mesa-dev] [v2 PATCH 14/16] ir_to_mesa, glsl_to_tgsi: Remove try_emit_saturate

Now that saturate is implemented natively as instruction, we can cut down on unneeded functionality. Signed-off-by: Abdiel Janulgue --- src/mesa/program/ir_to_mesa.cpp| 48 src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 51 -- 2

[Mesa-dev] [v2 PATCH 06/16] i965/fs: Add support for ir_unop_saturate

Reviewed-by: Matt Turner Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 1 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 2 files changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp

[Mesa-dev] [v2 PATCH 07/16] i965/vec4: Add support for ir_unop_saturate

Reviewed-by: Matt Turner Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index 65eb2da..68151fe 100644 --- a/

[Mesa-dev] [v2 PATCH 04/16] ir_to_mesa, glsl_to_tgsi: lower ir_unop_saturate

Needed when vertex programs doesn't allow saturate Reviewed-by: Matt Turner Signed-off-by: Abdiel Janulgue --- src/mesa/program/ir_to_mesa.cpp| 5 - src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/mesa/pro

[Mesa-dev] [v2 PATCH 01/16] glsl: Add ir_unop_saturate

Signed-off-by: Abdiel Janulgue --- src/glsl/ir.cpp | 2 ++ src/glsl/ir.h| 1 + src/glsl/ir_validate.cpp | 1 + 3 files changed, 4 insertions(+) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index 1d8bb6e..4a6e8e3 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@ -250,6

[Mesa-dev] [v2 PATCH 08/16] glsl: Implement saturate as ir_unop_saturate

Now that we have the ir_unop_saturate implemented as a single instruction, generate the correct simplified expression. Reviewed-by: Matt Turner Signed-off-by: Abdiel Janulgue --- src/glsl/ir_builder.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/glsl/ir_builder

[Mesa-dev] [v2 PATCH 13/16] i965/vec4: Allow propagation of instructions with saturate flag to sel

When sel conditon is bounded within 0 and 1.0. This allows code as: mov.sat a b sel.ge dst a 0.25F To be propagated as: sel.ge.sat dst b 0.25F Signed-off-by: Abdiel Janulgue --- .../drivers/dri/i965/brw_vec4_copy_propagation.cpp | 75 ++ 1 file chang

[Mesa-dev] [v2 PATCH 10/16] glsl: Optimize clamp(x, 0.0, b), where b < 1.0 as min(saturate(x), b)

v2: - Output min(saturate(x),b) instead of saturate(min(x,b)) suggested by Ilia Mirkin - Make sure we do component-wise comparison for vectors (Ian Romanick) Signed-off-by: Abdiel Janulgue --- src/glsl/opt_algebraic.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gls

[Mesa-dev] [v2 PATCH 09/16] glsl: Optimize clamp(x, 0, 1) as saturate(x)

v2: Check that the base type is float (Ian Romanick) Signed-off-by: Abdiel Janulgue --- src/glsl/opt_algebraic.cpp | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index ac7514a..2ad561c 100644 --- a/s

[Mesa-dev] [v2 PATCH 12/16] i965/fs: Allow propagation of instructions with saturate flag to sel

When sel conditon is bounded within 0 and 1.0. This allows code as: mov.sat a b sel.ge dst a 0.25F To be propagated as: sel.ge.sat dst b 0.25F Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 18 +- 1 file change

[Mesa-dev] [v2 PATCH 05/16] ir_to_mesa, glsl_to_tgsi: Add support for ir_unop_saturate

Reviewed-by: Matt Turner Signed-off-by: Abdiel Janulgue --- src/mesa/program/ir_to_mesa.cpp| 6 ++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 ++ 2 files changed, 12 insertions(+) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index e592f4

[Mesa-dev] [v2 PATCH 02/16] glsl: Add constant evaluation of ir_unop_saturate

v2: Use CLAMP macro (Ian Romanick) Signed-off-by: Abdiel Janulgue --- src/glsl/ir_constant_expression.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp index 7f83eb1..6813180 100644 --- a/src/glsl/ir_constant_

[Mesa-dev] [v2 PATCH 03/16] glsl: Add a pass to lower ir_unop_saturate to clamp(x, 0, 1)

Signed-off-by: Abdiel Janulgue --- src/glsl/ir_optimization.h | 1 + src/glsl/lower_instructions.cpp | 29 + 2 files changed, 30 insertions(+) diff --git a/src/glsl/ir_optimization.h b/src/glsl/ir_optimization.h index b83c225..1c6f72b 100644 --- a/src/glsl/ir_op

[Mesa-dev] [PATCH 02/16] gallium: add pipe_context::get_driver_query_group_info

This will be used to sort counters per group for GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_defines.h | 7 +++ src/gallium/include/pipe/p_screen.h | 11 +++ 2 files changed, 18 insertions(+) diff --git a/src/gallium/include/pipe/p_def

[Mesa-dev] [PATCH 08/16] nvc0: implement pipe_context::get_driver_query_group_info

This adds two groups of queries. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 52 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 ++ 3 files changed, 56 insertions(+) di

[Mesa-dev] GL_AMD_performance_monitor v2

Hello, This is the second version of GL_AMD_performance_monitor. V2 (global changes): - Fix radeon as pinpointd by Marek. - Implement pipe_driver_query_group_info for svga, radeon and freedreno GL_AMD_performance_monitor is now available for nvc0, svga, freedreno and radeon. Thanks in advanc

[Mesa-dev] [PATCH 04/16] gallium: use of pipe_driver_query_info::group_id v2

This adds two groups of queries for nvc0. All other drivers which use pipe_driver_query_info (freedreno, svga and radeon) only define one group of queries. V2: - rewrite commit message Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 4 src/gallium/drive

[Mesa-dev] [PATCH 12/16] gallium: Add a f32 field to pipe_query_result

This will be used for the GL_FLOAT counter type of AMD_performance_monitor. Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_defines.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index db5c9bf..6

[Mesa-dev] [PATCH 06/16] freedreno: implement pipe_context::get_driver_query_group_info

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/freedreno/freedreno_query.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/drivers/freedreno/freedreno_query.c b/src/gallium/drivers/freedreno/freedreno_query.c index cb3b49a..5dbac94 100644 --- a/src/ga

[Mesa-dev] [PATCH 11/16] nvc0: use of new counter types

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index 3e8c90b..2ce4378 100644 --

[Mesa-dev] [PATCH 10/16] gallium: add is_percentage and is_float fields to pipe_driver_query_info

This will be used by GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_defines.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index 501c1e2..db5c9bf 100644 --- a/src/gall

[Mesa-dev] [PATCH 01/16] nvc0: allocate more space before a counter is configured v2

On nvc0, a counter can up to 6 sources instead of only one for nve4+. This fixes a crash when a counter uses more than one source. V2: - add the Reviewed-by Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 5 +++-- 1 file changed, 3 i

[Mesa-dev] [PATCH 05/16] svga: implement pipe_context::get_driver_query_group_info

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/svga/svga_screen.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index b213b04..5621271 100644 --- a/src/gallium/drivers/svga/svga_s

[Mesa-dev] [PATCH 07/16] radeon: implement pipe_context::get_driver_query_group_info

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_pipe_common.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index 46e8a79..43d86a4 100644 --- a/src/gallium/

[Mesa-dev] [PATCH 14/16] nvc0: make begin_query return false when all MP counters are used v2

V2: - do not return immediately after nvc0_mp_pm_query_end() in order to set the current state of the given query Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/gallium/drive

[Mesa-dev] [PATCH 15/16] [RFC] mesa/st: implement GL_AMD_performance_monitor v3

From: Christoph Bumiller This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) V2: (Samuel Pitoiset) - Fix compilation - Improve the original code - Rewrite some parts of the original code V3: - Do not use pipe_driver_query

[Mesa-dev] [PATCH 16/16] [RFC] mesa/st: enable GL_AMD_performance_monitor

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 4207cb6..25042fb 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/

[Mesa-dev] [PATCH 09/16] gallium: replace pipe_driver_query_info::max_value by a union

This allows to return different numeric types for queries. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/hud/hud_driver_query.c| 2 +- src/gallium/drivers/freedreno/freedreno_query.c | 12 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 8 src/gallium/dri

[Mesa-dev] [PATCH 13/16] gallium: make pipe_context::begin_query return a boolean

This can be used to check if a query is unable to start. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/freedreno/freedreno_query.c| 4 ++-- src/gallium/drivers/freedreno/freedreno_query.h| 2 +- src/gallium/drivers/freedreno/freedreno_query_hw.c | 3 ++- src/gallium/drivers/f

[Mesa-dev] [PATCH 03/16] gallium: add a group_id field to pipe_driver_query_info v2

V2: - make group_id the last field of this struct, this fixes drivers which use pipe_driver_query_info like radeon Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/inc

[Mesa-dev] Mesa-dev Patch: Binding Atomic Buffers to mesa

Hi, In src/mesa/main, the bindings for atomic buffers are made to mesa_init_buffers, mesa_free_buffers, mesa_deletebuffers. Here are the two commits made on Jul 07 2014. https://github.com/adityaatluri/mesa/commits/master -- Regards, *Aditya Atluri,* *USA.* __

Re: [Mesa-dev] [PATCH 1/2] meta: Add a state flag for the GL_DITHER

"Pohjolainen, Topi" writes: > All the other state flags considered in _mesa_meta_begin() are > explicitly set as disabled. And having noticed that you > unconditionally disable dithering also in cleartexsubimage_using_fbo() > I'm wondering if I'm missing something. My understanding is that _mesa

Re: [Mesa-dev] [PATCH v3 2/2] meta: Add a meta implementation of GL_ARB_clear_texture

"Pohjolainen, Topi" writes: > Here in this function you use glClearBuffer*() and later on in > cleartexsubimage_depth_stencil() you use _mesa_ClearBuffer*() - I > would switch to the latter here also. Ah, whoops, yes, sorry about that. I'll fix it up in the Git branch. Thanks again for the revi

Re: [Mesa-dev] [PATCH 06/11] gallium: add new counter types to pipe_driver_query_info

On 07/06/2014 01:39 PM, Marek Olšák wrote: The same as patch 3 - this will break radeon. Marek Thanks for your reviews, I'll fix the radeon part. On Sat, Jul 5, 2014 at 8:49 PM, Samuel Pitoiset wrote: This will be used by GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset --- sr

Re: [Mesa-dev] GL_AMD_performance_monitor for Nouveau

On 07/05/2014 07:18 PM, Ilia Mirkin wrote: On Sat, Jul 5, 2014 at 2:49 PM, Samuel Pitoiset wrote: Hi, As part of my Google Summer of Code 2014, I implemented GL_AMD_performance_monitor for Nouveau using the state tracker of Gallium. Currently, only MP counters for NVC0+ (fermi) are exposed th

Re: [Mesa-dev] [PATCH v3 2/2] meta: Add a meta implementation of GL_ARB_clear_texture

On Fri, Jul 04, 2014 at 05:26:44PM +0100, Neil Roberts wrote: > Here is version 3 of the glClearTexImage implementation. I figured out > I could avoid the whole issue of preserving the glClearColor state by > using glClearBuffer instead of glClear. I think the patch is a lot > neater this way. I l

Re: [Mesa-dev] [PATCH 1/2] meta: Add a state flag for the GL_DITHER

On Fri, Jul 04, 2014 at 05:26:43PM +0100, Neil Roberts wrote: > The Meta implementation of glClearTexSubImage is going to want to ensure that > dithering is disabled so that it can get a consistent color across the whole > texture when clearing. This adds a state flag to easily save it and set it t