Re: [Mesa-dev] meson build for etnaviv and imx

2017-10-20 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 04:04:09PM -0700, Dylan Baker wrote: > This is all pretty straight-forward, it builds on my system, but I don't have > any actual hardware to test on. > > Christian and/or Wladimir, could one of you build this and do some kind of > testing to ensure it works? Sure, if you

Re: [Mesa-dev] [PATCH 1/8] mesa: handle OES_texture_half_float formats in _mesa_base_tex_format()

2017-10-20 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:21PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner > --- > src/mesa/main/glformats.c | 19 +++ > 1 file changed, 19 insertions(+) Reviewed-by: Wladimir J. van der Laan (as far as I'm qualified to review this code) > > diff --

Re: [Mesa-dev] [PATCH v2 23/32] mesa/glsl: add api_enabled flag to gl_transform_feedback_info

2017-10-20 Thread Timothy Arceri
On 21/10/17 10:14, Jason Ekstrand wrote: On Wed, Oct 18, 2017 at 10:32 PM, Jordan Justen mailto:jordan.l.jus...@intel.com>> wrote: From: Timothy Arceri mailto:timothy.arc...@collabora.com>> This will be used to disable the shader cache when xfb is enabled via the api as we don't

Re: [Mesa-dev] [PATCH 7/8] etnaviv: add float formats

2017-10-20 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:27PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan Optional suggestions inline. > --- > src/gallium/drivers/etnaviv/etnaviv_format.c | 22 +- > 1 file changed, 17 insertions(+), 5 dele

Re: [Mesa-dev] [PATCH 6/8] etnaviv: expose float formats only if GPU supports it

2017-10-20 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:26PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_scr

Re: [Mesa-dev] [PATCH 5/8] etnaviv: handle 8 byte block in tiling

2017-10-20 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:25PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_tiling.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers

Re: [Mesa-dev] [PATCH 3/8] etnaviv: update RS_FORMAT_MASK to include extended formats

2017-10-20 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:23PM +0200, Christian Gmeiner wrote: > Also update RS_FORMAT_RB_SWAP. > > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_format.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [Mesa-dev] [PATCH 2/8] etnaviv: HALTI0 indicates extended PE formats

2017-10-20 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:22PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan Verified that HALTI0 has PE TEXTURE_FORMAT_EXT by looking at GC2000 blob replays. > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 18 +

Re: [Mesa-dev] [PATCH 8/8] etnaviv: fix rs blit for formats with blocksize of 8

2017-10-20 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:28PM +0200, Christian Gmeiner wrote: > Fixes piglit/bin/oes_texture_float half > > Signed-off-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_translate.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/drivers/etnaviv/etnavi

Re: [Mesa-dev] [PATCH 4/8] etnaviv: add support for extended PE formats

2017-10-20 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:24PM +0200, Christian Gmeiner wrote: > Use the extended format if an such a format was passed. > > Signed-off-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_state.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Kenneth Graunke
On Friday, October 20, 2017 6:52:11 PM PDT Jordan Justen wrote: > I'm now doubting the uninitialized padding explanation. I tried the > memset in the glsl_struct_field constructor as Ken mentioned, but I > also tried adding initializers for the fields in the default > constructor, and it fixed valg

Re: [Mesa-dev] [PATCH v2 31/32] i965: Initialize disk shader cache if MESA_GLSL_CACHE_DISABLE is false

2017-10-20 Thread Matt Turner
On Wed, Oct 18, 2017 at 10:32 PM, Jordan Justen wrote: > Double negative FTW! > > For now, the shader cache is disabled by default on i965 to allow us > to verify its stability. > > In other words, to enable the shader cache on i965, set > MESA_GLSL_CACHE_DISABLE to false or 0. If the variable is

Re: [Mesa-dev] [PATCH v2 32/32] disk_cache: Add support for MESA_GLSL_CACHE_TIMESTAMP in debug builds

2017-10-20 Thread Jordan Justen
On 2017-10-20 16:24:54, Jason Ekstrand wrote: > On Thu, Oct 19, 2017 at 3:25 PM, Timothy Arceri > wrote: > > > Maybe add to docs? > > > > I'm not sure how I feel about that. I'm scared to death of options like > this becoming something some random user on the internet decides they > should use

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Ilia Mirkin
On Fri, Oct 20, 2017 at 9:52 PM, Jordan Justen wrote: > On 2017-10-20 14:14:25, Jason Ekstrand wrote: >> On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke >> wrote: >> >> > On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: >> > > Signed-off-by: Jordan Justen >> > > --- >> > > s

Re: [Mesa-dev] [PATCH] radv: Fix pipeline cache locking issues

2017-10-20 Thread Bas Nieuwenhuizen
For radv_create_shader_variants_from_pipeline_cache I'm not really sure why this would cause corruption. Yes we might create the variants a few times too much, but that should not cause any corruption. Either way, it is a fix, so Reviewed-by: Bas Nieuwenhuizen and pushed. Thanks. On Thu, Oct 19

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Jordan Justen
On 2017-10-20 14:14:25, Jason Ekstrand wrote: > On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke > wrote: > > > On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: > > > Signed-off-by: Jordan Justen > > > --- > > > src/compiler/glsl/builtin_variables.cpp | 1 + > > > 1 file chan

Re: [Mesa-dev] [PATCH v2] egl/wayland: Support for KHR_partial_update

2017-10-20 Thread Harish Krupo
Hi Emil, Emil Velikov writes: > On 20 October 2017 at 12:35, Harish Krupo wrote: > >> + else if (!n_rects || !try_damage_buffer(dri2_surf, rects, n_rects)) >>wl_surface_damage(dri2_surf->wl_surface_wrapper, >> 0, 0, INT32_MAX, INT32_MAX); >> > Please add a com

[Mesa-dev] [PATCH 1/2] ac/nir: Take the max workgroup size of all provided shaders.

2017-10-20 Thread Bas Nieuwenhuizen
Fixes: ffaf4d608a1 'radv: Enable tessellation shaders for GFX9.' --- src/amd/common/ac_nir_to_llvm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 61ffe91eafd..02420f46966 100644 --- a/src/amd/comm

[Mesa-dev] [PATCH 2/2] ac/nir: Set larged wrokgroup size for GS on GFX9.

2017-10-20 Thread Bas Nieuwenhuizen
They don't take a single wave anymore and we need the barriers. Fixes: 6bc42855f92 'radv: enable GS on GFX9' --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 02420f46966.

[Mesa-dev] [PATCH 1/3] automake: Remove unused include path

2017-10-20 Thread Dylan Baker
Signed-off-by: Dylan Baker --- src/egl/wayland/wayland-drm/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/egl/wayland/wayland-drm/Makefile.am b/src/egl/wayland/wayland-drm/Makefile.am index b27edddafb1..57782da936d 100644 --- a/src/egl/wayland/wayland-drm/M

[Mesa-dev] [PATCH 3/3] Move src/eg/wayland/wayland-drm into src/wsi

2017-10-20 Thread Dylan Baker
Nothing in wayand-drm is EGL specific, parts of the directory are used by EGL, parts by GBM, and parts by vulkan wsi, so it makes sense to move that into it's own directory. src/wsi was chosen because there's a lot of wsi code in mesa that could be moved here, vulkan/wsi, EGL, GBM, and GLX could al

[Mesa-dev] [PATCH 2/3] gbm: Don't traverse backwards for includes

2017-10-20 Thread Dylan Baker
This is just a terrible idea, but it also needs to be fixed for the next patch to work, so let's fix it right. Signed-off-by: Dylan Baker --- src/gbm/Makefile.am| 4 +++- src/gbm/backends/dri/gbm_dri.c | 2 +- src/gbm/meson.build| 6 +++--- 3 files changed, 7 insertions(+

[Mesa-dev] create src/wsi

2017-10-20 Thread Dylan Baker
This very short series creates a new src/wsi folder, and moves wayland-drm into it. Basically wsi stuff is scattered about, and is needed by multiple components within mesa, wayland-drm, for example, is used by EGL, GBM, and vulkan wayland-wsi. I think there's more that could be moved into wsi, we

[Mesa-dev] [PATCH] meson: fix egl build for meson version < 0.43

2017-10-20 Thread Dylan Baker
Meson 0.43 added the ability to pass nested lists to include_directories, so the code that we have works for 0.43, but not for 0.42. This patch changes the include_directories list to be flat so it works with 0.42 fixes: 108d257a16859898f5c ("meson: build libEGL") Signed-off-by: Dylan Baker ---

Re: [Mesa-dev] [PATCH] meson: bump libdrm_amdgpu requirement to 2.4.85

2017-10-20 Thread Bas Nieuwenhuizen
woops, r-b. Thanks. On Sat, Oct 21, 2017 at 1:30 AM, Dylan Baker wrote: > fixes: b60372570323243ec73 ("configure.ac: Bump libdrm_amdgpu version to > 2.4.85.") > cc: Bas Nieuwenhuizen > Signed-off-by: Dylan Baker > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [Mesa-dev] [PATCH] meson: bump libdrm_amdgpu requirement to 2.4.85

2017-10-20 Thread Eric Anholt
Dylan Baker writes: > fixes: b60372570323243ec73 ("configure.ac: Bump libdrm_amdgpu version to > 2.4.85.") > cc: Bas Nieuwenhuizen > Signed-off-by: Dylan Baker r-b signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.f

Re: [Mesa-dev] [PATCH 2/2] nir: Print the components referenced for split or packed shader in/outs.

2017-10-20 Thread Eric Anholt
Timothy Arceri writes: > On 20/10/17 20:52, Timothy Arceri wrote: >> >> >> On 20/10/17 17:33, Timothy Arceri wrote: >>> On 18/10/17 07:52, Eric Anholt wrote: Having 4 variables all called "gl_in_TexCoord0@n" isn't very informative, much better to see: decl_var shader_i

Re: [Mesa-dev] [PATCH v2 18/32] i965: add initial implementation of on disk shader cache

2017-10-20 Thread Jason Ekstrand
I've got a meta-comment and then a couple more inline comments below before I sign-off for the week-end. Most of my comments on this patch have focussed towards two goals: 1) As close to perfect paridy between read_program_data and write_program_data as we can manage. They should be almost iden

[Mesa-dev] [PATCH] meson: bump libdrm_amdgpu requirement to 2.4.85

2017-10-20 Thread Dylan Baker
fixes: b60372570323243ec73 ("configure.ac: Bump libdrm_amdgpu version to 2.4.85.") cc: Bas Nieuwenhuizen Signed-off-by: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 82c4d2ed12c..6b11a5d3103 100644 --- a/meson.bui

Re: [Mesa-dev] [PATCH v2 18/32] i965: add initial implementation of on disk shader cache

2017-10-20 Thread Jason Ekstrand
On Fri, Oct 20, 2017 at 4:05 PM, Jason Ekstrand wrote: > On Wed, Oct 18, 2017 at 10:32 PM, Jordan Justen > wrote: > >> From: Timothy Arceri >> >> This uses the recently-added disk_cache.c to write out the final >> linked binary for vertex and fragment shader programs. >> >> This is based off th

Re: [Mesa-dev] [PATCH v2 00/32] i965 disk shader cache

2017-10-20 Thread Jason Ekstrand
Over-all, I'm very happy with the way this turned out. Good work to all involved! I made a few comments here and there and a pile on patch 18. That said, I think they should all be fairly easy to resolve and, should Emil be willing to hold off on branching for a couple of days, think this should

Re: [Mesa-dev] [PATCH v2 32/32] disk_cache: Add support for MESA_GLSL_CACHE_TIMESTAMP in debug builds

2017-10-20 Thread Jason Ekstrand
On Thu, Oct 19, 2017 at 3:25 PM, Timothy Arceri wrote: > Maybe add to docs? > I'm not sure how I feel about that. I'm scared to death of options like this becoming something some random user on the internet decides they should use because it keeps the pre-populated shader cache they downloaded

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Jason Ekstrand
On Fri, Oct 20, 2017 at 4:14 PM, Kenneth Graunke wrote: > On Friday, October 20, 2017 4:11:20 PM PDT Kenneth Graunke wrote: > > On Friday, October 20, 2017 2:14:25 PM PDT Jason Ekstrand wrote: > > > On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke < > kenn...@whitecape.org> > > > wrote: > > > > >

Re: [Mesa-dev] [PATCH v2 23/32] mesa/glsl: add api_enabled flag to gl_transform_feedback_info

2017-10-20 Thread Jason Ekstrand
On Wed, Oct 18, 2017 at 10:32 PM, Jordan Justen wrote: > From: Timothy Arceri > > This will be used to disable the shader cache when xfb is enabled > via the api as we don't currently allow for it when generating the > sha for the shader. > --- > src/compiler/glsl/link_varyings.cpp | 5 - >

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Kenneth Graunke
On Friday, October 20, 2017 4:11:20 PM PDT Kenneth Graunke wrote: > On Friday, October 20, 2017 2:14:25 PM PDT Jason Ekstrand wrote: > > On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke > > wrote: > > > > > On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: > > > > Signed-off-by:

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Kenneth Graunke
On Friday, October 20, 2017 2:14:25 PM PDT Jason Ekstrand wrote: > On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke > wrote: > > > On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: > > > Signed-off-by: Jordan Justen > > > --- > > > src/compiler/glsl/builtin_variables.cpp | 1 +

Re: [Mesa-dev] [PATCH v2 18/32] i965: add initial implementation of on disk shader cache

2017-10-20 Thread Jason Ekstrand
On Wed, Oct 18, 2017 at 10:32 PM, Jordan Justen wrote: > From: Timothy Arceri > > This uses the recently-added disk_cache.c to write out the final > linked binary for vertex and fragment shader programs. > > This is based off the initial implementation done by Carl Worth. > > v2: > * Squash 'i9

[Mesa-dev] meson build for etnaviv and imx

2017-10-20 Thread Dylan Baker
This is all pretty straight-forward, it builds on my system, but I don't have any actual hardware to test on. Christian and/or Wladimir, could one of you build this and do some kind of testing to ensure it works? ___ mesa-dev mailing list mesa-dev@lists

[Mesa-dev] [PATCH 1/2] meson: build etnaviv driver + winsys

2017-10-20 Thread Dylan Baker
Build tested only. Signed-off-by: Dylan Baker --- meson.build| 6 ++ meson_options.txt | 2 +- src/gallium/drivers/etnaviv/meson.build| 96 ++ src/gallium/meson.build| 7 ++- src/galli

[Mesa-dev] [PATCH 2/2] meson: build imx driver

2017-10-20 Thread Dylan Baker
This is build tested only. Signed-off-by: Dylan Baker --- meson.build| 5 + meson_options.txt | 2 +- src/gallium/meson.build| 3 +++ src/gallium/targets/dri/meson.build| 5 + src/gallium/winsys/imx/drm/meson.build

[Mesa-dev] [PATCH 2/2] radv: disable implicit sync for radv allocated bos v2

2017-10-20 Thread Andres Rodriguez
Implicit sync kicks in when a buffer is used by two different amdgpu contexts simultaneously. Jobs that use explicit synchronization mechanisms end up needlessly waiting to be scheduled for long periods of time in order to achieve serialized execution. This patch disables implicit synchronization

[Mesa-dev] [PATCH 1/2] radv: factor out radv_alloc_memory

2017-10-20 Thread Andres Rodriguez
This allows us to pass extra parameters to the memory allocation operation that are not defined in the vulkan spec. This is useful for internal usage. Signed-off-by: Andres Rodriguez --- src/amd/vulkan/radv_device.c | 19 ++- src/amd/vulkan/radv_private.h | 11 +++ 2 fil

[Mesa-dev] [PATCH 0/2] Use explicit sync for non-dri BOs

2017-10-20 Thread Andres Rodriguez
Currently, implicit synchronization of jobs that access a shared bo is always enabled. Currently this behaviour is required for DRI use cases, where the protocol doesn't provide a mechanism to share a synchronization primitive alongside the surface. This patch selectively disables implicit synchr

Re: [Mesa-dev] [PATCH v2 17/32] intel/compiler: add new field for storing program size

2017-10-20 Thread Jason Ekstrand
I've looked at this patch and I think it's correct. I'd like to see how it's used before I pass any judgements on whether or not I like it. If we are going to go this direction, I'd like to see some follow-up that deletes the final_assembly_size parameter from all of the brw_compile_* functions.

Re: [Mesa-dev] [PATCH v2 13/32] main: Add nir serialization fields to gl_program

2017-10-20 Thread Jason Ekstrand
On Wed, Oct 18, 2017 at 10:32 PM, Jordan Justen wrote: > These fields can be used to optionally save off a nir serialized form > of the program. > > Signed-off-by: Jordan Justen > --- > src/mesa/main/mtypes.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/main/mtypes.h b/sr

Re: [Mesa-dev] [PATCH v2 11/32] nir: add serialization and deserialization

2017-10-20 Thread Jordan Justen
On 2017-10-18 22:31:59, Jordan Justen wrote: > From: Connor Abbott > > diff --git a/src/compiler/nir/nir_serialize.c > b/src/compiler/nir/nir_serialize.c > new file mode 100644 > index 00..fb6232446b > --- /dev/null > +++ b/src/compiler/nir/nir_serialize.c > +static void > +read_instr(r

[Mesa-dev] [PATCH 6/6] radv: Expose VK_EXT_global_priority

2017-10-20 Thread Andres Rodriguez
Expose the extension string as supported Signed-off-by: Andres Rodriguez --- src/amd/common/ac_gpu_info.c | 1 + src/amd/common/ac_gpu_info.h | 1 + src/amd/vulkan/radv_device.c | 2 ++ src/amd/vulkan/radv_extensions.py | 1 + 4 files changed, 5 insertions(+) diff --git a/src/amd

[Mesa-dev] [PATCH 0/6] radv: enable VK_EXT_global_priority v2

2017-10-20 Thread Andres Rodriguez
Changes in v1: * Separate radeonsi and radv WAVE_LIMIT patches * Check kernel version and expose extension string * Include an optimization patch This series enables VK_EXT_global_priority for radv. This extension is used to allocate queues that can provide latency guarantees even when the

[Mesa-dev] [PATCH 1/6] vulkan: update headers & registry to VK 1.0.63

2017-10-20 Thread Andres Rodriguez
Signed-off-by: Andres Rodriguez --- include/vulkan/vulkan.h| 35 +- src/vulkan/registry/vk.xml | 264 ++--- 2 files changed, 213 insertions(+), 86 deletions(-) diff --git a/include/vulkan/vulkan.h b/include/vulkan/vulkan.h index b19c1ef..e1398c6 1

[Mesa-dev] [PATCH 5/6] radv: don't skip PS/VS partial flush

2017-10-20 Thread Andres Rodriguez
This patch helps lower high priority compute latency. Found by bisecting a perf regression on computeparticles with high priority compute queues enabled. Reverting this micro-optimization doesn't seem to have any negative effect on performance on Dota2 or ssao. Signed-off-by: Andres Rodriguez --

[Mesa-dev] [PATCH 4/6] radv: Implement VK_EXT_global_priority

2017-10-20 Thread Andres Rodriguez
This extension allows the caller to change a queue's system wide priority. This is useful for applications with specific latency constraints. Signed-off-by: Andres Rodriguez --- src/amd/vulkan/radv_device.c | 32 --- src/amd/vulkan/radv_private.h

[Mesa-dev] [PATCH 3/6] radeonsi: hardcode shader WAVE_LIMIT to the maximum value

2017-10-20 Thread Andres Rodriguez
This is part of a cooperative scheduling approach used by radv. All drivers in the stack must opt-in to resource arbitration, otherwise GL based apps will be able to ignore system priorities. We always hardcode the field to its maximum value, instead of attempting to calculate an approximate usage

[Mesa-dev] [PATCH 2/6] radv: hardcode shader WAVE_LIMIT to the maximum value

2017-10-20 Thread Andres Rodriguez
When WAVE_LIMIT is set, a submission will opt-in for SPI based resource scheduling. Because this mechanism is cooperative, we must ensure that all submissions have this field set, otherwise they will bypass resource arbitration. We always hardcode the field to its maximum value, instead of attempt

Re: [Mesa-dev] [PATCH v2 11/32] nir: add serialization and deserialization

2017-10-20 Thread Jason Ekstrand
I left a few notes but have *not* reviewed this. I would feel much more comfortable landing it someone went through and verified two things by hand: 1) We actually fill out all of the data structure fields (clearly things like uses and defs are filled our by core NIR automatically) 2) We get th

Re: [Mesa-dev] [PATCH] i965: Add align1 ternary instruction-word support

2017-10-20 Thread Matt Turner
On Fri, Oct 20, 2017 at 1:32 PM, Scott D Phillips wrote: > Matt Turner writes: > >> Reviewed-by: Scott D Phillips >> --- >> src/intel/compiler/brw_inst.h | 108 >> ++ >> 1 file changed, 108 insertions(+) >> >> diff --git a/src/intel/compiler/brw_inst.h b

Re: [Mesa-dev] [PATCH] i965: Add align1 ternary instruction emission support

2017-10-20 Thread Matt Turner
On Fri, Oct 20, 2017 at 1:42 PM, Scott D Phillips wrote: > Matt Turner writes: > >> --- >> src/intel/compiler/brw_eu_emit.c | 219 >> +-- >> 1 file changed, 166 insertions(+), 53 deletions(-) >> >> diff --git a/src/intel/compiler/brw_eu_emit.c >> b/src/intel

[Mesa-dev] [PATCH] configure: Allow android as an EGL platform

2017-10-20 Thread Benjamin Gordon
I'm working on radeonsi support in the Chrome OS Android container (ARC++). Mesa in ARC++ uses autotools instead of Android.mk, but all the necessary EGL bits are there, so the existing check is too strict. Signed-off-by: Benjamin Gordon --- configure.ac | 3 ++- 1 file changed, 2 insertions(+)

Re: [Mesa-dev] [PATCH v2 10/32] glsl_to_nir: Zero nir_constant in constant_copy for valgrind & nir_serialize

2017-10-20 Thread Jason Ekstrand
In general, I agree with Ken. :) 1-4 and 6-10, except for the ones written by me, are Reviewed-by: Jason Ekstrand On Thu, Oct 19, 2017 at 2:47 PM, Timothy Arceri wrote: > 5-10: > > Reviewed-by: Timothy Arceri > > ___ > mesa-dev mailing list > mesa-

Re: [Mesa-dev] [PATCH 1/3] vulkan: update headers & registry to VK 1.0.63

2017-10-20 Thread Jason Ekstrand
Acked-by: Jason Ekstrand On Fri, Oct 20, 2017 at 1:34 PM, Andres Rodriguez wrote: > Signed-off-by: Andres Rodriguez > --- > include/vulkan/vulkan.h| 35 +- > src/vulkan/registry/vk.xml | 264 ++ > --- > 2 files changed, 213 insertions(+), 86 de

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Jason Ekstrand
On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke wrote: > On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/compiler/glsl/builtin_variables.cpp | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/compiler/glsl/bui

Re: [Mesa-dev] [PATCH] anv: disable depth pma fix on Gen > 9

2017-10-20 Thread Kenneth Graunke
On Friday, October 20, 2017 10:33:39 AM PDT Lionel Landwerlin wrote: > This workaround isn't listed on Gen10. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/gen8_cmd_buffer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/intel/vulkan/gen8_cmd_buffer.c > b/src/in

Re: [Mesa-dev] [PATCH] i965: Add align1 ternary instruction emission support

2017-10-20 Thread Scott D Phillips
Matt Turner writes: > --- > src/intel/compiler/brw_eu_emit.c | 219 > +-- > 1 file changed, 166 insertions(+), 53 deletions(-) > > diff --git a/src/intel/compiler/brw_eu_emit.c > b/src/intel/compiler/brw_eu_emit.c > index 7495a19fd8..4f98860044 100644 > ---

[Mesa-dev] [PATCH 3/3] radv: Implement VK_EXT_global_priority

2017-10-20 Thread Andres Rodriguez
This extension allows the caller to change a queue's system wide priority. This is useful for applications with specific latency constraints. Signed-off-by: Andres Rodriguez --- src/amd/vulkan/radv_device.c | 32 --- src/amd/vulkan/radv_private.h

[Mesa-dev] [PATCH 1/3] vulkan: update headers & registry to VK 1.0.63

2017-10-20 Thread Andres Rodriguez
Signed-off-by: Andres Rodriguez --- include/vulkan/vulkan.h| 35 +- src/vulkan/registry/vk.xml | 264 ++--- 2 files changed, 213 insertions(+), 86 deletions(-) diff --git a/include/vulkan/vulkan.h b/include/vulkan/vulkan.h index b19c1ef..e1398c6 1

[Mesa-dev] [PATCH 2/3] radv: hardcode shader WAVE_LIMIT to the maximum value

2017-10-20 Thread Andres Rodriguez
When WAVE_LIMIT is set, a submission will opt-in for SPI based resource scheduling. Because this mechanism is cooperative, we must ensure that all submissions have this field set, otherwise they will bypass resource arbitration. We always hardcode the field to its maximum value, instead of attempt

[Mesa-dev] [PATCH 0/3] radv: enable VK_EXT_global_priority

2017-10-20 Thread Andres Rodriguez
This series enables VK_EXT_global_priority for radv. This extension is used to allocate queues that can provide latency guarantees even when the system is overloaded. This extension is used by the steamvr composer to generate reprojected frames when the application falls behind. A bit of dirtynes

Re: [Mesa-dev] [PATCH] i965: Add align1 ternary instruction-word support

2017-10-20 Thread Scott D Phillips
Matt Turner writes: > Reviewed-by: Scott D Phillips > --- > src/intel/compiler/brw_inst.h | 108 > ++ > 1 file changed, 108 insertions(+) > > diff --git a/src/intel/compiler/brw_inst.h b/src/intel/compiler/brw_inst.h > index 1ddee77164..40723f9012 100644

[Mesa-dev] [PATCH 6/8] etnaviv: expose float formats only if GPU supports it

2017-10-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index 0fba192284..ff52054990 100644 --- a/src/gallium/drivers/etna

[Mesa-dev] [PATCH 4/8] etnaviv: add support for extended PE formats

2017-10-20 Thread Christian Gmeiner
Use the extended format if an such a format was passed. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_state.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_state.c b/src/gallium/drivers/etnaviv/etnav

[Mesa-dev] [PATCH 1/8] mesa: handle OES_texture_half_float formats in _mesa_base_tex_format()

2017-10-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/mesa/main/glformats.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 1e797c24c2..78299aebae 100644 --- a/src/mesa/main/glformats.c +++ b/src/mesa/main/glformats.c @@ -242

[Mesa-dev] [PATCH 7/8] etnaviv: add float formats

2017-10-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_format.c b/src/gallium/drivers/etnaviv/etnaviv_format.c index 7297de3d85..a7085800aa 1

[Mesa-dev] [PATCH 8/8] etnaviv: fix rs blit for formats with blocksize of 8

2017-10-20 Thread Christian Gmeiner
Fixes piglit/bin/oes_texture_float half Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_translate.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_translate.h b/src/gallium/drivers/etnaviv/etnaviv_translate.h index 0761251a36..

[Mesa-dev] [PATCH 3/8] etnaviv: update RS_FORMAT_MASK to include extended formats

2017-10-20 Thread Christian Gmeiner
Also update RS_FORMAT_RB_SWAP. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_format.c b/src/gallium/drivers/etnaviv/etnaviv_format.c index a2e215b439..

[Mesa-dev] [PATCH 0/8] etnaviv: add OES_texture_half_float support

2017-10-20 Thread Christian Gmeiner
This patch series adds support for half-float texture support. I have the feeling that RS and PE formats differ but that needs more investigation. The last patch in this series is a result of that assumption. Nevertheless it passes piglit/bin/oes_texture_float half. Christian Gmeiner (8): mesa:

[Mesa-dev] [PATCH 2/8] etnaviv: HALTI0 indicates extended PE formats

2017-10-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index 009bc73c14..0fba192284 100644

[Mesa-dev] [PATCH 5/8] etnaviv: handle 8 byte block in tiling

2017-10-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_tiling.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_tiling.c b/src/gallium/drivers/etnaviv/etnaviv_tiling.c index f4f85c1d6e..113b39cc98 100644 --- a/src/

Re: [Mesa-dev] [PATCH 2/2] i965: Reduce the frequency of madvise calls

2017-10-20 Thread Eric Anholt
Chris Wilson writes: > We can reduce the frequency of calling madvise by only using it for > buffers that are inactive (busy buffers will be pinned by they use by the > GPU, so should not significantly add to mempressure, but will still be > reaped by our timed cache.) > > v2: Remember about APPL

Re: [Mesa-dev] [PATCH v2] egl/wayland: Support for KHR_partial_update

2017-10-20 Thread Eric Engestrom
On Friday, 2017-10-20 11:35:40 +, Harish Krupo wrote: > This passes 33/37 deqp tests related to partial_update, 4 are not > supported. Tests not supported: > dEQP-EGL.functional.negative_partial_update.not_postable_surface > dEQP-EGL.functional.negative_partial_update.not_current_surface > dEQP

Re: [Mesa-dev] [PATCH v2] anv: don't assert on device init on Cannonlake

2017-10-20 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Oct 20, 2017 at 10:51 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > v2: Warn that support is still in alpha (Jason) > > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/anv_device.c | 6 -- > 1 file changed, 4 insertions(+), 2

[Mesa-dev] [PATCH v2] anv: don't assert on device init on Cannonlake

2017-10-20 Thread Lionel Landwerlin
v2: Warn that support is still in alpha (Jason) Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index a305afebc32..67028e8da9f 100644 --- a/s

Re: [Mesa-dev] [PATCH] anv: disable depth pma fix on Gen > 9

2017-10-20 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Oct 20, 2017 at 10:33 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > This workaround isn't listed on Gen10. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/gen8_cmd_buffer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --

Re: [Mesa-dev] [PATCH] blorp: enable R32G32B32X32 blorp ccs copies

2017-10-20 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Oct 20, 2017 at 10:31 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/blorp/blorp_blit.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blor

Re: [Mesa-dev] [PATCH] anv: don't assert on device init on Cannonlake

2017-10-20 Thread Jason Ekstrand
Perhaps add a warning for CNL saying that it's still alpha --Jason On Fri, Oct 20, 2017 at 10:33 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/anv_device.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH] anv: don't assert on device init on Cannonlake

2017-10-20 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index a4ea7e33d9c..a117e119641 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulk

[Mesa-dev] [PATCH] anv: disable depth pma fix on Gen > 9

2017-10-20 Thread Lionel Landwerlin
This workaround isn't listed on Gen10. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/gen8_cmd_buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/gen8_cmd_buffer.c b/src/intel/vulkan/gen8_cmd_buffer.c index f19867ca320..751212b8f43 100644 --- a/src/intel/vulk

[Mesa-dev] [PATCH] blorp: enable R32G32B32X32 blorp ccs copies

2017-10-20 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/blorp/blorp_blit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 11c2116a758..4507046dae5 100644 --- a/src/intel/blorp/blorp_blit.c +++ b/src/intel/blorp/blorp_blit.c @@ -2206,6

Re: [Mesa-dev] [PATCH 3/3] glsl/linker: validate explicit locations for SSO programs

2017-10-20 Thread Ilia Mirkin
On Fri, Oct 20, 2017 at 12:26 PM, Timothy Arceri wrote: > > > On 21/10/17 03:00, Ilia Mirkin wrote: >> >> On Fri, Oct 20, 2017 at 11:55 AM, Timothy Arceri >> wrote: >>> >>> >>> >>> On 21/10/17 00:35, Ilia Mirkin wrote: On Fri, Oct 20, 2017 at 6:46 AM, Iago Toral Quiroga wrote

Re: [Mesa-dev] [PATCH 3/3] glsl/linker: validate explicit locations for SSO programs

2017-10-20 Thread Timothy Arceri
On 21/10/17 03:00, Ilia Mirkin wrote: On Fri, Oct 20, 2017 at 11:55 AM, Timothy Arceri wrote: On 21/10/17 00:35, Ilia Mirkin wrote: On Fri, Oct 20, 2017 at 6:46 AM, Iago Toral Quiroga wrote: --- src/compiler/glsl/link_varyings.cpp | 53 + src/co

[Mesa-dev] [PATCH] loader/dri3: Try to make sure we only process our own NotifyMSC events

2017-10-20 Thread Michel Dänzer
From: Michel Dänzer We were using a sequence counter value to wait for a specific NotifyMSC event. However, we can receive events from other clients as well, which may already be using higher sequence numbers than us. In that case, we could stop processing after an event from another client, whic

Re: [Mesa-dev] [PATCH 3/3] glsl/linker: validate explicit locations for SSO programs

2017-10-20 Thread Ilia Mirkin
On Fri, Oct 20, 2017 at 11:55 AM, Timothy Arceri wrote: > > > On 21/10/17 00:35, Ilia Mirkin wrote: >> >> On Fri, Oct 20, 2017 at 6:46 AM, Iago Toral Quiroga >> wrote: >>> >>> --- >>> src/compiler/glsl/link_varyings.cpp | 53 >>> + >>> src/compiler/glsl/link

Re: [Mesa-dev] [PATCH 3/3] glsl/linker: validate explicit locations for SSO programs

2017-10-20 Thread Timothy Arceri
On 21/10/17 00:35, Ilia Mirkin wrote: On Fri, Oct 20, 2017 at 6:46 AM, Iago Toral Quiroga wrote: --- src/compiler/glsl/link_varyings.cpp | 53 + src/compiler/glsl/link_varyings.h | 4 +++ src/compiler/glsl/linker.cpp| 6 + 3 files chang

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-20 Thread Eric Engestrom
On Wednesday, 2017-10-18 10:20:01 +, Harish Krupo wrote: > Hi Eric, > > Eric Engestrom writes: > > > On Wednesday, 2017-10-18 06:06:45 +, Harish Krupo wrote: > >> Hi Eric, > >> > >> Eric Engestrom writes: > >> > I might need to double check the spec, but I thought "no damage hint" > >>

Re: [Mesa-dev] [PATCH 3/3] glsl/linker: validate explicit locations for SSO programs

2017-10-20 Thread Ilia Mirkin
On Fri, Oct 20, 2017 at 6:46 AM, Iago Toral Quiroga wrote: > --- > src/compiler/glsl/link_varyings.cpp | 53 > + > src/compiler/glsl/link_varyings.h | 4 +++ > src/compiler/glsl/linker.cpp| 6 + > 3 files changed, 63 insertions(+) > > diff --gi

Re: [Mesa-dev] [PATCH v2] egl/wayland: Support for KHR_partial_update

2017-10-20 Thread Emil Velikov
On 20 October 2017 at 12:35, Harish Krupo wrote: > + else if (!n_rects || !try_damage_buffer(dri2_surf, rects, n_rects)) >wl_surface_damage(dri2_surf->wl_surface_wrapper, > 0, 0, INT32_MAX, INT32_MAX); > Please add a comment why SetDamageRegionCalled is honoured

[Mesa-dev] [PATCH 1/2] i965: Put freed and idle buffers to the head of the free list

2017-10-20 Thread Chris Wilson
We treat our free list as a rough bidirectional MRU, at the tail we have active buffers to be reallocated for rendering, and at the head we have the inactive buffers that we can reallocate for use by the CPU. At both ends we want the most recently used of each category to limit RSS upon reuse. At

[Mesa-dev] [PATCH 2/2] i965: Reduce the frequency of madvise calls

2017-10-20 Thread Chris Wilson
We can reduce the frequency of calling madvise by only using it for buffers that are inactive (busy buffers will be pinned by they use by the GPU, so should not significantly add to mempressure, but will still be reaped by our timed cache.) v2: Remember about APPLE_purgeable_memory that also calls

[Mesa-dev] [PATCH v2] egl/wayland: Support for KHR_partial_update

2017-10-20 Thread Harish Krupo
This passes 33/37 deqp tests related to partial_update, 4 are not supported. Tests not supported: dEQP-EGL.functional.negative_partial_update.not_postable_surface dEQP-EGL.functional.negative_partial_update.not_current_surface dEQP-EGL.functional.negative_partial_update.buffer_preserved dEQP-EGL.fu

Re: [Mesa-dev] [PATCH 3/3] glsl/linker: validate explicit locations for SSO programs

2017-10-20 Thread Iago Toral
On Fri, 2017-10-20 at 22:29 +1100, Timothy Arceri wrote: > On 20/10/17 22:15, Iago Toral wrote: > > On Fri, 2017-10-20 at 13:07 +0200, Iago Toral wrote: > > > On Fri, 2017-10-20 at 22:03 +1100, Timothy Arceri wrote: > > > > > > > > On 20/10/17 21:46, Iago Toral Quiroga wrote: > > > > > --- > > > >

Re: [Mesa-dev] [PATCH 3/3] glsl/linker: validate explicit locations for SSO programs

2017-10-20 Thread Timothy Arceri
On 20/10/17 22:15, Iago Toral wrote: On Fri, 2017-10-20 at 13:07 +0200, Iago Toral wrote: On Fri, 2017-10-20 at 22:03 +1100, Timothy Arceri wrote: On 20/10/17 21:46, Iago Toral Quiroga wrote: ---   src/compiler/glsl/link_varyings.cpp | 53 +   src/compiler

Re: [Mesa-dev] [PATCH 3/3] glsl/linker: validate explicit locations for SSO programs

2017-10-20 Thread Iago Toral
On Fri, 2017-10-20 at 13:07 +0200, Iago Toral wrote: > On Fri, 2017-10-20 at 22:03 +1100, Timothy Arceri wrote: > > > > On 20/10/17 21:46, Iago Toral Quiroga wrote: > > > --- > > >   src/compiler/glsl/link_varyings.cpp | 53 > > > + > > >   src/compiler/glsl/link

  1   2   >