On Fri, May 3, 2019 at 10:39 PM Jason Ekstrand wrote:
> On Fri, May 3, 2019 at 3:29 PM Connor Abbott wrote:
>
>> FWIW, the reason I changed it away was to keep it consistent with the
>> line directly above that uses the length (since the C array won't exist if
>> it's length 0). Does that convin
On Fri, May 3, 2019 at 3:29 PM Connor Abbott wrote:
> FWIW, the reason I changed it away was to keep it consistent with the line
> directly above that uses the length (since the C array won't exist if it's
> length 0). Does that convince you?
>
Nope. First off, if you take Dylan's suggestions (
FWIW, the reason I changed it away was to keep it consistent with the line
directly above that uses the length (since the C array won't exist if it's
length 0). Does that convince you?
On Fri, May 3, 2019 at 10:26 PM Jason Ekstrand wrote:
> On Thu, May 2, 2019 at 3:51 PM Dylan Baker wrote:
>
>>
On Thu, May 2, 2019 at 3:51 PM Dylan Baker wrote:
> Quoting Connor Abbott (2019-05-02 13:34:07)
> > Just don't emit the transform array at all if there are no transforms
> > for a state, and avoid trying to walk over it.
> > ---
> > Brian, does this build on Windows? I tested it on my shader-db
>
On 05/02/2019 02:34 PM, Connor Abbott wrote:
Just don't emit the transform array at all if there are no transforms
for a state, and avoid trying to walk over it.
---
Brian, does this build on Windows? I tested it on my shader-db
on radeonsi.
Yes, it compiles. Thanks!
Tested-by: Brian Paul
T
Quoting Connor Abbott (2019-05-02 13:34:07)
> Just don't emit the transform array at all if there are no transforms
> for a state, and avoid trying to walk over it.
> ---
> Brian, does this build on Windows? I tested it on my shader-db
> on radeonsi.
>
> ---
> src/compiler/nir/nir_algebraic.py |
Just don't emit the transform array at all if there are no transforms
for a state, and avoid trying to walk over it.
---
Brian, does this build on Windows? I tested it on my shader-db
on radeonsi.
---
src/compiler/nir/nir_algebraic.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
di