Re: [Mesa-dev] [PATCH 4/9] i965/gs: Set control data header size/format appropriately for EndPrimitive().

2013-09-10 Thread Paul Berry
On 9 September 2013 17:56, Kenneth Graunke wrote: > On 09/09/2013 08:20 AM, Paul Berry wrote: > > diff --git a/src/mesa/drivers/dri/i965/brw_defines.h > b/src/mesa/drivers/dri/i965/brw_defines.h > > index 0406c4d..6db2570 100644 > > --- a/src/mesa/drivers/dri/i965/brw_defines.h > > +++ b/src/mesa

Re: [Mesa-dev] [PATCH 4/9] i965/gs: Set control data header size/format appropriately for EndPrimitive().

2013-09-10 Thread Paul Berry
On 9 September 2013 14:30, Chris Forbes wrote: > In the commit message: > > > Fortunately, OpenGL only requires separate streams to be supported > >when the output type is points, and EndPrimitive() only has an effect > > when the input type is line_strip or triangle_strip, so it's not a... > > S

Re: [Mesa-dev] [PATCH 4/9] i965/gs: Set control data header size/format appropriately for EndPrimitive().

2013-09-09 Thread Kenneth Graunke
On 09/09/2013 08:20 AM, Paul Berry wrote: > The gen7 geometry shader uses a "control data header" at the beginning > of the output URB entry to store either > > (a) flag bits (1 bit/vertex) indicating whether EndPrimitive() was > called after each vertex, or > > (b) stream ID bits (2 bits/ver

Re: [Mesa-dev] [PATCH 4/9] i965/gs: Set control data header size/format appropriately for EndPrimitive().

2013-09-09 Thread Chris Forbes
In the commit message: > Fortunately, OpenGL only requires separate streams to be supported >when the output type is points, and EndPrimitive() only has an effect > when the input type is line_strip or triangle_strip, so it's not a... Shouldn't this say 'output type' ? -- Chris On Tue, Sep 10,

[Mesa-dev] [PATCH 4/9] i965/gs: Set control data header size/format appropriately for EndPrimitive().

2013-09-09 Thread Paul Berry
The gen7 geometry shader uses a "control data header" at the beginning of the output URB entry to store either (a) flag bits (1 bit/vertex) indicating whether EndPrimitive() was called after each vertex, or (b) stream ID bits (2 bits/vertex) indicating which stream each vertex should be s