>> >>
>> >> +void
>> >> +brw_blorp_blit_program::manual_blend_linear(unsigned num_samples)
>> >> +{
>> >> + if (key->tex_layout == INTEL_MSAA_LAYOUT_CMS)
>> >> + mcs_fetch();
>> >
>> >
>> > This won't work. The MCS value we fetch has to match up with the pixel
>> > that we're sampling from.
On 26 June 2013 19:41, Anuj Phogat wrote:
> On Tue, Jun 25, 2013 at 10:27 AM, Paul Berry
> wrote:
> >
> > On 19 June 2013 19:45, Anuj Phogat wrote:
> >>
> >> Current implementation of ext_framebuffer_multisample_blit_scaled in
> >> i965/blorp uses nearest filtering for multisample scaled blits.
On Tue, Jun 25, 2013 at 10:27 AM, Paul Berry wrote:
>
> On 19 June 2013 19:45, Anuj Phogat wrote:
>>
>> Current implementation of ext_framebuffer_multisample_blit_scaled in
>> i965/blorp uses nearest filtering for multisample scaled blits. Using
>> nearest filtering produces blocky artifacts and
On 26 June 2013 14:57, Anuj Phogat wrote:
> On Tue, Jun 25, 2013 at 10:27 AM, Paul Berry
> wrote:
> > This seems like a lot of work to accomplish what is effectively a lookup
> > table. If this winds up becoming a performance bottleneck, you might
> want
> > to consider passing the table in via
On Tue, Jun 25, 2013 at 10:27 AM, Paul Berry wrote:
> On 19 June 2013 19:45, Anuj Phogat wrote:
>>
>> Current implementation of ext_framebuffer_multisample_blit_scaled in
>> i965/blorp uses nearest filtering for multisample scaled blits. Using
>> nearest filtering produces blocky artifacts and ne
On 19 June 2013 19:45, Anuj Phogat wrote:
> Current implementation of ext_framebuffer_multisample_blit_scaled in
> i965/blorp uses nearest filtering for multisample scaled blits. Using
> nearest filtering produces blocky artifacts and negates the benefits
> of MSAA. That is the reason why extensi
Current implementation of ext_framebuffer_multisample_blit_scaled in
i965/blorp uses nearest filtering for multisample scaled blits. Using
nearest filtering produces blocky artifacts and negates the benefits
of MSAA. That is the reason why extension was not enabled on i965.
This patch implements t