Re: [Mesa-dev] [PATCH V4 02/13] glsl: add texture gather changes

2013-09-30 Thread Ian Romanick
On 09/30/2013 12:08 PM, Kenneth Graunke wrote: > On 09/30/2013 11:03 AM, Ian Romanick wrote: >> On 09/30/2013 03:08 AM, Chris Forbes wrote: >>> From: Maxence Le Dore >>> >>> V2 [Chris Forbes]: >>>- Add new pattern, fixup parameter reading. >>> >>> V3: Rebase onto new builtins machinery >>> >>>

Re: [Mesa-dev] [PATCH V4 02/13] glsl: add texture gather changes

2013-09-30 Thread Kenneth Graunke
On 09/30/2013 11:03 AM, Ian Romanick wrote: > On 09/30/2013 03:08 AM, Chris Forbes wrote: >> From: Maxence Le Dore >> >> V2 [Chris Forbes]: >>- Add new pattern, fixup parameter reading. >> >> V3: Rebase onto new builtins machinery >> >> Reviewed-by: Kenneth Graunke >> --- >> src/glsl/builtin

Re: [Mesa-dev] [PATCH V4 02/13] glsl: add texture gather changes

2013-09-30 Thread Ian Romanick
On 09/30/2013 03:08 AM, Chris Forbes wrote: > From: Maxence Le Dore > > V2 [Chris Forbes]: >- Add new pattern, fixup parameter reading. > > V3: Rebase onto new builtins machinery > > Reviewed-by: Kenneth Graunke > --- > src/glsl/builtin_functions.cpp | 35

[Mesa-dev] [PATCH V4 02/13] glsl: add texture gather changes

2013-09-30 Thread Chris Forbes
From: Maxence Le Dore V2 [Chris Forbes]: - Add new pattern, fixup parameter reading. V3: Rebase onto new builtins machinery Reviewed-by: Kenneth Graunke --- src/glsl/builtin_functions.cpp | 35 +++ src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/