[Mesa-dev] [Bug 93053] GL_PROGRAM_BINARY_LENGTH always reports 0

2015-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93053 --- Comment #2 from Tapani Pälli --- Mesa does not support program binary extension, you seem to be using a custom branch (?) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 3/3] mesa: return initial value for VALIDATE_STATUS if pipe not bound

2015-11-23 Thread Timothy Arceri
On Mon, 2015-11-23 at 08:28 +0200, Tapani Pälli wrote: > > On 11/22/2015 01:25 PM, Timothy Arceri wrote: > > On Sun, 2015-11-22 at 11:00 +0100, gregory hainaut wrote: > > > On Sun, 22 Nov 2015 14:25:31 +1100 > > > Timothy Arceri wrote: > > > > > > > On Tue, 2015-09-01 at 13:53 +0300, Tapani Päll

Re: [Mesa-dev] [PATCH 3/3] mesa: return initial value for VALIDATE_STATUS if pipe not bound

2015-11-23 Thread Tapani Pälli
On 11/23/2015 10:18 AM, Timothy Arceri wrote: On Mon, 2015-11-23 at 08:28 +0200, Tapani Pälli wrote: On 11/22/2015 01:25 PM, Timothy Arceri wrote: On Sun, 2015-11-22 at 11:00 +0100, gregory hainaut wrote: On Sun, 22 Nov 2015 14:25:31 +1100 Timothy Arceri wrote: On Tue, 2015-09-01 at 13:5

Re: [Mesa-dev] [PATCH v2] mesa: error out in indirect draw when vertex bindings mismatch

2015-11-23 Thread Fredrik Höglund
On Thursday 19 November 2015, Tapani Pälli wrote: > Patch adds additional mask for tracking which vertex buffer bindings > are set. This array can be directly compared to which vertex arrays > are enabled and should match when drawing. > > Fixes following CTS tests: > >ES31-CTS.draw_indirect.

[Mesa-dev] nouveau -> dmabuf -> intel seems to requires linear layout

2015-11-23 Thread Julien Isorce
Hi, I tried zero-copy decoding with the following scheme: "nouveau" HW decoding -> dmabuf -> intel GL but it showed garbage. Colors looked okish but not pixel positions. (note that nouveau dec -> dmabuf -> nouveau GL and intel dec -> dmabuf -> intel GL are both working) So I was thinking a prob

Re: [Mesa-dev] [PATCH] glsl: split ssbo array copies into element copies

2015-11-23 Thread Iago Toral
On Fri, 2015-11-20 at 11:09 -0800, Jordan Justen wrote: > On 2015-11-20 06:48:27, Iago Toral Quiroga wrote: > > Improves register pressure, since otherwise we end up emitting > > loads for all the elements in the RHS and them emitting > > stores for all elements in the LHS. > > > > Fixes the follo

Re: [Mesa-dev] [PATCH v2] mesa: error out in indirect draw when vertex bindings mismatch

2015-11-23 Thread Tapani Pälli
On 11/23/2015 11:17 AM, Fredrik Höglund wrote: On Thursday 19 November 2015, Tapani Pälli wrote: Patch adds additional mask for tracking which vertex buffer bindings are set. This array can be directly compared to which vertex arrays are enabled and should match when drawing. Fixes following

Re: [Mesa-dev] [PATCH 3/5] i965: Check base format to determine whether to use tiled memcpy

2015-11-23 Thread Neil Roberts
Ben Widawsky writes: > I really don't know the corner cases well enough, but concept seems > good to me. In particular, I assume this is now going to return false > for more cases than previously - and that's okay, I guess? In practice I don't think it will disable any extra formats because the

Re: [Mesa-dev] [PATCH 5/5] i965/gen9: Don't allow the RGBX formats for texturing/rendering

2015-11-23 Thread Neil Roberts
Ben Widawsky writes: >> + /* The RGBX formats are not renderable. Normally these get mapped >> +* internally to RGBA formats when rendering. However on Gen9+ when this >> +* internal override is used fast clears don't work so they are disabled >> in >> +* brw_meta_fast_clear. To av

Re: [Mesa-dev] [PATCH 1/5] i965/gen9: Don't disallow fast clear for MSRT formats matching render

2015-11-23 Thread Neil Roberts
Ben Widawsky writes: >> + if (brw->gen >= 9 && >> + brw_format_for_mesa_format(irb->mt->format) != >> + brw->render_target_format[irb->mt->format]) > > Could you just do > !brw->format_supported_as_render_target[irb->mt->format]? Hrm, yes, you're right, that would be much

[Mesa-dev] [PATCH 1/2] target-hepers: add non inline sw helpers

2015-11-23 Thread Emil Velikov
Feeling rather dirty copying the inline ones, yet we need the inline ones for swrast only targets like libgl-xlib, osmesa. Cc: "11.1" Cc: Oded Gabbay Cc: Ilia Mirkin Cc: Edward O'Callaghan Signed-off-by: Emil Velikov --- src/gallium/auxiliary/target-helpers/sw_helper.h | 73 +++

[Mesa-dev] [PATCH 2/2] targets/dri: use the non-inline sw helpers

2015-11-23 Thread Emil Velikov
Previously (with the inline ones) things were embedded into the pipe-loader, which means that we cannot control/select what we want in each target. Cc: "11.1" Cc: Oded Gabbay Cc: Ilia Mirkin Cc: Edward O'Callaghan Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader_

Re: [Mesa-dev] [PATCH 1/5] i965/gen9: Don't disallow fast clear for MSRT formats matching render

2015-11-23 Thread Neil Roberts
> Ben Widawsky writes: > >>> + if (brw->gen >= 9 && >>> + brw_format_for_mesa_format(irb->mt->format) != >>> + brw->render_target_format[irb->mt->format]) >> >> Could you just do >> !brw->format_supported_as_render_target[irb->mt->format]? Neil Roberts writes: > Hrm, yes,

Re: [Mesa-dev] [PATCH] gallium: build virgl by default.

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 07:57, Albert Freeman wrote: > On 23 November 2015 at 03:17, Ilia Mirkin wrote: >> On Sun, Nov 22, 2015 at 9:28 PM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> No reason not to build this, it has no external >>> requirements at the moment. >> >> Not that I object, bu

Re: [Mesa-dev] [PATCH] gallium: build virgl by default.

2015-11-23 Thread Marek Olšák
On Mon, Nov 23, 2015 at 12:41 PM, Emil Velikov wrote: > On 23 November 2015 at 07:57, Albert Freeman > wrote: >> On 23 November 2015 at 03:17, Ilia Mirkin wrote: >>> On Sun, Nov 22, 2015 at 9:28 PM, Dave Airlie wrote: From: Dave Airlie No reason not to build this, it has no ext

Re: [Mesa-dev] [PATCH] gallium: build virgl by default.

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 11:49, Marek Olšák wrote: > On Mon, Nov 23, 2015 at 12:41 PM, Emil Velikov > wrote: >> On 23 November 2015 at 07:57, Albert Freeman >> wrote: >>> On 23 November 2015 at 03:17, Ilia Mirkin wrote: On Sun, Nov 22, 2015 at 9:28 PM, Dave Airlie wrote: > From: Dave

Re: [Mesa-dev] [Mesa-announce] Mesa 11.1.0 release candidate 1

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 09:18, Thierry Vignaud wrote: > On 21 November 2015 at 15:28, Emil Velikov wrote: >> The first release candidate for Mesa 11.1.0 is now available. >> >> The plan is to have one release candidate every Friday, until the final >> release on December 11th 2015. >> >> As a remi

Re: [Mesa-dev] [PATCH 2/3] i965: Use implicit backend_reg copy-constructor.

2015-11-23 Thread Francisco Jerez
Matt Turner writes: > In order to do this, we have to change the signature of the > backend_reg(brw_reg) constructor to take a reference to a brw_reg in > order to avoid unresolvable ambiguity about which constructor is > actually being called in the other modifications in this patch. > > As far

[Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Timothy Arceri
From: Timothy Arceri Enables 200+ dEQP SSO tests to proceed passed validation, while not regressing ES31-CTS.sepshaderobjs.PipelineApi. Cc: Tapani Pälli Cc: Gregory Hainaut --- src/mesa/main/pipelineobj.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --

Re: [Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Timothy Arceri
On Mon, 2015-11-23 at 23:24 +1100, Timothy Arceri wrote: > From: Timothy Arceri > > Enables 200+ dEQP SSO tests to proceed passed validation, > while not regressing ES31-CTS.sepshaderobjs.PipelineApi. > > Cc: Tapani Pälli > Cc: Gregory Hainaut > --- > src/mesa/main/pipelineobj.c | 25

[Mesa-dev] [PATCH 2/2] glsl/lower_ubo_reference: split struct copies into element copies

2015-11-23 Thread Iago Toral Quiroga
Improves register pressure, since otherwise we end up emitting loads for all the elements in the RHS and them emitting stores for all elements in the LHS. --- src/glsl/lower_ubo_reference.cpp | 56 ++-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --gi

[Mesa-dev] [PATCH 1/2] glsl/lower_ubo_reference: split array copies into element copies

2015-11-23 Thread Iago Toral Quiroga
Improves register pressure, since otherwise we end up emitting loads for all the elements in the RHS and them emitting stores for all elements in the LHS. v2: - Mark progress properly. This also fixes some instances where the added nodes with individual element copies where not being lowered

[Mesa-dev] [PATCH 0/2] Improve emitted code for copies of large buffer-backed variables

2015-11-23 Thread Iago Toral Quiroga
Fixes linking issues when copying large variables backed by buffers (ubos, ssbos, etc). In these cases, lower_ubo_reference would split the rhs into loads for all the elements first and then the lhs into writes to all the elements. This is not efficient, because it requires the whole set of loa

Re: [Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Gregory Hainaut
Thanks. Yes I think it must be this way. I said the same to Tapani 1 hour ago (but stupid gmail didn't reply all...). On 11/23/15, Timothy Arceri wrote: > On Mon, 2015-11-23 at 23:24 +1100, Timothy Arceri wrote: >> From: Timothy Arceri >> >> Enables 200+ dEQP SSO tests to proceed passed validati

Re: [Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Tapani Pälli
Hi; On 11/23/2015 02:24 PM, Timothy Arceri wrote: From: Timothy Arceri Enables 200+ dEQP SSO tests to proceed passed validation, while not regressing ES31-CTS.sepshaderobjs.PipelineApi. Cc: Tapani Pälli Cc: Gregory Hainaut --- src/mesa/main/pipelineobj.c | 25 - 1

Re: [Mesa-dev] [PATCH 2/7] glsl: only call dead code pass when new inputs/outputs demoted

2015-11-23 Thread Juha-Pekka Heikkila
Reviewed-by: Juha-Pekka Heikkila On 21.11.2015 10:02, Timothy Arceri wrote: From: Timothy Arceri This will help avoid eliminating inputs/outputs needed by SSOs. Cc: Gregory Hainaut --- src/glsl/linker.cpp | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) d

Re: [Mesa-dev] [PATCH 1/7] glsl: move and reused code to find first and last shaders

2015-11-23 Thread Juha-Pekka Heikkila
Reviewed-by: Juha-Pekka Heikkila On 21.11.2015 10:02, Timothy Arceri wrote: From: Timothy Arceri --- src/glsl/linker.cpp | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 331d9a2..eac2536 100

Re: [Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Gregory Hainaut
It is a different issue and it seems I already did it (or someone else patched it). You can see those lines in the code. /* Object is created by any Pipeline call but glGenProgramPipelines, * glIsProgramPipeline and GetProgramPipelineInfoLog */ pipe->EverBound = GL_TRUE; The trick i

Re: [Mesa-dev] [PATCH] configure.ac: use pkg-config for libelf

2015-11-23 Thread Jan Vesely
On Mon, 2015-11-23 at 14:24 +1100, Jonathan Gray wrote: > Use PKG_CHECK_MODULES to get the flags to link libelf. This has been discussed before, and it does not work with elfutils: http://lists.freedesktop.org/archives/mesa-dev/2014-October/069748.html Jan > > Signed-off-by: Jonathan Gray > Cc

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: use pkg-config for libelf

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 03:24, Jonathan Gray wrote: > Use PKG_CHECK_MODULES to get the flags to link libelf. > > Signed-off-by: Jonathan Gray > Cc: "11.0 11.1" > --- > configure.ac | 4 +--- > src/gallium/drivers/radeon/Makefile.am | 2 +- > src/gallium/targets/opencl/M

Re: [Mesa-dev] [PATCH] configure.ac: use pkg-config for libelf

2015-11-23 Thread Jonathan Gray
On Mon, Nov 23, 2015 at 07:52:44AM -0600, Jan Vesely wrote: > On Mon, 2015-11-23 at 14:24 +1100, Jonathan Gray wrote: > > Use PKG_CHECK_MODULES to get the flags to link libelf. > > This has been discussed before, and it does not work with elfutils: > http://lists.freedesktop.org/archives/mesa-dev/

Re: [Mesa-dev] [PATCH 1/7] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

2015-11-23 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, Nov 20, 2015 at 5:49 AM, Francisco Jerez > wrote: >> Chad Versace writes: >> >>> On Wed 04 Nov 2015, Jason Ekstrand wrote: Previously, we were relying on has_matching_typed_format returning true for MESA_FORMAT_NONE which, in turn, relied on _mesa_get

[Mesa-dev] [PATCH 3/8] st/va: move MPEG12 functions into separate file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 57 +++--- src/gallium/state_trackers/va/picture_mpeg12.c | 80 ++ src/gallium/state_trackers/va/v

[Mesa-dev] [PATCH 5/8] st/va: move VC-1 functions into separate file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 36 +- src/gallium/state_trackers/va/picture_vc1.c| 67 ++ src/gallium/state_trackers/va/va_pr

[Mesa-dev] [PATCH 4/8] st/va: move H264 functions into separate file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 76 + src/gallium/state_trackers/va/picture_h264.c | 113 + src/gallium/state_trackers/va/

[Mesa-dev] [PATCH] st/va: disable MPEG4 by default

2015-11-23 Thread Christian König
From: Christian König The workarounds are to hacky to enable them by default and otherwise MPEG4 doesn't work reliable. Signed-off-by: Christian König --- src/gallium/state_trackers/va/config.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trac

[Mesa-dev] [PATCH 1/8] st/va: fix post process dirty area handling

2015-11-23 Thread Christian König
From: Christian König The dirty area in this call isn't related to the screen at all. Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_

[Mesa-dev] [PATCH 7/8] st/va: move HEVC functions into separate file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 174 + src/gallium/state_trackers/va/picture_hevc.c | 159 ++ src/gallium/state_tracker

[Mesa-dev] [PATCH 8/8] st/va: fix indentation

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index ce75e2d..25d2940 100644 --

[Mesa-dev] [PATCH 2/8] st/va: move post processing function into own file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 58 +--- src/gallium/state_trackers/va/postproc.c | 94 ++ src/gallium/state_trackers/va/va_

[Mesa-dev] [PATCH 6/8] st/va: move MPEG4 functions into separate file

2015-11-23 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/picture.c| 186 +- src/gallium/state_trackers/va/picture_mpeg4.c | 209 + src/gallium/state_tracker

Re: [Mesa-dev] [PATCH] configure.ac: use pkg-config for libelf

2015-11-23 Thread Jan Vesely
On Tue, 2015-11-24 at 01:07 +1100, Jonathan Gray wrote: > On Mon, Nov 23, 2015 at 07:52:44AM -0600, Jan Vesely wrote: > > On Mon, 2015-11-23 at 14:24 +1100, Jonathan Gray wrote: > > > Use PKG_CHECK_MODULES to get the flags to link libelf. > > > > This has been discussed before, and it does not wor

[Mesa-dev] [PATCH v2 2/2] targets: use the non-inline sw helpers

2015-11-23 Thread Emil Velikov
Previously (with the inline ones) things were embedded into the pipe-loader, which means that we cannot control/select what we want in each target. That also meant that at runtime we ended up with the empty sw_screen_create() as the GALLIUM_SOFTPIPE/LLVMPIPE were not set. v2: Cover all the target

Re: [Mesa-dev] [PATCH v2 2/2] targets: use the non-inline sw helpers

2015-11-23 Thread Oded Gabbay
On Mon, Nov 23, 2015 at 5:28 PM, Emil Velikov wrote: > Previously (with the inline ones) things were embedded into the > pipe-loader, which means that we cannot control/select what we want in > each target. > > That also meant that at runtime we ended up with the empty > sw_screen_create() as the

[Mesa-dev] Mesa i965 instruction scheduler latency values

2015-11-23 Thread Eero Tamminen
Hi, Mesa i965 instruction scheduler latency values look weird. For example: -- void schedule_node::set_latency_gen7(bool is_haswell) { switch (inst->opcode) { ... case SHADER_OPCODE_UNTYPED_SURFACE_READ: case SHADER_OPCODE_UNTYPED_SURFACE_WRITE: case SHADER_OPCODE

Re: [Mesa-dev] [PATCH v2] i965: Handle lum, intensity and missing components in the fast clear

2015-11-23 Thread Neil Roberts
I've pushed this patch to master but I think it would be a good candidate to go on the 11.1 branch as well. Do I have to do something to make that happen? - Neil Neil Roberts writes: > It looks like the sampler hardware doesn't take into account the > surface format when sampling a cleared colo

Re: [Mesa-dev] [PATCH 1/8] st/va: fix post process dirty area handling

2015-11-23 Thread Julien Isorce
Make sense it was a copy past I did from vlVdpPresentationQueueDisplay. I tested this change and works fine. Thx for catching this. (feel free to set "clear_dirty" param of vl_compositor_render to false even if it will be ignored anyway) Reviewed-by: Julien Isorce On 23 November 2015 at 14:37,

Re: [Mesa-dev] [PATCH 8/8] st/va: fix indentation

2015-11-23 Thread Julien Isorce
Nice cleanups. I also tested these changes on "nouveau" driver with one video per format (except HEVC) and works fine with mpv and gstreamer. Patches "[PATCH 2/8] st/va: move post processing function into own file" to "[PATCH 8/8] st/va: fix indentation" are: Reviewed-by: Julien Isorce On 23 Nov

Re: [Mesa-dev] [PATCH] st/va: disable MPEG4 by default

2015-11-23 Thread Ilia Mirkin
On Mon, Nov 23, 2015 at 9:36 AM, Christian König wrote: > From: Christian König > > The workarounds are to hacky to enable them by default to hacky -> too hacky > and otherwise MPEG4 doesn't work reliable. reliable -> reliably > > Signed-off-by: Christian König > --- > src/gallium/state_tra

[Mesa-dev] [PATCH 2/2] targets/nine: remove freedreno target

2015-11-23 Thread Emil Velikov
Analogous to previous commit. As we no longer have anyone who uses NIR we can drop the link. Cc: Rob Clark Signed-off-by: Emil Velikov --- src/gallium/targets/d3dadapter9/Makefile.am | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/targets/d3dadapter9/Makefile.am b/src/gallium

[Mesa-dev] [PATCH 1/2] targets/nine: remove vc4 target

2015-11-23 Thread Emil Velikov
Any nir powered targets outside of DRI have been broken for a little while now (due to unresolved symbols). Not to mention that there are no users for it, yet. Cc: Eric Anholt Signed-off-by: Emil Velikov --- src/gallium/targets/d3dadapter9/Makefile.am | 2 -- 1 file changed, 2 deletions(-) dif

Re: [Mesa-dev] [PATCH 2/2] targets/nine: remove freedreno target

2015-11-23 Thread Rob Clark
just curious, but which syms? That said, I'm not really sure if wine/gallium9 has much usefulness on ARM, so Acked-by: Rob Clark On Mon, Nov 23, 2015 at 1:36 PM, Emil Velikov wrote: > Analogous to previous commit. As we no longer have anyone who uses NIR > we can drop the link. > > Cc: Rob Cla

[Mesa-dev] i965: Branch for debugging fast clears

2015-11-23 Thread Chad Versace
I recently spent a lot of time debugging fast clears. The hardware documentation is confusing on the subject, so I began poking individual bits in the auxiliary surface to better understand why things were not working as expecting. Some of you (CC'd) may find my debug branch useful if you ever fin

[Mesa-dev] [PATCH] i965: Use ull immediates in brw_inst_bits

2015-11-23 Thread Jason Ekstrand
This fixes a regression introduced in b1a83b5d1 that caused basically all shaders to fail to compile on 32-bit platforms. Reported-by: Mark Janes Cc: Matt Turner --- src/mesa/drivers/dri/i965/brw_inst.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 1/7] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

2015-11-23 Thread Jason Ekstrand
On Mon, Nov 23, 2015 at 6:15 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Fri, Nov 20, 2015 at 5:49 AM, Francisco Jerez >> wrote: >>> Chad Versace writes: >>> On Wed 04 Nov 2015, Jason Ekstrand wrote: > Previously, we were relying on has_matching_typed_format returning

Re: [Mesa-dev] [PATCH 2/2] targets/nine: remove freedreno target

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 18:44, Rob Clark wrote: > just curious, but which syms? > Seems that I had some local glsl/nir changes which caused the issue. I should stop doing so many things at one :-) > That said, I'm not really sure if wine/gallium9 has much usefulness on ARM, so > > Acked-by: Rob Cl

Re: [Mesa-dev] [PATCH 1/2] targets/nine: remove vc4 target

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 18:36, Emil Velikov wrote: > Any nir powered targets outside of DRI have been broken for a little > while now (due to unresolved symbols). PEBKAC things link fine. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org htt

Re: [Mesa-dev] [PATCH] i965: Always use Y-tiled buffers on SKL+

2015-11-23 Thread Neil Roberts
Hi, Has this situation changed at all? It's probably quite important to get this working because we have to disable fast clears for X-tiled buffers on SKL which effectively means we currently can't do it for window system buffers. Regards, - Neil Chris Wilson writes: > On Mon, Apr 13, 2015 at

[Mesa-dev] [PATCH 4/5] auxiliary/vl/drm: fd management cleanups

2015-11-23 Thread Emil Velikov
Analogous to previous commit. Spotted by Coverity. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/gallium/auxiliary/vl/vl_winsys_drm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_drm.c b/src/gallium/au

[Mesa-dev] [PATCH 1/5] pipe-loader: check if winsys.name is non-null prior to strcmp

2015-11-23 Thread Emil Velikov
In theory this wouldn't be an issue, as we'll find the correct name and break out of the loop before we hit the sentinel. Let's fix this and avoid issues in the future. Spotted by Coverity. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/gallium/auxiliary/pipe-loader/

[Mesa-dev] [PATCH 3/5] st/xa: fd management cleanups

2015-11-23 Thread Emil Velikov
Analogous to previous commit. Spotted by Coverity. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/gallium/state_trackers/xa/xa_tracker.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/xa/xa_tracker.c b/src/galli

[Mesa-dev] [PATCH 5/5] auxiliary/vl/dri: fd management cleanups

2015-11-23 Thread Emil Velikov
Analogous to previous commit, minus the extra dup. We are the one opening the device thus we can directly use the fd. Spotted by Coverity. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/gallium/auxiliary/vl/vl_winsys_dri.c | 7 +-- 1 file changed, 5 insertions(+),

[Mesa-dev] [PATCH 2/5] st/dri: fd management cleanups

2015-11-23 Thread Emil Velikov
Add some checks if the original/dup'd fd is valid, one and ensure that we don't leak it on error. In the former case the pipe_loader would correctly handle things, although let's make things more explicit. Spotted by Coverity. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH] nv50: add edgeflag support when using inline vertex data submit

2015-11-23 Thread Samuel Pitoiset
Fixes the following piglit tests: - gl-1.0-edgeflag - gl-1.0-edgeflag-quads - gl-2.0-edgeflag - gl-2.0-edgeflag-immediate - point-vertex-id divisor - point-vertex-id gl_InstanceID - point-vertex-id gl_InstanceID divisor I still need to figure out why point-vertex-id fails with gl_vertexID.

[Mesa-dev] [PATCH] r600: consolidate clip state updates

2015-11-23 Thread Dave Airlie
From: Dave Airlie Move some common code into one place, tess will also need to use this function. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_state_common.c | 31 ++-- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/r

Re: [Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Timothy Arceri
On Mon, 2015-11-23 at 15:19 +0200, Tapani Pälli wrote: > Hi; > > On 11/23/2015 02:24 PM, Timothy Arceri wrote: > > From: Timothy Arceri > > > > Enables 200+ dEQP SSO tests to proceed passed validation, > > while not regressing ES31-CTS.sepshaderobjs.PipelineApi. > > > > Cc: Tapani Pälli > > Cc

[Mesa-dev] [PATCH] pipe-loader: fix off-by one error

2015-11-23 Thread Emil Velikov
With earlier commit we've dropped the manual iteration over the fixed size array and prepemtively set the variable storing the size, that is to be returned. Yet we forgot to adjust the comparison, as before we were comparing the index, now we're comparing the size. Fixes: ff9cd8a67ca "pipe-loader:

Re: [Mesa-dev] [PATCH] pipe-loader: fix off-by one error

2015-11-23 Thread Tom Stellard
On Mon, Nov 23, 2015 at 09:37:51PM +, Emil Velikov wrote: > With earlier commit we've dropped the manual iteration over the fixed > size array and prepemtively set the variable storing the size, that is > to be returned. Yet we forgot to adjust the comparison, as before we > were comparing the

Re: [Mesa-dev] [PATCH] st/va: disable MPEG4 by default

2015-11-23 Thread Emil Velikov
On 23 November 2015 at 14:36, Christian König wrote: > From: Christian König > > The workarounds are to hacky to enable them by default > and otherwise MPEG4 doesn't work reliable. > > Signed-off-by: Christian König Thanks Christian. Should we document the new variable in docs/envvars.html and

Re: [Mesa-dev] [PATCH] r600: consolidate clip state updates

2015-11-23 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 23, 2015 at 9:50 PM, Dave Airlie wrote: > From: Dave Airlie > > Move some common code into one place, tess will also need > to use this function. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r600/r600_state_common.c | 31 > +++

Re: [Mesa-dev] [PATCH 1/7] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

2015-11-23 Thread Chad Versace
On Mon 23 Nov 2015, Jason Ekstrand wrote: > On Mon, Nov 23, 2015 at 6:15 AM, Francisco Jerez > wrote: > > Jason Ekstrand writes: > > For that reason 'has_matching_typed_format(MESA_FORMAT_NONE) = true' > > makes sense to me, but 'has_matching_typed_format(BRW_SURFACEFORMAT_RAW) > > = true' and

Re: [Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Ian Romanick
On 11/23/2015 04:24 AM, Timothy Arceri wrote: > From: Timothy Arceri > > Enables 200+ dEQP SSO tests to proceed passed validation, ^^ past? > while not regressing ES31-CTS.sepshaderobjs.PipelineApi. > > Cc: Tapani Pälli > Cc: Gregory Hainaut > ---

[Mesa-dev] [PATCH 03/13] i965: Mark count_trailing_one_bits() static.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp index ba11d3d..cb3c6f7 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp +++ b/s

[Mesa-dev] [PATCH 13/13] i965: Clean up #includes in the compiler.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_blorp.cpp | 1 - src/mesa/drivers/dri/i965/brw_blorp.h| 1 - src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 1 - src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h| 1 - src/mesa/drivers/dri/i965/brw_context.h

[Mesa-dev] [PATCH 04/13] i965: Remove unneeded forward declarations.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_gs.h | 2 -- src/mesa/drivers/dri/i965/intel_asm_annotation.h | 3 --- src/mesa/drivers/dri/i965/intel_fbo.h| 1 - src/mesa/drivers/dri/i965/intel_tex.h| 2 -- 4 files changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 07/13] i965: Mark functions called from C as extern "C".

2015-11-23 Thread Matt Turner
These functions' prototypes are marked with extern "C", which apparently overrides a lack of extern "C" at the definition site if the prototype has been seen first. --- src/mesa/drivers/dri/i965/brw_link.cpp | 2 +- src/mesa/drivers/dri/i965/brw_shader.cpp | 4 ++-- 2 files changed, 3 insertions

[Mesa-dev] [PATCH 11/13] i965: Compile brw_cs_fill_local_id_payload() as C.

2015-11-23 Thread Matt Turner
It's only called from C, it compiles as C, so just compile it as C. Notice the missing extern "C" on the definition of the function, which would screw things up if the prototype wasn't parsed before the definition. --- src/mesa/drivers/dri/i965/brw_cs.c | 36

[Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.

2015-11-23 Thread Matt Turner
It's never used. --- src/mesa/drivers/dri/i965/brw_clear.c | 1 - src/mesa/drivers/dri/i965/brw_clip.c | 1 - src/mesa/drivers/dri/i965/brw_clip_line.c | 1 - src/mesa/drivers/dri/i965/brw_clip_point.c | 1 - src/mesa/drivers/dri/i965/brw_clip_tri.c | 1 - src/mes

[Mesa-dev] [PATCH 01/13] util: Include assert.h in macros.h.

2015-11-23 Thread Matt Turner
--- src/util/macros.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/macros.h b/src/util/macros.h index 84e4f18..5014b91 100644 --- a/src/util/macros.h +++ b/src/util/macros.h @@ -24,6 +24,8 @@ #ifndef UTIL_MACROS_H #define UTIL_MACROS_H +#include + /* Compute the size of an

[Mesa-dev] [PATCH 10/13] i965: Move MRF macros from brw_inst.h to brw_eu.h.

2015-11-23 Thread Matt Turner
brw_inst.h is only for the brw_inst/brw_compact_inst functions. --- src/mesa/drivers/dri/i965/brw_eu.h| 9 + src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 1 + src/mesa/drivers/dri/i965/brw_inst.h | 9 - 3 files changed, 10 insertions(+), 9 deleti

[Mesa-dev] [PATCH 08/13] i965: Push down inclusion of brw_program.h.

2015-11-23 Thread Matt Turner
We were including it in headers, which then caused it to be included in tons of places it wasn't needed. --- src/mesa/drivers/dri/i965/brw_cs.c | 1 + src/mesa/drivers/dri/i965/brw_cs.h | 2 -- src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + src/mesa/drivers/dri

[Mesa-dev] [PATCH 06/13] i965: Push down inclusion of vbo/vbo.h.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_draw.h | 1 - src/mesa/drivers/dri/i965/brw_primitive_restart.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.h b/src/mesa/drivers/dri/i965/brw_draw.h index 695973b..23d98ef 100644 --- a/src/me

[Mesa-dev] [PATCH 02/13] i965: Remove useless gen6_blorp.h/gen7_blorp.h headers.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/Makefile.sources | 2 -- src/mesa/drivers/dri/i965/brw_blorp.cpp| 2 -- src/mesa/drivers/dri/i965/brw_blorp.h | 7 + src/mesa/drivers/dri/i965/gen6_blorp.cpp | 1 - src/mesa/drivers/dri/i965/gen6_blorp.h | 41 -- src/

[Mesa-dev] [PATCH 05/13] i965: Remove duplicate #includes.

2015-11-23 Thread Matt Turner
Added in commits 36fd65381 and 337dad8ce even though the existing include was in view. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index c439da2..1e39b39 10064

[Mesa-dev] [PATCH 12/13] i965: Move brw_new_shader and brw_link_shader prototypes from brw_wm.h.

2015-11-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_shader.h | 3 +++ src/mesa/drivers/dri/i965/brw_wm.h | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.h b/src/mesa/drivers/dri/i965/brw_shader.h index d78e552..5c226ec 100644 --- a/src/mesa/drivers/d

Re: [Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.

2015-11-23 Thread Ian Romanick
Have you built this series with debug and release builds? There have been cases in the past where removing or changing headers worked fine in one but not the other. On 11/23/2015 01:55 PM, Matt Turner wrote: > It's never used. > --- > src/mesa/drivers/dri/i965/brw_clear.c | 1 - > src/m

Re: [Mesa-dev] [PATCH] i965: Use ull immediates in brw_inst_bits

2015-11-23 Thread Ian Romanick
On 11/23/2015 10:54 AM, Jason Ekstrand wrote: > This fixes a regression introduced in b1a83b5d1 that caused basically all > shaders to fail to compile on 32-bit platforms. Here's the part from the b1a83b5d1 commit message that makes me sad: v2 (Iago) - Replace ~0 by ~0ull - Removed

Re: [Mesa-dev] [PATCH] i965: Use ull immediates in brw_inst_bits

2015-11-23 Thread Ian Romanick
On 11/23/2015 02:01 PM, Ian Romanick wrote: > On 11/23/2015 10:54 AM, Jason Ekstrand wrote: >> This fixes a regression introduced in b1a83b5d1 that caused basically all >> shaders to fail to compile on 32-bit platforms. > > Here's the part from the b1a83b5d1 commit message that makes me sad: > >

Re: [Mesa-dev] [PATCH] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Ian Romanick
On 11/23/2015 01:51 PM, Ian Romanick wrote: > On 11/23/2015 04:24 AM, Timothy Arceri wrote: >> From: Timothy Arceri >> >> Enables 200+ dEQP SSO tests to proceed passed validation, > ^^ past? > >> while not regressing ES31-CTS.sepshaderobjs.PipelineApi.

Re: [Mesa-dev] [PATCH] i965: Use ull immediates in brw_inst_bits

2015-11-23 Thread Jason Ekstrand
On Mon, Nov 23, 2015 at 10:54 AM, Jason Ekstrand wrote: > This fixes a regression introduced in b1a83b5d1 that caused basically all > shaders to fail to compile on 32-bit platforms. > > Reported-by: Mark Janes > Cc: Matt Turner > --- > src/mesa/drivers/dri/i965/brw_inst.h | 4 ++-- > 1 file cha

Re: [Mesa-dev] [PATCH 8/8] st/va: fix indentation

2015-11-23 Thread Leo Liu
the patch series Reviewed-by: Leo Liu On 11/23/2015 09:37 AM, Christian König wrote: From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/state_track

Re: [Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.

2015-11-23 Thread Matt Turner
On Mon, Nov 23, 2015 at 1:57 PM, Ian Romanick wrote: > Have you built this series with debug and release builds? There have > been cases in the past where removing or changing headers worked fine in > one but not the other. Yes. ___ mesa-dev mailing li

[Mesa-dev] [PATCH 2/2] r600: add missing register to initial state

2015-11-23 Thread Dave Airlie
From: Dave Airlie We really should initialise HS/LS_2 and SQ_LDS_ALLOC exists on all evergreen not just cayman, so we should initialise it as well. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 2 +- src/gallium/drivers/r600/evergreen_state.c | 19 +++

[Mesa-dev] [PATCH 1/2] r600: define registers required for tessellation

2015-11-23 Thread Dave Airlie
From: Dave Airlie This adds the defines for a bunch of registers and shader values that are required to implement tessellation. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreend.h | 123 +++--- src/gallium/drivers/r600/r600_sq.h| 8 +++ 2 file

Re: [Mesa-dev] [PATCH 09/13] i965: Drop #include of main/glheader.h.

2015-11-23 Thread Ian Romanick
On 11/23/2015 02:09 PM, Matt Turner wrote: > On Mon, Nov 23, 2015 at 1:57 PM, Ian Romanick wrote: >> Have you built this series with debug and release builds? There have >> been cases in the past where removing or changing headers worked fine in >> one but not the other. > > Yes. Cool. This se

Re: [Mesa-dev] [PATCH 2/2] r600: add missing register to initial state

2015-11-23 Thread Glenn Kennard
On Mon, 23 Nov 2015 23:46:25 +0100, Dave Airlie wrote: From: Dave Airlie We really should initialise HS/LS_2 and SQ_LDS_ALLOC exists on all evergreen not just cayman, so we should initialise it as well. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_compute.c | 2 +- sr

Re: [Mesa-dev] [PATCH 1/2] r600: define registers required for tessellation

2015-11-23 Thread Glenn Kennard
On Mon, 23 Nov 2015 23:46:24 +0100, Dave Airlie wrote: From: Dave Airlie This adds the defines for a bunch of registers and shader values that are required to implement tessellation. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreend.h | 123 +++-

[Mesa-dev] [PATCH 2/2] glsl: implement recent spec update to SSO validation

2015-11-23 Thread Timothy Arceri
From: Timothy Arceri Enables 200+ dEQP SSO tests to proceed past validation, and fixes a ES31-CTS.sepshaderobjs.PipelineApi subtest. V2: split out change that reverts a previous patch into its own commit, move variable declaration to top of function, and fix some formatting all suggested by Ian.

[Mesa-dev] [PATCH 1/2] Revert "mesa: return initial value for VALIDATE_STATUS if pipe not bound"

2015-11-23 Thread Timothy Arceri
From: Timothy Arceri This reverts commit ba02f7a3b6a0e4314753a8e5080db61241563f9c. The commit checked whether the pipeline was currently bound instead of checking whether it had ever been bound. The previous setting of Validated during object creation makes this unnecessary. The real problem w

Re: [Mesa-dev] [PATCH 5/7] glsl: add always_active_io attribute to ir_variable

2015-11-23 Thread Timothy Arceri
On Sat, 2015-11-21 at 19:02 +1100, Timothy Arceri wrote: > From: Gregory Hainaut > > The value will be set in separate-shader program when an input/output > must remains active. e.g. when deadcode removal isn't allowed because > it will create interface location/name-matching mismatch. > > v3: >

  1   2   >