Re: [Mesa-dev] [PATCH 08/92] nir: add nir_lower_uniforms_to_ubo pass

On 26.06.2017 21:07, Connor Abbott wrote: I think this would probably be a lot simpler if it ran after nir_lower_io, since you wouldn't need to do all the dereference munging to compute the offset. That is, instead of translating load_var intrinsics, it would translate load_uniform intrinsics int

Re: [Mesa-dev] [PATCH 1/2] radeonsi: check nr_cbufs in other places before flushing CB

Reviewed-by: Nicolai Hähnle On 27.06.2017 02:14, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c in

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

On 27.06.2017 02:14, Marek Olšák wrote: From: Marek Olšák Shader key size: 107 -> 47 Nice improvement. Divisors of 0 and 1 are encoded in the shader key. Greater instance divisors are loaded from a constant buffer. The shader code doing the division is huge. Is it something we need to wor

Re: [Mesa-dev] [PATCH 16/92] st/nir: make nir_lower_tex configurable

On 26.06.2017 21:09, Rob Clark wrote: So the solution to this so far has been to call this both from driver and from mesa/st. (The mesa/st call to nir_lower_tex is only in the rare case of gles + yuv EGLImageExternal (ie. basically a hack because android expects YUV texture support. So I guess

Re: [Mesa-dev] [PATCH 18/92] gallium: add PIPE_CAP_NIR_LOWER_IO

On 27.06.2017 02:25, Connor Abbott wrote: Ok, so I just looked into it a little further, and I guess that since nir_to_llvm needs to know about the ABI to know where all the "special" inputs/outputs like tess factors, position etc. are, switching radv to using the normal input/output intrinsics w

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

On 27.06.2017 00:15, Marek Olšák wrote: On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle wrote: On 20.06.2017 20:00, Marek Olšák wrote: From: Marek Olšák sizeof(struct si_shader_key): Before reverting the 2 commits: 120 bytes After reverting the 2 commits: 128 bytes With #pragma

[Mesa-dev] [Bug 97957] Awful screen tearing in a separate X server with DRI3

https://bugs.freedesktop.org/show_bug.cgi?id=97957 Michel Dänzer changed: What|Removed |Added CC||thellst...@vmware.com --- Comment #11 fr

Re: [Mesa-dev] [PATCH 01/92] glsl: add glsl_base_type_is_integer

Reviewed-by: Samuel Pitoiset On 06/26/2017 04:09 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle We will use this from radeonsi/nir, which we want to keep as pure C code. --- src/compiler/glsl_types.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/compiler/glsl_types.h

Re: [Mesa-dev] [PATCH 09/92] ddebug: handle some cases of non-TGSI shaders

Don't you need to also update dd_unreference_copy_of_draw_state() and dd_copy_draw_state() ? On 06/26/2017 04:09 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/drivers/ddebug/dd_context.c | 6 -- src/gallium/drivers/ddebug/dd_draw.c| 9 +++-- src/gallium/driv

Re: [Mesa-dev] [PATCH 11/92] tgsi_from_mesa: add pipe_shader_type_from_mesa

Reviewed-by: Samuel Pitoiset On 06/26/2017 04:09 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle So... the pipe_ prefix doesn't really fit into a TGSI header; on the other hand, the return type has the pipe_ prefix. --- src/gallium/auxiliary/tgsi/tgsi_from_mesa.h | 23 +++

Re: [Mesa-dev] [PATCH 13/92] st/mesa: use pipe_shader_type_from_mesa

Reviewed-by: Samuel Pitoiset On 06/26/2017 04:09 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 23 ++- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa

[Mesa-dev] [Bug 97957] Awful screen tearing in a separate X server with DRI3

https://bugs.freedesktop.org/show_bug.cgi?id=97957 --- Comment #12 from Thomas Hellström --- Created attachment 132276 --> https://bugs.freedesktop.org/attachment.cgi?id=132276&action=edit Patch to grab a new backbuffer if we're presenting a buffer that's already in the swap chain -- You are

[Mesa-dev] [Bug 97957] Awful screen tearing in a separate X server with DRI3

https://bugs.freedesktop.org/show_bug.cgi?id=97957 --- Comment #13 from Thomas Hellström --- It sounds to me like a back- to back SwapBuffers() is an application bug. The back buffer content is undefined after a SwapBuffers(). But we shouldn't present a back buffer that's already in the swap cha

Re: [Mesa-dev] [PATCH v5 2/6] mesa/st: glsl_to_tgsi: implement new temporary register lifetime tracker

Thanks for your comments Am Montag, den 26.06.2017, 14:52 +0200 schrieb Nicolai Hähnle: > Thanks for the update. First off, you're still not tracking > individual  > components, but that's absolute necessary. Think: > > BGNLOOP >    MOV TEMP[1].x, ... > >    UIF ... >  MOV TEMP[1].y, ... >

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

Just curious. Can this extension be added to NV04 and NV10? As those are the only drivers that don't currently support it. I have cards I could test those with, but don't have an NV20. On 09/09/16 10:56, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- This was tested on a NV25-on-NV34 si

[Mesa-dev] [Bug 97957] Awful screen tearing in a separate X server with DRI3

https://bugs.freedesktop.org/show_bug.cgi?id=97957 --- Comment #14 from Thomas Hellström --- Actually, it seems that at least Gallium advertises GLX_SWAP_COPY_OML. But dri3 doesn't implemented it. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact f

Re: [Mesa-dev] [PATCH v5 0/6] mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

Am Montag, den 26.06.2017, 15:13 +0200 schrieb Nicolai Hähnle: > Thanks for the update. Do you have the series on an accessible git  > repository somewhere? E.g. on GitHub or Gitlab or wherever? That > would be helpful. I've put the code on https://github.com/gerddie/mesa and I am already pushi

[Mesa-dev] [PATCH mesa] mesa: add missing include

src/mesa/drivers/x11/xm_dd.c:688:7: warning: implicit declaration of function ‘_mesa_update_draw_buffer_bounds’; did you mean ‘_mesa_has_ARB_draw_buffers_blend’? [-Wimplicit-function-declaration] _mesa_update_draw_buffer_bounds(ctx, ctx->DrawBuffer); ^~~

Re: [Mesa-dev] [PATCH] i965: skip varyings without slot

On Tue, 2017-06-27 at 09:29 +1000, Timothy Arceri wrote: > On 16/06/17 18:12, Juan A. Suarez Romero wrote: > > > Commit 00620782c9 (i965: use nir_shader_gather_info() over > > do_set_program_inouts()) changed how we compute the outputs written. > > > > In the previous version it was using the IR

[Mesa-dev] [PATCH 00/42] Some various KHR_no_error patches

Hi, This series adds KHR_no_error support to various GL calls, mostly the ones used by the DOW3 benchmark. Piglit updates are coming shortly. I didn't do any benchmarks, but this should save few CPU time here and there. Please review, Thanks! Samuel Pitoiset (42): mesa: pass the 'caller' func

[Mesa-dev] [PATCH 02/42] mesa: rename attach_shader() to attach_shader_err()

And add a no_error variant. Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 8d044d0fa39..457a18e4175 100644 --

[Mesa-dev] [PATCH 06/42] mesa: add KHR_no_error support for glCreateShader() and glCreateShaderObjectARB()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 4 ++-- src/mesa/main/shaderapi.c | 16 src/mesa/main/shaderapi.h | 6 ++ 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 08/42] mesa: add KHR_no_error support for glCullFace()

--- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/polygon.c | 8 src/mesa/main/polygon.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 415ed6a98bb..ba71d36451e 100644 --- a/src/

[Mesa-dev] [PATCH 09/42] mesa: add front_face() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/polygon.c | 27 +-- src/mesa/main/polygon.h | 2 +- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/polygon.c b/src/mesa/main/polygon.c index 49a60e8e533..7ad536fe5e0 100644 --- a/src/mesa/mai

[Mesa-dev] [PATCH 10/42] mesa: add KHR_no_error support for glFrontFace()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/polygon.c | 8 src/mesa/main/polygon.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index ba71d36451

[Mesa-dev] [PATCH 03/42] mesa: add KHR_no_error support for glAttachShader() and glAttachObjectARB()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 4 ++-- src/mesa/main/shaderapi.c | 28 src/mesa/main/shaderapi.h | 7 ++- 3 files changed, 36 insertions(+), 3 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/g

[Mesa-dev] [PATCH 01/42] mesa: pass the 'caller' function to attach_shader()

In order to fix GL error messages. Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 5a7124043bb..8d044d0fa39 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 14/42] mesa: add bind_texture_unit() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/texobj.c | 56 ++ 1 file changed, 34 insertions(+), 22 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index a5988159a57..5337f0513e4 100644 --- a/src/mesa/main/texobj.c +++

[Mesa-dev] [PATCH 19/42] mesa: prepare create_textures() helper for KHR_no_error support

Signed-off-by: Samuel Pitoiset --- src/mesa/main/texobj.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 0fcf5839689..1b2bb50d1d3 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main

[Mesa-dev] [PATCH 12/42] mesa: add KHR_no_error support for glDepthFunc()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/depth.c | 8 src/mesa/main/depth.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index bcd1205537

[Mesa-dev] [PATCH 05/42] mesa: rename create_shader() to create_shader_err()

And add a no_error variant. Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index bb944191813..52bf0bfaff3 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 22/42] mesa: add KHR_no_error support for gl*Samplers()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/ARB_sampler_objects.xml | 2 +- src/mesa/main/samplerobj.c | 14 ++ src/mesa/main/samplerobj.h | 7 +++ 4 files changed, 23 i

[Mesa-dev] [PATCH 16/42] mesa: prepare create_buffers() helper for KHR_no_error support

Signed-off-by: Samuel Pitoiset --- src/mesa/main/bufferobj.c | 45 ++--- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 6e2979f6db9..e31fcc357da 100644 --- a/src/mesa/main/bufferob

[Mesa-dev] [PATCH 04/42] mesa: pass the 'caller' function to create_shader()

Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 7318833e9b8..bb944191813 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH 07/42] mesa: add cull_face() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/polygon.c | 33 - src/mesa/main/polygon.h | 2 +- 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/polygon.c b/src/mesa/main/polygon.c index 03c63628dfc..13dca6d39cf 100644 --- a/src/me

[Mesa-dev] [PATCH 11/42] mesa: add depth_func() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/depth.c | 51 ++- src/mesa/main/depth.h | 2 +- 2 files changed, 31 insertions(+), 22 deletions(-) diff --git a/src/mesa/main/depth.c b/src/mesa/main/depth.c index 1ea7d1af5c0..4bc000fd138 100644 --

[Mesa-dev] [PATCH 15/42] mesa: add KHR_no_error support for glBindTextureUnit()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/texobj.c | 8 src/mesa/main/texobj.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_dire

[Mesa-dev] [PATCH 23/42] mesa: prepare create_program_pipelines() for KHR_no_error support

Signed-off-by: Samuel Pitoiset --- src/mesa/main/pipelineobj.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index 0f0d1dafffe..ca17fa3f06c 100644 --- a/src/mesa/main/pipelineobj.c

[Mesa-dev] [PATCH 24/42] mesa: add KHR_no_error support for gl*ProgramPipelines()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/ARB_separate_shader_objects.xml | 2 +- src/mesa/main/pipelineobj.c| 14 ++ src/mesa/main/pipelineobj.h| 6 ++ 4 file

[Mesa-dev] [PATCH 18/42] mesa: fix an error message in create_textures()

Trivial. Signed-off-by: Samuel Pitoiset --- src/mesa/main/texobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 30d3c961e6e..0fcf5839689 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -1220,7 +1220,

[Mesa-dev] [PATCH 36/42] mesa: add KHR_no_error support for glVertex*AttribBinding()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/ARB_vertex_attrib_binding.xml | 2 +- src/mesa/main/varray.c | 23 +++ src/mesa/main/varray.h | 7 +++ 4 fi

[Mesa-dev] [PATCH 39/42] mesa: add bind_attrib_location() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/shader_query.cpp | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index 6efbc379656..98441075551 100644 --- a/src/mesa/main/shader_quer

[Mesa-dev] [PATCH 32/42] mesa: add uniform_block_binding() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniforms.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index 71acb288864..ef57866d6dc 100644 --- a/src/mesa/main/uniforms.c +++ b/src/mesa/main/u

[Mesa-dev] [PATCH 34/42] mesa: add shader_storage_block_binding() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniforms.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index a71e0695b05..28f530c4f68 100644 --- a/src/mesa/main/uniforms.c +++ b/src/mesa/mai

[Mesa-dev] [PATCH 13/42] mesa: add KHR_no_error support for glDepthRangeIndexed()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_viewport_array.xml | 2 +- src/mesa/main/viewport.c | 9 + src/mesa/main/viewport.h | 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_viewport_array.xml

[Mesa-dev] [PATCH 33/42] mesa: add KHR_no_error support for glUniformBlockBinding()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_uniform_buffer_object.xml | 2 +- src/mesa/main/uniforms.c | 10 ++ src/mesa/main/uniforms.h | 5 + 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi

[Mesa-dev] [PATCH 37/42] mesa: create read_buffer_err() and always inline read_buffer()

Signed-off-by: Samuel Pitoiset --- src/mesa/main/buffers.c | 46 +- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index d85974afe60..dfee7a4421e 100644 --- a/src/mesa/main/buffers.c +++

[Mesa-dev] [PATCH 17/42] mesa: add KHR_no_error support for gl*Buffers()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/bufferobj.c | 16 src/mesa/main/bufferobj.h | 6 ++ 4 files changed, 24

[Mesa-dev] [PATCH 21/42] mesa: prepare create_samplers() helper for KHR_no_error support

Signed-off-by: Samuel Pitoiset --- src/mesa/main/samplerobj.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index d3ed4da3932..2fbaab9a8dc 100644 --- a/src/mesa/main/samplerobj.c

[Mesa-dev] [PATCH 42/42] mesa: add KHR_no_error support for glClear()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/clear.c | 8 src/mesa/main/clear.h | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 64078c44166

[Mesa-dev] [PATCH 20/42] mesa: add KHR_no_error support for gl*Textures()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/texobj.c | 16 src/mesa/main/texobj.h | 6 ++ 4 files changed, 24

[Mesa-dev] [PATCH 28/42] mesa: add client_wait_sync() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/syncobj.c | 42 ++ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/syncobj.c b/src/mesa/main/syncobj.c index a3124e40056..ce9c99725ea 100644 --- a/src/mesa/main/syncobj.c +++ b/s

[Mesa-dev] [PATCH 40/42] mesa: add KHR_no_error support for glBindAttribLocation()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shader_query.cpp | 11 +++ src/mesa/main/shaderapi.h | 3 +++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index d

[Mesa-dev] [PATCH 26/42] mesa: add KHR_no_error support for gl*Renderbuffers()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +- src/mesa/main/fbobject.c | 16 src/mesa/main/fbobject.h | 6 ++ 4 files changed, 24

[Mesa-dev] [PATCH 25/42] mesa: prepare create_render_buffers() for KHR_no_error support

Signed-off-by: Samuel Pitoiset --- src/mesa/main/fbobject.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 74b38180900..d16fe6bd21a 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/

[Mesa-dev] [PATCH 35/42] mesa: add KHR_no_error support for glShaderStorageBlockBinding()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_shader_storage_buffer_object.xml | 2 +- src/mesa/main/uniforms.c| 12 src/mesa/main/uniforms.h| 6 ++ 3 files changed, 19 insertions(+), 1 deletion(-) dif

[Mesa-dev] [PATCH 27/42] mesa: add KHR_no_error support for glCheckFramebufferStatus()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_framebuffer_object.xml | 2 +- src/mesa/main/fbobject.c | 10 ++ src/mesa/main/fbobject.h | 3 +++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_fr

[Mesa-dev] [PATCH 30/42] mesa: add fence_sync() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/syncobj.c | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/syncobj.c b/src/mesa/main/syncobj.c index 1347a0fcc4b..4278827b11d 100644 --- a/src/mesa/main/syncobj.c +++ b/s

[Mesa-dev] [PATCH 31/42] mesa: add KHR_no_error support for glFenceSync()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_sync.xml | 2 +- src/mesa/main/syncobj.c | 8 src/mesa/main/syncobj.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_sync.xml b/src/mapi/glapi/gen/ARB_sync.xml index

[Mesa-dev] [PATCH 41/42] mesa: add clear() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/clear.c | 54 +-- 1 file changed, 31 insertions(+), 23 deletions(-) diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c index 884cf986c70..1b07a756ee4 100644 --- a/src/mesa/main/clear.c +++ b/

[Mesa-dev] [PATCH 38/42] mesa: add KHR_no_error support for gl*ReadBuffer()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/buffers.c| 33 ++ src/mesa/main/buffers.h| 5 4 files chan

[Mesa-dev] [PATCH 29/42] mesa: add KHR_no_error support for glClientWaitSync()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_sync.xml | 2 +- src/mesa/main/syncobj.c | 10 ++ src/mesa/main/syncobj.h | 3 +++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_sync.xml b/src/mapi/glapi/gen/ARB_sync.xml i

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

This functionality is only available on NV20, NV25, and NV28 (i.e. all the NV2x boards). These are all AGP-only (discounting the NV2A inside Xbox), and I don't have any AGP systems. The way I tested it, through an emulation layer inside the NV3x hardware which lets it present the NV25's 3d class, i

Re: [Mesa-dev] [PATCH 01/11] etnaviv: fill in layer_stride for imported resources

On Fri, Jun 23, 2017 at 05:50:18PM +0200, Lucas Stach wrote: > The layer stride information is used in various parts of the driver, > so it needs to be present regardless if the driver allocated the > buffer itself or merely imported it from an external source. Reviewed-by: Wladimir J. van der Laa

Re: [Mesa-dev] [PATCH v5 3/6] mesa/st: glsl_to_tgsi: add tests for the new temporary lifetime tracker

> > +TEST_F(LifetimeEvaluatorExactTest, SimpleMoveAddMoveTexoffset) > > +{ > > +   const vector code = { > > +  { TGSI_OPCODE_MOV, {1}, {in0}, {}}, > > +  { TGSI_OPCODE_MOV, {2}, {in1}, {}}, > > +  { TGSI_OPCODE_UADD, {out0}, {},  {1,2}}, > > UADD doesn't have texoffsets. The test jus

Re: [Mesa-dev] [PATCH v5 3/6] mesa/st: glsl_to_tgsi: add tests for the new temporary lifetime tracker

On Tue, Jun 27, 2017 at 8:10 AM, Gert Wollny wrote: >> > +TEST_F(LifetimeEvaluatorExactTest, SimpleMoveAddMoveTexoffset) >> > +{ >> > + const vector code = { >> > + { TGSI_OPCODE_MOV, {1}, {in0}, {}}, >> > + { TGSI_OPCODE_MOV, {2}, {in1}, {}}, >> > + { TGSI_OPCODE_UADD, {out0}, {}

Re: [Mesa-dev] [st/va] Fix leak in VAAPI subpictures

Sure Emil, Will take care of it next time. Thank you for the suggestion. Regards, Chandu -Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: Thursday, June 22, 2017 9:48 PM To: Namburu, Chandu-babu Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [st/v

[Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

Add support for ETC2 compressed textures in the etnaviv driver. One step closer towards GL ES 3 support. For now, treat SRGB and RGB formats the same. It looks like these are distinguished using a different bit in sampler state, and not part of the format, but I have not yet been able to confirm

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

On Tue, Jun 27, 2017 at 02:54:56PM +0200, Wladimir J. van der Laan wrote: > Add support for ETC2 compressed textures in the etnaviv driver. > > One step closer towards GL ES 3 support. > > For now, treat SRGB and RGB formats the same. It looks like these are > distinguished using a different bit

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

Am 27.06.2017 um 15:01 schrieb Roland Scheidegger: > These chips can't do border color? I wonder how they got away with that > with d3d since afaik it isn't optional. Err, I should have known better, EVERYTHING is optional with d3d9 (albeit it doesn't mean apps were actually prepared for hw not sup

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

On Tue, Jun 27, 2017 at 9:07 AM, Roland Scheidegger wrote: > Am 27.06.2017 um 15:01 schrieb Roland Scheidegger: >> These chips can't do border color? I wonder how they got away with that >> with d3d since afaik it isn't optional. > Err, I should have known better, EVERYTHING is optional with d3d9

[Mesa-dev] [PATCH mesa] build systems: uniformize git_sha1.h generation

Signed-off-by: Eric Engestrom --- Note: Autotools and SCons are tested, but Android isn't. --- git_sha1_gen.sh | 13 + src/Makefile.am | 13 + src/SConscript | 28 src/mesa/Android

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

These chips can't do border color? I wonder how they got away with that with d3d since afaik it isn't optional. So what happens if you use these border wrap modes? You just get black border? I suppose another question is if you couldn't announce support for it nevertheless. Without a border color,

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

Am 27.06.2017 um 15:11 schrieb Ilia Mirkin: > On Tue, Jun 27, 2017 at 9:07 AM, Roland Scheidegger > wrote: >> Am 27.06.2017 um 15:01 schrieb Roland Scheidegger: >>> These chips can't do border color? I wonder how they got away with that >>> with d3d since afaik it isn't optional. >> Err, I should

Re: [Mesa-dev] [PATCH 02/11] etnaviv: fix memory leak when BO allocation fails

On Fri, Jun 23, 2017 at 05:50:19PM +0200, Lucas Stach wrote: > The resource struct is already allocated at this point and should be > free properly. > > Signed-off-by: Lucas Stach Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 6 +- > 1 file

Re: [Mesa-dev] [PATCH mesa] mesa: add missing include

Reviewed-by: Marek Olšák Marek On Tue, Jun 27, 2017 at 12:50 PM, Eric Engestrom wrote: > src/mesa/drivers/x11/xm_dd.c:688:7: warning: implicit declaration of function > ‘_mesa_update_draw_buffer_bounds’; did you mean > ‘_mesa_has_ARB_draw_buffers_blend’? [-Wimplicit-function-declaration] >

Re: [Mesa-dev] [PATCH 04/11] etnaviv: pad scanout buffer size to RS alignment

On Fri, Jun 23, 2017 at 05:50:21PM +0200, Lucas Stach wrote: > This fixes failures to import the scanout buffer with screen resolutions > that don't satisfy teh RS alignment restrictions, like 1680x1050. Thanks. I remember having this issue on OLPC, but never came up with a good solution. Reviewe

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

On Tue, Jun 27, 2017 at 10:02 AM, Nicolai Hähnle wrote: > On 27.06.2017 00:15, Marek Olšák wrote: >> >> On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle >> wrote: >>> >>> On 20.06.2017 20:00, Marek Olšák wrote: From: Marek Olšák sizeof(struct si_shader_key): Befo

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

On Tue, Jun 27, 2017 at 9:22 AM, Nicolai Hähnle wrote: > On 27.06.2017 02:14, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Shader key size: 107 -> 47 > > > Nice improvement. > > >> Divisors of 0 and 1 are encoded in the shader key. Greater instance >> divisors >> are loaded from a constant bu

Re: [Mesa-dev] gallium: Reduce trace_dump_box_bytes size by box->x.

On Tue, Jun 27, 2017 at 8:57 AM, Michel Dänzer wrote: > On 27/06/17 04:10 AM, Marek Olšák wrote: >> In my opinion, dumping resources isn't very useful. I think it would >> be better to remove that completely. > > You'd have to remove the whole trace driver along with it, since its > purpose is to

Re: [Mesa-dev] [PATCH 11/11] etnaviv: advertise supported dmabuf modifiers

On Fri, Jun 23, 2017 at 05:50:28PM +0200, Lucas Stach wrote: > Simply advertise all supported modifiers, independent of the format. > Special formats, like compressed, which don't support all those modifiers > are already culled from the dmabuf format list, as we don't support > the render target b

Re: [Mesa-dev] [PATCH 07/11] etnaviv: implement resource import with modifier

On Fri, 2017-06-23 at 17:50 +0200, Lucas Stach wrote: > This implements resource import with modifier, deriving the correct > internal layout from the modifier and constructing a render compatible > base resource if needed. > > This removes the special cases for DDX and renderonly scanout allocate

Re: [Mesa-dev] [PATCH 11/11] etnaviv: advertise supported dmabuf modifiers

Am Dienstag, den 27.06.2017, 17:10 +0200 schrieb Wladimir J. van der Laan: > On Fri, Jun 23, 2017 at 05:50:28PM +0200, Lucas Stach wrote: > > Simply advertise all supported modifiers, independent of the format. > > Special formats, like compressed, which don't support all those modifiers > > are al

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

2017-06-27 14:54 GMT+02:00 Wladimir J. van der Laan : > Add support for ETC2 compressed textures in the etnaviv driver. > > One step closer towards GL ES 3 support. > > For now, treat SRGB and RGB formats the same. It looks like these are > distinguished using a different bit in sampler state, and

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

> I can confirm that 11 bit stuff works on the GC2000 . I used piglit's > oes_compressed_etc2_texture-miptree_gles3 for verification. > How have you tested these formats? I rendered the example images from https://github.com/Ericsson/ETCPACK/tree/master/testing/testvectors_correct/pkm, which displ

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50, nvc0: remove IDX from bufctx immediately, to avoid conflicts with clear

Ilia, this patch tries to fix 61d8f3387d which, in turn, tried to fix 330d0607e. None of them did it for 17.1 so I suppose we should leave this out, then. Let me know if you think otherwise. On Sat, 2017-06-24 at 13:24 -0400, Ilia Mirkin wrote: > The idxbuf could linger, and when a clear happene

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

On Tue, Jun 27, 2017 at 05:31:52PM +0200, Wladimir J. van der Laan wrote: > > sure if we should advertise the broken formats (on gpus with HALTI0). FWIW, I did check on both GC2000 and GC3000, so HALTI0 should be ok. Wladimir ___ mesa-dev mailing list

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50, nvc0: remove IDX from bufctx immediately, to avoid conflicts with clear

Indeed you are quite right. My apologies for the incorrect tag. My internal timer said "it's been a while", but I didn't check if it was in the last release. On Tue, Jun 27, 2017 at 11:34 AM, Andres Gomez wrote: > Ilia, this patch tries to fix 61d8f3387d which, in turn, tried to fix > 330d0607e.

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

2017-06-27 17:39 GMT+02:00 Wladimir J. van der Laan : > On Tue, Jun 27, 2017 at 05:31:52PM +0200, Wladimir J. van der Laan wrote: > >> > sure if we should advertise the broken formats (on gpus with HALTI0). > > FWIW, I did check on both GC2000 and GC3000, so HALTI0 should be ok. > Great - could yo

[Mesa-dev] [RFC PATCH 1/2] nir: Add a C wrapper for glsl_type::std430_array_stride

Signed-off-by: Alex Smith --- src/compiler/nir_types.cpp | 7 +++ src/compiler/nir_types.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 25980b9..554130c 100644 --- a/src/compiler/nir_types.cpp +++ b/src/compiler/nir_t

[Mesa-dev] [RFC PATCH 2/2] ac/nir: Don't treat each element as a vec4 in compute shared memory

Currently every element in shared memory (including individual elements of an array) are treated as a vec4. For example, the following: shared uint array[1024]; gets treated as an array of 1024 vec4s with only the first component ever used. This can be highly wasteful of LDS space. We have a

Re: [Mesa-dev] [PATCH mesa] Fix khrplatform.h not installed if EGL is disabled.

Sound like a good inclusion for -stable (?) On Mon, 2017-06-12 at 12:00 +0100, Eric Engestrom wrote: > From: Eric Le Bihan > > KHR/khrplatform.h is required by the EGL, GLES and VG headers, but is > only installed if Mesa3d is compiled with EGL support. > > This patch installs this header file

[Mesa-dev] [PATCH] winsys/radeon: only call pb_slabs_reclaim when slabs are actually used

From: Nicolai Hähnle Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100242 Fixes: fb827c055cb1 ("winsys/radeon: enable buffer allocation from slabs") Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

Re: [Mesa-dev] [PATCH 1/2] svga: clamp device line width to at least 1 to fix HWv8 line stippling

It looks like we could want these 2 into -stable (?) On Thu, 2017-06-15 at 11:41 -0600, Brian Paul wrote: > The line stipple fallback code for virtual HW version 8 didn't work. > > With HW version 8, we were getting zero when querying the max line > widths (AA and non-AA). This means we were set

Re: [Mesa-dev] [PATCH] winsys/radeon: only call pb_slabs_reclaim when slabs are actually used

Good catch! Reviewed-by: Samuel Pitoiset On 06/27/2017 06:19 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100242 Fixes: fb827c055cb1 ("winsys/radeon: enable buffer allocation from slabs") Cc: mesa-sta...@lists.freedesktop.org --- src

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

On 27.06.2017 17:07, Marek Olšák wrote: On Tue, Jun 27, 2017 at 9:22 AM, Nicolai Hähnle wrote: On 27.06.2017 02:14, Marek Olšák wrote: From: Marek Olšák Shader key size: 107 -> 47 Nice improvement. Divisors of 0 and 1 are encoded in the shader key. Greater instance divisors are loaded

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

On 27.06.2017 17:02, Marek Olšák wrote: On Tue, Jun 27, 2017 at 10:02 AM, Nicolai Hähnle wrote: On 27.06.2017 00:15, Marek Olšák wrote: On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle wrote: On 20.06.2017 20:00, Marek Olšák wrote: From: Marek Olšák sizeof(struct si_shader_key): B

[Mesa-dev] [PATCH 1/2] radeonsi: use the DISPATCH packets to force COMPUTE_START_X/Y/Z = 0

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 65f3261..91a6a40 100644 --- a/src/gallium/drivers/radeons

[Mesa-dev] [PATCH 2/2] radeonsi: set COMPUTE_DISPATCH_INITIATOR.ORDER_MODE = 1

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 91a6a40..fba02fa 100644 --- a/src/gallium/drivers/radeonsi/si_compu

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

On Tue, Jun 27, 2017 at 6:50 PM, Nicolai Hähnle wrote: > On 27.06.2017 17:07, Marek Olšák wrote: >> >> On Tue, Jun 27, 2017 at 9:22 AM, Nicolai Hähnle >> wrote: >>> >>> On 27.06.2017 02:14, Marek Olšák wrote: From: Marek Olšák Shader key size: 107 -> 47 >>> >>> >>> >>> N

  1   2   >