From: Kevin Rogovin
This is an RFC for documentation I am making for the Intel OTC
Vulkan driver. The eventual goal for the documentation is to
help new developers understand the code base more quickly so
that they can contribute more easily.
Kevin Rogovin (1):
vulkan: Initial partial
---
src/gbm/main/gbm.h | 10 +-
src/mapi/glapi/glapi.h | 17 +
src/mesa/main/context.c | 45 -
src/mesa/program/program.h | 8 +---
src/mesa/swrast/s_context.h | 10 +-
src/mesa/tnl/t_context.h|
---
doxygen/all.doxy | 1 +
src/gbm/gbm.doxy_text| 15 ++
src/mesa/drivers/dri/i965/i965.doxy_text | 176 +
src/mesa/main/main.doxy_text | 257 +++
src/mesa/program/program.doxy_text |
---
src/gbm/main/gbm.h | 10 +-
src/mapi/glapi/glapi.h | 17 +
src/mesa/main/context.c | 45 -
src/mesa/program/program.h | 8 +---
src/mesa/swrast/s_context.h | 10 +-
src/mesa/tnl/t_context.h|
---
doxygen/all.doxy | 1 +
src/gbm/gbm.doxy_text| 15 ++
src/mesa/drivers/dri/i965/i965.doxy_text | 176 +
src/mesa/main/main.doxy_text | 257 +++
src/mesa/program/program.doxy_text |
This patch adds a function interface for enabling no wrap on batch commands,
adds to it assert enforcement that the number bytes added to the
batch buffer does not exceed a passed value and finally this is used
in brw_try_draw_prims() to help make sure that estimated_max_prim_size
is a good value.
feedback integrated
space-pace
---
src/mesa/drivers/dri/i965/brw_context.h | 85 +++
src/mesa/drivers/dri/i965/brw_draw.c | 4 +-
src/mesa/drivers/dri/i965/brw_state_batch.c | 15 +
src/mesa/drivers/dri/i965/intel_batchbuffer.h | 6 ++
4 files change
Track bytes written during no flush phases for debug builds
---
src/mesa/drivers/dri/i965/brw_context.h | 85 +++
src/mesa/drivers/dri/i965/brw_draw.c | 4 +-
src/mesa/drivers/dri/i965/brw_state_batch.c | 15 +
src/mesa/drivers/dri/i965/intel_batchb
feedback integrated
space-pace
---
src/mesa/drivers/dri/i965/brw_context.h | 85 +++
src/mesa/drivers/dri/i965/brw_draw.c | 4 +-
src/mesa/drivers/dri/i965/brw_state_batch.c | 15 +
src/mesa/drivers/dri/i965/intel_batchbuffer.h | 6 ++
4 files change
Allow for GLSL shaders to have #extension directive
anywhere in source file; during preprocessor, #extension
directives are saved to a list rather than being added
to the pre-processed string. That list is played back
before parsing of pre-processed text takes place.
---
src/glsl/Makefile.sour
Add an additional bit flag, GLSL_EXTENSION_STRICT for
gl_context#Shader#Flags to require that #extension
directives must come before variable of function
declarations. The flag is set to on if MESA_GLSL has
the option extension_strict_ordering in it.
---
src/glsl/glsl_parser_extras.cpp | 6 +++-
Allow for GLSL shaders to have #extension directive
anywhere in source file; during preprocessor, #extension
directives are saved to a list rather than being added
to the pre-processed string. That list is played back
before parsing of pre-processed text takes place.
---
src/glsl/Makefile.sour
Add an additional bit flag, GLSL_EXTENSION_STRICT for
gl_context#Shader#Flags to require that #extension
directives must come before variable or function
declarations. The flag is set to on if MESA_GLSL has
the option extension_strict_ordering in it.
---
src/glsl/glsl_parser_extras.cpp | 7
This (very tiny) patch fixes the bug (#72264) where when
no matching function call was found the error message
gave the line and column number as 0.
---
src/glsl/ast_function.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function
This patch changes the error reporting behavior for incorrect
function invocation (triggered by match_function_by_name()
unable to find a matching function call) from using the line
number information associated to the function name term
to using the line number information of the entire function
Enhancement: if no function signature is found for a function
name, report that the function is not found instead of printing
an empty list of candidates.
---
src/glsl/ast_function.cpp | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/src/glsl/ast_f
Fixes the tests for the depth parameter for TexImage3D calls when the
target type is GL_TEXTURE_2D_ARRAY or GL_TEXTURE_CUBE_MAP_ARRAY
so that a depth value of 0 is accepted. Previously, the check
incorrectly required the depth argument to be atleast 1.
---
src/mesa/main/teximage.c | 4 ++--
1 fi
Add support for GLES2 extentions for floating point and half
floating point textures (GL_OES_texture_float, GL_OES_texture_half_float,
GL_OES_texture_float_linear and GL_OES_texture_half_float_linear).
---
src/mesa/main/extensions.c | 12 +
src/mesa/main/glformats.c | 27
Add support for GLES2 extensions for floating point and half
floating point textures (GL_OES_texture_float, GL_OES_texture_half_float,
GL_OES_texture_float_linear and GL_OES_texture_half_float_linear).
---
src/mesa/main/extensions.c | 12 +-
src/mesa/main/glformats.c | 25
From: Kevin Rogovin
Define the macro GL_OES_standard_derivatives as 1 if the extension
GL_OES_standard_derivatives is supported.
---
src/glsl/glcpp/glcpp-parse.y | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y
index 9887583
Fixes a minor oversight where a precision qualifier was not
allowed for an array of samplers.
---
src/glsl/ast_to_hir.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 1bfb4e5..08fd0d3 100644
--- a/src/glsl/ast_to_hir
Place centroid keyword as an interpolation qualifier.
Previously was a storage qualifier. Fixes front end
to accept input of the form "centroid in type variable"
---
src/glsl/glsl_parser.yy | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/glsl/glsl_parser.yy b
Corrects the format for the temp texture used in
for the case where source framebuffer is an integer
texture when blitframebuffer_texture() cannot be used.
Note: Does NOT correct the underling blits, rather only
corrects the format of the temporary texture to be
an integer format.
---
src/mesa/dr
When deciding if a clear color is suitable for fast clear,
take into account if a color channel is active in the
buffer format.
---
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
b/
From: Kevin Rogovin
This patch sequence enforces an extra check
for GenQueriesARB and DeleteQueriesARB that
is not preset in GenQueries and DeleteQueries.
Kevin Rogovin (2):
Differentiate between GenQueries and GenQueriesARB
Differentiate between DeleteQueries and DeleteQueriesARB
src
From: Kevin Rogovin
The extension, GL_ARB_occlusion_queries mandates that an
INVALID_OPERATION should be thrown if GenQueriesARB is
called while a query is active. In contrast, the GL spec
has no such requirement for GenQueries. This patch unaliases
the two functions and has that the ARB variant
From: Kevin Rogovin
The extension, GL_ARB_occlusion_queries mandates that an
INVALID_OPERATION should be thrown if DeleteQueriesARB is
called while a query is active. In contrast, the GL spec
has no such requirement for DeleteQueries. This patch
unaliases the two functions and has that the ARB
From: Kevin Rogovin
Add helper convenience function that intersects the scissor values
against a passed bounding box. In addition, to avoid replicated code,
make the function _mesa_scissor_bounding_box() use this new function.
---
src/mesa/main/framebuffer.c | 63
From: Kevin Rogovin
Mark GL_ARB_framebuffer_no_attachments as done for i965.
---
docs/GL3.txt | 2 +-
docs/relnotes/10.6.0.html | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 172fd3c..cf3b5a2 100644
--- a/docs/GL3.txt
+++ b
From: Kevin Rogovin
Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments:
- extension table
- additions to gl_framebuffer
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/fbobject.c| 1 +
src/mesa/main/framebuffer.c | 1 +
src/mesa/main/mtypes.h | 52
From: Kevin Rogovin
Change references to gl_framebuffer::Width, Height, MaxNumLayers
and Visual::samples to use the _mesa_geometry_ convenience functions
for those places where the geometry of the gl_framebuffer is needed
(in contrast to the geometry of the intersection of the attachments
of the
From: Kevin Rogovin
Add convenience helper functions for fetching geometry of gl_framebuffer
that return the geometry of the gl_framebuffer instead of the geometry of
the buffers of the gl_framebuffer when then the gl_framebuffer has no
attachments.
---
src/mesa/main/framebuffer.h | 29
From: Kevin Rogovin
Implement GL_ARB_framebuffer_no_attachments in Mesa core
- changes to conditions for framebuffer completenss
- implement set/get functions for framebuffers for
new functions in GL_ARB_framebuffer_no_attachments
---
src/mesa/main/fbobject.c | 154
From: Kevin Rogovin
Enable GL_ARB_framebuffer_no_attachments in i965 for Gen7 and higher.
---
src/mesa/drivers/dri/i965/brw_context.c | 6 ++
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
2 files changed, 7 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b
From: Kevin Rogovin
Define the enumeration constants, function entry points and
glGet for the GL_ARB_framebuffer_no_attachments
---
.../glapi/gen/ARB_framebuffer_no_attachments.xml | 33 +++
src/mapi/glapi/gen/Makefile.am | 1 +
src/mapi/glapi/gen
From: Kevin Rogovin
If the fragment shader has atomic buffer access, the shader must execute
even if the current draw buffer has no attachments.
---
src/mesa/drivers/dri/i965/gen7_wm_state.c | 7 +++
src/mesa/drivers/dri/i965/gen8_ps_state.c | 4
2 files changed, 11 insertions
From: Kevin Rogovin
This patch series implements:
- the needed functionality in Mesa-core for ARB_framebuffer_no_attachments
- implements and enables the extension i965
Kevin Rogovin (10):
mesa:Define extension ARB_framebuffer_no_attachments to gl_framebuffer
for extension
From: Kevin Rogovin
Implement GL_ARB_framebuffer_no_attachments in Mesa core
- changes to conditions for framebuffer completenss
- implement set/get functions for framebuffers for
new functions in GL_ARB_framebuffer_no_attachments
v1 -> v2
Spacing and exceed 80 characters per line fi
From: Kevin Rogovin
Define the enumeration constants, function entry points and
glGet for the GL_ARB_framebuffer_no_attachments.
v1 -> v2
Add output="true" for GetFramebufferParameteriv parameter params.
Alphabetical insertion.
v2 -> v3
Implement _mesa_GetFramebuffe
From: Kevin Rogovin
Ensure that the GPU spawns the fragment shader thread for those
fragment shaders with atomic buffer access.
v1 -> v2
No change.
v2 -> v3
Use utility function _mesa_active_fragment_shader_has_atomic_ops().
Reviewed-by: Tapani Pälli (v1)
Signed-off-by: Kevin R
From: Kevin Rogovin
Add helper function that checks if current fragment shader active
of gl_context has atomic buffer access.
v1 -> v3
Added in v3 of patch series.
Signed-off-by: Kevin Rogovin
---
src/mesa/main/mtypes.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --
From: Kevin Rogovin
Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments:
- extension table
- additions to gl_framebuffer
v1 -> v2
Spacing and trailing spaces fixes.
v2 -> v3
mtypes.h: Correct comment on _HasAttachments.
Signed-off-by: Kevin Rogovin
---
sr
From: Kevin Rogovin
Change references to gl_framebuffer::Width, Height, MaxNumLayers
and Visual::samples to use the _mesa_geometry_ convenience functions
for those places where the geometry of the gl_framebuffer is needed
(in contrast to the geometry of the intersection of the attachments
of the
From: Kevin Rogovin
Add convenience helper functions for fetching geometry of gl_framebuffer
that return the geometry of the gl_framebuffer instead of the geometry of
the buffers of the gl_framebuffer when then the gl_framebuffer has no
attachments.
v1 -> v2
Split from patch "mes
From: Kevin Rogovin
Enable GL_ARB_framebuffer_no_attachments in i965 for Gen7 and higher.
v1 -> v2
No changes.
v2 -> v3
intel_extensions.c: Alphabetize insertion.
Reviewed-by: Ian Romanick (v2)
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/brw_context.c | 6 +
From: Kevin Rogovin
Add helper convenience function that intersects the scissor values
against a passed bounding box. In addition, to avoid replicated code,
make the function _mesa_scissor_bounding_box() use this new function.
v1 -> v2
Split from patch "mesa:helper-conveniance funct
From: Kevin Rogovin
Mark GL_ARB_framebuffer_no_attachments as done for i965.
v1 -> v2
File added to patch series
v2 -> v3
docs/GL3.txt : add done mark under GLES3.1
docs/relnotes/10.6.0.html : maintain alphabetical order
Reviewed-by: Ian Romanick (v2)
Signed-off-by: Kevin R
This patch series implements:
- the needed functionality in Mesa-core for ARB_framebuffer_no_attachments
- implements and enables the extension i965
Kevin Rogovin (10):
mesa: Define infrastructure for ARB_framebuffer_no_attachments
mesa: Constants and functions for
as always error.
v4:
Formatting fixes.
Remove added documentation of how to add enums for glGet
Signed-off-by: Kevin Rogovin
---
.../glapi/gen/ARB_framebuffer_no_attachments.xml | 32 ++
src/mapi/glapi/gen/Makefile.am | 1 +
src/mapi/glapi/gen/
ement
ARB_framebuffer_no_attachment".
White space and long line fixes.
v3:
No changes.
v4:
No changes.
Signed-off-by: Kevin Rogovin
---
src/mesa/main/framebuffer.c | 63 +++--
src/mesa/main/framebuffer.h | 5
2 files changed, 48 insertions(+), 20
s for drivers to implement
ARB_framebuffer_no_attachment".
v3:
Add error check for functions of extension.
Implement DSA functions dependent on extension.
v4:
Formatting fixes.
Signed-off-by: Kevin Rogovin
---
src/mesa/main/framebuffer.h | 28
src/mesa/mai
Ensure that the GPU spawns the fragment shader thread for those
fragment shaders with atomic buffer access.
v2:
No change.
v3:
Use utility function _mesa_active_fragment_shader_has_atomic_ops().
v4:
Formatting fixes.
Reviewed-by: Tapani Pälli (v1)
Signed-off-by: Kevin Rogovin
---
src
Enable GL_ARB_framebuffer_no_attachments in i965 for Gen7 and higher.
v2:
No changes.
v3:
intel_extensions.c: Alphabetize insertion.
v4:
No changes.
Reviewed-by: Ian Romanick (v2)
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/brw_context.c | 6 ++
src/mesa/drivers
functions of extension.
v4:
Formatting fixes.
Add early return to functions when extension(s) not present.
Signed-off-by: Kevin Rogovin
---
src/mesa/main/fbobject.c | 220 ---
1 file changed, 187 insertions(+), 33 deletions(-)
diff --git a/src/mesa/main
Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments:
- extension table
- additions to gl_framebuffer
v2:
Formatting fixes.
v3:
mtypes.h: Correct comment on _HasAttachments.
v4:
Formatting fixes.
mtypes.h: Clarify comments
Signed-off-by: Kevin Rogovin
---
src
: Kevin Rogovin
---
docs/GL3.txt | 4 ++--
docs/relnotes/10.7.0.html | 4 +++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 9d56ee5..fae8253 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -157,7 +157,7 @@ GL 4.3, GLSL 4.30
Add helper function that checks if current fragment shader active
of gl_context has atomic buffer access.
v3:
Added in v3 of patch series.
v4:
Formatting fixes.
Signed-off-by: Kevin Rogovin
---
src/mesa/main/mtypes.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a
remove casts to int.
Formatting fixes.
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/brw_clip_state.c | 9 ++---
src/mesa/drivers/dri/i965/brw_misc_state.c | 9 ++---
src/mesa/drivers/dri/i965/brw_sf_state.c | 6 ++
src/mesa/drivers/dri/i965
From: Noone
For GL_TEXTURE_1D_ARRAY targets we store the depth of the array
in the Height field and leave Depth=1 in the underlying texture
object. When we call intel_miptree_copy_teximage in the process
of re-creating a miptree (possibily because the number of miplevels
has changed) we didn't ac
From: Noone
For GL_TEXTURE_1D_ARRAY targets we store the depth of the array
in the Height field and leave Depth=1 in the underlying texture
object. When we call intel_miptree_copy_teximage in the process
of re-creating a miptree (possibily because the number of miplevels
has changed) we didn't ac
From: Kevin Rogovin
Add extension flag and constant values for ARB_framebuffer_no_attachments.
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/fbobject.c| 1 +
src/mesa/main/framebuffer.c | 1 +
src/mesa/main/mtypes.h | 52 -
4 files
From: Kevin Rogovin
Ensure that the GPU spawns the fragment shader thread for those
fragment shaders with atomic buffer access.
---
src/mesa/drivers/dri/i965/gen7_wm_state.c | 7 +++
src/mesa/drivers/dri/i965/gen8_ps_state.c | 4
2 files changed, 11 insertions(+)
diff --git a/src
From: Kevin Rogovin
Define enumerations, functions and associated glGet's for
extension ARB_framebuffer_no_attachment.
---
.../glapi/gen/ARB_framebuffer_no_attachments.xml | 33 ++
src/mapi/glapi/gen/Makefile.am | 1 +
src/mapi/glapi/gen/gl_AP
From: Kevin Rogovin
Complete the implementation of ARB_framebuffer_no_attachment in Mesa core:
1. Implement _mesa_GetFramebufferParameteriv() and
_mesa_FramebufferParameteri()
2. Additions to _mesa_test_framebuffer_completeness()
---
src/mesa/main/fbobject.c | 153
From: Kevin Rogovin
Enable extension GL_ARB_framebuffer_no_attachment in i965 for Gen7
and higher. Lower gens are left disabled because those generations
do not support fragment shaders with side effects.
---
src/mesa/drivers/dri/i965/brw_context.c | 6 ++
src/mesa/drivers/dri/i965
From: Kevin Rogovin
To assist drivers to implement ARB_framebuffer_no_attachment, provide
a set of convenience functions that check for gl_framebuffer::_HasAttachments
that return the geometry of the gl_framebuffer.
---
src/mesa/main/framebuffer.c | 49
From: Kevin Rogovin
To prepare for i965 to support ARB_framebuffer_no_attachment, use
the convenience functions mesa_geometry_width/height/layers/samples
to specify the geometry of the render target surfaces to the GPU.
---
src/mesa/drivers/dri/i965/brw_clip_state.c | 9 -
src
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/genX_state_upload.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
b/src/mesa/drivers/dri/i965/genX_state_upload.c
index 453b8e4add..1474d9a150 100644
--- a/src
From: Kevin Rogovin
Define the application interface to BatchbufferLogger. The
BatchbufferLogger needs from the application when a GL/GLES
API call is issues and returns. It will use this information
to correctly correlate batchbuffer additions to GL/GLES API
calls.
In addition, because the
From: Kevin Rogovin
Define the output format of the BatchbufferLogger. The output
is a sequence of blocks where blocks can have member blocks
or values. The top level blocks come from the application
calling into the BatchBufferLogger when an GL/GLES API call
is started and returns.
Signed-off
From: Kevin Rogovin
Define the driver interface for BatchbufferLogger. The
interface assumes that for any -thread- there is only
one batchbuffer to which commands are to be added. A
driver needs to provide the information on what is the
active batchbuffer on a calling thread and also a function
From: Kevin Rogovin
The interface for BatchbufferLogger is that it is active
only if it is LD_PRELOAD'ed. Thus, the i965 driver is to
use dlsym to see if it is there, and if so fetch the object
at intel_screen creation.
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/brw_buf
From: Kevin Rogovin
This patch series defines and implements a BatchbufferLogger
for Intel GEN. The main purpose of the BatchbufferLogger is
to strongly correlate API calls to data added to a batchbuffer.
In addition to this function, the BatchbufferLogger also tracks
GPU state (respecting HW
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/common/gen_decoder.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h
index 8b00b6edc2..e3b2457dfd 100644
--- a/src/intel/common/gen_decoder.h
+++ b/src
From: Kevin Rogovin
The length function is needed if one wishes to save GEN binary
shaders to file.
Signed-off-by: Kevin Rogovin
---
src/intel/tools/disasm.c | 7 +++
src/intel/tools/gen_disasm.h | 2 ++
2 files changed, 9 insertions(+)
diff --git a/src/intel/tools/disasm.c b/src
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/tools/disasm.c | 6 +++---
src/intel/tools/gen_disasm.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c
index 251acd313d..27f99e21f9 100644
--- a/src
From: Kevin Rogovin
Without this patch, if a shader has errors, the disassembly of the
shader often stops after the first opcode that has errors.
Signed-off-by: Kevin Rogovin
---
src/intel/tools/disasm.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/Makefile.tools.am | 8 ++
src/intel/tools/.gitignore| 1 +
src/intel/tools/i965_batchbuffer_logger_sh.in | 108 ++
3 files changed, 117 insertions(+)
create mode
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/compiler/brw_eu.c | 11 ++-
src/intel/compiler/brw_eu.h | 3 +++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/intel/compiler/brw_eu.c b/src/intel/compiler/brw_eu.c
index bc297a21b3..8969ae5bda 100644
From: Kevin Rogovin
Without this fix, disassembling of GEN shaders with GPU commands
that the disassembler does not know would result in errors being
added to the annotator which would crash when more than one error
was added.
Signed-off-by: Kevin Rogovin
---
src/intel/compiler
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/Makefile.tools.am | 5 ++
src/intel/tools/.gitignore | 1 +
src/intel/tools/i965_batchbuffer_dump_show.c | 129 +++
3 files changed, 135 insertions(+)
create mode
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/Makefile.tools.am| 6 +-
src/intel/tools/.gitignore | 1 +
.../tools/i965_batchbuffer_dump_show_json.cpp | 253 +
3 files changed, 259 insertions(+), 1
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/Makefile.tools.am | 4
1 file changed, 4 insertions(+)
diff --git a/src/intel/Makefile.tools.am b/src/intel/Makefile.tools.am
index 9919b5f241..c308b816f9 100644
--- a/src/intel/Makefile.tools.am
+++ b/src/intel
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/Makefile.tools.am | 21 ++-
src/intel/tools/.gitignore| 1 +
src/intel/tools/gen_shader_disassembler.c | 221 ++
3 files changed, 242 insertions(+), 1 deletion(-)
create
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/Makefile.tools.am| 6 +-
src/intel/tools/.gitignore | 1 +
src/intel/tools/i965_batchbuffer_dump_show_xml.cpp | 217 +
3 files changed, 223 insertions(+), 1
From: Kevin Rogovin
This patch series implements a needed workaround for Gen9 for ASTC5x5
sampler reads. The crux of the work around is to make sure that the
sampler does not read an ASTC5x5 texture and a surface with an auxilary
buffer without having a texture cache invalidate between such
From: Kevin Rogovin
Blorp will only read from an ASTC5x5 texture if it copies from
such a surface, that can only if an application is fetching
such pixels. Because an ASTC5x3 texture can never be a render
target, we do not need to worry about blorp reading such surfaces
on framebuffer blits, or
From: Kevin Rogovin
Perform the ASTC5x5 workaround tasks for compute; note that
the function does not do anything and immediately returns
if the bug is not present on the hardware.
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/brw_compute.c | 6 ++
1 file changed, 6
From: Kevin Rogovin
Some GEN's have a bug in the sample where if the sampler accesses
a texture with an auxialry surface and an ASTC5x5 texture without
having the texture cache invalidated between such accesses, then
the GPU will hang. This patch defines the infrastructure to
implemen
From: Kevin Rogovin
Perform the ASTC5x5 workaround tasks for drawing; note that
the function does not do anything and immediately returns
if the bug is not present on the hardware.
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/brw_draw.c | 6 ++
src/mesa/drivers
From: Kevin Rogovin
One of the presteps in each draw (and compute) call is to validate
the textures. This is the perfect place (since all texture units
are looped through) to see if ASTC5x5 and/or textures with an
auxilary surface are accessed by the GPU.
Signed-off-by: Kevin Rogovin
---
src
From: Kevin Rogovin
This patch series adds a new debug option to pad each GEM BO
allocated by the brw_bufmgr with random noise values which
are then checked after each batchbuffer dispatch to the kernel.
This can be quite valuable to find diffucult to track down
heisenberg style bugs.
A
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/brw_bufmgr.c | 68 +-
src/mesa/drivers/dri/i965/brw_bufmgr.h | 12 ++
2 files changed, 79 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c
b/src
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/common/gen_debug.c | 1 +
src/intel/common/gen_debug.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/intel/common/gen_debug.c b/src/intel/common/gen_debug.c
index a978f2f..2154b23 100644
--- a/src/intel/common
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/intel_batchbuffer.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
index 91a6506..549ea3e 100644
From: Kevin Rogovin
Define the driver interface for BatchbufferLogger. The
interface assumes that for any -thread- there is only
one batchbuffer to which commands are to be added. A
driver needs to provide the information on what is the
active batchbuffer on a calling thread and also a function
From: Kevin Rogovin
Define the application interface to BatchbufferLogger. The
BatchbufferLogger needs from the application when a GL/GLES
API call is issues and returns. It will use this information
to correctly correlate batchbuffer additions to GL/GLES API
calls.
In addition, because the
From: Kevin Rogovin
This patch series defines and implements a BatchbufferLogger
for Intel GEN. The main purpose of the BatchbufferLogger is
to strongly correlate API calls to data added to a batchbuffer.
In addition to this function, the BatchbufferLogger also tracks
GPU state (respecting HW
From: Kevin Rogovin
The interface for BatchbufferLogger is that it is active
only if it is LD_PRELOAD'ed. Thus, the i965 driver is to
use dlsym to see if it is there, and if so fetch the object
at intel_screen creation.
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/brw_buf
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/genX_state_upload.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
b/src/mesa/drivers/dri/i965/genX_state_upload.c
index 04a492539a..3643d79231 100644
--- a/src
1 - 100 of 192 matches
Mail list logo