Re: [patch 04/13] ppp_generic: fix lockdep warning

2007-05-13 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Mon, 14 May 2007 08:07:00 +0200 > After sending this patch I was a little confused, when next > lockdep warning report appeared, and I thought - since this is > not enough, this patch could be dumped. But now I changed my > mind: there are really ma

Re: [IPSEC]: Don't warn if high-order hash resize fails

2007-05-13 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 14 May 2007 15:48:37 +1000 > Hi Dave: > > I just got this when rekeying my VPN (2.6.21.1): > > events/0: page allocation failure. order:7, mode:0xd0 > [] __alloc_pages+0x1e5/0x2e0 > [] __get_free_pages+0x26/0x50 > [] xfrm_hash_alloc+0x2f/0x80 >

Re: [PATCH] tbf scheduler: TSO support (updated)

2007-05-13 Thread Herbert Xu
Hirokazu Takahashi <[EMAIL PROTECTED]> wrote: > > Uhh, you are right. > skb_shinfo(skb)->gso_segs and skb_shinfo(skb)->gso_size should be used. Actually forget about gso_segs, it's only filled in for TCP. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL

Re: [patch 04/13] ppp_generic: fix lockdep warning

2007-05-13 Thread Jarek Poplawski
On Fri, May 11, 2007 at 02:12:25PM -0700, Andrew Morton wrote: > On Fri, 11 May 2007 14:03:09 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > From: Jeff Garzik <[EMAIL PROTECTED]> > > Date: Fri, 11 May 2007 16:57:19 -0400 > > > > > applied > > > > I was under the impression that this

[IPSEC]: Don't warn if high-order hash resize fails

2007-05-13 Thread Herbert Xu
Hi Dave: I just got this when rekeying my VPN (2.6.21.1): events/0: page allocation failure. order:7, mode:0xd0 [] __alloc_pages+0x1e5/0x2e0 [] __get_free_pages+0x26/0x50 [] xfrm_hash_alloc+0x2f/0x80 [] xfrm_bydst_resize+0x37/0xc0 [] xfrm_hash_resize+0x0/0x80 [] xfrm_hash_resize+0x77/0x80

Re: compile breakage due to [SK_BUFF]: Convert skb->end to sk_buff_data_t

2007-05-13 Thread Muli Ben-Yehuda
On Sun, May 13, 2007 at 08:27:35PM -0300, Arnaldo Carvalho de Melo wrote: > Well, the fix is easy, can you provide a patch? Sure, but I was hoping you had a follow-on patch to get rid of the ugly ifdefs in .c files that would make it irrelevant? if not I'll whip out the obvious patch. Cheers, Mu

Fw: [Bugme-new] [Bug 8474] New: regression failure, can't even ping modem

2007-05-13 Thread Andrew Morton
Begin forwarded message: Date: Sun, 13 May 2007 19:05:40 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 8474] New: regression failure, can't even ping modem http://bugzilla.kernel.org/show_bug.cgi?id=8474 Summary: regression failure, can't even ping m

[PATCH 2.6.21 1/3]S2IO: getringparam ethtool option

2007-05-13 Thread Sreenivasa Honnur
Fwding to Ram, there was a typo in Ram's e-mail id. -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Saturday, May 12, 2007 2:25 AM To: Sreenivasa Honnur Cc: netdev@vger.kernel.org; Alicia Pena; Leonid Grossman; [EMAIL PROTECTED]; Rastapur Santosh; Sivakumar Subraman

[PATCH 15/17] sky2: only disable 88e8056 on some boards

2007-05-13 Thread Florin Malita
Hi Stephen, Stephen Hemminger wrote: Use DMI to add a blacklist of broken board. For now only one is known bad. Gentoo users report driver works on other motherboards (strange). [snip] + .ident = "Gigabyte 965P-S3", + .matches = { + DMI_MATCH(

Re: [PATCH] sky2: re-enable 88E8056 for most motherboards

2007-05-13 Thread kernel
RE: sky2 88e8056 Gigabyte GA-965GM-S2 uATX motherboard Stephen Hemminger wrote: >I can use DMI to narrow down to one motherboard. >Or just let everything through and let user's discover what's unstable, it >fails >relatively quickly. > >Could you please get full PCI info lspci -vvxxx for working/

Re: 2.6.21-rc7: BUG: sleeping function called from invalid context at net/core/sock.c:1523

2007-05-13 Thread Greg KH
On Fri, May 11, 2007 at 06:59:31PM +0530, Satyam Sharma wrote: > [1] This is the first problem point. However, I didn't find any reason > why this particular driver's .disconnect() couldn't sleep. In fact, a > comment in include/linux/usb.h:811 says: > > "The probe() and disconnect() methods a

Re: [BUG][PATCH] Fix race condition about network device name allocation

2007-05-13 Thread Kenji Kaneshige
Hi Stephen, Thank you for comments. I'll try your patch. I have one concern about your patch, though I don't know very much about netdev codes. @@ -3411,6 +3410,9 @@ void unregister_netdevice(struct net_dev > /* Notifier chain MUST detach us from master device. */ > BUG_TRAP(!dev->m

Re: Kconfig warnings on latest GIT

2007-05-13 Thread Simon Horman
On Fri, May 11, 2007 at 01:45:37PM +0200, Johannes Berg wrote: > On Fri, 2007-05-11 at 10:22 +0900, Simon Horman wrote: > > > Actually, it was with ARCH=ia64. I have a feeling that you can get > > it to show up quite easily with anything other than ARCH=powerpc. > > Ick, I didn't know that driver

Re: compile breakage due to [SK_BUFF]: Convert skb->end to sk_buff_data_t

2007-05-13 Thread Randy Dunlap
On Sun, 13 May 2007 20:27:35 -0300 Arnaldo Carvalho de Melo wrote: > Muli Ben-Yehuda wrote: > > On Fri, Apr 27, 2007 at 05:03:44PM +, Linux Kernel Mailing List wrote: > > > > > >> Gitweb: > >> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4305b541357dd

Re: compile breakage due to [SK_BUFF]: Convert skb->end to sk_buff_data_t

2007-05-13 Thread Arnaldo Carvalho de Melo
Muli Ben-Yehuda wrote: On Fri, Apr 27, 2007 at 05:03:44PM +, Linux Kernel Mailing List wrote: Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4305b541357ddbd205aa145dc378926b7cb12283 Commit: 4305b541357ddbd205aa145dc378926b7cb12283 Parent:

compile breakage due to [SK_BUFF]: Convert skb->end to sk_buff_data_t

2007-05-13 Thread Muli Ben-Yehuda
On Fri, Apr 27, 2007 at 05:03:44PM +, Linux Kernel Mailing List wrote: > Gitweb: > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4305b541357ddbd205aa145dc378926b7cb12283 > Commit: 4305b541357ddbd205aa145dc378926b7cb12283 > Parent: 27a884dc3cb63b93

[2/2] 2.6.22-rc1: known regressions

2007-05-13 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions (http://bugzilla.kernel.org/ is not available, information are not up-to-date) Networking Subject: panic with e1000 driver on HP Inte

Re: default y idiocy

2007-05-13 Thread Krzysztof Halasa
James Bottomley <[EMAIL PROTECTED]> writes: > drivers/ata/Kconfig has a select SCSI at the top, so if you selected > modular ATA, you'll be forced to have modular SCSI. Or built-in. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

Re: [PATCH] tbf scheduler: TSO support (updated)

2007-05-13 Thread Hirokazu Takahashi
Hi, > > > I'm now thinking I can make it just hold a TSO packet until > > > p->tokens reaches the size of the packet. I think it is > > > straightforward implementation. I'll try this. > > > > I re-implemented the patch, which is simpler than the previous one. > > > > sch->dev->mtu is used to de

Re: [PATCH] tbf scheduler: TSO support (updated)

2007-05-13 Thread Stephen Hemminger
On Sun, 13 May 2007 21:42:36 +0900 (JST) Hirokazu Takahashi <[EMAIL PROTECTED]> wrote: > Hi, > > > I'm now thinking I can make it just hold a TSO packet until > > p->tokens reaches the size of the packet. I think it is > > straightforward implementation. I'll try this. > > I re-implemented the p

Re: [PATCH] sky2: re-enable 88E8056 for most motherboards

2007-05-13 Thread Daniel Drake
Stephen Hemminger wrote: I can use DMI to narrow down to one motherboard. Or just let everything through and let user's discover what's unstable, it fails relatively quickly. Could you please get full PCI info lspci -vvxxx for working/non-working 88e8056 (Yukon EC-U) systems? It might be some

[patch/resend] smc911x: fix compilation breakage

2007-05-13 Thread Vitaly Wool
Looks like the new version of this patch has been overlooked, so I'm resending it. It just adapts the driver to the new IRQ API according to what Russell has pointed out. drivers/net/smc911x.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) Signed-off-by: Vitaly Wool <[EMAIL PROT

[LAST CALL] [PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-13 Thread jamal
Ok, I am upgrading this to last call after taking in Patricks feedback. Speak now - or send patches against it later. Dave, just let it simmer down for a day or two, then if no complaints, go ahead and apply it. It is against net-2.6 Many thanks to Thomas, Peter and Patrick for their reviews. ch

Re: [patch 4/5] s2io driver updates

2007-05-13 Thread Andreas Schwab
Ananda Raju <[EMAIL PROTECTED]> writes: > @@ -2704,6 +2792,10 @@ static void tx_intr_handler(fifo_info_t > if (txdlp->Control_1 & TXD_T_CODE) { > unsigned long long err; > err = txdlp->Control_1 & TXD_T_CODE; > + if (er

[PATCH] tbf scheduler: TSO support (updated)

2007-05-13 Thread Hirokazu Takahashi
Hi, > I'm now thinking I can make it just hold a TSO packet until p->tokens > reaches the size of the packet. I think it is straightforward > implementation. I'll try this. I re-implemented the patch, which is simpler than the previous one. sch->dev->mtu is used to determine how many segments ar