Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Trond Myklebust
On Fri, Jun 19, 2015 at 9:27 PM, Steven Rostedt wrote: > On Fri, 19 Jun 2015 19:25:59 -0400 > Trond Myklebust wrote: > > >> 8<-- >> >From 4876cc779ff525b9c2376d8076edf47815e71f2c Mon Sep 17 00:00:00 2001 >> From: Trond Myklebust >> Date

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Steven Rostedt
On Fri, 19 Jun 2015 19:25:59 -0400 Trond Myklebust wrote: > 8<-- > >From 4876cc779ff525b9c2376d8076edf47815e71f2c Mon Sep 17 00:00:00 2001 > From: Trond Myklebust > Date: Fri, 19 Jun 2015 16:17:57 -0400 > Subject: [PATCH v2] SUNRPC: En

Re: [PATCH v2] bpf: BPF based latency tracing

2015-06-19 Thread Alexei Starovoitov
On 6/19/15 7:00 AM, Daniel Wagner wrote: BPF offers another way to generate latency histograms. We attach kprobes at trace_preempt_off and trace_preempt_on and calculate the time it takes to from seeing the off/on transition. ... Signed-off-by: Daniel Wagner ... With the rebase on net-next n

[PATCH 2/2] rcar_can: unify error messages

2015-06-19 Thread Sergei Shtylyov
All the error messages in the driver but the ones from devm_clk_get() failures use similar format. Make those two messages consitent with others. Signed-off-by: Sergei Shtylyov --- drivers/net/can/rcar_can.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: linux-can/driv

[PATCH 1/2] rcar_can: print request_irq() error code

2015-06-19 Thread Sergei Shtylyov
Also print the error code when the request_irq() call fails in rcar_can_open(), rewording the error message... Signed-off-by: Sergei Shtylyov --- drivers/net/can/rcar_can.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-can/drivers/net/can/rcar_can.c =

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Steven Rostedt
On Fri, 19 Jun 2015 20:37:45 -0400 Steven Rostedt wrote: > > Is it causing any other damage than the rkhunter warning you reported? > > Well, not that I know of. Are you sure that this port will be > reconnected, and is not just a leak. Not sure if you could waste more > ports this way with con

[PATCH 0/2] Error message clean-ups for Renesas R-Car CAN driver

2015-06-19 Thread Sergei Shtylyov
Hello. Here's the set of 2 patches against Marc Kleine-Budde's 'linux-can.git' repo plus 3 fix patches just posted; they are small error message cleanups for the Renesas R-Car CAN driver. [1/2] rcar_can: print request_irq() error code [2/2] rcar_can: unify error messages WBR, Sergei -- To un

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Steven Rostedt
On Fri, 19 Jun 2015 19:25:59 -0400 Trond Myklebust wrote: > On Fri, 2015-06-19 at 18:14 -0400, Steven Rostedt wrote: > > On Fri, 19 Jun 2015 16:30:18 -0400 > > Trond Myklebust wrote: > > > > > Steven, how about something like the following patch? > > > > > > > OK, the box I'm running this on

[PATCH 3/3] rcar_can: fix typo in error message

2015-06-19 Thread Sergei Shtylyov
Fix typo in the first error message printed by rcar_can_open(). Based on the original patch by Vladimir Barinov. Fixes: 862e2b6af941 ("can: rcar_can: support all input clocks") Reported-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov --- drivers/net/can/rcar_can.c |3 ++- 1 file chang

[PATCH 2/3] rcar_can: print signed IRQ #

2015-06-19 Thread Sergei Shtylyov
Printing IRQ # using "%x" and "%u" unsigned formats isn't quite correct as 'ndev->irq' is of type *int*, so the "%d" format needs to be used instead. While fixing this, beautify the dev_info() message in rcar_can_probe() a bit. Fixes: fd1159318e55 ("can: add Renesas R-Car CAN driver") Signed-o

[PATCH 1/3] rcar_can: fix IRQ check

2015-06-19 Thread Sergei Shtylyov
rcar_can_probe() regards 0 as a wrong IRQ #, despite platform_get_irq() that it calls returns negative error code in that case. This leads to the following being printed to the console when attempting to open the device: error requesting interrupt fffa because rcar_can_open() calls request_i

[PATCH 0/3] Small fixes for Renesas R-Car CAN driver

2015-06-19 Thread Sergei Shtylyov
Hello. Here's the set of 3 patches against Marc Kleine-Budde's 'linux-can.git' repo; they are small fixes for the Renesas R-Car CAN driver. rcar_can: fix IRQ check rcar_can: print signed IRQ # rcar_can: fix typo in error message WBR, Sergei -- To unsubscribe from this list: send the line "un

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Trond Myklebust
On Fri, 2015-06-19 at 18:14 -0400, Steven Rostedt wrote: > On Fri, 19 Jun 2015 16:30:18 -0400 > Trond Myklebust wrote: > > > Steven, how about something like the following patch? > > > > OK, the box I'm running this on is using v4.0.5, can you make a patch > based on that, as whatever you make

[PATCH net] netfilter: nf_queue: Don't recompute the hook_list head

2015-06-19 Thread Eric W. Biederman
If someone sends packets from one of the netdevice ingress hooks to the a userspace queue, and then userspace later accepts the packet, the netfilter code can enter an infinite loop as the list head will never be found. Pass in the saved list_head to avoid this. Signed-off-by: "Eric W. Biederman

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Steven Rostedt
On Fri, 19 Jun 2015 16:30:18 -0400 Trond Myklebust wrote: > Steven, how about something like the following patch? > OK, the box I'm running this on is using v4.0.5, can you make a patch based on that, as whatever you make needs to go to stable as well. distcc[31554] ERROR: compile /home/roste

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Steven Rostedt
On Fri, 19 Jun 2015 16:30:18 -0400 Trond Myklebust wrote: > Steven, how about something like the following patch? Building it now. Will let you know in a bit. > > 8<- > >From 9a0bcfdbdbc793eae1ed6d901a6396b6c66f9513 Mon Sep 17 00

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Steven Rostedt
On Fri, 19 Jun 2015 13:39:08 -0400 Trond Myklebust wrote: > Hang on. This is on the client box while there is an active NFSv4 > mount? Then that's probably the NFSv4 callback channel listening for > delegation callbacks. > > Can you please try: > > echo "options nfs callback_tcpport=4048" > /e

[net-next] vmxnet3: Changes for vmxnet3 adapter version 2 (fwd)

2015-06-19 Thread Shreyas Bhatewara
Make the driver understand adapter version 2. Cc: Rachel Lunnon Signed-off-by: Guolin Yang Signed-off-by: Shreyas N Bhatewara -- diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h index 3718d02..221a530 100644 --- a/drivers/net/vmxnet3/vmxnet3_defs.h +++ b/d

[net-next] vmxnet3: Fix memory leaks in rx path (fwd)

2015-06-19 Thread Shreyas Bhatewara
If rcd length was zero, the page used for frag was not being released. It was being replaced with a newly allocated page. This change takes care of that memory leak. Signed-off-by: Guolin Yang Signed-off-by: Shreyas N Bhatewara --- diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/

[net-next] vmxnet3: Register shutdown handler for device (fwd)

2015-06-19 Thread Shreyas Bhatewara
Implement a handler for pci shutdown so that the driver has an opportunity to make sure that device is quiesced before the PCI switches to legacy IRQs. This way the possibility of "screaming interrupt" is avoided. Acked-by: Shrikrishna Khare Signed-off-by: Shreyas N Bhatewara --- diff --git a/

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Trond Myklebust
On Fri, 2015-06-19 at 15:52 -0400, Jeff Layton wrote: > On Fri, 19 Jun 2015 13:39:08 -0400 > Trond Myklebust wrote: > > > On Fri, Jun 19, 2015 at 1:17 PM, Steven Rostedt < > > rost...@goodmis.org> wrote: > > > On Fri, 19 Jun 2015 12:25:53 -0400 > > > Steven Rostedt wrote: > > > > > > > > > > I

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Jeff Layton
On Fri, 19 Jun 2015 13:39:08 -0400 Trond Myklebust wrote: > On Fri, Jun 19, 2015 at 1:17 PM, Steven Rostedt wrote: > > On Fri, 19 Jun 2015 12:25:53 -0400 > > Steven Rostedt wrote: > > > > > >> I don't see that 55201 anywhere. But then again, I didn't look for it > >> before the port disappeared

Re: [PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key()

2015-06-19 Thread J. Bruce Fields
Thanks, applying.--b. On Tue, Jun 16, 2015 at 09:57:52PM +0200, Fabian Frederick wrote: > Don't opencode sg_init_one() > > Signed-off-by: Fabian Frederick > --- > net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/net/sunrpc/a

Re: [PATCH 02/22] fjes: Hardware initialization routine

2015-06-19 Thread Yasuaki Ishimatsu
Hi Izumi-san, On Thu, 18 Jun 2015 09:49:27 +0900 Taku Izumi wrote: > This patch adds hardware initialization routine to be > invoked at driver's .probe routine. > > Signed-off-by: Taku Izumi > --- > drivers/platform/x86/fjes/Makefile| 2 +- > drivers/platform/x86/fjes/fjes_hw.c | 305

[no subject]

2015-06-19 Thread CEO at Epis
Are You Seriously In Need Of Loan,Get approved loan today, at 3% contact (tracycla...@dr.com)-- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net] netfilter: nf_qeueue: Drop queue entries on nf_unregister_hook

2015-06-19 Thread Eric W. Biederman
Add code to nf_unregister_hook to flush the nf_queue when a hook is unregistered. This guarantees that the pointer that the nf_queue code retains into the nf_hook list will remain valid while a packet is queued. I tested what would happen if we do not flush queued packets and was trivially able

Re: [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-19 Thread roopa
On 6/19/15, 10:17 AM, Robert Shearman wrote: No need for that - use the example of how RTA_MULTIPATH is used for ipv4/ipv6: +--+ | RTA_MULTIPATH| +--+ | +--+ | | | struct rtnexthop | | | +--+ | | | RTA_GATEWAY, et

Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-19 Thread Robert Shearman
On 19/06/15 19:34, roopa wrote: On 6/19/15, 10:25 AM, Robert Shearman wrote: n 19/06/15 16:14, roopa wrote: Today lwtunnel_skb_lwstate is called from lwtunnel_output which is only called from ipv4 code. And my ipv6 variant code was supposed to have a 6 suffix. something like lwtunnel_output6. O

Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-19 Thread roopa
On 6/19/15, 10:25 AM, Robert Shearman wrote: n 19/06/15 16:14, roopa wrote: Today lwtunnel_skb_lwstate is called from lwtunnel_output which is only called from ipv4 code. And my ipv6 variant code was supposed to have a 6 suffix. something like lwtunnel_output6. Or to be more explicit i will prob

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Trond Myklebust
On Fri, Jun 19, 2015 at 1:17 PM, Steven Rostedt wrote: > On Fri, 19 Jun 2015 12:25:53 -0400 > Steven Rostedt wrote: > > >> I don't see that 55201 anywhere. But then again, I didn't look for it >> before the port disappeared. I could reboot and look for it again. I >> should have saved the full ne

Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-19 Thread Robert Shearman
n 19/06/15 16:14, roopa wrote: On 6/19/15, 7:43 AM, Robert Shearman wrote: + +static inline struct lwtunnel_state *lwtunnel_skb_lwstate(struct sk_buff *skb) +{ +struct rtable *rt = (struct rtable *)skb_dst(skb); + +return rt->rt_lwtstate; +} It doesn't look like this patch will build

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

2015-06-19 Thread Steven Rostedt
On Fri, 19 Jun 2015 12:25:53 -0400 Steven Rostedt wrote: > I don't see that 55201 anywhere. But then again, I didn't look for it > before the port disappeared. I could reboot and look for it again. I > should have saved the full netstat -tapn as well :-/ Of course I didn't find it anywhere, tha

Re: [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-19 Thread Robert Shearman
On 19/06/15 16:28, roopa wrote: On 6/19/15, 8:19 AM, Robert Shearman wrote: On 19/06/15 05:49, Roopa Prabhu wrote: From: Roopa Prabhu Introduces two netlink attributes RTA_ENCAP_TYPE and RTA_ENCAP to support attaching encap information to ipv4 routes. Surely RTA_ENCAP_TYPE should be part of

Re: [PATCH net] netfilter: nftables: Do not run chains in the wrong network namespace

2015-06-19 Thread Pablo Neira Ayuso
On Fri, Jun 19, 2015 at 10:41:21AM -0500, Eric W. Biederman wrote: > > Currenlty nf_tables chains added in one network namespace are being > run in all network namespace. The issues are myriad with the simplest > being an unprivileged user can cause any network packets to be dropped. > > Address

[PATCH 03/12] netfilter: x_tables: align per cpu xt_counter

2015-06-19 Thread Pablo Neira Ayuso
From: Eric Dumazet Let's force a 16 bytes alignment on xt_counter percpu allocations, so that bytes and packets sit in same cache line. xt_counter being exported to user space, we cannot add __align(16) on the structure itself. Signed-off-by: Eric Dumazet Cc: Florian Westphal Acked-by: Floria

[PATCH 05/12] netfilter: bridge: split ipv6 code into separated file

2015-06-19 Thread Pablo Neira Ayuso
Resolve compilation breakage when CONFIG_IPV6 is not set by moving the IPv6 code into a separated br_netfilter_ipv6.c file. Fixes: efb6de9b4ba0 ("netfilter: bridge: forward IPv6 fragmented packets") Reported-by: kbuild test robot Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/br_net

[PATCH 07/12] net: sched: Simplify em_ipset_match

2015-06-19 Thread Pablo Neira Ayuso
From: "Eric W. Biederman" em->net is always set and always available, use it in preference to dev_net(skb->dev). Signed-off-by: "Eric W. Biederman" Signed-off-by: Pablo Neira Ayuso --- net/sched/em_ipset.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/em

[PATCH 04/12] netfilter: bridge: rename br_netfilter.c to br_netfilter_hooks.c

2015-06-19 Thread Pablo Neira Ayuso
To prepare separation of the IPv6 code into different file. Signed-off-by: Pablo Neira Ayuso --- net/bridge/Makefile |1 + net/bridge/{br_netfilter.c => br_netfilter_hooks.c} |0 2 files changed, 1 insertion(+) rename net/bridge/{br_netfilter.c => br_netf

[PATCH 08/12] net: include missing headers in net/net_namespace.h

2015-06-19 Thread Pablo Neira Ayuso
Include linux/idr.h and linux/skbuff.h since they are required by objects that are declared in the net structure. struct net { ... struct idr netns_ids; ... struct sk_buff_head wext_nlevents; ... Signed-off-by: Pablo Neira Ayuso Signed-of

[PATCH 01/12] netfilter: nfnetlink_queue: add security context information

2015-06-19 Thread Pablo Neira Ayuso
From: Roman Kubiak This patch adds an additional attribute when sending packet information via netlink in netfilter_queue module. It will send additional security context data, so that userspace applications can verify this context against their own security databases. Signed-off-by: Roman Kubia

[PATCH 06/12] netfilter: Kill unused copies of RCV_SKB_FAIL

2015-06-19 Thread Pablo Neira Ayuso
From: "Eric W. Biederman" This appears to have been a dead macro in both nfnetlink_log.c and nfnetlink_queue_core.c since these pieces of code were added in 2005. Signed-off-by: "Eric W. Biederman" Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetlink_log.c|2 -- net/netfil

[PATCH 12/12] netfilter: xtables: fix warnings on 32bit platforms

2015-06-19 Thread Pablo Neira Ayuso
From: Florian Westphal On 32bit archs gcc complains due to cast from void* to u64. Add intermediate casts to long to silence these warnings. include/linux/netfilter/x_tables.h:376:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] include/linux/netfilter/x_table

[PATCH 11/12] netfilter: Remove spurios included of netfilter.h

2015-06-19 Thread Pablo Neira Ayuso
From: Eric W Biederman While testing my netfilter changes I noticed several files where recompiling unncessarily because they unncessarily included netfilter.h. Signed-off-by: "Eric W. Biederman" Signed-off-by: Pablo Neira Ayuso --- drivers/net/hamradio/bpqether.c |1 - drivers/net/ppp/pp

[PATCH 10/12] netfilter: don't pull include/linux/netfilter.h from netns headers

2015-06-19 Thread Pablo Neira Ayuso
This pulls the full hook netfilter definitions from all those that include net_namespace.h. Instead let's just include the bare minimum required in the new linux/netfilter_defs.h file, and use it from the netfilter netns header files. I also needed to include in.h and in6.h from linux/netfilter.h

[PATCH 09/12] netfilter: use forward declaration instead of including linux/proc_fs.h

2015-06-19 Thread Pablo Neira Ayuso
We don't need to pull the full definitions in that file, a simple forward declaration is enough. Moreover, include linux/procfs.h from nf_synproxy_core, otherwise this hits a compilation error due to missing declarations, ie. net/netfilter/nf_synproxy_core.c: In function ‘synproxy_proc_init’: net

[PATCH 00/12] Netfilter updates for net-next

2015-06-19 Thread Pablo Neira Ayuso
Hi David, The following patchset contains a final Netfilter pull request for net-next 4.2. This mostly addresses some fallout from the previous pull request, small netns updates and a couple of new features for nfnetlink_log and the socket match that didn't get in time for the previous pull reques

[PATCH 02/12] netfilter: xt_socket: add XT_SOCKET_RESTORESKMARK flag

2015-06-19 Thread Pablo Neira Ayuso
From: Harout Hedeshian xt_socket is useful for matching sockets with IP_TRANSPARENT and taking some action on the matching packets. However, it lacks the ability to match only a small subset of transparent sockets. Suppose there are 2 applications, each with its own set of transparent sockets. T

Re: [PATCH next v3] bonding: Display LACP info only to CAP_NET_ADMIN capable user

2015-06-19 Thread Andy Gospodarek
On Fri, Jun 19, 2015 at 10:02:39AM -0700, Mahesh Bandewar wrote: > On Thu, Jun 18, 2015 at 8:00 PM, Andy Gospodarek > wrote: [...] > > With this patch, actor_oper_port_state and partner_oper.port_state are > > not displayed in /proc, but that information is available via netlink > > from bond_fill

Re: [PATCH next v3] bonding: Display LACP info only to CAP_NET_ADMIN capable user

2015-06-19 Thread Mahesh Bandewar
On Thu, Jun 18, 2015 at 8:00 PM, Andy Gospodarek wrote: > > On Thu, Jun 18, 2015 at 11:30:54AM -0700, Mahesh Bandewar wrote: > > Actor and Partner details can be accessed via proc-fs, sys-fs > > entries or netlink interface. These interfaces are world readable > > at this moment. The earlier patch

Re: [PATCH net-next RFC v2 3/3] mpls: support for ip tunnels

2015-06-19 Thread Robert Shearman
On 19/06/15 05:49, Roopa Prabhu wrote: From: Roopa Prabhu Support ip mpls tunnels using the new lwt infrastructure. Signed-off-by: Roopa Prabhu ... +int mpls_output(struct sock *sk, struct sk_buff *skb) +{ + struct mpls_iptunnel_encap *tun_encap_info; + struct mpls_shim_hdr *hdr

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-19 Thread Vivien Didelot
Hi Andrew, On Jun 19, 2015, at 11:05 AM, Andrew Lunn and...@lunn.ch wrote: >> Yes I do have debug too, but via sysfs (with eventually write access) for: >> GLOBAL1, GLOBAL2, cpu port registers, SerDes registers, PVIDs, and VTU. >> Not really standard though. > > We should really get an implementa

[PATCH net] netfilter: nftables: Do not run chains in the wrong network namespace

2015-06-19 Thread Eric W. Biederman
Currenlty nf_tables chains added in one network namespace are being run in all network namespace. The issues are myriad with the simplest being an unprivileged user can cause any network packets to be dropped. Address this by simply not running nf_tables chains in the wrong network namespace. C

Re: [PATCH] xen-netback: fix a BUG() during initialization

2015-06-19 Thread Wei Liu
On Fri, Jun 19, 2015 at 02:21:51PM +0200, Imre Palik wrote: > From: "Palik, Imre" > > Commit edafc132baac ("xen-netback: making the bandwidth limiter runtime > settable") > introduced the capability to change the bandwidth rate limit at runtime. > But it also introduced a possible crashing bug.

Re: [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-19 Thread roopa
On 6/19/15, 8:19 AM, Robert Shearman wrote: On 19/06/15 05:49, Roopa Prabhu wrote: From: Roopa Prabhu Introduces two netlink attributes RTA_ENCAP_TYPE and RTA_ENCAP to support attaching encap information to ipv4 routes. Surely RTA_ENCAP_TYPE should be part of RTA_ENCAP, since the type doesn

Re: [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-19 Thread Robert Shearman
On 19/06/15 05:49, Roopa Prabhu wrote: From: Roopa Prabhu Introduces two netlink attributes RTA_ENCAP_TYPE and RTA_ENCAP to support attaching encap information to ipv4 routes. Surely RTA_ENCAP_TYPE should be part of RTA_ENCAP, since the type doesn't make sense without the data and vice versa

Re: [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-19 Thread roopa
On 6/19/15, 7:55 AM, Robert Shearman wrote: On 19/06/15 15:19, roopa wrote: On 6/18/15, 11:59 PM, Julian Anastasov wrote: Some other places may need changes: - nh_comp: there is logic that decides if same fib_info is reused from many fib nodes. There should be check if NH matches by nh_l

Re: [PATCH 1/1] ssb: remove unncessary out label

2015-06-19 Thread Michael Büsch
On Fri, 19 Jun 2015 14:23:45 +0530 Maninder Singh wrote: > This patch removes unnecessary label "out" and > some restructring for using device_create_file directly. > > Signed-off-by: Maninder Singh > Reviewed-by: Rohit Thapliyal > --- > drivers/ssb/pci.c |8 +--- > 1 files changed, 1

Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-19 Thread roopa
On 6/19/15, 7:43 AM, Robert Shearman wrote: diff --git a/include/linux/lwtunnel.h b/include/linux/lwtunnel.h new file mode 100644 +/* lw tunnel state flags */ +#define LWTUNNEL_STATE_OUTPUT_REDIRECT 0x1 + +#define lwtunnel_output_redirect(lwtstate) (lwtstate && \ +(lwtstate->flags

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-19 Thread Andrew Lunn
> Yes I do have debug too, but via sysfs (with eventually write access) for: > GLOBAL1, GLOBAL2, cpu port registers, SerDes registers, PVIDs, and VTU. > Not really standard though. We should really get an implementation into mainline. There is no point us all implementing our own. You say your co

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-06-19 Thread Vivien Didelot
Hi Andrew, On Jun 17, 2015, at 9:11 PM, Andrew Lunn and...@lunn.ch wrote: > On Wed, Jun 17, 2015 at 02:09:52PM -0400, Vivien Didelot wrote: >> Hi Andrew, All, >> >> On 12/06/15 10:18, Andrew Lunn wrote: >> > By default, DSA and CPU ports are configured to the maximum speed the >> > switch support

Re: [PATCH net-next RFC v2 0/3] light weight tunnel infrastructure and driver

2015-06-19 Thread roopa
On 6/19/15, 7:38 AM, Robert Shearman wrote: This series implements infrastructure for light weight tunnels to support mpls label edge routers (ie mpls ip tunnels). As previously discussed having netdevices will not scale. Hence this series introduces new RTA_ENCAP* attributes to attach encap i

Re: [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-19 Thread Robert Shearman
On 19/06/15 15:19, roopa wrote: On 6/18/15, 11:59 PM, Julian Anastasov wrote: Hello, On Thu, 18 Jun 2015, Roopa Prabhu wrote: @@ -366,6 +371,7 @@ static inline size_t fib_nlmsg_size(struct fib_info *fi) payload += nla_total_size((RTAX_MAX * nla_total_size(4))); if (fi->fib_nhs

Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels

2015-06-19 Thread Robert Shearman
On 19/06/15 05:49, Roopa Prabhu wrote: From: Roopa Prabhu provides ops to parse, build and output encaped packets for drivers that want to attach tunnel encap information to routes. Signed-off-by: Roopa Prabhu --- include/linux/lwtunnel.h |6 ++ include/net/lwtunnel.h| 8

Re: [PATCH net-next RFC v2 0/3] light weight tunnel infrastructure and driver

2015-06-19 Thread Robert Shearman
On 19/06/15 05:49, Roopa Prabhu wrote: From: Roopa Prabhu This series implements infrastructure for light weight tunnels to support mpls label edge routers (ie mpls ip tunnels). As previously discussed having netdevices will not scale. Hence this series introduces new RTA_ENCAP* attributes to a

[PATCH] net: dsa: mv88e6xxx: split phy page accessors

2015-06-19 Thread Vivien Didelot
Split mv88e6xxx_phy_page_read and mv88e6xxx_phy_page_write into two functions each, one to acquire the smi_mutex and one to call the actual read/write functions. This will be useful to access registers such as Fiber/SERDES Control, from setup code with SMI lock held. Also rename their "error" lab

Re: [PATCH net-next 00/15] Simplify netfilter and network namespaces

2015-06-19 Thread Eric W. Biederman
Julian Anastasov writes: > Hello, > > On Thu, 18 Jun 2015, Eric W. Biederman wrote: > >> My incremental patch for ipvs on top of everything else I have pushed >> out looks like this: >> >> From: "Eric W. Biederman" >> Date: Fri, 12 Jun 2015 18:34:12 -0500 >> Subject: [PATCH] ipvs: Pass st

Re: [PATCH net-next RFC v2 2/3] ipv4: add support for light weight tunnel encap attributes

2015-06-19 Thread roopa
On 6/18/15, 11:59 PM, Julian Anastasov wrote: Hello, On Thu, 18 Jun 2015, Roopa Prabhu wrote: @@ -366,6 +371,7 @@ static inline size_t fib_nlmsg_size(struct fib_info *fi) payload += nla_total_size((RTAX_MAX * nla_total_size(4))); if (fi->fib_nhs) { + size_t

[PATCH v2 net-next] macvtap: Increase limit of macvtap queues

2015-06-19 Thread Pankaj Gupta
Macvtap should be compatible with tuntap for maximum number of queues. commit 'baf71c5c1f80d82e92924050a60b5baaf97e3094 (tuntap: Increase the number of queues in tun.)' removes the limitations and increases number of queues in tuntap. Now, Its safe to increase number of queues in Macvtap as wel

[PATCH v2] bpf: BPF based latency tracing

2015-06-19 Thread Daniel Wagner
BPF offers another way to generate latency histograms. We attach kprobes at trace_preempt_off and trace_preempt_on and calculate the time it takes to from seeing the off/on transition. The first array is used to store the start time stamp. The key is the CPU id. The second array stores the log2(ti

[PATCH v1] bpf: BPF based latency tracing

2015-06-19 Thread Daniel Wagner
BPF offers another way to generate latency histograms. We attach kprobes at trace_preempt_off and trace_preempt_on and calculate the time it takes to from seeing the off/on transition. The first array is used to store the start time stamp. The key is the CPU id. The second array stores the log2(ti

Re: [PATCH net-next v2] bridge: multicast: start querier timer when running user-space stp

2015-06-19 Thread Nikolay Aleksandrov
> On Jun 19, 2015, at 4:47 PM, Herbert Xu wrote: > > On Fri, Jun 19, 2015 at 01:45:50AM -0700, Nikolay Aleksandrov wrote: >> When STP is running in user-space and querier is configured, the >> querier timer is not started when a port goes to a non-blocking state. >> This patch unifies the user-

Re: [PATCH] net: inet_diag: export IPV6_V6ONLY sockopt

2015-06-19 Thread Eric Dumazet
On Fri, 2015-06-19 at 14:15 +0200, Phil Sutter wrote: > For AF_INET6 sockets, the value of struct ipv6_pinfo.ipv6only is > exported to userspace. It indicates whether an unbound socket listens on > IPv4 as well as IPv6. What is an 'unbound socket' ??? This makes no sense to me here. > Since the

Re: [PATCH net-next v2] bridge: multicast: start querier timer when running user-space stp

2015-06-19 Thread Herbert Xu
On Fri, Jun 19, 2015 at 01:45:50AM -0700, Nikolay Aleksandrov wrote: > When STP is running in user-space and querier is configured, the > querier timer is not started when a port goes to a non-blocking state. > This patch unifies the user- and kernel-space stp multicast port enable > path and enabl

Re: [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta"

2015-06-19 Thread Simon Guinot
On Wed, Jun 17, 2015 at 05:01:12PM +, Jason Cooper wrote: > Hi Gregory, > > On Wed, Jun 17, 2015 at 05:15:28PM +0200, Gregory CLEMENT wrote: > > On 17/06/2015 17:12, Gregory CLEMENT wrote: > > > On 17/06/2015 15:19, Simon Guinot wrote: > > >> The mvneta driver supports the Ethernet IP found in

[PATCH] xen-netback: fix a BUG() during initialization

2015-06-19 Thread Imre Palik
From: "Palik, Imre" Commit edafc132baac ("xen-netback: making the bandwidth limiter runtime settable") introduced the capability to change the bandwidth rate limit at runtime. But it also introduced a possible crashing bug. If netback receives two XenbusStateConnected without getting the hotplu

[PATCH] net: inet_diag: export IPV6_V6ONLY sockopt

2015-06-19 Thread Phil Sutter
For AF_INET6 sockets, the value of struct ipv6_pinfo.ipv6only is exported to userspace. It indicates whether an unbound socket listens on IPv4 as well as IPv6. Since the socket is natively IPv6, it is not listed by e.g. 'netstat -l -4'. Signed-off-by: Phil Sutter --- This patch is accompanied by

Re: [PATCH net-next] inet_diag: Remove _bh suffix in inet_diag_dump_reqs().

2015-06-19 Thread Hiroaki Shimoda
On Thu, 18 Jun 2015 23:42:08 -0700 Eric Dumazet wrote: > Sure, although this will soon be removed completely when SYN_RECV > sockets will be stored in regular ehash table. OK. Thank you for letting me know. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mes

Re: [PATCH v2] fm10k: Report MAC address on driver load

2015-06-19 Thread Jeff Kirsher
On Thu, 2015-06-18 at 19:41 -0700, Alexander Duyck wrote: > This change adds the MAC address to the list of values recorded on > driver > load. The MAC address represents the serial number of the unit and > allows > us to track the value should a card be replaced in a system. > > The log message

[PATCH 1/1] ssb: remove unncessary out label

2015-06-19 Thread Maninder Singh
This patch removes unnecessary label "out" and some restructring for using device_create_file directly. Signed-off-by: Maninder Singh Reviewed-by: Rohit Thapliyal --- drivers/ssb/pci.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/ssb/pci.c b/drivers/ss

[PATCH net-next v2] bridge: multicast: start querier timer when running user-space stp

2015-06-19 Thread Nikolay Aleksandrov
When STP is running in user-space and querier is configured, the querier timer is not started when a port goes to a non-blocking state. This patch unifies the user- and kernel-space stp multicast port enable path and enables it in all states different from blocking. Note that when a port goes in BR

Re: [PATCH net 0/2] bridge: multicast behaviour fixes

2015-06-19 Thread Nikolay Aleksandrov
> On Jun 17, 2015, at 2:28 PM, Nikolay Aleksandrov > wrote: > > Hi, > Patch 01 fixes a problem when a router is configured and a port goes > through a link down/up, the router configuration was not restored. > Patch 02 starts the multicast querier when using user-space STP and a > port goes to

Re: [PATCH RFC net] neigh: do not modify unlinked entries

2015-06-19 Thread Julian Anastasov
Hello, On Fri, 19 Jun 2015, YOSHIFUJI Hideaki/吉藤英明 wrote: > Should we always drop the packet here since it is > already dead, shouldn't we? It can be a NETDEV_CHANGEADDR event, eth_header() will build valid header. It can be some race condition with neigh_forced_gc and neigh_per

[PATCH net v2] bridge: multicast: restore router configuration on port link down/up

2015-06-19 Thread Nikolay Aleksandrov
From: Satish Ashok When a port goes through a link down/up the multicast router configuration is not restored. Signed-off-by: Satish Ashok Signed-off-by: Nikolay Aleksandrov Fixes: 0909e11758bd ("bridge: Add multicast_router sysfs entries") Acked-by: Herbert Xu --- v2: Added the acked-by and

Re: [PATCH net v2] tcp: Do not call tcp_fastopen_reset_cipher from interrupt context

2015-06-19 Thread Eric Dumazet
On Thu, 2015-06-18 at 09:15 -0700, Christoph Paasch wrote: > tcp_fastopen_reset_cipher really cannot be called from interrupt > context. It allocates the tcp_fastopen_context with GFP_KERNEL and > calls crypto_alloc_cipher, which allocates all kind of stuff with > GFP_KERNEL. > > Thus, we might sl

Re: [PATCH RFC net] neigh: do not modify unlinked entries

2015-06-19 Thread YOSHIFUJI Hideaki/吉藤英明
Hi, Julian Anastasov wrote: > The lockless lookups can return entry that is unlinked. > Sometimes they get reference before last neigh_cleanup_and_release, > sometimes they do not need reference. Later, any > modification attempts may result in the following problems: > > 1. entry is not destroye