[PATCH] net: hisilicon: fix ptr_ret.cocci warnings

2015-10-19 Thread kbuild test robot
drivers/net/ethernet/hisilicon/hns/hnae.c:442:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Arnd Bergmann Signed-off-by: Fengguang Wu --- hnae.c |5 + 1 file changed, 1 ins

[net-next:master 241/245] drivers/net/ethernet/hisilicon/hns/hnae.c:442:1-3: WARNING: PTR_ERR_OR_ZERO can be used

2015-10-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 7b4b000951f09cfe3604a6fdf5469894b4e75adb commit: 876133d3161dcb743983d1f9e5bf247aea2fb0f1 [241/245] net: hisilicon: add OF dependency coccinelle warnings: (new ones prefixed by >>) >> drivers/net/ethernet

Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-19 Thread Oliver Neukum
On Mon, 2015-10-19 at 21:16 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > > usbnet drives no devices of its own. It makes more sense to > > select it whenever a driver for actual hardware that needs > > it is chosen rather than offer it as an option of its own. > > > > Signed-off-by: Olive

Re: [PATCH nf-next 4/4] netfilter: ipv6: avoid nf_iterate recursion

2015-10-19 Thread Joe Stringer
On 17 October 2015 at 13:14, Florian Westphal wrote: > @@ -606,19 +599,22 @@ struct sk_buff *nf_ct_frag6_gather(struct net *net, > struct sk_buff *skb, u32 use > spin_unlock_bh(&fq->q.lock); > pr_debug("Can't insert skb to queue\n"); > inet_frag_put

Re: [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag

2015-10-19 Thread Joe Stringer
On 17 October 2015 at 13:14, Florian Westphal wrote: > [ CC netdev since patch #2 isn't nf-specific. Dave, if you want > I can resubmit that one after the next nf-pull request; let me know if > you would prefer that ]. > > Openvswitch seems broken wrt. to defragmentation, it doesn't call > nf

Re: [PATCH 1/2] NFC: delete null dereference

2015-10-19 Thread Samuel Ortiz
Hi Julia, On Sat, Oct 17, 2015 at 11:32:19AM +0200, Julia Lawall wrote: > The exit label performs device_unlock(&dev->dev);, which will fail when dev > is NULL, and nfc_put_device(dev);, which is not useful when dev is NULL, so > just exit the function immediately. > > Problem found using scripts

Re: [PATCH] nfc: netlink: avoid NULL pointer dereference on error

2015-10-19 Thread Samuel Ortiz
Hi Vincent, On Wed, Oct 07, 2015 at 11:33:19AM +0200, Vincent Stehlé wrote: > The function nfc_genl_llc_sdreq() can dereference the dev pointer while > it is NULL on its error path. Create a new error handling label to avoid > that. > > This fixes the following coccinelle error: > > ./net/nfc/

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-10-19 Thread Tom Herbert
On Mon, Oct 19, 2015 at 8:40 PM, Eric Dumazet wrote: > From: Eric Dumazet > > Tom Herbert added SIT support to GRO with commit > 19424e052fb4 ("sit: Add gro callbacks to sit_offload"), > later reverted by Herbert Xu. > > The problem came because Tom patch was building GRO > packets without proper

[PATCH net-next] ipv6: gro: support sit protocol

2015-10-19 Thread Eric Dumazet
From: Eric Dumazet Tom Herbert added SIT support to GRO with commit 19424e052fb4 ("sit: Add gro callbacks to sit_offload"), later reverted by Herbert Xu. The problem came because Tom patch was building GRO packets without proper meta data : If packets were locally delivered, we would not care.

[PATCH net-next] net: dummy: add more features

2015-10-19 Thread Eric Dumazet
From: Eric Dumazet While testing my SIT/GRO patch using netfilter TEE module and a dummy device, I found some features were missing : TSO IPv6, UFO, and encapsulated traffic. ethtool -k dummy0 now gives : ... tcp-segmentation-offload: on tx-tcp-segmentation: on tx-tcp-ecn-segmen

Re: [PATCH V4 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-19 Thread xiakaixu
于 2015/10/20 10:14, Alexei Starovoitov 写道: > On 10/19/15 3:37 AM, Kaixu Xia wrote: >> +/* flags for PERF_EVENT_ARRAY maps*/ >> +enum { >> +BPF_EVENT_CTL_BIT_CUR = 0, >> +BPF_EVENT_CTL_BIT_ALL = 1, >> +__NR_BPF_EVENT_CTL_BITS, >> +}; >> + >> +#defineBPF_CTL_BIT_FLAG_MASK \ >> +((

[PATCHv3 net 2/4] openvswitch: Clarify conntrack COMMIT behaviour

2015-10-19 Thread Joe Stringer
The presence of this attribute does not modify the ct_state for the current packet, only future packets. Make this more clear in the header definition. Signed-off-by: Joe Stringer --- v3: First post. --- include/uapi/linux/openvswitch.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[PATCHv3 net 1/4] openvswitch: Reject ct_state masks for unknown bits

2015-10-19 Thread Joe Stringer
Currently, 0-bits are generated in ct_state where the bit position is undefined, and matches are accepted on these bit-positions. If userspace requests to match the 0-value for this bit then it may expect only a subset of traffic to match this value, whereas currently all packets will have this bit

[PATCHv3 net 4/4] openvswitch: Serialize nested ct actions if provided

2015-10-19 Thread Joe Stringer
If userspace provides a ct action with no nested mark or label, then the storage for these fields is zeroed. Later when actions are requested, such zeroed fields are serialized even though userspace didn't originally specify them. Fix the behaviour by ensuring that no action is serialized in this c

[PATCHv3 net 3/4] openvswitch: Mark connections new when not confirmed.

2015-10-19 Thread Joe Stringer
New, related connections are marked as such as part of ovs_ct_lookup(), but they are not marked as "new" if the commit flag is used. Make this consistent by setting the "new" flag whenever !nf_ct_is_confirmed(ct). Reported-by: Jarno Rajahalme Signed-off-by: Joe Stringer --- v2: Acked. v3: Took a

Re: [PATCH V4 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-19 Thread Alexei Starovoitov
On 10/19/15 3:37 AM, Kaixu Xia wrote: +/* flags for PERF_EVENT_ARRAY maps*/ +enum { + BPF_EVENT_CTL_BIT_CUR = 0, + BPF_EVENT_CTL_BIT_ALL = 1, + __NR_BPF_EVENT_CTL_BITS, +}; + +#defineBPF_CTL_BIT_FLAG_MASK \ + ((1ULL << __NR_BPF_EVENT_CTL_BITS) - 1) +#define

Re: [PATCH v2 net-next 3/4] ipv6: Add gro functions to sit_offloads

2015-10-19 Thread Eric Dumazet
On Fri, 2015-10-16 at 08:23 -0700, Eric Dumazet wrote: > What about the following more complete patch ? > > We properly set skb->encapsulation and inner network header as some NIC > drivers depend on it. Our GSO should also work properly I think. > > Wolfgang, could you please test it ? (this is

Routing Policy Database Rule 0

2015-10-19 Thread Richard Laing
Hi, We recently found a bug in our code which resulted in rule 0 in the routing policy database being deleted, this is a bad thing and the man page documentation for "ip rule" indicates Rule 0 is special. It cannot be deleted or overridden. which seems entirely reasonable. The code in net/core

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-19 Thread Eric Dumazet
On Tue, 2015-10-20 at 02:12 +0100, Alan Burlison wrote: > Another problem is that if I call close() on a Linux socket that's in > accept() the accept call just sits there until there's an incoming > connection, which succeeds even though the socket is supposed to be > closed, but then an immedi

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-19 Thread Alan Burlison
On 20/10/2015 00:33, Eric Dumazet wrote: It looks it is a long standing problem, right ? Yep, seems so. inet_shutdown() has this very specific comment from beginning of git tree : switch (sk->sk_state) { ... /* Remaining two branches are temporary solution for missing

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-19 Thread Alexei Starovoitov
On 10/19/15 4:02 PM, Hannes Frederic Sowa wrote: I bet commercial software will make use of this ebpf framework, too. And the kernel always helped me and gave me a way to see what is going on, debug which part of my operating system universe interacts with which other part. Merely dropping file d

[PATCH net] netfilter: xt_TEE: fix NULL dereference

2015-10-19 Thread Eric Dumazet
From: Eric Dumazet iptables -I INPUT ... -j TEE --gateway 10.1.2.3 because --oif was not specified tee_tg_check() sets ->priv pointer to NULL in this case. Fixes: bbde9fc1824a ("netfilter: factor out packet duplication for IPv4/IPv6") Signed-off-by: Eric Dumazet --- net/netfilter/xt_TEE.c |

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-19 Thread John Stultz
On Mon, Oct 19, 2015 at 5:18 PM, Christopher Hall wrote: > On Thu, 15 Oct 2015 01:15:57 -0700, Thomas Gleixner > wrote: >>> >>> > >>> > > +#define SHADOW_HISTORY_DEPTH 7 >>> > >>> > And that number is 7 because? >>> >>> Due to power of 2 it will be 8 instead. As above the useful history is >>> 8-

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-19 Thread Alexei Starovoitov
On 10/19/15 3:17 PM, Daniel Borkmann wrote: On 10/19/2015 10:48 PM, Alexei Starovoitov wrote: On 10/19/15 1:03 PM, Hannes Frederic Sowa wrote: I doubt it will stay a lightweight feature as it should not be in the responsibility of user space to provide those debug facilities. It feels we're

Re: [PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-19 Thread Thomas Graf
On 10/19/15 at 04:13pm, Joe Stringer wrote: > I think that the proper solution instead of this patch is to set NEW > if !nf_ct_is_confirmed(ct). This is more accurately the meaning for > 'NEW' that we are actually trying to expose. As long as this is done > before confirming the connection during a

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-19 Thread Christopher Hall
Thomas, On Thu, 15 Oct 2015 01:15:57 -0700, Thomas Gleixner wrote: > > > +#define SHADOW_HISTORY_DEPTH 7 > > And that number is 7 because? Due to power of 2 it will be 8 instead. As above the useful history is 8-2*1 ms (1 ms is the minimum jiffy length). Array size 4 would not be enough

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-19 Thread Eric Dumazet
On Mon, 2015-10-19 at 09:59 -0700, Stephen Hemminger wrote: > This looks like corner case, but worth forwarding. > > Begin forwarded message: > > Date: Mon, 19 Oct 2015 13:21:33 + > From: "bugzilla-dae...@bugzilla.kernel.org" > > To: "shemmin...@linux-foundation.org" > Subject: [Bug 106241

Re: [PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-19 Thread Joe Stringer
On 19 October 2015 at 02:03, Thomas Graf wrote: > On 10/19/15 at 12:07am, Joe Stringer wrote: >> > I'm probably missing something obvious. Why is the reply direction >> > not considered NEW? Wouldn't this consider an ICMPv6 as related+new >> > depending on simply the direction? >> >> My thoughts w

Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

2015-10-19 Thread Michael Chan
On Sun, 2015-10-18 at 22:19 -0700, Stephen Hemminger wrote: > On Sat, 17 Oct 2015 00:21:44 -0400 > Michael Chan wrote: > > > +static bool bnxt_vf_pciid(int idx) > > +{ > > + if (idx == BCM57304_VF || idx == BCM57404_VF) > > + return true; > > + return false; > > +} > > + > > I pre

[net-next v2 01/17] i40e: Lock for VSI's MAC filter list

2015-10-19 Thread Jeff Kirsher
From: Kiran Patil This patch introduces a spinlock which is to be used for synchronizing access to VSI's MAC filter list. This patch also synchronizes execution of other codepaths which are accessing VSI's MAC filter list with execution of service_task:sync_vsi_filters. In function i40e_add_vsi

[net-next v2 08/17] i40e/i40evf: change dynamic interrupt thresholds

2015-10-19 Thread Jeff Kirsher
From: Jesse Brandeburg The dynamic algorithm, while now working, doesn't have good performance in 40G mode. One part of this patch addresses the high CPU utilization of some small streaming workloads that the driver should reduce CPU in. It also changes the minimum ITR that the dynamic algorith

[net-next v2 05/17] i40evf: don't give up

2015-10-19 Thread Jeff Kirsher
From: Mitch Williams When the VF driver is unable to communicate with the PF, it just gives up and never tries again. Aside from the obvious character flaw that this shows, it's also a lousy user experience. When PF communications fail, wait five seconds, and try again. And again. Don't give up,

[net-next v2 03/17] i40e: Fix basic support for X722 devices

2015-10-19 Thread Jeff Kirsher
From: Anjali Singhai Acquire NVM, before issuing an AQ read nvm command for X722. We need to acquire the NVM before issuing an AQ read to the NVM otherwise we will get EBUSY from the FW. Also release when done. This fixes the two X722 issues with respect to eeprom checksum verify and reading NVM

[net-next v2 06/17] i40e/i40evf: refactor IRQ enable function

2015-10-19 Thread Jeff Kirsher
From: Jesse Brandeburg This change moves a multi-line register setting into a function which simplifies reading the flow of the enable function. This also fixes a bug where the enable function was enabling the interrupt twice while trying to update the two interrupt throttle rate thresholds for

[net-next v2 07/17] i40e/i40evf: fix bug in throttle rate math

2015-10-19 Thread Jeff Kirsher
From: Jesse Brandeburg The driver was using a value expressed in 2us increments for the divisor to figure out our bytes/usec values. Fix the usecs variable to contain a value in microseconds. Change-ID: I5c20493103c295d6f201947bb908add7040b7c41 Signed-off-by: Jesse Brandeburg Tested-by: Andrew

[net-next v2 09/17] i40e/i40evf: adjust interrupt throttle less frequently

2015-10-19 Thread Jeff Kirsher
From: Jesse Brandeburg The adaptive ITR (interrupt throttle rate) algorithm was adjusting the hardware's interrupt rate too frequently. This caused a lot of variation in the interrupt rate for fairly constant workloads. Change the code to have a counter and adjust only once every N number of in

[net-next v2 04/17] i40e/i40evf: use napi_schedule_irqoff()

2015-10-19 Thread Jeff Kirsher
From: Alexander Duyck The i40e_intr and i40e/i40evf_msix_clean_rings functions run from hard interrupt context or with interrupts already disabled in netpoll. They can use napi_schedule_irqoff() instead of napi_schedule() Signed-off-by: Alexander Duyck Tested-by: Andrew Bowers Signed-off-by:

[net-next v2 10/17] i40e: Fix for Tools loopback test failing after driver load

2015-10-19 Thread Jeff Kirsher
From: Carolyn Wyborny This patch fixes a problem where our Tools MAC Loopback test, after driver unbind would fail. This was because the hw was configured for multiqueue and unbind operation did not clear this configuration. The problem is fixed by resetting this configuration in i40e_remove. C

[net-next v2 15/17] i40e: fix kernel-doc argument name

2015-10-19 Thread Jeff Kirsher
From: Jean Sacren The second argument name in the kernel-doc argument list for i40e_features_check() was slightly off. Fix it for the kernel doc. Signed-off-by: Jean Sacren Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file cha

[net-next v2 02/17] i40evf: fix overlong BIT defines

2015-10-19 Thread Jeff Kirsher
From: Jesse Brandeburg The defines from the RSS enabling call were mistakenly missed in the patches to the i40e which should have been to i40evf as well. This is a follow up to (commit ed921559886dd40528) "fix 32 bit build warnings". Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Si

[net-next v2 12/17] i40e/i40evf: Fix an accidental error with BIT_ULL replacement

2015-10-19 Thread Jeff Kirsher
From: Anjali Singhai Jain A mask value of 0x1FF was accidentally replaced with a bit mask causing flow director sideband to be broken. Change-ID: Id3387f67dd1b567b41692b570b383c58671e1eae Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/

[net-next v2 16/17] i40e: declare rather than initialize int object

2015-10-19 Thread Jeff Kirsher
From: Jean Sacren 'err' would be overwritten immediately, so we should declare it only rather than initialize it to zero. Signed-off-by: Jean Sacren Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1

[net-next v2 11/17] i40e: fix for PHY NVM interaction problem

2015-10-19 Thread Jeff Kirsher
From: Carolyn Wyborny This patch fixes a problem where the NVMUpdate Tool, when using the PHY NVM feature, gets bad data from the PHY because of contention on the MDIO interface from get PHY capability calls from the driver during regular operations. The problem is fixed by adding a check if med

[net-next v2 14/17] i40e: Move error message to debug level

2015-10-19 Thread Jeff Kirsher
From: Catherine Sullivan There is an error coming back from get_phy_capabilities that does not seem to have any functional implications. We will continue looking into why this error message is occurring, but in the meantime, we will move it to debug to avoid confusion. Change-ID: I9091754bf62c06

[net-next v2 17/17] i40e/i40evf: Bump i40e to 1.3.38 and i40evf to 1.3.25

2015-10-19 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: Id0a7ecaa491f88ce94c9eba4901e592a56044ee0 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 2 fil

[net-next v2 13/17] i40e: Fix order of checks when enabling/disabling autoneg in ethtool

2015-10-19 Thread Jeff Kirsher
From: Catherine Sullivan We were previously checking if autoneg was allowed to change before checking if autoneg was changing. We need to do this in the other order or else we will erroneously return EINVAL when autoneg is not changing. Change-ID: Iff9f7d1c9bddc1ad1e5d227d4f42754f90155410 Signed

[net-next v2 00/17][pull request] Intel Wired LAN Driver Updates 2015-10-19

2015-10-19 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Kiran adds a spinlock around code accessing VSI MAC filter list to ensure that we are synchronizing access to the filter list, otherwise we can end up with multiple accesses at the same time which can cause the VSI MAC filter list to get in an

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-19 Thread Daniel Borkmann
On 10/19/2015 10:48 PM, Alexei Starovoitov wrote: On 10/19/15 1:03 PM, Hannes Frederic Sowa wrote: I doubt it will stay a lightweight feature as it should not be in the responsibility of user space to provide those debug facilities. It feels we're talking past each other. I want to solve 'per

Re: linux 3.4.43 : kernel crash at __nf_conntrack_confirm

2015-10-19 Thread Ani Sinha
On Mon, Oct 19, 2015 at 1:33 PM, Florian Westphal wrote: > Ani Sinha wrote: >> On Sun, Oct 18, 2015 at 2:40 PM, Florian Westphal wrote: >> > Ani Sinha wrote: >> >> Indeed. So it seems to me that we have run into one another such case. >> >> In patch c6825c0976fa7893692, I see we have added an a

Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

2015-10-19 Thread Michael Chan
On Sun, 2015-10-18 at 22:21 -0700, Stephen Hemminger wrote: > On Sat, 17 Oct 2015 00:21:44 -0400 > Michael Chan wrote: > > > +static inline u32 bnxt_tx_avail(struct bnxt *bp, struct bnxt_tx_ring_info > > *txr) > > +{ > > + /* Tell compiler to fetch tx indices from memory. */ > > + barrier()

[PATCH 0/2] xfrm/crypto: unaligned access fixes

2015-10-19 Thread Sowmini Varadhan
A two-part patchset that fixes some "unaligned access" warnings that showed up my sparc test machines with ipsec set up. Sowmini Varadhan (2): crypto/x509: Fix unaligned access in x509_get_sig_params() Fix unaligned access in xfrm_notify_sa() for DELSA crypto/asymmetric_keys/x509_public_key

[PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA

2015-10-19 Thread Sowmini Varadhan
On sparc, deleting established SAs (e.g., by restarting ipsec at the peer) results in unaligned access messages via xfrm_del_sa -> km_state_notify -> xfrm_send_state_notify(). Use an aligned pointer to xfrm_usersa_info for this case. Signed-off-by: Sowmini Varadhan --- net/xfrm/xfrm_user.c |

[PATCH 1/2] crypto/x509: Fix unaligned access in x509_get_sig_params()

2015-10-19 Thread Sowmini Varadhan
x509_get_sig_params() has the same code pattern as the one in pkcs7_verify() that is fixed by commit 62f57d05e287 ("crypto: pkcs7 - Fix unaligned access in pkcs7_verify()") so apply a similar fix here: make sure that desc is pointing at an algined value past the digest_size, and take alignment valu

Re: [PATCH] tcp: remove improper preemption check in tcp_xmit_probe_skb()

2015-10-19 Thread Eric Dumazet
On Mon, 2015-10-19 at 18:51 -0200, Renato Westphal wrote: > Commit e520af48c7e5a introduced the following bug when setting the > TCP_REPAIR sockoption: > > > Since tcp_xmit_probe_skb() can be called from process context, use > NET_INC_STATS() instead of NET_INC_STATS_BH(). > > Signed-off-by: Re

Re: [PATCH v2 net-next] netfilter: ipset: Fixing unnamed union initg

2015-10-19 Thread Akemi Yagi
On Sun, Sep 13, 2015 at 4:52 AM, Pablo Neira Ayuso wrote: > On Sat, Sep 12, 2015 at 06:01:27PM -0700, Akemi Yagi wrote: >> Thanks to all for this effort. The patch is finally in the mainline >> kernel 4.3-rc1 released today. Now I wish backporting to the 4.2 >> branch goes smoothly. > > It's on it

[PATCH] tcp: remove improper preemption check in tcp_xmit_probe_skb()

2015-10-19 Thread Renato Westphal
Commit e520af48c7e5a introduced the following bug when setting the TCP_REPAIR sockoption: [ 2860.657036] BUG: using __this_cpu_add() in preemptible [] code: daemon/12164 [ 2860.657045] caller is __this_cpu_preempt_check+0x13/0x20 [ 2860.657049] CPU: 1 PID: 12164 Comm: daemon Not tainted 4

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-19 Thread Alexei Starovoitov
On 10/19/15 1:03 PM, Hannes Frederic Sowa wrote: I doubt it will stay a lightweight feature as it should not be in the responsibility of user space to provide those debug facilities. It feels we're talking past each other. I want to solve 'persistent map' problem. debugging of maps/progs, hier

Re: [Patch net-next 3/4] sch_htb: update backlog as well

2015-10-19 Thread Cong Wang
On Fri, Oct 16, 2015 at 5:19 AM, Jamal Hadi Salim wrote: > > Like i said earlier, the idea of keeping track of backlog is useful. > I think the commit log threw me off. > "It is odd to see qlen!=0 but backlog==0" > If you change that commit log then: Sure, I think DaveM probably already discards

Re: linux 3.4.43 : kernel crash at __nf_conntrack_confirm

2015-10-19 Thread Florian Westphal
Ani Sinha wrote: > On Sun, Oct 18, 2015 at 2:40 PM, Florian Westphal wrote: > > Ani Sinha wrote: > >> Indeed. So it seems to me that we have run into one another such case. > >> In patch c6825c0976fa7893692, I see we have added an additional check > >> (along with comparing tuple and zone) to v

Re: linux 3.4.43 : kernel crash at __nf_conntrack_confirm

2015-10-19 Thread Ani Sinha
On Sun, Oct 18, 2015 at 2:40 PM, Florian Westphal wrote: > Ani Sinha wrote: >> Indeed. So it seems to me that we have run into one another such case. >> In patch c6825c0976fa7893692, I see we have added an additional check (along >> with comparing tuple and zone) to verify that if the conntrack

[net-next:master 241/245] drivers/net/ethernet/hisilicon/hix5hd2_gmac.c:24:0: warning: "PORT_EN" redefined

2015-10-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 7b4b000951f09cfe3604a6fdf5469894b4e75adb commit: 876133d3161dcb743983d1f9e5bf247aea2fb0f1 [241/245] net: hisilicon: add OF dependency config: blackfin-allmodconfig (attached as .config) reproduce: wg

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-19 Thread Hannes Frederic Sowa
Hi Alexei, On Mon, Oct 19, 2015, at 21:34, Alexei Starovoitov wrote: > On 10/19/15 11:46 AM, Hannes Frederic Sowa wrote: > > Hi, > > > > On Mon, Oct 19, 2015, at 20:15, Alexei Starovoitov wrote: > >> On 10/19/15 10:37 AM, Daniel Borkmann wrote: > >>> An eBPF program or map loading/destruction is *

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-19 Thread Alexei Starovoitov
On 10/19/15 11:46 AM, Hannes Frederic Sowa wrote: Hi, On Mon, Oct 19, 2015, at 20:15, Alexei Starovoitov wrote: On 10/19/15 10:37 AM, Daniel Borkmann wrote: An eBPF program or map loading/destruction is *not* by any means to be considered fast-path. We currently hold a global mutex during load

Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-19 Thread Bjørn Mork
Oliver Neukum writes: > usbnet drives no devices of its own. It makes more sense to > select it whenever a driver for actual hardware that needs > it is chosen rather than offer it as an option of its own. > > Signed-off-by: Oliver Neukum > --- > drivers/net/usb/Kconfig | 75 > +++-

Re: [RFC] bpf: change bpf syacall to use u64 temp variables

2015-10-19 Thread Alexei Starovoitov
On Mon, Oct 19, 2015 at 03:10:46PM +0800, yalin wang wrote: > This patch change map_lookup_elem() and map_update_elem() function > to use u64 temp variable if the key_size or value_size is less than > u64, we don't need use kmalloc() for these small variables. > > Signed-off-by: yalin wang > ---

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-19 Thread Hannes Frederic Sowa
Hi, On Mon, Oct 19, 2015, at 20:15, Alexei Starovoitov wrote: > On 10/19/15 10:37 AM, Daniel Borkmann wrote: > > An eBPF program or map loading/destruction is *not* by any means to be > > considered fast-path. We currently hold a global mutex during loading. > > So, how can that be considered fast

Re: [PATCH net-next V17 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-19 Thread Pravin Shelar
On Sat, Oct 17, 2015 at 6:12 PM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double > tagged vlan. Inner TPID encode

Re: [PATCH net-next V17 1/3] openvswitch: 802.1ad uapi changes.

2015-10-19 Thread Pravin Shelar
On Sat, Oct 17, 2015 at 6:12 PM, Thomas F Herbert wrote: > openvswitch: Add support for 8021.AD > > Change the description of the VLAN tpid field. > > Signed-off-by: Thomas F Herbert Acked-by: Pravin B Shelar -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [PATCH net-next V17 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-10-19 Thread Pravin Shelar
On Sat, Oct 17, 2015 at 6:12 PM, Thomas F Herbert wrote: > Signed-off-by: Thomas F Herbert Acked-by: Pravin B Shelar -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordom

[PATCH 4/4] netfilter: ipset: Fix sleeping memory allocation in atomic context

2015-10-19 Thread Pablo Neira Ayuso
From: Nikolay Borisov Commit 00590fdd5be0 introduced RCU locking in list type and in doing so introduced a memory allocation in list_set_add, which is done in an atomic context, due to the fact that ipset rcu list modifications are serialised with a spin lock. The reason why we can't use a mutex

[PATCH 1/4] netfilter: fix Kconfig dependencies for nf_dup_ipv{4,6}

2015-10-19 Thread Pablo Neira Ayuso
net/built-in.o: In function `nf_dup_ipv4': (.text+0xed24d): undefined reference to `nf_conntrack_untracked' net/built-in.o: In function `nf_dup_ipv4': (.text+0xed267): undefined reference to `nf_conntrack_untracked' net/built-in.o: In function `nf_dup_ipv6': (.text+0x158aef): undefined reference

[PATCH 0/4] Netfilter fixes for net

2015-10-19 Thread Pablo Neira Ayuso
Hi David, The following patchset contains four Netfilter fixes for net, they are: 1) Fix Kconfig dependencies of new nf_dup_ipv4 and nf_dup_ipv6. 2) Remove bogus test nh_scope in IPv4 rpfilter match that is breaking --accept-local, from Xin Long. 3) Wait for RCU grace period after dropping t

[PATCH 2/4] netfilter: ipt_rpfilter: remove the nh_scope test in rpfilter_lookup_reverse

2015-10-19 Thread Pablo Neira Ayuso
From: lucien --accept-local option works for res.type == RTN_LOCAL, which should be from the local table, but there, the fib_info's nh->nh_scope = RT_SCOPE_NOWHERE ( > RT_SCOPE_HOST). in fib_create_info(). if (cfg->fc_scope == RT_SCOPE_HOST) { struct fib_nh *nh = fi->fib

[PATCH 3/4] netfilter: sync with packet rx also after removing queue entries

2015-10-19 Thread Pablo Neira Ayuso
From: Florian Westphal We need to sync packet rx again after flushing the queue entries. Otherwise, the following race could happen: cpu1: nf_unregister_hook(H) called, H unliked from lists, calls synchronize_net() to wait for packet rx completion. Problem is that while no new nf_queue_entry st

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-19 Thread Alexei Starovoitov
On 10/19/15 10:37 AM, Daniel Borkmann wrote: An eBPF program or map loading/destruction is *not* by any means to be considered fast-path. We currently hold a global mutex during loading. So, how can that be considered fast-path? Similarly, socket creation/ destruction is also not fast-path, etc.

Re: [PATCH net-next] Adding switchdev ageing notification on port bridged

2015-10-19 Thread Scott Feldman
On Mon, Oct 19, 2015 at 5:37 AM, Elad Raz wrote: > Configure ageing time to the HW for newly bridged device > > CC: Scott Feldman > CC: Jiri Pirko > Signed-off-by: Elad Raz Acked-by: Scott Feldman -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH v8 net-next 2/2] bonding: Simplify the xmit function for modes that use xmit_hash

2015-10-19 Thread Mahesh Bandewar
On Mon, Oct 19, 2015 at 9:35 AM, Jiri Pirko wrote: > Sun, Oct 05, 2014 at 02:45:01AM CEST, mahe...@google.com wrote: >>Earlier change to use usable slave array for TLB mode had an additional >>performance advantage. So extending the same logic to all other modes >>that use xmit-hash for slave sele

Re: [PATCH v8 net-next 2/2] bonding: Simplify the xmit function for modes that use xmit_hash

2015-10-19 Thread Jiri Pirko
Mon, Oct 19, 2015 at 08:01:24PM CEST, mahe...@google.com wrote: >On Mon, Oct 19, 2015 at 9:35 AM, Jiri Pirko wrote: >> Sun, Oct 05, 2014 at 02:45:01AM CEST, mahe...@google.com wrote: >>>Earlier change to use usable slave array for TLB mode had an additional >>>performance advantage. So extending t

Re: [PATCH net v3] openvswitch: Allocate memory for ovs internal device stats.

2015-10-19 Thread Pravin Shelar
On Mon, Oct 19, 2015 at 8:31 AM, James Morse wrote: > "openvswitch: Remove vport stats" removed the per-vport statistics, in > order to use the netdev's statistics fields. > "openvswitch: Fix ovs_vport_get_stats()" fixed the export of these stats > to user-space, by using the provided netdev_ops t

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-19 Thread Daniel Borkmann
On 10/19/2015 06:22 PM, Alexei Starovoitov wrote: On 10/19/15 7:23 AM, Daniel Borkmann wrote: The mknod is not the holder but rather the kobject which should be represented in sysfs will be. So you can still get the map major:minor by looking up the /dev file in the correspdonding sysfs director

Re: [RFC PATCH] RDS: convert bind hash table to re-sizable hashtable

2015-10-19 Thread santosh shilimkar
Hi David L, On 10/14/2015 2:15 PM, Santosh Shilimkar wrote: From: Santosh Shilimkar To further improve the RDS connection scalabilty on massive systems where number of sockets grows into tens of thousands of sockets, there is a need of larger bind hashtable. Pre-allocated 8K or 16K table is n

Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-19 Thread Stephen Hemminger
This looks like corner case, but worth forwarding. Begin forwarded message: Date: Mon, 19 Oct 2015 13:21:33 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

RE: [PATCH] intel: i40e: fix confused code

2015-10-19 Thread Nelson, Shannon
> From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > Sent: Saturday, October 17, 2015 1:58 PM > Subject: [PATCH] intel: i40e: fix confused code > > This code is pretty confused. The variable name 'bytes_not_copied' > clearly indicates that the programmer knew the semantics of > copy_{to,fr

Re: [RFC PATCH] RDS: convert bind hash table to re-sizable hashtable

2015-10-19 Thread santosh shilimkar
On 10/18/2015 6:56 PM, David Miller wrote: From: Santosh Shilimkar Date: Wed, 14 Oct 2015 14:15:31 -0700 From: Santosh Shilimkar To further improve the RDS connection scalabilty on massive systems where number of sockets grows into tens of thousands of sockets, there is a need of larger bin

Re: [PATCH] nfc: free skb buffer using skb_free_datagram

2015-10-19 Thread Eric Dumazet
On Mon, 2015-10-19 at 15:59 +, Insu Yun wrote: > Freeing sk_buff genereated by skb_recv_datagram is always by > skb_free_datagram, not kfree_skb. > > Signed-off-by: Insu Yun > --- > net/nfc/llcp_sock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/nfc/llcp_soc

[PATCH] [net-next] net: Fix typo in 80211.xml

2015-10-19 Thread Masanari Iida
This patch fix spelling typos found in Documentation/ DocBook/80211.xml. It is because this file was generated from comments in source, so I had to fix comments in source files. Signed-off-by: Masanari Iida --- include/net/cfg80211.h | 2 +- include/net/mac80211.h | 6 +++--- net/mac80211/sta_

Re: [PATCH v8 net-next 2/2] bonding: Simplify the xmit function for modes that use xmit_hash

2015-10-19 Thread Jiri Pirko
Sun, Oct 05, 2014 at 02:45:01AM CEST, mahe...@google.com wrote: >Earlier change to use usable slave array for TLB mode had an additional >performance advantage. So extending the same logic to all other modes >that use xmit-hash for slave selection (viz 802.3AD, and XOR modes). >Also consolidating t

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-19 Thread Alexei Starovoitov
On 10/19/15 7:23 AM, Daniel Borkmann wrote: The mknod is not the holder but rather the kobject which should be represented in sysfs will be. So you can still get the map major:minor by looking up the /dev file in the correspdonding sysfs directory or I think we should provide a 'unbind' file, whi

[PATCH net-next v3] netlink: Rightsize IFLA_AF_SPEC size calculation

2015-10-19 Thread Ronen Arad
if_nlmsg_size() overestimates the minimum allocation size of netlink dump request (when called from rtnl_calcit()) or the size of the message (when called from rtnl_getlink()). This is because ext_filter_mask is not supported by rtnl_link_get_af_size() and rtnl_link_get_size(). The over-estimation

Re: [PATCH v2 3/3] net: wireless: b43: Statics are init to 0

2015-10-19 Thread Michael Büsch
On Mon, 19 Oct 2015 17:02:23 +0100 Paul McQuade wrote: > diff --git a/drivers/net/wireless/b43/phy_lp.c > b/drivers/net/wireless/b43/phy_lp.c > index 058a9f2..086f0ba 100644 > --- a/drivers/net/wireless/b43/phy_lp.c > +++ b/drivers/net/wireless/b43/phy_lp.c > @@ -2502,7 +2502,7 @@ static int lpp

Re: [PATCH v2 2/3] net: wireless: b43: Coding Style

2015-10-19 Thread Michael Büsch
On Mon, 19 Oct 2015 17:02:22 +0100 Paul McQuade wrote: > Fixed Pointer Coding Style > > Signed-off-by: Paul McQuade > --- > drivers/net/wireless/b43/main.c | 6 +++--- > drivers/net/wireless/b43/main.h | 2 +- > drivers/net/wireless/b43/xmit.h | 2 +- > 3 files changed, 5 insertions(+), 5 dele

[PATCH v2 0/3] Coding Style Cleanning

2015-10-19 Thread Paul McQuade
Paul McQuade (3): net: wireless: rsi: Coding Spaces net: wireless: b43: Coding Style net: wireless: b43: Statics are init to 0 drivers/net/wireless/b43/main.c | 8 drivers/net/wireless/b43/main.h | 2 +- drivers/net/wireless/b43/phy_lp.c | 2 +- dr

[PATCH v2 3/3] net: wireless: b43: Statics are init to 0

2015-10-19 Thread Paul McQuade
No Need to state Statics are a 0 or NULL Signed-off-by: Paul McQuade --- drivers/net/wireless/b43/main.c | 2 +- drivers/net/wireless/b43/phy_lp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c index 040c

[PATCH v2 1/3] net: wireless: rsi: Coding Spaces

2015-10-19 Thread Paul McQuade
Removed space before that ',' Signed-off-by: Paul McQuade --- drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 2 +- drivers/net/wireless/rsi/rsi_mgmt.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio_ops.c b/drivers/net/wirele

[PATCH v2 2/3] net: wireless: b43: Coding Style

2015-10-19 Thread Paul McQuade
Fixed Pointer Coding Style Signed-off-by: Paul McQuade --- drivers/net/wireless/b43/main.c | 6 +++--- drivers/net/wireless/b43/main.h | 2 +- drivers/net/wireless/b43/xmit.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wire

[PATCH] nfc: free skb buffer using skb_free_datagram

2015-10-19 Thread Insu Yun
Freeing sk_buff genereated by skb_recv_datagram is always by skb_free_datagram, not kfree_skb. Signed-off-by: Insu Yun --- net/nfc/llcp_sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c index b7de0da..15e681f 100644 --- a/net/nfc

[PATCH v2] igb: improve handling of disconnected adapters

2015-10-19 Thread Jarod Wilson
Clean up array_rd32 so that it uses igb_rd32 the same as rd32, per the suggestion of Alexander Duyck, and use io_addr in more places, so that we don't have the need to call E1000_REMOVED (which simply looks for a null hw_addr) nearly as much. CC: Mark Rustad CC: Jeff Kirsher CC: Alexander Duyck

[PATCH net 1/1] tipc: conditionally expand buffer headroom over udp tunnel

2015-10-19 Thread Jon Maloy
In commit d999297c3dbbe ("tipc: reduce locking scope during packet reception") we altered the packet retransmission function. Since then, when restransmitting packets, we create a clone of the original buffer using __pskb_copy(skb, MIN_H_SIZE), where MIN_H_SIZE is the size of the area we want to ha

[PATCH] net: cavium: change NET_VENDOR_CAVIUM to bool

2015-10-19 Thread Andreas Schwab
CONFIG_NET_VENDOR_CAVIUM is only used to hide/show config options and to include subdirectories in the build, so it doesn't make sense to make it tristate. Signed-off-by: Andreas Schwab --- drivers/net/ethernet/cavium/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

2015-10-19 Thread Alexei Starovoitov
On Mon, Oct 19, 2015 at 11:06:49AM +0200, Jiri Benc wrote: > On Sun, 18 Oct 2015 08:11:58 -0700, Alexei Starovoitov wrote: > > it looks dangerous. > > Does it mean that 'for (4B) { create new dev; free old dev; } > > will keep incrementing that max index and dos it eventually? > > This is not chan

  1   2   >