Re: [PATCH] net: take care of bonding in build_skb_flow_key (v4)

2016-01-25 Thread zhuyj
On 01/22/2016 02:52 PM, Jiri Pirko wrote: Fri, Jan 22, 2016 at 05:21:28AM CET, wen.gang.w...@oracle.com wrote: 在 2016年01月21日 16:35, Jiri Pirko 写道: Thu, Jan 21, 2016 at 06:32:58AM CET, wen.gang.w...@oracle.com wrote: In a bonding setting, we determines fragment size according to MTU and PMTU a

[PATCH] fddi: Fixup potential uninitialized bars

2016-01-25 Thread Hannes Reinecke
dfx_get_bars() allocates the various bars, depending on the bus type. But as the function itself returns void and there is no default selection there is a risk of the function returning without allocating any bars. This patch moves the entries around so that PCI is assumed to the the default bus, a

Re: [net 0/2][pull request] Intel Wired LAN Driver Updates 2016-01-25

2016-01-25 Thread David Miller
From: Jeff Kirsher Date: Mon, 25 Jan 2016 15:58:50 -0800 > This series contains updates to i40e only and so I won't continue receiving > patches to fix the same issue (again). > > Arnd fixes the driver from causing the compiler whining about uninitialized > variables, so initialize those variabl

Re: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-25 Thread zhuyj
On 01/26/2016 02:26 PM, zhuyj wrote: On 01/26/2016 02:00 PM, Jay Vosburgh wrote: zhuyj wrote: On 01/26/2016 08:43 AM, Jay Vosburgh wrote: wrote: From: Zhu Yanjun Bonding will utilize notifier callbacks to detect slave link state changes. It is intended to be used with miimon set to zero

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Arend van Spriel
On 26-01-16 00:41, Julian Calaby wrote: > Hi Arend, > > On Tue, Jan 26, 2016 at 2:39 AM, Arend van Spriel wrote: >> On 25-01-16 12:06, Julian Calaby wrote: >>> Hi Sjoerd, >>> >>> On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons >>> wrote: On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4

Re: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-25 Thread zhuyj
On 01/26/2016 02:00 PM, Jay Vosburgh wrote: zhuyj wrote: On 01/26/2016 08:43 AM, Jay Vosburgh wrote: wrote: From: Zhu Yanjun Bonding will utilize notifier callbacks to detect slave link state changes. It is intended to be used with miimon set to zero, and does not support the updelay or

Re: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-25 Thread Jay Vosburgh
zhuyj wrote: >On 01/26/2016 08:43 AM, Jay Vosburgh wrote: >> wrote: >> >>> From: Zhu Yanjun >>> >>> Bonding will utilize notifier callbacks to detect slave >>> link state changes. It is intended to be used with miimon >>> set to zero, and does not support the updelay or downdelay >>> options to

Re: [PATCH net] inet: frag: Always orphan skbs inside ip_defrag()

2016-01-25 Thread Eric Dumazet
On Mon, 2016-01-25 at 17:11 -0800, Joe Stringer wrote: > Thanks, I can roll this into a v2 (or keep as a separate patch?). I > got sidetracked on the IPv6 side, some other issues are blocking me on > that but I intend to continue following up there as well. No, don't worry, I will submit this in

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-25 Thread Andrew Lunn
On Mon, Jan 25, 2016 at 05:45:21PM +0200, Aaro Koskinen wrote: > Hi, > > I get the below crash on OCTEON (with octeon_mgmt interface, genphy) > always during systemd boot. Hi Aaro I think i know what is going on now. What does your phy look like in DT? Thanks Andrew

Re: [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves

2016-01-25 Thread Jarod Wilson
On Mon, Jan 25, 2016 at 09:27:20AM -0500, Jarod Wilson wrote: > On Sun, Jan 24, 2016 at 10:42:22PM -0800, David Miller wrote: > > From: Jarod Wilson > > Date: Fri, 22 Jan 2016 14:11:22 -0500 > > > > > diff --git a/net/core/dev.c b/net/core/dev.c > > > index 8cba3d8..1354c7b 100644 > > > --- a/net

[PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

2016-01-25 Thread Bernie Harris
There are cases where qdisc_dequeue_peeked can return NULL, and the result is dereferenced later on in the function. Similarly to the other qdisc dequeue functions, check whether the skb pointer is NULL and if it is, goto out. Signed-off-by: Bernie Harris --- net/sched/sch_drr.c | 2 ++ 1 file

Re: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-25 Thread zhuyj
On 01/26/2016 08:43 AM, Jay Vosburgh wrote: wrote: From: Zhu Yanjun Bonding will utilize notifier callbacks to detect slave link state changes. It is intended to be used with miimon set to zero, and does not support the updelay or downdelay options to bonding. Because of link flap from the

Re: [PATCH net] inet: frag: Always orphan skbs inside ip_defrag()

2016-01-25 Thread Joe Stringer
On 22 January 2016 at 17:22, Eric Dumazet wrote: > On Fri, 2016-01-22 at 15:49 -0800, Joe Stringer wrote: >> Later parts of the stack (including fragmentation) expect that there is >> never a socket attached to frag in a frag_list, however this invariant >> was not enforced on all defrag paths. Th

Re: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-25 Thread Jay Vosburgh
wrote: >From: Zhu Yanjun > >Bonding will utilize notifier callbacks to detect slave >link state changes. It is intended to be used with miimon >set to zero, and does not support the updelay or downdelay >options to bonding. > >Because of link flap from the slave interface, if the notifier >is NE

Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-01-25 Thread Simon Horman
On Mon, Jan 25, 2016 at 12:52:55AM +0900, Yoshihiro Kaneko wrote: > From: Kazuya Mizuguchi > > This patch supports the following interrupts. > > - One interrupt for multiple (descriptor, error, management) > - One interrupt for emac > - Four interrupts for dma queue (best effort rx/tx, network c

Re: [PATCH] af_packet: Raw socket destruction warning fix

2016-01-25 Thread Daniel Borkmann
On 01/21/2016 12:40 PM, Maninder Singh wrote: The other sock_put() in packet_release() to drop the final ref and call into sk_free(), which drops the 1 ref on the sk_wmem_alloc from init time. Since you got into __sk_free() via sock_wfree() destructor, your socket must have invoked packet_release

Re: [PATCH 1/3] i40e: fix build warning

2016-01-25 Thread Jeff Kirsher
On Mon, 2016-01-25 at 11:40 +0530, Sudip Mukherjee wrote: > While building we are getting warning about: > i40e_main.c:8604:13: warning: 'i40e_add_geneve_port' defined but not > used > and > i40e_main.c:8651:13: warning: 'i40e_del_geneve_port' defined but not > used > > The contents of these funct

[net 0/2][pull request] Intel Wired LAN Driver Updates 2016-01-25

2016-01-25 Thread Jeff Kirsher
This series contains updates to i40e only and so I won't continue receiving patches to fix the same issue (again). Arnd fixes the driver from causing the compiler whining about uninitialized variables, so initialize those variables. Eric fixes the build errors/warnings which were introduced by An

[net 2/2] net: i40e: shut up uninitialized variable warnings

2016-01-25 Thread Jeff Kirsher
From: Arnd Bergmann intel/i40e/i40e_txrx.c: In function 'i40e_xmit_frame_ring': intel/i40e/i40e_txrx.c:2367:20: error: 'oiph' may be used uninitialized in this function [-Werror=maybe-uninitialized] intel/i40e/i40e_txrx.c:2317:16: note: 'oiph' was declared here intel/i40e/i40e_txrx.c:2367:17: er

[net 1/2] i40e: fix build warnings

2016-01-25 Thread Jeff Kirsher
From: Eric Dumazet Fixes following build warnings : drivers/net/ethernet/intel/i40e/i40e_main.c:7057:13: warning: 'i40e_sync_udp_filters_subtask' defined but not used [-Wunused-function] drivers/net/ethernet/intel/i40e/i40e_main.c:8524:13: warning: 'i40e_add_vxlan_port' defined but not used [-Wu

Re: [PATCH 4.1] [media] media/vivid-osd: fix info leak in ioctl

2016-01-25 Thread Yuki Machida
It has sent to the wrong Mainling List. sorry. On 2016年01月25日 19:42, Yuki Machida wrote: commit eda98796aff0d9bf41094b06811f5def3b4c333c upstream. The vivid_fb_ioctl() code fails to initialize the 16 _reserved bytes of struct fb_vblank after the ->hcount member. Add an explicit memset(0) before

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Julian Calaby
Hi Arend, On Tue, Jan 26, 2016 at 2:39 AM, Arend van Spriel wrote: > On 25-01-16 12:06, Julian Calaby wrote: >> Hi Sjoerd, >> >> On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons >> wrote: >>> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems >>> the card responds very quickl

RE: [PATCH net 2/4] lan78xx: replace devid to chipid & chiprev

2016-01-25 Thread Woojung.Huh
> Such cleanups are not appropriate for the 'net' tree. > > And the 'net-next' tree is closed. > > You _MUST_ separate out the pure bug fixes and submit only those > changes targetting the 'net' tree. > > You must learn how to submit changes properly. Thanks for pointing out. Will resubmit afte

Re: [PATCH net 2/4] lan78xx: replace devid to chipid & chiprev

2016-01-25 Thread David Miller
Such cleanups are not appropriate for the 'net' tree. And the 'net-next' tree is closed. You _MUST_ separate out the pure bug fixes and submit only those changes targetting the 'net' tree. You must learn how to submit changes properly.

[RESEND][RFC][PATCH] vsock: Fix blocking ops call in prepare_to_wait

2016-01-25 Thread Laura Abbott
We receoved a bug report from someone using vmware: WARNING: CPU: 3 PID: 660 at kernel/sched/core.c:7389 __might_sleep+0x7d/0x90() do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait+0x2d/0x90 Modules linked in: vmw_vsock_vmci_transport vsock snd_seq_midi snd_seq_midi_ev

[PATCH net 4/4] lan78xx: throttle tx path per usb speed

2016-01-25 Thread Woojung.Huh
Throttle TX path when slower than SUPER SPEED USB to avoid choking CPU. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 9b95333..e0cbc5a 100644 --- a/drive

[PATCH net 3/4] lan78xx: Add to handle mux control per chip id

2016-01-25 Thread Woojung.Huh
Depends on chip, some EEPROM pins are muxed with LED function. Disable & restore LED function to access EEPROM. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 92 ++- 1 file changed, 67 insertions(+), 25 deletions(-) diff --git a/drivers/

[PATCH net 2/4] lan78xx: replace devid to chipid & chiprev

2016-01-25 Thread Woojung.Huh
Replace devid of struct lan78xx_net to chipid & chiprev for easy access. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 11 +++ drivers/net/usb/lan78xx.h | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx

[PATCH net 1/4] lan78xx: change to use updated phy-ignore-interrupts

2016-01-25 Thread Woojung.Huh
Update lan78xx to use patch of commit 4f2aaf7dd95b (fix-phy-ignore-interrupts) by Florian Fainelli. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/n

[PATCH 0/4 net] lan78xx: updates & fixes

2016-01-25 Thread Woojung.Huh
Woojung Huh (4): lan78xx: change to use updated phy-ignore-interrupts lan78xx: replace devid to chipid & chiprev lan78xx: add to handle mux control per chip id lan78xx: throttle tx path per usb speed drivers/net/usb/lan78xx.c | 137 ++ driv

[PATCH 13/22] net: Fix dependencies for !HAS_IOMEM archs

2016-01-25 Thread Richard Weinberger
Not every arch has io memory. So, unbreak the build by fixing the dependencies. Signed-off-by: Richard Weinberger --- drivers/net/ethernet/ezchip/Kconfig | 1 + drivers/net/phy/Kconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ezchip/Kconfig b/driver

Re: Bypass at packet-page level (Was: Optimizing instruction-cache, more packets at each stage)

2016-01-25 Thread Jesper Dangaard Brouer
On Mon, 25 Jan 2016 09:50:16 -0800 John Fastabend wrote: > On 16-01-25 09:09 AM, Tom Herbert wrote: > > On Mon, Jan 25, 2016 at 5:15 AM, Jesper Dangaard Brouer > > wrote: > >> [...] > >> > >> There are two ideas, getting mixed up here. (1) bundling from the > >> RX-ring, (2) allowing to pic

[PATCH net] tcp: fix tcp_mark_head_lost to check skb len before fragmenting

2016-01-25 Thread Yuchung Cheng
From: Neal Cardwell This commit fixes a corner case in tcp_mark_head_lost() which was causing the WARN_ON(len > skb->len) in tcp_fragment() to fire. tcp_mark_head_lost() was assuming that if a packet has tcp_skb_pcount(skb) of N, then it's safe to fragment off a prefix of M*mss bytes, for any M

Re: Bypass at packet-page level (Was: Optimizing instruction-cache, more packets at each stage)

2016-01-25 Thread John Fastabend
On 16-01-25 01:32 PM, Tom Herbert wrote: > On Mon, Jan 25, 2016 at 9:50 AM, John Fastabend > wrote: >> On 16-01-25 09:09 AM, Tom Herbert wrote: >>> On Mon, Jan 25, 2016 at 5:15 AM, Jesper Dangaard Brouer >>> wrote: After reading John's reply about perfect filters, I want to re-state >>>

Re: Bypass at packet-page level (Was: Optimizing instruction-cache, more packets at each stage)

2016-01-25 Thread Tom Herbert
On Mon, Jan 25, 2016 at 9:50 AM, John Fastabend wrote: > On 16-01-25 09:09 AM, Tom Herbert wrote: >> On Mon, Jan 25, 2016 at 5:15 AM, Jesper Dangaard Brouer >> wrote: >>> >>> After reading John's reply about perfect filters, I want to re-state >>> my idea, for this very early RX stage. And descr

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-25 Thread Andrew Lunn
On Mon, Jan 25, 2016 at 05:45:21PM +0200, Aaro Koskinen wrote: > Hi, > > I get the below crash on OCTEON (with octeon_mgmt interface, genphy) > always during systemd boot. > > Bisected to: > > commit a9049e0c513c4521dbfaa302af8ed08b3366b41f > Author: Andrew Lunn > Date: Wed Jan 6 20:11:26 201

Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties withrfkill_gpio

2016-01-25 Thread Marc Dietrich
Am Montag 25 Januar 2016, 13:18:40 schrieb Thierry Reding: > On Mon, Jan 25, 2016 at 12:03:48PM +0300, Heikki Krogerus wrote: > > Pass the rfkill name and type to the device with properties > > instead of driver specific platform data. > > > > Signed-off-by: Heikki Krogerus > > CC: Alexandre Cour

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Doug Anderson
Hi, On Mon, Jan 25, 2016 at 12:07 PM, Arend van Spriel wrote: >> In any case, in my experience the Broadcom firmware is fairly >> complicated and has numerous cases where it stretches SDIO more than >> the other SDIO WiFi chip I've worked with. It wouldn't terribly >> surprise me if there was a

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Arend van Spriel
On 25-1-2016 20:23, Doug Anderson wrote: > Hi, > > On Mon, Jan 25, 2016 at 7:36 AM, Arend van Spriel wrote: >> On 25-01-16 11:47, Sjoerd Simons wrote: >>> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems >>> the card responds very quickly most of the time, unfortunately du

Re: [dm-devel] [PATCH 22/26] iscsi_tcp: Use ahash

2016-01-25 Thread Mike Christie
On 01/24/2016 07:19 AM, Herbert Xu wrote: > This patch replaces uses of the long obsolete hash interface with > ahash. > > Signed-off-by: Herbert Xu > --- > > drivers/scsi/iscsi_tcp.c| 54 > ++-- > drivers/scsi/iscsi_tcp.h|4 +-- > drivers/

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Doug Anderson
Hi, On Mon, Jan 25, 2016 at 7:36 AM, Arend van Spriel wrote: > On 25-01-16 11:47, Sjoerd Simons wrote: >> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems >> the card responds very quickly most of the time, unfortunately during >> initialisation it sometimes seems to take

Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation

2016-01-25 Thread David Miller
From: Vitaly Kuznetsov Date: Mon, 25 Jan 2016 16:00:41 +0100 > Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add > VLAN ID to flow_keys")) introduced a performance regression in netvsc > driver. Is problem is, however, not the above mentioned commit but the > fact that netv

Re: [PATCH net-next] hv_netvsc: Fix book keeping of skb during batching process

2016-01-25 Thread David Miller
From: Haiyang Zhang Date: Mon, 25 Jan 2016 09:49:31 -0800 > Since eliminating send_completion_tid from struct hv_netvsc_packet, we > haven't add proper book keeping for the skb of the batched packet. This > patch fixes this issue and allows the previous skb is properly freed. > Otherwise, a panic

Re: [PATCH v2] net: fec: use CONFIG_ARM instead of CONFIG_ARCH_MXC/SOC_IMX28

2016-01-25 Thread David Miller
From: Johannes Berg Date: Mon, 25 Jan 2016 11:40:50 +0100 > As Arnd Bergmann points out, using CONFIG_ARCH_MXC and/or SOC_IMX28 > is wrong if some other ARM platform uses this device - the operation > of the driver would depend on an unrelated ARM platform that might > or might not be set for mul

Re: [PATCH net] sit: set rtnl_link_ops before calling register_netdevice

2016-01-25 Thread David Miller
From: Thadeu Lima de Souza Cascardo Date: Mon, 25 Jan 2016 11:29:19 -0200 > When creating a SIT tunnel with ip tunnel, rtnl_link_ops is not set before > ipip6_tunnel_create is called. When register_netdevice is called, there is > no linkinfo attribute in the NEWLINK message because of that. > >

Re: [PATCH v2] defxx: fix build warning

2016-01-25 Thread David Miller
From: Sudip Mukherjee Date: Mon, 25 Jan 2016 13:05:20 +0530 > We are getting many build warnings about: > 'bar_start' may be used uninitialized > and > 'bar_len' may be used uninitialized > > They are not actually uninitialized as dfx_get_bars() will initialize > them properly. But still lets ha

Re: [PATCH 2/3] net: macb: fix build warning

2016-01-25 Thread David Miller
From: Sudip Mukherjee Date: Mon, 25 Jan 2016 11:43:09 +0530 > We are getting build warning about: > macb.c:2889:13: warning: 'tx_clk' may be used uninitialized in this function > macb.c:2888:11: warning: 'hclk' may be used uninitialized in this function > > In reality they are not used uninitial

Re: [PATCH v2] net: fec: make driver endian-safe

2016-01-25 Thread David Miller
From: Johannes Berg Date: Sun, 24 Jan 2016 16:52:37 +0100 > The driver treats the device descriptors as CPU-endian, which appears > to be correct with the default endianness on both ARM (typically LE) > and PowerPC (typically BE) SoCs, indicating that the hardware block > is generated differently

Re: [PATCH v2] net: dsa: fix mv88e6xxx switches

2016-01-25 Thread David Miller
From: Russell King Date: Sun, 24 Jan 2016 09:22:05 + > Since commit 76e398a62712 ("net: dsa: use switchdev obj for VLAN add/del > ops"), the Marvell 88E6xxx switch has been unable to pass traffic > between ports - any received traffic is discarded by the switch. > Taking a port out of bridge

Re: [PATCH] 82xx: FCC: Fixing a bug causing to FCC port lock-up (second try)

2016-01-25 Thread David Miller
From: Martin Roth Date: Sun, 24 Jan 2016 00:56:19 +0200 > This is an additional patch to the one already submitted recently. > The previous patch was not complete, and the FCC port lock-up scenario > has been reproduced in lab. > I had an opportunity to check the current patch in lab and the FCC

Re: [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV

2016-01-25 Thread David Miller
From: Herbert Xu Date: Mon, 25 Jan 2016 21:56:28 +0800 > On Mon, Jan 25, 2016 at 12:58:44PM +0100, Thomas Egerer wrote: >> The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have >> to select CRYPTO_ECHAINIV in order to work properly. This solves the >> issues caused by a misconf

Re: [PATCH net 1/3] sctp: fix the transport dead race check by using atomic_add_unless on refcnt

2016-01-25 Thread David Miller
From: Vlad Yasevich Date: Fri, 22 Jan 2016 13:54:09 -0500 > OK, I see how that holds together, but I think there might be hole wrt icmp > handling. Some icmp processes assume transport can't disappear on them, but > in > this case that last put(transport) may result in a call to > sctp_transp

RE: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-25 Thread Tantilov, Emil S
>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: Monday, January 25, 2016 10:00 AM >To: Tantilov, Emil S >Cc: zyjzyj2...@gmail.com; mkube...@suse.cz; vfal...@gmail.com; >go...@cumulusnetworks.com; netdev@vger.kernel.org; Shteinbock, Boris (Wind >River); jay.vosbu.

Re: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-25 Thread David Miller
From: "Tantilov, Emil S" Date: Mon, 25 Jan 2016 16:33:37 + > The patch you are referring to has not been accepted in net-next yet. > If/when that happens you can request it to be ported to the stable tree. Wrong. If you want a patch to get submitted to stable, it must be appropriate for and

[PATCH net] sctp: fix copying more bytes than expected in sctp_add_bind_addr

2016-01-25 Thread Marcelo Ricardo Leitner
Great. Dmitry, please give this a run. Local tests looked good but who knows what syzkaller may find. Thanks --8<-- Dmitry reported that sctp_add_bind_addr may read more bytes than expected in case the parameter is a IPv4 addr supplied by the user through calls such as sctp_bindx_add(), because

Re: Bypass at packet-page level (Was: Optimizing instruction-cache, more packets at each stage)

2016-01-25 Thread John Fastabend
On 16-01-25 09:09 AM, Tom Herbert wrote: > On Mon, Jan 25, 2016 at 5:15 AM, Jesper Dangaard Brouer > wrote: >> >> After reading John's reply about perfect filters, I want to re-state >> my idea, for this very early RX stage. And describe a packet-page >> level bypass use-case, that John indirectl

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

2016-01-25 Thread Bjorn Andersson
On Tue, Dec 29, 2015 at 11:03 AM, Bjorn Andersson wrote: > On Tue 29 Dec 10:34 PST 2015, Rob Herring wrote: > >> On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: >> > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. >> > Signed-off-by: Bjorn Andersson >> > --- >> >

for stable: xfrm: dst_entries_init() per-net dst_ops

2016-01-25 Thread Dan Streetman
David, can you queue commit a8a572a for stable please? It fixes commit d7c7544c3d from 2010, and without it anyone using multiple ipsec net namespaces can find one (or more) of their netns incorrectly reach the ipsec dst limit and are no longer usable. Thanks!

Re: net/sctp: out-of-bounds access in sctp_add_bind_addr

2016-01-25 Thread Neil Horman
On Mon, Jan 25, 2016 at 02:16:00PM -0200, Marcelo Ricardo Leitner wrote: > Something like this. Builds, but UNTESTED. > Uses union sizeof where possible but when reading from a buffer that is > not aligned to it, like that user supplied one. Then relies on > af->sockaddr_len > > --8<-- > > --- >

Re: [PATCH 4.1] [media] media/vivid-osd: fix info leak in ioctl

2016-01-25 Thread Greg KH
On Mon, Jan 25, 2016 at 07:42:18PM +0900, Yuki Machida wrote: > commit eda98796aff0d9bf41094b06811f5def3b4c333c upstream. > > The vivid_fb_ioctl() code fails to initialize the 16 _reserved bytes of > struct fb_vblank after the ->hcount member. Add an explicit > memset(0) before filling the structu

Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation

2016-01-25 Thread Eric Dumazet
On Mon, 2016-01-25 at 16:00 +0100, Vitaly Kuznetsov wrote: > Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add > VLAN ID to flow_keys")) introduced a performance regression in netvsc > driver. Is problem is, however, not the above mentioned commit but the > fact that netvsc_s

Re: Bypass at packet-page level (Was: Optimizing instruction-cache, more packets at each stage)

2016-01-25 Thread Tom Herbert
On Mon, Jan 25, 2016 at 5:15 AM, Jesper Dangaard Brouer wrote: > > After reading John's reply about perfect filters, I want to re-state > my idea, for this very early RX stage. And describe a packet-page > level bypass use-case, that John indirectly mentions. > > > There are two ideas, getting mi

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-25 Thread Andrew Lunn
On Mon, Jan 25, 2016 at 05:45:21PM +0200, Aaro Koskinen wrote: > Hi, > > I get the below crash on OCTEON (with octeon_mgmt interface, genphy) > always during systemd boot. Hi Aaro Olof reported a similar issue with a Marvell Ethernet driver/MDIO driver. Olof thinking was the mutex was used befor

RE: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-25 Thread Tantilov, Emil S
>-Original Message- >From: zyjzyj2...@gmail.com [mailto:zyjzyj2...@gmail.com] >Sent: Thursday, January 21, 2016 2:16 AM >To: zyjzyj2...@gmail.com; mkube...@suse.cz; vfal...@gmail.com; >go...@cumulusnetworks.com; netdev@vger.kernel.org; Shteinbock, Boris (Wind >River); jay.vosbu...@canonical

RE: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-25 Thread Tantilov, Emil S
>-Original Message- >From: zyjzyj2...@gmail.com [mailto:zyjzyj2...@gmail.com] >Sent: Thursday, January 21, 2016 2:16 AM >To: zyjzyj2...@gmail.com; mkube...@suse.cz; vfal...@gmail.com; >go...@cumulusnetworks.com; netdev@vger.kernel.org; Shteinbock, Boris (Wind >River); jay.vosbu...@canonical

RE: [PATCH net] lan78xx: changed to use updated phy-ignore-interrupts

2016-01-25 Thread Woojung.Huh
Florian, > Looks fine, just one nit below: > > > @@ -954,6 +956,7 @@ static int lan78xx_link_reset(struct lan78xx_net > *dev) > > > > ret = lan78xx_update_flowcontrol(dev, ecmd.duplex, ladv, > radv); > > netif_carrier_on(dev->net); > > Do you need this netif_carrier_on()

bonding (IEEE 802.3ad) not working with qemu/virtio

2016-01-25 Thread Bjørnar Ness
As subject says, 802.3ad bonding is not working with virtio network model. The only errors I see is: No 802.3ad response from the link partner for any adapters in the bond. Dumping the network traffic shows that no LACP packets are sent from the host running with virtio driver, changing to for e

Re: [PATCH 16/26] libceph: Use skcipher

2016-01-25 Thread Ilya Dryomov
On Sun, Jan 24, 2016 at 2:18 PM, Herbert Xu wrote: > This patch replaces uses of blkcipher with skcipher. > > Signed-off-by: Herbert Xu > --- > > net/ceph/crypto.c | 97 > +++--- > 1 file changed, 56 insertions(+), 41 deletions(-) Could you get

Re: net/sctp: out-of-bounds access in sctp_add_bind_addr

2016-01-25 Thread Marcelo Ricardo Leitner
Something like this. Builds, but UNTESTED. Uses union sizeof where possible but when reading from a buffer that is not aligned to it, like that user supplied one. Then relies on af->sockaddr_len --8<-- --- include/net/sctp/structs.h | 2 +- net/sctp/bind_addr.c | 14 -- net/sc

[PATCH net-next] hv_netvsc: Fix book keeping of skb during batching process

2016-01-25 Thread Haiyang Zhang
Since eliminating send_completion_tid from struct hv_netvsc_packet, we haven't add proper book keeping for the skb of the batched packet. This patch fixes this issue and allows the previous skb is properly freed. Otherwise, a panic may happen. Thanks to Simon Xiao for bisecting and analysis. Sign

Re: net/sctp: out-of-bounds access in sctp_add_bind_addr

2016-01-25 Thread Neil Horman
On Mon, Jan 25, 2016 at 12:48:02PM -0200, Marcelo Ricardo Leitner wrote: > On Mon, Jan 25, 2016 at 03:42:14PM +0100, Dmitry Vyukov wrote: > > On Mon, Jan 25, 2016 at 3:31 PM, Neil Horman wrote: > > > On Mon, Jan 25, 2016 at 03:02:38PM +0100, Dmitry Vyukov wrote: > > >> Hello, > > >> > > >> I've gi

net/irda: use-after-free in ircomm_param_request

2016-01-25 Thread Dmitry Vyukov
Hello, I've hit the following use-after-free report while running syzkaller fuzzer: == BUG: KASAN: use-after-free in ircomm_param_request+0x514/0x570 at addr 880035732c78 Read of size 4 by task syz-executor/10736

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Sjoerd Simons
On Mon, 2016-01-25 at 16:36 +0100, Arend van Spriel wrote: > On 25-01-16 11:47, Sjoerd Simons wrote: > > On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it > > seems > > the card responds very quickly most of the time, unfortunately > > during > > initialisation it sometimes seems t

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Arend van Spriel
On 25-01-16 12:06, Julian Calaby wrote: > Hi Sjoerd, > > On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons > wrote: >> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems >> the card responds very quickly most of the time, unfortunately during >> initialisation it sometimes seem

[BISECTED] v4.5-rc1 phylib regression

2016-01-25 Thread Aaro Koskinen
Hi, I get the below crash on OCTEON (with octeon_mgmt interface, genphy) always during systemd boot. Bisected to: commit a9049e0c513c4521dbfaa302af8ed08b3366b41f Author: Andrew Lunn Date: Wed Jan 6 20:11:26 2016 +0100 mdio: Add support for mdio drivers. [ 250.179887] CPU 2 Unable to ha

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Arend van Spriel
On 25-01-16 11:47, Sjoerd Simons wrote: > On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems > the card responds very quickly most of the time, unfortunately during > initialisation it sometimes seems to take just a bit over 2 seconds to > respond. > > This results intializat

Re: [PATCH 2/2] ppp: implement rtnetlink device handling

2016-01-25 Thread Guillaume Nault
On Mon, Jan 25, 2016 at 12:09:34PM +0100, walter harms wrote: > > > Am 23.12.2015 21:04, schrieb Guillaume Nault: > > @@ -1012,7 +1017,24 @@ static int ppp_dev_configure(struct net *src_net, > > struct net_device *dev, > > int indx; > > int err; > > > > - file = conf->file; > > + i

Re: [PATCH v2] defxx: fix build warning

2016-01-25 Thread Maciej W. Rozycki
On Mon, 25 Jan 2016, Sudip Mukherjee wrote: > We are getting many build warnings about: > 'bar_start' may be used uninitialized > and > 'bar_len' may be used uninitialized > > They are not actually uninitialized as dfx_get_bars() will initialize > them properly. But still lets have them initializ

[PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation

2016-01-25 Thread Vitaly Kuznetsov
Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add VLAN ID to flow_keys")) introduced a performance regression in netvsc driver. Is problem is, however, not the above mentioned commit but the fact that netvsc_set_hash() function did some assumptions on the struct flow_keys dat

Re: net/sctp: out-of-bounds access in sctp_add_bind_addr

2016-01-25 Thread Marcelo Ricardo Leitner
On Mon, Jan 25, 2016 at 03:42:14PM +0100, Dmitry Vyukov wrote: > On Mon, Jan 25, 2016 at 3:31 PM, Neil Horman wrote: > > On Mon, Jan 25, 2016 at 03:02:38PM +0100, Dmitry Vyukov wrote: > >> Hello, > >> > >> I've git the following error report while running syzkaller fuzzer: > >> > >> ==

Re: net/sctp: out-of-bounds access in sctp_add_bind_addr

2016-01-25 Thread Dmitry Vyukov
On Mon, Jan 25, 2016 at 3:31 PM, Neil Horman wrote: > On Mon, Jan 25, 2016 at 03:02:38PM +0100, Dmitry Vyukov wrote: >> Hello, >> >> I've git the following error report while running syzkaller fuzzer: >> >> == >> BUG: KASAN: slab-out-

Re: net/sctp: out-of-bounds access in sctp_add_bind_addr

2016-01-25 Thread Neil Horman
On Mon, Jan 25, 2016 at 03:02:38PM +0100, Dmitry Vyukov wrote: > Hello, > > I've git the following error report while running syzkaller fuzzer: > > == > BUG: KASAN: slab-out-of-bounds in memcpy+0x1d/0x40 at addr 88006c6361e8 > Re

Re: [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves

2016-01-25 Thread Jarod Wilson
On Sun, Jan 24, 2016 at 10:42:22PM -0800, David Miller wrote: > From: Jarod Wilson > Date: Fri, 22 Jan 2016 14:11:22 -0500 > > > diff --git a/net/core/dev.c b/net/core/dev.c > > index 8cba3d8..1354c7b 100644 > > --- a/net/core/dev.c > > +++ b/net/core/dev.c > > @@ -4153,8 +4153,11 @@ ncls: > >

net/sctp: out-of-bounds access in sctp_add_bind_addr

2016-01-25 Thread Dmitry Vyukov
Hello, I've git the following error report while running syzkaller fuzzer: == BUG: KASAN: slab-out-of-bounds in memcpy+0x1d/0x40 at addr 88006c6361e8 Read of size 28 by task syz-executor/12551

Re: [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV

2016-01-25 Thread Herbert Xu
On Mon, Jan 25, 2016 at 12:58:44PM +0100, Thomas Egerer wrote: > The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have > to select CRYPTO_ECHAINIV in order to work properly. This solves the > issues caused by a misconfiguration as described in [1]. > The original approach, patchi

[PATCH net] sit: set rtnl_link_ops before calling register_netdevice

2016-01-25 Thread Thadeu Lima de Souza Cascardo
When creating a SIT tunnel with ip tunnel, rtnl_link_ops is not set before ipip6_tunnel_create is called. When register_netdevice is called, there is no linkinfo attribute in the NEWLINK message because of that. Setting rtnl_link_ops before calling register_netdevice fixes that. Signed-off-by: Th

Bypass at packet-page level (Was: Optimizing instruction-cache, more packets at each stage)

2016-01-25 Thread Jesper Dangaard Brouer
After reading John's reply about perfect filters, I want to re-state my idea, for this very early RX stage. And describe a packet-page level bypass use-case, that John indirectly mentions. There are two ideas, getting mixed up here. (1) bundling from the RX-ring, (2) allowing to pick up the "p

Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio

2016-01-25 Thread Thierry Reding
On Mon, Jan 25, 2016 at 12:03:48PM +0300, Heikki Krogerus wrote: > Pass the rfkill name and type to the device with properties > instead of driver specific platform data. > > Signed-off-by: Heikki Krogerus > CC: Alexandre Courbot > CC: Thierry Reding > CC: Stephen Warren > --- > arch/arm/mach

[PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV

2016-01-25 Thread Thomas Egerer
The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have to select CRYPTO_ECHAINIV in order to work properly. This solves the issues caused by a misconfiguration as described in [1]. The original approach, patching crypto/Kconfig was turned down by Herbert Xu [2]. [1] https://lists

Re: [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV

2016-01-25 Thread Thomas Egerer
On 01/25/2016 11:26 AM, Herbert Xu wrote: > Thomas Egerer wrote: >> The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have >> to select CRYPTO_ECHAINIV in order to work properly. This solves the >> issues caused by a misconfiguration as described in [1]. >> The original approach,

Re: [PATCH 2/2] ppp: implement rtnetlink device handling

2016-01-25 Thread walter harms
Am 23.12.2015 21:04, schrieb Guillaume Nault: > Define PPP device handler for use with rtnetlink. > > The only PPP specific attribute is IFLA_PPP_DEV_FD. It is mandatory and > contains the file descriptor of the associated /dev/ppp instance (the > file descriptor which would have been used for i

Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Julian Calaby
Hi Sjoerd, On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons wrote: > On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems > the card responds very quickly most of the time, unfortunately during > initialisation it sometimes seems to take just a bit over 2 seconds to > respond. >

[PATCH] brcmfmac: sdio: Increase the default timeouts a bit

2016-01-25 Thread Sjoerd Simons
On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems the card responds very quickly most of the time, unfortunately during initialisation it sometimes seems to take just a bit over 2 seconds to respond. This results intialization failing with message like: brcmf_c_preinit_dcm

Re: [PATCH v2] net: fec: use CONFIG_ARM instead of CONFIG_ARCH_MXC/SOC_IMX28

2016-01-25 Thread Arnd Bergmann
On Monday 25 January 2016 11:40:50 Johannes Berg wrote: > As Arnd Bergmann points out, using CONFIG_ARCH_MXC and/or SOC_IMX28 > is wrong if some other ARM platform uses this device - the operation > of the driver would depend on an unrelated ARM platform that might > or might not be set for multi-p

Re: Supermicro AOC-STGN-i2S w intel 82599ES on Brocade ICX6610 - random link failures

2016-01-25 Thread zhuyj
https://www.mail-archive.com/netdev@vger.kernel.org/msg94109.html Maybe this link can help you. If work, please let me know. Thanks a lot. Zhu Yanjun On 01/25/2016 06:08 PM, Nikola Ciprich wrote: Hello netdev readers, I'd like to consult following problem we're dealing with: I have a cluster

[PATCH 4.1] [media] media/vivid-osd: fix info leak in ioctl

2016-01-25 Thread Yuki Machida
commit eda98796aff0d9bf41094b06811f5def3b4c333c upstream. The vivid_fb_ioctl() code fails to initialize the 16 _reserved bytes of struct fb_vblank after the ->hcount member. Add an explicit memset(0) before filling the structure to avoid the info leak. This fixes CVE-2015-7884. Signed-off-by: Sa

[PATCH v2] net: fec: use CONFIG_ARM instead of CONFIG_ARCH_MXC/SOC_IMX28

2016-01-25 Thread Johannes Berg
As Arnd Bergmann points out, using CONFIG_ARCH_MXC and/or SOC_IMX28 is wrong if some other ARM platform uses this device - the operation of the driver would depend on an unrelated ARM platform that might or might not be set for multi-platform kernels. Prior to my previous patch, any other platform

[PATCH] net: fec: use CONFIG_ARM instead of CONFIG_ARCH_MXC/SOC_IMX28

2016-01-25 Thread Johannes Berg
From: Johannes Berg As Arnd Bergmann points out, using CONFIG_ARCH_MXC and/or SOC_IMX28 is wrong if some other ARM platform uses this device - the operation of the driver would depend on an unrelated ARM platform that might or might not be set for multi-platform kernels. Prior to my previous pat

6lowpan: presenting my stateful compression work

2016-01-25 Thread Alexander Aring
Hi, maybe somebody is in the near and has time to visit me at [0]. I am be there at 27.01.2016 from 12:45 until 14:15 (MEZ) for doing a postersession. The postersession is public, so everybody should be welcome to join as visitor. Background: Currently I try to reach my master degree and need to

Re: [PATCH] ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV

2016-01-25 Thread Herbert Xu
Thomas Egerer wrote: > The ESP algorithms using CBC mode require echainiv. Hence INET*_ESP have > to select CRYPTO_ECHAINIV in order to work properly. This solves the > issues caused by a misconfiguration as described in [1]. > The original approach, patching crypto/Kconfig was turned down by > He

  1   2   >