[PATCH v2] brcmfmac: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-20 Thread Christophe JAILLET
If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error handling path to free it in such a case. Cc: sta...@vger.kernel.org Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") Signed-off-by: Christophe JAILLET --- v2: Add CC tag

Re: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-20 Thread Steffen Klassert
On Mon, Jun 19, 2017 at 11:33:20AM +0300, yoss...@mellanox.com wrote: > From: Yossi Kuperman > > IPv6 payload length indicates the size of the payload, including any > extension headers. In xfrm6_transport_finish, ipv6_hdr(skb)->payload_len > is set to the payload size

[PATCH net-next] qede: Fix compilation without QED_RDMA

2017-06-20 Thread Yuval Mintz
From: Chad Dupuis When CONFIG_QED_RDMA isn't defined, we'd hit the following: /include/linux/qed/qede_rdma.h:84:19: warning: ‘qede_rdma_dev_add’ used but never defined [enabled by default] static inline int qede_rdma_dev_add(struct qede_dev *dev); Fixes: bbfcd1e8e167

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread John Crispin
On 20/06/17 23:52, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 07:37:35PM +0200, John Crispin wrote: On 20/06/17 16:01, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/21 11:13, Andrew Lunn wrote: > On Wed, Jun 21, 2017 at 10:03:29AM +0800, l00371289 wrote: >> Hi, Andrew >> >> On 2017/6/20 21:27, Andrew Lunn wrote: >>> On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: hi, Florian On 2017/6/20 5:00, Florian Fainelli

[PATCH net-next] r8152: correct the definition

2017-06-20 Thread Hayes Wang
Replace VLAN_HLEN and CRC_SIZE with ETH_FCS_LEN. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 8bc4573..6cfffef

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread David Ahern
On 6/20/17 2:42 PM, Cong Wang wrote: > In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier after > ipv6_dev_notf") > I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired, > unfortunately, as reported by jeffy, netdev_wait_allrefs() > could rebroadcast NETDEV_UNREGISTER event until

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread Andrew Lunn
On Wed, Jun 21, 2017 at 10:03:29AM +0800, l00371289 wrote: > Hi, Andrew > > On 2017/6/20 21:27, Andrew Lunn wrote: > > On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: > >> hi, Florian > >> > >> On 2017/6/20 5:00, Florian Fainelli wrote: > >>> On 06/16/2017 02:24 AM, Lin Yun Sheng

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread jeffy
Hi Cong Wang, oh, oops, i did misread. also, Tested-by: Jeffy Chen On 06/21/2017 11:01 AM, jeffy wrote: Hi Cong Wang, i don't know much about net core, maybe i'm misreading the code...but On 06/21/2017 02:42 AM, Cong Wang wrote: In commit 242d3a49a2a1 ("ipv6:

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-20 Thread David Ahern
On 6/20/17 5:41 PM, Ben Greear wrote: > On 06/20/2017 11:05 AM, Michal Kubecek wrote: >> On Tue, Jun 20, 2017 at 07:12:27AM -0700, Ben Greear wrote: >>> On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM, Ben Greear wrote: > On 06/13/2017 07:27 PM, David Ahern wrote: >

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread jeffy
Hi Cong Wang, i don't know much about net core, maybe i'm misreading the code...but On 06/21/2017 02:42 AM, Cong Wang wrote: In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf") I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired, unfortunately, as

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Felix Manlunas
From: David Miller Date: Tue, 20 Jun 2017 21:17:13 -0400 > From: Felix Manlunas > Date: Tue, 20 Jun 2017 13:51:25 -0700 > > > From: Derek Chickles > > Date: Tue, 20 Jun 2017 13:15:34 -0700 > > > >> > From: David

Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Ethan Zhao
Gustavo, The return value of ret_val seems used to check if the access to PHY/NVM got its semaphore, generally speaking, it is needed for every PHY access of this driver. Reviewed-by: Ethan Zhao On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva

[PATCH] PATCH v3 Convert multiple netdev_info messages to netdev_dbg

2017-06-20 Thread Michael J Dilmore
The bond_options.c file contains multiple netdev_info messages that clutter kernel output. This patches replaces these with netdev_dbg messages and adds a netdev_dbg for packets for slave. Signed-off-by: Michael J Dilmore Suggested-by: Joe Perches

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/20 21:28, Andrew Lunn wrote: The question really is, why is not this properly integrated into the PHY driver and PHYLIB such that the only thing the Ethernet MAC driver has to call is a function of the PHY driver putting it in self-test? >>> >>> This whole

[PATCH net-next] Add a tcp_filter hook before handle ack packet

2017-06-20 Thread Chenbo Feng
From: Chenbo Feng Currently in both ipv4 and ipv6 code path, the ack packet received when sk at TCP_NEW_SYN_RECV state is not filtered by socket filter or cgroup filter since it is handled from tcp_child_process and never reaches the tcp_filter inside tcp_v4_rcv or tcp_v6_rcv.

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/20 21:27, Andrew Lunn wrote: > On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: >> hi, Florian >> >> On 2017/6/20 5:00, Florian Fainelli wrote: >>> On 06/16/2017 02:24 AM, Lin Yun Sheng wrote: This patch fixes the phy loopback self_test failed issue. when

linux-next: manual merge of the net-next tree with the pci tree

2017-06-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/wireless/marvell/mwifiex/pcie.c between commit: c336cc0ee4eb ("PCI: Split ->reset_notify() method into ->reset_prepare() and ->reset_done()") from the pci tree and commit: 68efd0386988 ("mwifiex:

linux-next: manual merge of the net-next tree with the net tree

2017-06-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/core/rtnetlink.c between commit: db833d40ad32 ("rtnetlink: add IFLA_GROUP to ifla_policy") from the net tree and commit: 3d3ea5af5c0b ("rtnl: Add support for netdev event to link messages") from the net-next

[net-next 05/15] i40e: use dev_dbg instead of dev_info when warning about missing routine

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller When searching for the vf_capability client routine, dev_info() was used, instead of the normal dev_dbg(). This causes the message to be displayed at standard log levels which can cause administrators to worry. Avoid this by using dev_dbg instead.

[net-next 08/15] i40e: Support firmware CEE DCB UP to TC map re-definition

2017-06-20 Thread Jeff Kirsher
From: Greg Bowers Changes parsing of FW 4.33 AQ command Get CEE DCBX OPER CFG (0x0A07). Change is required because FW now creates the oper_prio_tc nibbles reversed from those in the CEE Priority Group sub-TLV. This change will only apply to FW 4.33 as future FW

[net-next 13/15] i40e: clear only cause_ena bit

2017-06-20 Thread Jeff Kirsher
From: Shannon Nelson When disabling interrupts, we should only be clearing the CAUSE_ENA bit, not clearing the whole register. Clearing the whole register sets the NEXTQ_IDX field to 0 instead of 0x7ff which can confuse the Firmware in some reset sequences.

[net-next 07/15] i40e: Fix potential out of bound array access

2017-06-20 Thread Jeff Kirsher
From: Sudheer Mogilappagari This is a fix for the static code analysis issue where dcbcfg->numapps could be greater than size of array (i.e dcbcfg->app[I40E_DCBX_MAX_APPS]). The fix makes sure that the array is not accessed past the size of of the array (i.e.

[net-next 15/15] i40e: don't hold RTNL lock for the entire reset

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller We recently refactored i40e_do_reset() and its friends to be able to hold the RTNL lock only for the portions that actually need to be protected. However, a separate refactoring added several new callers of these functions during the PCIe error

[net-next 12/15] i40e: fix disabling overflow promiscuous mode

2017-06-20 Thread Jeff Kirsher
From: Alan Brady There exists a bug in which the driver does not correctly exit overflow promiscuous mode. This can occur if "too many" mac filters are added, putting the driver into overflow promiscuous mode, and the filters are then removed. When the failed filters are

[net-next 10/15] i40e: genericize the partition bandwidth control

2017-06-20 Thread Jeff Kirsher
From: Shannon Nelson Partition bandwidth control is not in just one form of MFP (multi-function partitioning), so make the code more generic and be sure to nudge the Tx scheduler for all MFP. Copyright updated to 2017. Signed-off-by: Shannon Nelson

[net-next 04/15] i40e/i40evf: update WOL and I40E_AQC_ADDR_VALID_MASK flags

2017-06-20 Thread Jeff Kirsher
From: Alice Michael Update a few flags related to FW interactions. Copyright updated to 2017. Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 03/15] i40evf: assign num_active_queues inside i40evf_alloc_queues

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller The variable num_active_queues represents the number of active queues we have for the device. We assign this pretty early in i40evf_init_subtask. Several code locations are written with loops over the tx_rings and rx_rings structures, which don't get

[net-next 01/15] i40e: add XDP support for pass and drop actions

2017-06-20 Thread Jeff Kirsher
From: Björn Töpel This commit adds basic XDP support for i40e derived NICs. All XDP actions will end up in XDP_DROP. Signed-off-by: Björn Töpel Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 09/15] i40e: Add message for unsupported MFP mode

2017-06-20 Thread Jeff Kirsher
From: Carolyn Wyborny This patch adds a check and message if the device is in MFP mode as changing RSS input set is not supported in MFP mode. Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers Signed-off-by:

[net-next 14/15] i40e: Handle PE_CRITERR properly with IWARP enabled

2017-06-20 Thread Jeff Kirsher
From: Catherine Sullivan When IWARP is enabled, we weren't clearing the PE_CRITERR, just logging it and removing it from the mask. We need to do a corer to reset the PE_CRITERR register, so set the bit for that as we handle the interrupt. We should also be checking

[net-next 02/15] i40e: add support for XDP_TX action

2017-06-20 Thread Jeff Kirsher
From: Björn Töpel This patch adds proper XDP_TX action support. For each Tx ring, an additional XDP Tx ring is allocated and setup. This version does the DMA mapping in the fast-path, which will penalize performance for IOMMU enabled systems. Further, debugfs support is

[net-next 11/15] i40e: Add support for OEM firmware version

2017-06-20 Thread Jeff Kirsher
From: Filip Sadowski This patch adds support for OEM firmware version. If OEM specific adapter is detected ethtool reports OEM product version in firmware version string instead of etrack id. Signed-off-by: Filip Sadowski Tested-by: Andrew

[net-next 06/15] i40e: comment that udp_port must be in host byte order

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller The firmware expects the port number passed when setting up the UDP tunnel configuration to be in Little Endian format. The i40e_aq_add_udp_tunnel command byte swaps the value from host order to Little Endian. Since commit fe0b0cd97b4f ("i40e: send

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2017-06-20

2017-06-20 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Björn adds additional XDP support for i40e, by adding pass and drop actions and XDP_TX action support. Jake fixes a possible NULL pointer dereference in i40evf_get_ethtool_stats() which could occur if the VF fails to recover from a reset, and

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread David Miller
From: Felix Manlunas Date: Tue, 20 Jun 2017 13:51:25 -0700 > From: Derek Chickles > Date: Tue, 20 Jun 2017 13:15:34 -0700 > >> > From: David Miller [mailto:da...@davemloft.net] >> > Sent: Tuesday, June 20, 2017 12:22 PM >> > >> > From:

Investment portfolio

2017-06-20 Thread HDD Investment Co.
Hello, How are you today? we have the financial capability to finance any investment portfolio as far as is genuine, all we need is a capable business partner that possesses investment strategies or profitable business information for good turn over within 10-20years. We can provide proof of

Re: [PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev_dbg

2017-06-20 Thread Joe Perches
On Tue, 2017-06-20 at 23:05 +0100, Michael J Dilmore wrote: > The bond_options.c file contains several netdev_info messages that clutter > kernel output. This patch changes all netdev_info messages > to netdev_dbg and adds a netdev debug for the packets per slave parameter. Hey Michael. You

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Russell King - ARM Linux
On Wed, Jun 21, 2017 at 12:00:30AM +0200, Thomas Gleixner wrote: > Yes, but there are still quite some issues to solve there: > > 1) How do you tell the system that it should apply the offset in the > first place, i.e at boot time before NTP or any other mechanism can > correct

[PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev_dbg

2017-06-20 Thread Michael J Dilmore
The bond_options.c file contains several netdev_info messages that clutter kernel output. This patch changes all netdev_info messages to netdev_dbg and adds a netdev debug for the packets per slave parameter. Suggested-by: Joe Perches Signed-off-by: Michael J Dilmore

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Pavel Machek
Hi! > >> > This is it. > >> > https://patchwork.kernel.org/patch/6219401/ > >> > >> Thanks. > >> > >> Yes, that's argument against changing rtc _drivers_ for hardware that > >> can not do better than 32bit. For generic code (such as 44/51 sysfs, > >> 51/51 suspend test), the change still makes

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Thomas Gleixner
On Tue, 20 Jun 2017, Alexandre Belloni wrote: > On 20/06/2017 at 22:15:36 +0100, Russell King - ARM Linux wrote: > > On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > > > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > > > : > > > >> Yes,

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread Andrew Lunn
> On Tue, Jun 20, 2017 at 07:37:35PM +0200, John Crispin wrote: > > > On 20/06/17 16:01, Andrew Lunn wrote: > >On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: > >>RPS and probably other kernel features are currently broken on some if not > >>all DSA devices. The root cause of this

Re: [PATCH] net: phy: smsc: fix buffer overflow in memcpy

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 10:40:46PM +0200, Arnd Bergmann wrote: > The memcpy annotation triggers for a fixed-length buffer copy: > > In file included from /git/arm-soc/arch/arm64/include/asm/processor.h:30:0, > from /git/arm-soc/arch/arm64/include/asm/spinlock.h:21, >

Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround

2017-06-20 Thread Florian Fainelli
On 06/20/2017 10:48 AM, Zach Brown wrote: > The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an > autoneg failure case by resetting the hardware. This turns off > intterupts. Things will work themselves out if the phy polls, as it will > figure out it's state during a poll.

Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 12:48:11PM -0500, Zach Brown wrote: > The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an > autoneg failure case by resetting the hardware. This turns off > intterupts. Things will work themselves out if the phy polls, as it will > figure out it's state

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-20 Thread Ben Greear
On 06/20/2017 11:05 AM, Michal Kubecek wrote: On Tue, Jun 20, 2017 at 07:12:27AM -0700, Ben Greear wrote: On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM, Ben Greear wrote: On 06/13/2017 07:27 PM, David Ahern wrote: Let's try a targeted debug patch. See attached I had to

[PATCH net-next v2 06/12] nfp: add stats and xmit helpers for representors

2017-06-20 Thread Simon Horman
Provide helpers for stats and xmit on representor netdevs. Parts based on work by Bert van Leeuwen, Benjamin LaHaise and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski ---

[PATCH net-next v2 12/12] nfp: add VF and PF representors to flower app

2017-06-20 Thread Simon Horman
Initialise VF and PF representors in flower app. Based in part on work by Benjamin LaHaise, Bert van Leeuwen and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski ---

[PATCH net-next v2 11/12] nfp: add flower app

2017-06-20 Thread Simon Horman
Add app for flower offload. At this point the PF netdev and phys port representor netdevs are initialised. Follow-up work will add support for VF and PF representors and beyond that offloading the flower classifier. Based in part on work by Benjamin LaHaise and Bert van Leeuwen. Signed-off-by:

[PATCH net-next v2 08/12] nfp: provide nfp_port to of nfp_net_get_mac_addr()

2017-06-20 Thread Simon Horman
Provide port rather than vNIC as parameter of nfp_net_get_mac_addr. This is to allow this function to be used by representor netdevs where a vNIC may have more than one physical port none of which are associated with the vNIC. Signed-off-by: Simon Horman Reviewed-by:

[PATCH net-next v2 10/12] nfp: add support for control messages for flower app

2017-06-20 Thread Simon Horman
In preparation for adding a new flower app - targeted at offloading the flower classifier - provide support for control message that it will use to communicate with the NFP. Based in part on work by Bert van Leeuwen. Signed-off-by: Simon Horman Reviewed-by: Jakub

[PATCH net-next v2 09/12] nfp: add support for tx/rx with metadata portid

2017-06-20 Thread Simon Horman
Allow tx/rx with metadata port id. This will be used for tx/rx of representor netdevs acting as upper-devices while a pf netdev acts as a lower-device. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski ---

[PATCH net-next v2 07/12] nfp: app callbacks for SRIOV

2017-06-20 Thread Simon Horman
Add app-callbacks for app-specific initialisation of SRIOV. Disabling SRIOV is brought forward in nfp_pci_remove() so that nfp_app_sriov_disable is called while the app still exists. This is intended to be used to implement representor netdevs for virtual ports. Signed-off-by: Simon Horman

[PATCH net-next v2 00/12] nfp: add flower app with representors

2017-06-20 Thread Simon Horman
Hi, this series adds a flower app to the NFP driver. It initialises four types of netdevs: * PF netdev - lower-device for communication of packets to device * PF representor netdev * VF representor netdevs * Phys port representor netdevs The PF netdev acts as a lower-device which sends and

[PATCH net-next v2 01/12] net: store port/representator id in metadata_dst

2017-06-20 Thread Simon Horman
From: Jakub Kicinski Switches and modern SR-IOV enabled NICs may multiplex traffic from Port representators and control messages over single set of hardware queues. Control messages and muxed traffic may need ordered delivery. Those requirements make it hard to

[PATCH net-next v2 05/12] nfp: general representor implementation

2017-06-20 Thread Simon Horman
Provide infrastructure to create and destroy representors of a given type. Parts based on work by Bert van Leeuwen, Benjamin LaHaise, and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski ---

[PATCH net-next v2 04/12] nfp: map mac_stats and vf_cfg BARs

2017-06-20 Thread Simon Horman
If present map mac_stats and vf_cfg BARs. These will be used by representor netdevs to read statistics for phys port and vf representors. Also provide defines describing the layout of the mac_stats area. Similar defines are already present for the cf_cfg area. Based in part on work by Jakub

[PATCH net-next v2 03/12] nfp: move physical port init into a helper

2017-06-20 Thread Simon Horman
From: Jakub Kicinski Move MAC/PHY port init into a helper to make it easier to reuse it in the representor code. Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman ---

[PATCH net-next v2 02/12] nfp: devlink add support for getting eswitch mode

2017-06-20 Thread Simon Horman
From: Jakub Kicinski Add app callback for reporting eswitch mode. Non-SRIOV apps should not implement this callback, nfp_app code will then respond with -EOPNOTSUPP. Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 22:15:36 +0100, Russell King - ARM Linux wrote: > On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > > : > > >> Yes, that's argument against changing rtc _drivers_ for hardware

Re: [PATCH net-next v3 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-20 Thread Nikolay Aleksandrov
On 20/06/17 23:54, Julien Gomes wrote: > Add Netlink notifications on cache reports in ip6mr, in addition to the > existing mrt6msg sent to mroute6_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. > > MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the >

Re: [PATCH net-next v3 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-20 Thread Nikolay Aleksandrov
On 20/06/17 23:54, Julien Gomes wrote: > Add Netlink notifications on cache reports in ipmr, in addition to the > existing igmpmsg sent to mroute_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R. > > MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the > same

Re: [PATCH net-next v3 07/15] bpf: Add setsockopt helper function to bpf

2017-06-20 Thread Craig Gallek
On Mon, Jun 19, 2017 at 11:00 PM, Lawrence Brakmo wrote: > Added support for calling a subset of socket setsockopts from > BPF_PROG_TYPE_SOCK_OPS programs. The code was duplicated rather > than making the changes to call the socket setsockopt function because > the changes required

[PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Gustavo A. R. Silva
Check return value from call to e1e_wphy(). This value is being checked during previous calls to function e1e_wphy() and it seems a check was missing here. Addresses-Coverity-ID: 1226905 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/intel/e1000e/ich8lan.c

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Russell King - ARM Linux
On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > : > >> Yes, that's argument against changing rtc _drivers_ for hardware that > >> can not do better than 32bit. For generic code (such as 44/51

[PATCH net-next v3 1/4] rtnetlink: add NEWCACHEREPORT message type

2017-06-20 Thread Julien Gomes
New NEWCACHEREPORT message type to be used for cache reports sent via Netlink, effectively allowing splitting cache report reception from mroute programming. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes Reviewed-by: Nikolay Aleksandrov

[PATCH net-next v3 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-20 Thread Julien Gomes
Currently, all ipmr/ip6mr cache reports are sent through the mroute/mroute6 socket only. This forces the use of a single socket for mroute programming, cache reports and, regarding ipmr, IGMP messages without Router Alert option reception. The present patches are aiming to send Netlink

[PATCH net-next v3 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

2017-06-20 Thread Julien Gomes
Add RTNLGRP_{IPV4,IPV6}_MROUTE_R as two new restricted groups for the NETLINK_ROUTE family. Binding to these groups specifically requires CAP_NET_ADMIN to allow multicast of sensitive messages (e.g. mroute cache reports). Suggested-by: Nikolay Aleksandrov

[PATCH net-next v3 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-20 Thread Julien Gomes
Add Netlink notifications on cache reports in ip6mr, in addition to the existing mrt6msg sent to mroute6_sk. Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the same data as their equivalent fields in the mrt6msg

[PATCH net-next v3 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-20 Thread Julien Gomes
Add Netlink notifications on cache reports in ipmr, in addition to the existing igmpmsg sent to mroute_sk. Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R. MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the same data as their equivalent fields in the igmpmsg

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Felix Manlunas
From: Derek Chickles Date: Tue, 20 Jun 2017 13:15:34 -0700 > > From: David Miller [mailto:da...@davemloft.net] > > Sent: Tuesday, June 20, 2017 12:22 PM > > > > From: Denys Vlasenko > > Date: Mon, 19 Jun 2017 21:50:52 +0200 > > > > > Only

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-20 Thread Scott Branden
Hi Rob, On 17-06-18 07:04 AM, Rob Herring wrote: On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote: Add device tree binding documentation for the Broadcom DTE PTP clock driver. Signed-off-by: Arun Parameswaran ---

Re: [PATCH net-next 06/12] nfp: add stats and xmit helpers for representors

2017-06-20 Thread Simon Horman
On Wed, Jun 21, 2017 at 01:15:05AM +0800, kbuild test robot wrote: > Hi Simon, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Simon-Horman/nfp-add-flower-app-with-representors/20170620-233831 > config: arm-allmodconfig

[PATCH] net: phy: smsc: fix buffer overflow in memcpy

2017-06-20 Thread Arnd Bergmann
The memcpy annotation triggers for a fixed-length buffer copy: In file included from /git/arm-soc/arch/arm64/include/asm/processor.h:30:0, from /git/arm-soc/arch/arm64/include/asm/spinlock.h:21, from /git/arm-soc/include/linux/spinlock.h:87, from

RE: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Chickles, Derek
> From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, June 20, 2017 12:22 PM > > From: Denys Vlasenko > Date: Mon, 19 Jun 2017 21:50:52 +0200 > > > Only compile-tested - I don't have the hardware. > > > > From code inspection, octeon_pci_write_core_mem()

[net-next PATCH] tcp: md5: hide unused variable

2017-06-20 Thread Arnd Bergmann
Changing from a memcpy to per-member comparison left the size variable unused: net/ipv4/tcp_ipv4.c: In function 'tcp_md5_do_lookup': net/ipv4/tcp_ipv4.c:910:15: error: unused variable 'size' [-Werror=unused-variable] This does not show up when CONFIG_IPV6 is enabled, but the variable can be

[GIT] Networking

2017-06-20 Thread David Miller
1) Fix refcounting wrt. timers which hold onto inet6 address objects, from Xin Long. 2) Fix an ancient bug in wireless wext ioctls, from Johannes Berg. 3) Firmware handling fixes in brcm80211 driver, from Arend Van Spriel. 4) Several mlx5 driver fixes (firmware readiness, timestamp cap

Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-20 Thread Arend van Spriel
On 20-06-17 08:22, Christophe JAILLET wrote: > If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error > handling path to free it in such a case. Thanks. Please add the following tags: Cc: sta...@vger.kernel.org > Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload

Re: [Patch net] igmp: add a missing spin_lock_init()

2017-06-20 Thread David Miller
From: Cong Wang Date: Tue, 20 Jun 2017 10:46:27 -0700 > Andrey reported a lockdep warning on non-initialized > spinlock: > > INFO: trying to register non-static key. > the code is fine but needs lockdep annotation. > turning off the locking correctness validator. >

Re: [pull request][net-next 00/10] Mellanox, mlx5 IPoIB updates 2017-06-20

2017-06-20 Thread David Miller
From: Saeed Mahameed Date: Tue, 20 Jun 2017 17:13:04 +0300 > This series mainly from Erez and Feras includes some updates and > ethtool/ndos extension to the mlx5 IPoIB netdevice. > > for more detalis please see tag log below. > > Please pull and let me know if there's any

Re: [PATCH net-next 0/4] s390/net updates, part 2 (v2)

2017-06-20 Thread David Miller
From: Julian Wiedmann Date: Tue, 20 Jun 2017 16:00:30 +0200 > thanks for the feedback. Here's an updated patchset that honours > the reverse christmas tree and drops the __packed attribute. Please apply. Series applied.

Re: pull-request: wireless-drivers 2017-06-20

2017-06-20 Thread David Miller
From: Kalle Valo Date: Tue, 20 Jun 2017 16:39:59 +0300 > here's a pull request to net tree, few important fixes still I would > like to have in 4.12. Please let me know if there are any problems. Pulled, thanks Kalle.

Re: [PATCH net] net: stmmac: free an skb first when there are no longer any descriptors using it

2017-06-20 Thread David Miller
From: Niklas Cassel Date: Tue, 20 Jun 2017 14:32:41 +0200 > When having the skb pointer in the first descriptor, stmmac_tx_clean > can get called at a moment where the IP has only cleared the own bit > of the first descriptor, thus freeing the skb, even though there can >

Re: [PATCH net] sfc: remove duplicate up_write on VF filter_sem

2017-06-20 Thread David Miller
From: Edward Cree Date: Tue, 20 Jun 2017 13:08:51 +0100 > Somehow two copies of the line 'up_write(>efx->filter_sem);' got into > efx_ef10_sriov_set_vf_vlan(). This would put the mutex in a bad state and > cause all subsequent down attempts to hang. > > Fixes:

Re: [PATCH] rtnetlink: add IFLA_GROUP to ifla_policy

2017-06-20 Thread David Miller
From: Serhey Popovych Date: Tue, 20 Jun 2017 14:35:23 +0300 > Network interface groups support added while ago, however > there is no IFLA_GROUP attribute description in policy > and netlink message size calculations until now. > > Add IFLA_GROUP attribute to the

Re: ipv6: Do not leak throw route references

2017-06-20 Thread David Miller
From: Serhey Popovych Date: Tue, 20 Jun 2017 13:29:25 +0300 > While commit 73ba57bfae4a ("ipv6: fix backtracking for throw routes") > does good job on error propagation to the fib_rules_lookup() > in fib rules core framework that also corrects throw routes > handling,

Re: [PATCH net-next] sctp: uncork the old asoc before changing to the new one

2017-06-20 Thread David Miller
From: Xin Long Date: Tue, 20 Jun 2017 16:01:55 +0800 > local_cork is used to decide if it should uncork asoc outq after processing > some cmds, and it is set when replying or sending msgs. local_cork should > always have the same value with current asoc q->cork in some way.

Re: [PATCH net-next] sctp: handle errors when updating asoc

2017-06-20 Thread David Miller
From: Xin Long Date: Tue, 20 Jun 2017 16:05:11 +0800 > It's a bad thing not to handle errors when updating asoc. The memory > allocation failure in any of the functions called in sctp_assoc_update() > would cause sctp to work unexpectedly. > > This patch is to fix it by

Re: [PATCH net] dccp: call inet_add_protocol after register_pernet_subsys in dccp_v4_init

2017-06-20 Thread David Miller
From: Xin Long Date: Tue, 20 Jun 2017 15:42:38 +0800 > Now dccp_ipv4 works as a kernel module. During loading this module, if > one dccp packet is being recieved after inet_add_protocol but before > register_pernet_subsys in which v4_ctl_sk is initialized, a null pointer >

Re: [PATCH net] dccp: call inet_add_protocol after register_pernet_subsys in dccp_v6_init

2017-06-20 Thread David Miller
From: Xin Long Date: Tue, 20 Jun 2017 15:44:44 +0800 > Patch "call inet_add_protocol after register_pernet_subsys in dccp_v4_init" > fixed a null pointer dereference issue for dccp_ipv4 module. > > The same fix is needed for dccp_ipv6 module. > > Signed-off-by: Xin Long

Re: [PATCH net-next v2] enic: Fix format truncation warning

2017-06-20 Thread David Miller
From: Govindarajulu Varadarajan Date: Mon, 19 Jun 2017 16:28:44 -0700 > With -Wformat-truncation, gcc throws the following warning. > > Fix this by increasing the size of devname to accommodate 15 character > netdev interface name and description. > > Remove length format

Re: [oss-drivers] Re: [PATCH net-next 00/12] nfp: add flower app with representors

2017-06-20 Thread Jakub Kicinski
On Tue, 20 Jun 2017 19:13:43 +0300, Or Gerlitz wrote: > > Control queues are used to send and receive control messages which are > > used to communicate configuration information with the firmware. These > > are in separate vNIC to the queues belonging to the PF netdev. The control > > queues are

Re: [PATCH net-next v2 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-20 Thread David Miller
From: Julien Gomes Date: Mon, 19 Jun 2017 13:44:13 -0700 > Currently, all ipmr/ip6mr cache reports are sent through the > mroute/mroute6 socket only. > This forces the use of a single socket for mroute programming, cache > reports and, regarding ipmr, IGMP messages without

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread David Miller
From: Denys Vlasenko Date: Mon, 19 Jun 2017 21:50:52 +0200 > Only compile-tested - I don't have the hardware. > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned > anyway. >

Re: [PATCH net-next 00/12] nfp: add flower app with representors

2017-06-20 Thread Simon Horman
On Tue, Jun 20, 2017 at 07:13:43PM +0300, Or Gerlitz wrote: > On Tue, Jun 20, 2017 at 8:51 AM, Simon Horman > wrote: > > this series adds a flower app to the NFP driver. > > It initialises four types of netdevs: > > > > * PF netdev - lower-device for communication of

Re: [PATCH net-next] net: stmmac: enable TSO for IPv6

2017-06-20 Thread David Miller
From: Niklas Cassel Date: Mon, 19 Jun 2017 18:36:44 +0200 > There is nothing in the IP that prevents us from enabling TSO for IPv6. > > Before patch: > ftp fe80::2aa:bbff:fecc:1336%eth0 > ftp> get /dev/zero > 882512708 bytes received in 00:14 (56.11 MiB/s) > > After

Re: [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state

2017-06-20 Thread David Miller
From: John Allen Date: Mon, 19 Jun 2017 11:27:53 -0500 > If the ibmvnic driver is not in the VNIC_OPEN state, return from > ibmvnic_resume callback. If we are not in the VNIC_OPEN state, interrupts > may not be initialized and directly calling the interrupt handler

Re: [PATCH] dt-bindings: net: sms911x: Add missing optional VDD regulators

2017-06-20 Thread David Miller
From: Krzysztof Kozlowski Date: Mon, 19 Jun 2017 18:05:41 +0200 > The lan911x family of devices require supplying from 3.3 V power > supplies (connected to VDD_IO, VDD_A and VREG_3.3 pins). The existing > driver however obtains only VDD_IO and VDD_A regulators in an optional >

Re: [PATCH net-next] sctp: uncork the old asoc before changing to the new one

2017-06-20 Thread Neil Horman
On Tue, Jun 20, 2017 at 04:01:55PM +0800, Xin Long wrote: > local_cork is used to decide if it should uncork asoc outq after processing > some cmds, and it is set when replying or sending msgs. local_cork should > always have the same value with current asoc q->cork in some way. > > The thing is

  1   2   3   >