Re: [patch] add net_device_stats support to ethtool

2008-01-18 Thread Dan Nicolaescu
Jeff Garzik <[EMAIL PROTECTED]> writes: > Dan Nicolaescu wrote: > > Hi, > > > > I have posted this patch in the past with absolutely no reply. > > I would appreciate some sort of feedback of the form interested/not > > interested. Should I just

Re: [patch] add net_device_stats support to ethtool

2008-01-16 Thread Dan Nicolaescu
Ben Greear <[EMAIL PROTECTED]> writes: > Dan Nicolaescu wrote: > > Ben Greear <[EMAIL PROTECTED]> writes: > > > > > Dan Nicolaescu wrote: > > > > Hi, > > > > > > > > I have posted this patch in the pa

Re: [patch] add net_device_stats support to ethtool

2008-01-16 Thread Dan Nicolaescu
Ben Greear <[EMAIL PROTECTED]> writes: > Dan Nicolaescu wrote: > > Hi, > > > > I have posted this patch in the past with absolutely no reply. > > I would appreciate some sort of feedback of the form interested/not > > interested. Should I jus

[patch] add net_device_stats support to ethtool

2008-01-16 Thread Dan Nicolaescu
Hi, I have posted this patch in the past with absolutely no reply. I would appreciate some sort of feedback of the form interested/not interested. Should I just drop it? "ethtool -S" only supports devices that have custom code written to print the stats. A lot of drivers use "struct net_devi

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-05 Thread Dan Nicolaescu
Lennert Buytenhek <[EMAIL PROTECTED]> writes: > On Mon, Dec 04, 2006 at 10:27:52AM -0800, Dan Nicolaescu wrote: > > > > > The Opencores Ethernet Controller is Verilog code that can be used to > > > > implement an Ethernet device in hardware. It need

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-05 Thread Dan Nicolaescu
Stephen Hemminger <[EMAIL PROTECTED]> writes: > > > > > Indentation. See Documentation style. > > > What about IRQF_SHARED? > > > > Not sure, maybe I should make this another driver parameter. On my > > platform is not shared... > > The trouble with devices, is that some poo

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Dan Nicolaescu
Stephen Hemminger <[EMAIL PROTECTED]> writes: > On Mon, 04 Dec 2006 10:01:01 -0800 > Dan Nicolaescu <[EMAIL PROTECTED]> wrote: > > > > > Hi, > > > > Here is a driver for the Opencores Ethernet Controller. I started from > > a

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Dan Nicolaescu
Lennert Buytenhek <[EMAIL PROTECTED]> writes: > On Mon, Dec 04, 2006 at 10:01:01AM -0800, Dan Nicolaescu wrote: > > > The Opencores Ethernet Controller is Verilog code that can be used to > > implement an Ethernet device in hardware. It needs to be coupled w

[RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Dan Nicolaescu
Hi, Here is a driver for the Opencores Ethernet Controller. I started from a 2.4 uClinux driver, ported it to 2.6, made it work, cleaned it up and added the MII interface. The Opencores Ethernet Controller is Verilog code that can be used to implement an Ethernet device in hardware. It needs to

[patch] add net_device_stats support to ethtool

2006-12-04 Thread Dan Nicolaescu
Hi, "ethtool -S" only supports devices that have custom code written to print the stats. A lot of drivers use "struct net_device_stats", so adding code to ethtool would make it very easy for such drivers to add support for "ethtool -S". The drivers would just need to add this: .get_strin