Re: [PATCH] mt76: Fixed kernel test robot warning

2020-12-10 Thread Souptick Joarder
On Thu, Dec 10, 2020 at 12:46 PM Kalle Valo wrote: > > Souptick Joarder writes: > > > Kernel test robot throws below warning -> > > > >drivers/net/wireless/mediatek/mt76/tx.c: In function > > 'mt76_txq_schedule': > >>> drivers/ne

[PATCH] mt76: Fixed kernel test robot warning

2020-12-09 Thread Souptick Joarder
e] 499 | struct mt76_queue *q; | ^ This patch will silence this warning. Reported-by: kernel test robot Signed-off-by: Souptick Joarder --- drivers/net/wireless/mediatek/mt76/tx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/driv

Re: [PATCH 1/2] docs: mm/gup: pin_user_pages.rst: add a "case 5"

2020-05-31 Thread Souptick Joarder
On Sat, May 30, 2020 at 5:13 AM John Hubbard wrote: > > There are four cases listed in pin_user_pages.rst. These are > intended to help developers figure out whether to use > get_user_pages*(), or pin_user_pages*(). However, the four cases > do not cover all the situations. For example, drivers/vh

Re: [RFC] mm/gup.c: Updated return value of {get|pin}_user_pages_fast()

2020-05-07 Thread Souptick Joarder
On Thu, May 7, 2020 at 3:43 PM Jan Kara wrote: > > On Wed 06-05-20 21:38:40, Souptick Joarder wrote: > > On Wed, May 6, 2020 at 6:29 PM Jan Kara wrote: > > > > > > On Wed 06-05-20 17:51:39, Souptick Joarder wrote: > > > > On Wed, May 6, 2020 at 3:36 PM J

Re: [RFC] mm/gup.c: Updated return value of {get|pin}_user_pages_fast()

2020-05-06 Thread Souptick Joarder
On Wed, May 6, 2020 at 6:29 PM Jan Kara wrote: > > On Wed 06-05-20 17:51:39, Souptick Joarder wrote: > > On Wed, May 6, 2020 at 3:36 PM Jan Kara wrote: > > > > > > On Wed 06-05-20 02:06:56, Souptick Joarder wrote: > > > > On Wed, May 6, 2020 at 1:08 AM J

Re: [RFC] mm/gup.c: Updated return value of {get|pin}_user_pages_fast()

2020-05-06 Thread Souptick Joarder
On Wed, May 6, 2020 at 3:36 PM Jan Kara wrote: > > On Wed 06-05-20 02:06:56, Souptick Joarder wrote: > > On Wed, May 6, 2020 at 1:08 AM John Hubbard wrote: > > > > > > On 2020-05-05 12:14, Souptick Joarder wrote: > > > > Currently {get|pin}_user_

Re: [RFC] mm/gup.c: Updated return value of {get|pin}_user_pages_fast()

2020-05-05 Thread Souptick Joarder
On Wed, May 6, 2020 at 1:08 AM John Hubbard wrote: > > On 2020-05-05 12:14, Souptick Joarder wrote: > > Currently {get|pin}_user_pages_fast() have 3 return value 0, -errno > > and no of pinned pages. The only case where these two functions will > > return 0, is for nr_p

[RFC] mm/gup.c: Updated return value of {get|pin}_user_pages_fast()

2020-05-05 Thread Souptick Joarder
{get|pin}_user_pages_fast() will have 2 return values -errno & no of pinned pages. Update all the callers which deals with return value 0 accordingly. Signed-off-by: Souptick Joarder --- arch/ia64/kernel/err_inject.c | 2 +- drivers/platform/goldfish/goldfish_pipe.c | 2 +- drivers/st

Re: [RFC PATCH V2 4/5] vhost: introduce helpers to get the size of metadata area

2019-03-06 Thread Souptick Joarder
On Wed, Mar 6, 2019 at 12:48 PM Jason Wang wrote: > > Signed-off-by: Jason Wang Is the change log left with any particular reason ? > --- > drivers/vhost/vhost.c | 46 -- > 1 file changed, 28 insertions(+), 18 deletions(-) > > diff --git a/drivers/vho

Re: [PATCH] tools: testing: selftests: Remove duplicate headers

2019-03-06 Thread Souptick Joarder
On Mon, Mar 4, 2019 at 4:19 PM Souptick Joarder wrote: > > On Tue, Feb 26, 2019 at 10:59 AM Souptick Joarder > wrote: > > > > On Tue, Feb 26, 2019 at 7:18 AM Michael Ellerman > > wrote: > > > > > > Souptick Joarder writes: > > &g

[PATCH] selftest/net: Remove duplicate header

2019-03-04 Thread Souptick Joarder
Remove duplicate header which is included twice. Signed-off-by: Sabyasachi Gupta Signed-off-by: Souptick Joarder --- tools/testing/selftests/net/udpgso.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/net/udpgso.c b/tools/testing/selftests/net/udpgso.c index

Re: [PATCH] tools: testing: selftests: Remove duplicate headers

2019-03-04 Thread Souptick Joarder
On Tue, Feb 26, 2019 at 10:59 AM Souptick Joarder wrote: > > On Tue, Feb 26, 2019 at 7:18 AM Michael Ellerman wrote: > > > > Souptick Joarder writes: > > > Remove duplicate headers which are included twice. > > > > > > Signed-off-by: Sabyasachi

Re: [PATCH] tools: testing: selftests: Remove duplicate headers

2019-02-25 Thread Souptick Joarder
On Tue, Feb 26, 2019 at 7:18 AM Michael Ellerman wrote: > > Souptick Joarder writes: > > Remove duplicate headers which are included twice. > > > > Signed-off-by: Sabyasachi Gupta > > Signed-off-by: Souptick Joarder > > --- > ... > > tools/testing/

[PATCH] tools: testing: selftests: Remove duplicate headers

2019-02-22 Thread Souptick Joarder
Remove duplicate headers which are included twice. Signed-off-by: Sabyasachi Gupta Signed-off-by: Souptick Joarder --- tools/testing/selftests/gpio/gpio-mockup-chardev.c | 1 - tools/testing/selftests/net/udpgso.c| 1 - tools/testing/selftests/powerpc/pmu/ebb

Re: [RESEND PATCH 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-20 Thread Souptick Joarder
Hi Ira, On Wed, Feb 20, 2019 at 11:01 AM wrote: > > From: Ira Weiny > > To facilitate additional options to get_user_pages_fast() change the > singular write parameter to be gup_flags. > > This patch does not change any functionality. New functionality will > follow in subsequent patches. > > S

Re: [PATCH] net: Use dma_pool_zalloc()

2018-03-08 Thread Souptick Joarder
On Thu, Mar 8, 2018 at 7:15 PM, Krzysztof Hałasa wrote: > Souptick Joarder writes: > >> Any comment for this patch. > > I thought something like this was already aplied. I am not seeing anything similar till 4.16-rc4. Is it going to merge in netdev git ? > > Acked-by: K

Re: [PATCH] net: Use dma_pool_zalloc()

2018-03-06 Thread Souptick Joarder
Any comment for this patch. On Fri, Feb 16, 2018 at 9:58 PM, Souptick Joarder wrote: > Use dma_pool_zalloc() instead of dma_pool_alloc + memset > > Signed-off-by: Souptick Joarder > --- > drivers/net/ethernet/xscale/ixp4xx_eth.c | 3 +-- > drivers/net/wan/ixp4xx_hss.c

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread Souptick Joarder
Hi David, Dan, On Thu, Nov 30, 2017 at 12:50 AM, David Daney wrote: > On 11/29/2017 08:07 AM, Souptick Joarder wrote: >> >> On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder >> wrote: >>> >>> On Wed, Nov 29, 2017 at 6:25 AM, David Daney >>> wr

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread Souptick Joarder
On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder wrote: > On Wed, Nov 29, 2017 at 6:25 AM, David Daney wrote: >> From: Carlos Munoz >> >> The Cavium OCTEON cn78xx and cn73xx SoCs have network packet I/O >> hardware that is significantly different from previous g

Re: [PATCH] net: wan: Use dma_pool_zalloc

2016-12-16 Thread Souptick Joarder
On Fri, Dec 16, 2016 at 11:40 AM, Joe Perches wrote: > On Fri, 2016-12-16 at 11:33 +0530, Souptick Joarder wrote: >> On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches wrote: >> > On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote: >> > > On Mon, Dec 12, 2016

Re: [PATCH] net: wan: Use dma_pool_zalloc

2016-12-15 Thread Souptick Joarder
On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches wrote: > On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote: >> On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder >> wrote: >> > On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa wrote: >> > > Souptick

Re: [PATCH] net: wan: Use dma_pool_zalloc

2016-12-14 Thread Souptick Joarder
On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder wrote: > On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa wrote: >> Souptick Joarder writes: >> >>> We should use dma_pool_zalloc instead of dma_pool_alloc/memset >>> >>> Signed-off-by: Soup

Re: [PATCH] net: wan: Use dma_pool_zalloc

2016-12-11 Thread Souptick Joarder
On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa wrote: > Souptick Joarder writes: > >> We should use dma_pool_zalloc instead of dma_pool_alloc/memset >> >> Signed-off-by: Souptick joarder >> --- >> drivers/net/wan/ixp4xx_hss.c | 5 ++--- >> 1

[PATCH v2] ethernet :mellanox :mlx5: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-29 Thread Souptick Joarder
In alloc_cmd_box(), pci_pool_alloc() followed by memset will be replaced by pci_pool_zalloc() Signed-off-by: Souptick joarder --- v2: - Address comments from Sergei Alignment was not proper drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3

Re: [PATCH v3] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-29 Thread Souptick Joarder
2AM +0530, Souptick Joarder wrote: >> In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be >> replaced by pci_pool_zalloc() >> >> Signed-off-by: Souptick joarder >> --- >> v3: >> - Fixed alignment issues > > You mean remove e

[PATCH v3] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-29 Thread Souptick Joarder
In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be replaced by pci_pool_zalloc() Signed-off-by: Souptick joarder --- v3: - Fixed alignment issues v2: - Address comment from sergei Alignment was not proper drivers/net/ethernet/mellanox/mlx4/cmd.c | 6 ++ 1

Re: [PATCH v2] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-29 Thread Souptick Joarder
, Nov 29, 2016 at 12:55 PM, Souptick Joarder wrote: > Please ignore this v2 patch. > > On Tue, Nov 29, 2016 at 12:29 PM, Souptick Joarder > wrote: >> In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be >> replaced by pci_pool_zalloc(). >> >>

Re: [PATCH v2] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-28 Thread Souptick Joarder
Please ignore this v2 patch. On Tue, Nov 29, 2016 at 12:29 PM, Souptick Joarder wrote: > In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be > replaced by pci_pool_zalloc(). > > Signed-off-by: Souptick joarder > --- > v2: > - Address comment from s

[PATCH v2] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-28 Thread Souptick Joarder
In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be replaced by pci_pool_zalloc(). Signed-off-by: Souptick joarder --- v2: - Address comment from sergei Alignment was not proper drivers/net/ethernet/mellanox/mlx4/cmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3

Re: [PATCH] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-28 Thread Souptick Joarder
On Tue, Nov 29, 2016 at 12:36 AM, Sergei Shtylyov wrote: > Hello. > > On 11/28/2016 04:28 PM, Souptick Joarder wrote: > >> In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be >> replaced by pci_pool_zalloc() >> >> Signed-off-by: Soup

[PATCH] ethernet :mellanox :mlx5: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-28 Thread Souptick Joarder
In alloc_cmd_box(), pci_pool_alloc() followed by memset will be replaced by pci_pool_zalloc() Signed-off-by: Souptick joarder --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b

[PATCH] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-28 Thread Souptick Joarder
In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be replaced by pci_pool_zalloc() Signed-off-by: Souptick joarder --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b

Re: [PATCH 3/3] net-iwlegacy: Another refactoring for il_eeprom_init()

2016-01-02 Thread Souptick Joarder
On Sat, Jan 2, 2016 at 2:02 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 1 Jan 2016 21:16:01 +0100 > > Rename a jump label according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/intel/iwlegacy/common.c | 4 ++--

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

2015-12-30 Thread Souptick Joarder
On Wed, Dec 30, 2015 at 10:35 PM, Bjorn Andersson wrote: > On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder > wrote: >> >> HI Bjorn, >> >> On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote: >> > Make the addr parameter const in SET_IEEE80211_PERM_

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

2015-12-30 Thread Souptick Joarder
HI Bjorn, On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote: > Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save > clients from having to cast away a const qualifier. > > Signed-off-by: Bjorn Andersson > --- > include/net/mac80211.h | 2 +- > 1 file changed, 1 insertion(+)

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-29 Thread Souptick Joarder
Brent, On Tue, Dec 22, 2015 at 2:42 PM, Kalle Valo wrote: > Souptick Joarder writes: > >> Hi Brent, >> >> On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor wrote: >>> On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder >>> wrote: >>>> Hi B

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-22 Thread Souptick Joarder
Hi Brent, On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor wrote: > On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder > wrote: >> Hi Brent, >> >> On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: >>> Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar-&g

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Souptick Joarder
On Mon, Dec 21, 2015 at 10:17 PM, Nicholas Mc Guire wrote: > This is an API consolidation only. The use of kmalloc + memset to 0 > is equivalent to kzalloc. > > Signed-off-by: Nicholas Mc Guire > --- > > Found by coccinelle script (relaxed version of > scripts/coccinelle/api/alloc/kzalloc-simple.

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-21 Thread Souptick Joarder
Hi Brent, On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: > Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to > be pointing to memory allocated by vmalloc. If the api1 method (via > ath6kl_fetch_fw_api1) is used to allocate memory for ar->fw, then kmemdup is >