Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-09 Thread Jeff Garzik
Don Fry wrote: The patch below moves the init_block out of the private struct and only allocates init block with pci_alloc_consistent. This has two effects: 1. Performance increase for non cache coherent machines, because the CPU only data in the private struct are now cached 2. locks are

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-07 Thread Don Fry
On Wed, Mar 07, 2007 at 12:15:26PM -0800, Michael K. Edwards wrote: > cacheability of the allocated block. Maybe it doesn't. The alpha > version of pci_alloc_consistent, on the other hand, does interesting > things to make the memory visible to PCI. Don, what arches did you > have in mind when y

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-07 Thread Michael K. Edwards
On 3/7/07, Ralf Baechle <[EMAIL PROTECTED]> wrote: GFP_* flags have no influence on caching or prefetching. The zone modifier flags (like GFP_DMA) can in principle affect the cache/prefetch policy, since they affect what physical address range the memory is allocated from. I don't know whether

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-07 Thread Ralf Baechle
On Wed, Mar 07, 2007 at 08:35:30AM -0800, Michael K. Edwards wrote: > >Price question: why would this patch make a difference under VMware? :-) > > Moving the struct pcnet32_private from the GFP_DMA32 init_block to the > GFP_KERNEL netdev allocation may be a win even on systems where > GFP_DMA32

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-07 Thread Michael K. Edwards
On 3/6/07, Ralf Baechle <[EMAIL PROTECTED]> wrote: Price question: why would this patch make a difference under VMware? :-) Moving the struct pcnet32_private from the GFP_DMA32 init_block to the GFP_KERNEL netdev allocation may be a win even on systems where GFP_DMA32 is normally cached, becaus

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-07 Thread Lennart Sorensen
On Tue, Mar 06, 2007 at 07:39:21PM -0800, Michael K. Edwards wrote: > On 3/6/07, Ralf Baechle <[EMAIL PROTECTED]> wrote: > >This small change btw. delivers about ~ 3% extra performance on a very > >slow test system. > > Has this change been tested / benchmarked under VMWare? pcnet32 is > the (def

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-06 Thread Ralf Baechle
On Tue, Mar 06, 2007 at 07:39:21PM -0800, Michael K. Edwards wrote: > On 3/6/07, Ralf Baechle <[EMAIL PROTECTED]> wrote: > >This small change btw. delivers about ~ 3% extra performance on a very > >slow test system. > > Has this change been tested / benchmarked under VMWare? pcnet32 is > the (de

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-06 Thread Michael K. Edwards
On 3/6/07, Ralf Baechle <[EMAIL PROTECTED]> wrote: This small change btw. delivers about ~ 3% extra performance on a very slow test system. Has this change been tested / benchmarked under VMWare? pcnet32 is the (default?) virtual device presented by VMWare Workstation, and that's probably a la

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-06 Thread Ralf Baechle
On Tue, Mar 06, 2007 at 10:45:23AM -0800, Don Fry wrote: > The patch below moves the init_block out of the private struct and > only allocates init block with pci_alloc_consistent. > > This has two effects: > > 1. Performance increase for non cache coherent machines, because the >CPU only d

[PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-06 Thread Don Fry
The patch below moves the init_block out of the private struct and only allocates init block with pci_alloc_consistent. This has two effects: 1. Performance increase for non cache coherent machines, because the CPU only data in the private struct are now cached 2. locks are working now for p