On Mon, Oct 10, 2016 at 02:03:32AM -0700, Florian Fainelli wrote:
> > +
> > +#ifdef CONFIG_LED_TRIGGER_PHY
> > +
> > +#include
> > +#include
> > +
> > +#define PHY_LINK_LED_MAX_TRIGGERS 5
> > +#define PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE 7
> > +#define PHY_MII_BUS_ID_SIZE(20 - 3)
>
> This
> Andrew, are you happy with this implementation?
Sorry, been to busy with other things to follow the discussion.
What would be nice to see is a comment about how the link to LEDs in
the PHYs is made. Often there is a couple of LEDs in the RJ45 socket
driven by the PHY. They can show link, speed,
On 10/07/2016 02:14 PM, Zach Brown wrote:
> From: Josh Cartwright
>
> Create an option CONFIG_LED_TRIGGER_PHY (default n), which will
> create a set of led triggers for each instantiated PHY device. There is
> one LED trigger per link-speed, per-phy.
>
> This allows for a user to configure thei
From: Josh Cartwright
Create an option CONFIG_LED_TRIGGER_PHY (default n), which will
create a set of led triggers for each instantiated PHY device. There is
one LED trigger per link-speed, per-phy.
This allows for a user to configure their system to allow a set of LEDs
to represent link state