[net-next 09/17] ice: Fix casting issues

2020-05-22 Thread Jeff Kirsher
From: Karol Kolacinski Change min() macros to min_t() which has compare type specified and it helps avoid precision loss. In some cases there was precision loss during calls or assignments. Some fields in structs were unnecessarily large and gave multiple warnings. There were also some minor ty

Re: [PATCH v4 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-22 Thread Bartosz Golaszewski
śr., 20 maj 2020 o 23:23 Arnd Bergmann napisał(a): > > On Wed, May 20, 2020 at 7:35 PM Bartosz Golaszewski wrote: > > śr., 20 maj 2020 o 16:37 Arnd Bergmann napisał(a): > > > > I just noticed how the naming of NET_MEDIATEK_MAC and NET_MEDIATEK_SOC > > > for two different drivers doing the same t

Re: [PATCH v4 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-22 Thread Arnd Bergmann
On Fri, May 22, 2020 at 9:44 AM Bartosz Golaszewski wrote: > śr., 20 maj 2020 o 23:23 Arnd Bergmann napisał(a): > > On Wed, May 20, 2020 at 7:35 PM Bartosz Golaszewski wrote: > > > śr., 20 maj 2020 o 16:37 Arnd Bergmann napisał(a): > > > My thinking was this: if I mask the relevant interrupt (

Re: [External] Re: [PATCH] files: Use rcu lock to get the file structures for better performance

2020-05-22 Thread Muchun Song
On Fri, May 22, 2020 at 12:47 AM Matthew Wilcox wrote: > > On Thu, May 21, 2020 at 08:38:35PM +0800, Muchun Song wrote: > > +++ b/fs/proc/fd.c > > @@ -34,19 +34,27 @@ static int seq_show(struct seq_file *m, void *v) > > if (files) { > > unsigned int fd = proc_fd(m->private); >

RE: do a single memdup_user in sctp_setsockopt

2020-05-22 Thread David Laight
From: Christoph Hellwig > Sent: 21 May 2020 18:47 > based on the review of Davids patch to do something similar I dusted off > the series I had started a few days ago to move the memdup_user or > copy_from_user from the inidividual sockopts into sctp_setsockopt, > which is done with one patch per o

[PATCH v2 net-next 01/12] net: atlantic: changes for multi-TC support

2020-05-22 Thread Igor Russkikh
From: Dmitry Bezrukov This patch contains the following changes: * access cfg via aq_nic_get_cfg() in aq_nic_start() and aq_nic_map_skb(); * call aq_nic_get_dev() just once in aq_nic_map_skb(); * move ring allocation/deallocation out of aq_vec_alloc()/aq_vec_free(); * add the missing aq_nic_deini

[PATCH v2 net-next 09/12] net: atlantic: always use random TC-queue mapping for TX on A2.

2020-05-22 Thread Igor Russkikh
From: Mark Starovoytov This patch changes the TC-queue mapping mechanism used on A2. Configure the A2 HW in such a way that we can keep queue index mapping exactly as it was on A1. Signed-off-by: Mark Starovoytov Signed-off-by: Igor Russkikh --- .../aquantia/atlantic/hw_atl2/hw_atl2.c |

[PATCH v2 net-next 10/12] net: atlantic: change the order of arguments for TC weight/credit setters

2020-05-22 Thread Igor Russkikh
From: Mark Starovoytov This patch changes the order of arguments for TC weight/credit setter functions. Having the "value to be set" on the right is slightly more robust in a sense that it's more natural for the humans, so it's a bit more error-proof this way. Signed-off-by: Mark Starovoytov Si

[PATCH v2 net-next 04/12] net: atlantic: QoS implementation: multi-TC support

2020-05-22 Thread Igor Russkikh
From: Dmitry Bezrukov This patch adds multi-TC support. PTP is automatically disabled when the user enables more than 2 TCs, otherwise traffic on TC2 won't quite work, because it's reserved for PTP. Signed-off-by: Dmitry Bezrukov Co-developed-by: Dmitry Bogdanov Signed-off-by: Dmitry Bogdanov

[PATCH v2 net-next 03/12] net: atlantic: changes for multi-TC support

2020-05-22 Thread Igor Russkikh
From: Dmitry Bezrukov This patch contains the following changes: * add cfg->is_ptp (used for PTP enable/disable switch, which is described in more details below); * add cfg->tc_mode (A1 supports 2 HW modes only); * setup queue to TC mapping based on TC mode on A2; * remove hw_tx_tc_mode_get / h

[PATCH v2 net-next 12/12] net: atlantic: proper rss_ctrl1 (54c0) initialization

2020-05-22 Thread Igor Russkikh
From: Mark Starovoytov This patch fixes an inconsistency between code and spec, which was found while working on the QoS implementation. When 8TCs are used, 2 is the maximum supported number of index bits. In a 4TC mode, we do support 3, but we shouldn't really use the bytes, which are intended

[PATCH v2 net-next 11/12] net: atlantic: QoS implementation: min_rate

2020-05-22 Thread Igor Russkikh
From: Mark Starovoytov This patch adds support for mqprio min_rate limiters. A2 HW supports Weighted Strict Priority (WSP) arbitration for Tx Descriptor Queue scheduling among TCs, which can be used for min_rate shaping. Signed-off-by: Mark Starovoytov Signed-off-by: Igor Russkikh --- .../ne

[PATCH v2 net-next 05/12] net: atlantic: per-TC queue statistics

2020-05-22 Thread Igor Russkikh
From: Mark Starovoytov This patch adds support for per-TC queue statistics. By default (single TC), the output is the same as it used to be, e.g.: Queue[0] InPackets: 2 Queue[0] OutPackets: 8 Queue[0] Restarts: 0 Queue[0] InJumboPackets: 0 Queue[0] InLroPackets: 0 Q

[PATCH v2 net-next 06/12] net: atlantic: make TCVEC2RING accept nic_cfg

2020-05-22 Thread Igor Russkikh
From: Mark Starovoytov This patch updates TCVEC2RING to accept nic_cfg, which is needed to be able to use it from hw_atl. The name is updated to reflect the changes. Signed-off-by: Mark Starovoytov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c | 2 +- d

[PATCH v2 net-next 07/12] net: atlantic: QoS implementation: max_rate

2020-05-22 Thread Igor Russkikh
From: Mark Starovoytov This patch adds initial support for mqprio rate limiters (max_rate only). Atlantic HW supports Rate-Shaping for time-sensitive traffic at per Traffic Class (TC) granularity. Target rate is defined by: * nominal link rate (always 10G); * rate factor (ratio between nominal r

[PATCH v2 net-next 00/12] net: atlantic: QoS implementation

2020-05-22 Thread Igor Russkikh
This patch series adds support for mqprio rate limiters and multi-TC: * max_rate is supported on both A1 and A2; * min_rate is supported on A2 only; This is a joint work of Mark and Dmitry. To implement this feature, a couple of rearrangements and code improvements were done, in areas of TC/rin

[PATCH v2 net-next 08/12] net: atlantic: automatically downgrade the number of queues if necessary

2020-05-22 Thread Igor Russkikh
From: Mark Starovoytov This patch adds support for automatic queue number downgrade. On A2: this is a must have, because only TC0/TC1 support more than 4Q. Other TCs support 4Qs maximum. Thus, on A2 we must downgrade the number of queues per TC to 4, if more than 2 TCs are requested. On A1: thi

[PATCH v2 net-next 02/12] net: atlantic: move PTP TC initialization to a separate function

2020-05-22 Thread Igor Russkikh
From: Dmitry Bezrukov This patch moves the PTP TC initialization into a separate function. Signed-off-by: Dmitry Bezrukov Co-developed-by: Mark Starovoytov Signed-off-by: Mark Starovoytov Signed-off-by: Igor Russkikh --- .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 31 ---

Re: [PATCH bpf] flow_dissector: Drop BPF flow dissector prog ref on netns cleanup

2020-05-22 Thread Jakub Sitnicki
On Thu, 21 May 2020 17:53:14 -0700 Alexei Starovoitov wrote: > On Thu, May 21, 2020 at 12:09 PM Andrii Nakryiko > wrote: > > > > On Wed, May 20, 2020 at 10:24 AM Jakub Sitnicki > > wrote: > > > > > > When attaching a flow dissector program to a network namespace with > > > bpf(BPF_PROG_ATTAC

[RFC PATCH v12 02/11] arm/arm64: KVM: Advertise KVM UID to guests via SMCCC

2020-05-22 Thread Jianyong Wu
From: Will Deacon We can advertise ourselves to guests as KVM and provide a basic features bitmap for discoverability of future hypervisor services. Cc: Marc Zyngier Signed-off-by: Will Deacon Signed-off-by: Jianyong Wu --- virt/kvm/arm/hypercalls.c | 29 +++-- 1 file

[RFC PATCH v12 01/11] arm64: Probe for the presence of KVM hypervisor services during boot

2020-05-22 Thread Jianyong Wu
From: Will Deacon Although the SMCCC specification provides some limited functionality for describing the presence of hypervisor and firmware services, this is generally applicable only to functions designated as "Arm Architecture Service Functions" and no portable discovery mechanism is provided

[RFC PATCH v12 0/11] Enable ptp_kvm for arm64

2020-05-22 Thread Jianyong Wu
Currently, we offen use ntp (sync time with remote network clock) to sync time in VM. But the precision of ntp is subject to network delay so it's difficult to sync time in a high precision. kvm virtual ptp clock (ptp_kvm) offers another way to sync time in VM, as the remote clock locates in the h

[RFC PATCH v12 06/11] clocksource: Add clocksource id for arm arch counter

2020-05-22 Thread Jianyong Wu
Add clocksource id for arm arch counter to let it be identified easily and elegantly in ptp_kvm implementation for arm. Signed-off-by: Jianyong Wu --- drivers/clocksource/arm_arch_timer.c | 2 ++ include/linux/clocksource_ids.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/c

[RFC PATCH v12 04/11] ptp: Reorganize ptp_kvm modules to make it arch-independent.

2020-05-22 Thread Jianyong Wu
Currently, ptp_kvm modules implementation is only for x86 which includs large part of arch-specific code. This patch move all of those code into new arch related file in the same directory. Signed-off-by: Jianyong Wu --- drivers/ptp/Makefile| 1 + drivers/ptp/ptp_kvm.h

[RFC PATCH v12 07/11] psci: Add hypercall service for kvm ptp.

2020-05-22 Thread Jianyong Wu
ptp_kvm modules will get this service through smccc call. The service offers real time and counter cycle of host for guest. Also let caller determine which cycle of virtual counter or physical counter to return. Signed-off-by: Jianyong Wu --- include/linux/arm-smccc.h | 14 virt/kvm

[RFC PATCH v12 05/11] time: Add mechanism to recognize clocksource in time_get_snapshot

2020-05-22 Thread Jianyong Wu
From: Thomas Gleixner System time snapshots are not conveying information about the current clocksource which was used, but callers like the PTP KVM guest implementation have the requirement to evaluate the clocksource type to select the appropriate mechanism. Introduce a clocksource id field in

[RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-22 Thread Jianyong Wu
In general, vm inside will use virtual counter compered with host use phyical counter. But in some special scenarios, like nested virtualization, phyical counter maybe used by vm. A interface added in ptp_kvm driver to offer a mechanism to let user choose which counter should be return from host. T

[RFC PATCH v12 08/11] ptp: arm64: Enable ptp_kvm for arm/arm64

2020-05-22 Thread Jianyong Wu
Currently, there is no mechanism to keep time sync between guest and host in arm64 virtualization environment. Time in guest will drift compared with host after boot up as they may both use third party time sources to correct their time respectively. The time deviation will be in order of milliseco

[RFC PATCH v12 03/11] psci: export smccc conduit get helper.

2020-05-22 Thread Jianyong Wu
Export arm_smccc_1_1_get_conduit then modules can use smccc helper which adopts it. Acked-by: Mark Rutland Signed-off-by: Jianyong Wu --- drivers/firmware/psci/psci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c index 2937d44b5d

[RFC PATCH v12 11/11] arm64: Add kvm capability check extension for ptp_kvm

2020-05-22 Thread Jianyong Wu
Let userspace check if there is kvm ptp service in host. Before VMs migrate to another host, VMM may check if this cap is available to determine the next behavior. Signed-off-by: Jianyong Wu Suggested-by: Marc Zyngier --- include/uapi/linux/kvm.h | 1 + virt/kvm/arm/arm.c | 1 + 2 files c

[RFC PATCH v12 09/11] ptp: extend input argument for getcrosstimestamp API

2020-05-22 Thread Jianyong Wu
sometimes we may need tell getcrosstimestamp call back how to perform itself. Extending input arguments for getcrosstimestamp API to offer more exquisite control for the operation. Signed-off-by: Jianyong Wu --- drivers/clocksource/arm_arch_timer.c| 2 +- drivers/net/ethernet/intel/e1000e/pt

[PATCH net] felix: Fix initialization of ioremap resources

2020-05-22 Thread Claudiu Manoil
The caller of devm_ioremap_resource(), either accidentally or by wrong assumption, is writing back derived resource data to global static resource initialization tables that should have been constant. Meaning that after it computes the final physical start address it saves the address for no reaso

RE: [PATCH V1 net-next 05/15] net: ena: add prints to failed commands

2020-05-22 Thread Kiyanovski, Arthur
> -Original Message- > From: Jakub Kicinski > Sent: Friday, May 22, 2020 1:00 AM > To: Kiyanovski, Arthur > Cc: da...@davemloft.net; netdev@vger.kernel.org; Woodhouse, David > ; Machulsky, Zorik ; > Matushevsky, Alexander ; Bshara, Saeed > ; Wilson, Matt ; Liguori, Anthony > ; Bshara, Naf

[PATCH V2 net-next 00/14] ENA features and cosmetic changes

2020-05-22 Thread akiyano
From: Arthur Kiyanovski Diff from V1 of this patchset: Removed error prints patch This patchset includes: 1. new rx offset feature 2. reduction of the driver load time 3. multiple cosmetic changes to the code Arthur Kiyanovski (14): net: ena: add support for the rx offset feature net: ena:

[PATCH V2 net-next 02/14] net: ena: rename ena_com_free_desc to make API more uniform

2020-05-22 Thread akiyano
From: Arthur Kiyanovski Rename ena_com_free_desc to ena_com_free_q_entries to match the LLQ mode. In non-LLQ mode, an entry in an IO ring corresponds to a a descriptor. In LLQ mode an entry may correspond to several descriptors (per LLQ definition). Signed-off-by: Igor Chauskin Signed-off-by:

[PATCH V2 net-next 11/14] net: ena: cosmetic: code reorderings

2020-05-22 Thread akiyano
From: Arthur Kiyanovski 1. Reorder sanity checks in get_comp_ctxt() to make more sense 2. Reorder variables in ena_com_fill_hash_function() and ena_calc_io_queue_size() in reverse christmas tree. 3. Move around member initializations. Signed-off-by: Arthur Kiyanovski --- drivers/net/etherne

[PATCH V2 net-next 09/14] net: ena: cosmetic: fix line break issues

2020-05-22 Thread akiyano
From: Arthur Kiyanovski 1. Join unnecessarily broken short lines in ena_com.c ena_netdev.c 2. Fix Indentations of broken lines Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c| 8 +++- drivers/net/ethernet/amazon/ena/ena_netdev.c | 13 ++--- 2 fil

[PATCH V2 net-next 05/14] net: ena: simplify ena_com_update_intr_delay_resolution()

2020-05-22 Thread akiyano
From: Arthur Kiyanovski Initialize prev_intr_delay_resolution with ena_dev->intr_delay_resolution unconditionally, since it is initialized with ENA_DEFAULT_INTR_DELAY_RESOLUTION in ena_probe(). This approach makes much more sense than handling errors of not initializing it. Also added unlikely t

[PATCH V2 net-next 06/14] net: ena: cosmetic: rename ena_update_tx/rx_rings_intr_moderation()

2020-05-22 Thread akiyano
From: Arthur Kiyanovski Rename ena_update_tx/rx_rings_intr_moderation() to ena_update_tx/rx_rings_nonadaptive_intr_moderation() to distinguish between adaptive and non adaptive interrupt moderaion. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 8

[PATCH V2 net-next 07/14] net: ena: cosmetic: set queue sizes to u32 for consistency

2020-05-22 Thread akiyano
From: Arthur Kiyanovski Make all types of variables that convey the number and sizeof queues to be u32, for consistency with the API between the driver and device via ena_admin_defs.h:ena_admin_get_feat_resp.max_queue_ext fields. Current code sometimes uses int and there are multiple assignments

[PATCH V2 net-next 08/14] net: ena: cosmetic: fix spelling and grammar mistakes in comments

2020-05-22 Thread akiyano
From: Arthur Kiyanovski fix spelling and grammar mistakes in comments in ena_com.h, ena_com.c and ena_netdev.c Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c| 2 +- drivers/net/ethernet/amazon/ena/ena_com.h| 30 ++-- drivers/net/ethernet

[PATCH V2 net-next 04/14] net: ena: fix ena_com_comp_status_to_errno() return value

2020-05-22 Thread akiyano
From: Arthur Kiyanovski Default return value should be -EINVAL since the input in this case was unexpected. Also remove the now redundant check in the beginning of the function. Signed-off-by: Sameeh Jubran Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c | 5 +--

[PATCH V2 net-next 03/14] net: ena: use explicit variable size for clarity

2020-05-22 Thread akiyano
From: Arthur Kiyanovski Use u64 instead of unsigned long long for clarity Signed-off-by: Shai Brandes Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_c

[PATCH V2 net-next 13/14] net: ena: cosmetic: minor code changes

2020-05-22 Thread akiyano
From: Arthur Kiyanovski 1. Use BIT macro instead of shift operator for code clarity 2. Replace multiple flag assignments to a single assignment of multiple flags in ena_com_add_single_rx_desc() 3. Move ENA_HASH_KEY_SIZE from ena_netdev.h to ena_com.h Signed-off-by: Arthur Kiyanovski --- dri

[PATCH V2 net-next 10/14] net: ena: cosmetic: remove unnecessary code

2020-05-22 Thread akiyano
From: Arthur Kiyanovski 1. Remove unused definition of DRV_MODULE_VERSION 2. Remove {} from single line-of-code ifs 3. Remove unnecessary comments from ena_get/set_coalesce() 4. Remove unnecessary extra spaces and newlines Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/en

[PATCH V2 net-next 01/14] net: ena: add support for the rx offset feature

2020-05-22 Thread akiyano
From: Arthur Kiyanovski Newer ENA devices can write data to rx buffers with an offset from the beginning of the buffer. This commit adds support for this feature in the driver. Signed-off-by: Sameeh Jubran Signed-off-by: Arthur Kiyanovski --- .../net/ethernet/amazon/ena/ena_admin_defs.h |

[PATCH V2 net-next 14/14] net: ena: reduce driver load time

2020-05-22 Thread akiyano
From: Arthur Kiyanovski This commit reduces the driver load time by using usec resolution instead of msec when polling for hardware state change. Also add back-off mechanism to handle cases where minimal sleep time is not enough. Signed-off-by: Josh Triplett Signed-off-by: Sameeh Jubran Signe

[PATCH V2 net-next 12/14] net: ena: cosmetic: fix spacing issues

2020-05-22 Thread akiyano
From: Arthur Kiyanovski 1. Add leading and trailing spaces to several comments for better readability 2. Make tabs and spaces uniform in enum defines in ena_admin_defs.h Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 6 +++--- drivers/net/ethernet/a

Re: [bpf-next PATCH v4 4/5] bpf: selftests, add sk_msg helpers load and attach test

2020-05-22 Thread Jakub Sitnicki
On Thu, 21 May 2020 21:25:06 -0700 John Fastabend wrote: > The test itself is not particularly useful but it encodes a common > pattern we have. > > Namely do a sk storage lookup then depending on data here decide if > we need to do more work or alternatively allow packet to PASS. Then > if we n

WARNING in __queue_work (2)

2020-05-22 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:ac935d22 Add linux-next specific files for 20200415 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=13666a2210 kernel config: https://syzkaller.appspot.com/x/.config?x=bc498783097e9019 dashboard

Re: [PATCH net] felix: Fix initialization of ioremap resources

2020-05-22 Thread Vladimir Oltean
On Fri, 22 May 2020 at 11:55, Claudiu Manoil wrote: > > The caller of devm_ioremap_resource(), either accidentally > or by wrong assumption, is writing back derived resource data > to global static resource initialization tables that should > have been constant. Meaning that after it computes the

Re: [PATCH v2 0/7] Share events between metrics

2020-05-22 Thread kajoljain
On 5/20/20 11:50 PM, Ian Rogers wrote: > Metric groups contain metrics. Metrics create groups of events to > ideally be scheduled together. Often metrics refer to the same events, > for example, a cache hit and cache miss rate. Using separate event > groups means these metrics are multiplexed at

Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-22 Thread tanhuazhong
On 2020/5/22 5:37, David Miller wrote: From: Jakub Kicinski Date: Thu, 21 May 2020 12:17:07 -0700 On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: This patchset adds two new VLAN feature. [patch 1] adds a new dynamic VLAN mode. [patch 2] adds support for 'QoS' field to PVID. Change

[PATCH] can: flexcan: Fix runtime PM imbalance on error

2020-05-22 Thread Dinghao Liu
When register_flexcandev() returns an error code, a pairing runtime PM usage counter decrement is needed to keep the counter balanced. Also, call pm_runtime_disable() when register_flexcandev() returns an error code. Signed-off-by: Dinghao Liu --- drivers/net/can/flexcan.c | 2 ++ 1 file change

[PATCH net-next] net: phy: at803x: fix PHY ID masks

2020-05-22 Thread Michael Walle
Ever since its first commit 0ca7111a38f05 ("phy: add AT803x driver") the PHY ID mask was set to 0xffef. It is unclear to me why this mask was chosen in the first place. Both the AR8031/AR8033 and the AR8035 datasheets mention it is always the given value: - for AR8031/AR8033 its 0x004d/0xd074

Re: [PATCH -next] mt76: mt7915: Fix build error

2020-05-22 Thread Kalle Valo
YueHaibing writes: > In file included from ./include/linux/firmware.h:6:0, > from drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:4: > In function ‘__mt7915_mcu_msg_send’, > inlined from ‘mt7915_mcu_send_message’ at > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:370:6: >

Re: [PATCH v2 0/7] Share events between metrics

2020-05-22 Thread Jiri Olsa
On Thu, May 21, 2020 at 02:22:35PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, May 21, 2020 at 01:43:25PM +0200, Jiri Olsa escreveu: > > On Wed, May 20, 2020 at 11:20:04AM -0700, Ian Rogers wrote: > > > > SNIP > > > > > There are 5 out of 12 metric groups where no events are shared, such > >

[PATCH] Fix typo in the comment

2020-05-22 Thread Hari
Continuous Double "the" in a comment. Changed it to single "the" Signed-off-by: Hari --- drivers/net/ethernet/intel/e1000/e1000_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c inde

Re: [PATCH] ath9k: release allocated buffer if timed out

2020-05-22 Thread Kalle Valo
Brian Norris writes: > On Wed, May 13, 2020 at 12:02 PM Brian Norris > wrote: >> >> On Wed, May 13, 2020 at 12:05 AM Kalle Valo wrote: >> > Actually it's already reverted in -next, nobody just realised that it's >> > a regression from commit 728c1e2a05e4: >> > >> > ced21a4c726b ath9k: Fix use-

Re: [bpf-next PATCH] bpf: Add rx_queue_mapping to bpf_sock

2020-05-22 Thread kbuild test robot
. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Amritha-Nambiar/bpf-Add-rx_queue_mapping-to-bpf_sock/20200522-081144 base: https://git.kernel.o

Re: devlink interface for asynchronous event/messages from firmware?

2020-05-22 Thread Jiri Pirko
Thu, May 21, 2020 at 11:51:13PM CEST, k...@kernel.org wrote: >On Thu, 21 May 2020 13:59:32 -0700 Jacob Keller wrote: >> >> So the ice firmware can optionally send diagnostic debug messages via >> >> its control queue. The current solutions we've used internally >> >> essentially hex-dump the binary

Re: devlink interface for asynchronous event/messages from firmware?

2020-05-22 Thread Jiri Pirko
Thu, May 21, 2020 at 10:59:32PM CEST, jacob.e.kel...@intel.com wrote: > > >On 5/21/2020 1:52 PM, Ido Schimmel wrote: >> On Thu, May 21, 2020 at 01:22:34PM -0700, Jacob Keller wrote: >>> On 5/20/2020 5:16 PM, Jakub Kicinski wrote: On Wed, 20 May 2020 17:03:02 -0700 Jacob Keller wrote: > Hi

[PATCH] net: Fix return value about devm_platform_ioremap_resource()

2020-05-22 Thread Tiezhu Yang
When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Signed-off-by: Tiezhu Yang --- drivers/net/can/ifi_canfd/ifi_canfd.c | 5 - drivers/net/can/sun4i_can.c | 2 +- drivers/net/dsa/b53/b53_srab

Re: [PATCH RFC bpf-next 0/4] bpf: Add support for XDP programs in DEVMAPs

2020-05-22 Thread Jesper Dangaard Brouer
On Thu, 21 May 2020 19:05:22 -0600 David Ahern wrote: > Implementation of Daniel's proposal for allowing DEVMAP entries to be > a device index, program id pair. Daniel suggested an fd to specify the > program, but that seems odd to me that you insert the value as an fd, but > read it back as an i

[PATCH] selftests/bpf: add general instructions for test execution

2020-05-22 Thread Alan Maguire
Getting a clean BPF selftests run involves ensuring latest trunk LLVM/clang are used, pahole is recent (>=1.16) and config matches the specified config file as closely as possible. Add to bpf_devel_QA.rst and point tools/testing/selftests/bpf/README.rst to it. Signed-off-by: Alan Maguire Acked-b

[PATCH bpf 1/2] selftests/bpf: CONFIG_IPV6_SEG6_BPF required for test_seg6_loop.o

2020-05-22 Thread Alan Maguire
test_seg6_loop.o uses the helper bpf_lwt_seg6_adjust_srh(); it will not be present if CONFIG_IPV6_SEG6_BPF is not specified. Fixes: b061017f8b4d ("selftests/bpf: add realistic loop tests") Signed-off-by: Alan Maguire --- tools/testing/selftests/bpf/config | 1 + 1 file changed, 1 insertion(+) d

[PATCH bpf 2/2] selftests/bpf: CONFIG_LIRC required for test_lirc_mode2.sh

2020-05-22 Thread Alan Maguire
test_lirc_mode2.sh assumes presence of /sys/class/rc/rc0/lirc*/uevent which will not be present unless CONFIG_LIRC=y Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program") Signed-off-by: Alan Maguire --- tools/testing/selftests/bpf/config | 1 + 1 file changed, 1 insertion(+) dif

[PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config

2020-05-22 Thread Alan Maguire
Selftests "config" file is intended to represent the config required to run the tests; a few values are missing for the BPF selftests and these can result in test failures due to missing helpers etc. Add the missing values as they will help document the config needed for a clean BPF selftests run.

Re: [External] Re: [PATCH] files: Use rcu lock to get the file structures for better performance

2020-05-22 Thread Matthew Wilcox
On Fri, May 22, 2020 at 03:52:39PM +0800, Muchun Song wrote: > On Fri, May 22, 2020 at 12:47 AM Matthew Wilcox wrote: > > > @@ -160,14 +168,23 @@ static int proc_fd_link(struct dentry *dentry, > > > struct path *path) > > > unsigned int fd = proc_fd(d_inode(dentry)); > > >

[PATCH v5 07/11] ARM64: dts: mediatek: add pericfg syscon to mt8516.dtsi

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds support for the PERICFG register range as a syscon. This will soon be used by the MediaTek Ethernet MAC driver for NIC configuration. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 5 + 1 file changed, 5 insertions(+)

[PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds the driver for the MediaTek STAR Ethernet MAC currently used on the MT8* SoC family. For now we only support full-duplex. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Kconfig |7 + drivers/net/ethernet/mediatek/Makefile

[PATCH v5 08/11] ARM64: dts: mediatek: add the ethernet node to mt8516.dtsi

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the Ethernet MAC node to mt8516.dtsi. This defines parameters common to all the boards based on this SoC. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/b

[PATCH v5 05/11] net: ethernet: mediatek: remove unnecessary spaces from Makefile

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The Makefile formatting in the kernel tree usually doesn't use tabs, so remove them before we add a second driver. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v5 10/11] ARM64: dts: mediatek: add ethernet pins for pumpkin boards

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Setup the pin control for the Ethernet MAC. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot

[PATCH v5 09/11] ARM64: dts: mediatek: add an alias for ethernet0 for pumpkin boards

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the ethernet0 alias for ethernet so that u-boot can find this node and fill in the MAC address. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek

[PATCH v5 01/11] dt-bindings: convert the binding document for mediatek PERICFG to yaml

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Convert the DT binding .txt file for MediaTek's peripheral configuration controller to YAML. There's one special case where the compatible has three positions. Otherwise, it's a pretty normal syscon. Signed-off-by: Bartosz Golaszewski --- .../arm/mediatek/mediatek,per

[PATCH v5 11/11] ARM64: dts: mediatek: enable ethernet on pumpkin boards

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add remaining properties to the ethernet node and enable it. Signed-off-by: Bartosz Golaszewski --- .../boot/dts/mediatek/pumpkin-common.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi

[PATCH v5 00/11] mediatek: add support for MediaTek Ethernet MAC

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This series adds support for the STAR Ethernet Controller present on MediaTeK SoCs from the MT8* family. First we convert the existing DT bindings for the PERICFG controller to YAML and add a new compatible string for mt8516 variant of it. Then we add the DT bindings fo

[PATCH v5 04/11] net: ethernet: mediatek: rename Kconfig prompt

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski We'll soon by adding a second MediaTek Ethernet driver so modify the Kconfig prompt. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/Kconfig

[PATCH v5 02/11] dt-bindings: add new compatible to mediatek,pericfg

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The PERICFG controller is present on the MT8516 SoC. Add an appropriate compatible variant. Signed-off-by: Bartosz Golaszewski --- .../devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devic

[PATCH v5 03/11] dt-bindings: net: add a binding document for MediaTek STAR Ethernet MAC

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds yaml DT bindings for the MediaTek STAR Ethernet MAC present on the mt8* family of SoCs. Signed-off-by: Bartosz Golaszewski --- .../bindings/net/mediatek,eth-mac.yaml| 89 +++ 1 file changed, 89 insertions(+) create mode 100644 Docume

Re: [PATCH RFC bpf-next 1/4] bpf: Handle 8-byte values in DEVMAP and DEVMAP_HASH

2020-05-22 Thread Jesper Dangaard Brouer
On Thu, 21 May 2020 19:05:23 -0600 David Ahern wrote: > Add support to DEVMAP and DEVMAP_HASH to support 8-byte values as a > pair. To do this, a new struct is needed in > bpf_dtab_netdev to hold the values to return on lookup. I would like to see us leverage BTF instead of checking on the size

[PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-22 Thread Dan Murphy
Add the internal delay values into the header and update the binding with the internal delay properties. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83869.yaml | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ti,d

[PATCH net-next v2 2/4] net: phy: Add a helper to return the index for of the internal delay

2020-05-22 Thread Dan Murphy
Add a helper function that will return the index in the array for the passed in internal delay value. The helper requires the array, size and delay value. The helper will then return the index for the exact match or return the index for the index to the closest smaller value. Signed-off-by: Dan

[PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-22 Thread Dan Murphy
Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 101 ++ 1 file changed, 101 insertions(+) diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c index cfb22a21a2e6..a9008d32e2b6 10064

[PATCH net-next v2 1/4] dt-bindings: net: Add tx and rx internal delays

2020-05-22 Thread Dan Murphy
tx-internal-delays and rx-internal-delays are a common setting for RGMII capable devices. These properties are used when the phy-mode or phy-controller is set to rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the controller that the PHY will add the internal delay for the connection.

[PATCH net-next v2 0/4] RGMII Internal delay common property

2020-05-22 Thread Dan Murphy
Hello The RGMII internal delay is a common setting found in most RGMII capable PHY devices. It was found that many vendor specific device tree properties exist to do the same function. This creates a common property to be used for PHY's that have tunable internal delays for the Rx and Tx paths.

Re: [PATCH RFC net-next 10/13] net: bridge: add port flags for host flooding

2020-05-22 Thread Nikolay Aleksandrov
On 22/05/2020 00:10, Vladimir Oltean wrote: > From: Vladimir Oltean > > In cases where the bridge is offloaded by a switchdev, there are > situations where we can optimize RX filtering towards the host. To be > precise, the host only needs to do termination, which it can do by > responding at the

Re: [PATCH v2] xfrm: policy: Fix xfrm policy match

2020-05-22 Thread Yuehaibing
On 2020/5/22 13:49, Xin Long wrote: > On Fri, May 22, 2020 at 9:45 AM Yuehaibing wrote: >> >> On 2020/5/21 14:49, Xin Long wrote: >>> On Tue, May 19, 2020 at 4:53 PM Steffen Klassert >>> wrote: On Fri, May 15, 2020 at 04:39:57PM +0800, Yuehaibing wrote: > > Friendly ping...

Re: [PATCH -next] mt76: mt7915: Fix build error

2020-05-22 Thread Kalle Valo
YueHaibing wrote: > In file included from ./include/linux/firmware.h:6:0, > from drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:4: > In function ‘__mt7915_mcu_msg_send’, > inlined from ‘mt7915_mcu_send_message’ at > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:370:6: > .

[PATCH net-next] mptcp: adjust tcp rcvspace after moving skbs from ssk to sk queue

2020-05-22 Thread Florian Westphal
TCP does tcp rcvbuf tuning when copying packets to userspace, e.g. in tcp_read_sock(). In case of mptcp, that function is only rarely used (when discarding retransmitted duplicate data). Instead, skbs are moved from the tcp rx queue to the mptcp socket rx queue. Adjust subflow rcvbuf when we do s

Re: [RFC PATCH v12 03/11] psci: export smccc conduit get helper.

2020-05-22 Thread Sudeep Holla
On Fri, May 22, 2020 at 04:37:16PM +0800, Jianyong Wu wrote: > Export arm_smccc_1_1_get_conduit then modules can use smccc helper which > adopts it. > > Acked-by: Mark Rutland > Signed-off-by: Jianyong Wu > --- > drivers/firmware/psci/psci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH RFC net-next 10/13] net: bridge: add port flags for host flooding

2020-05-22 Thread Vladimir Oltean
On Fri, 22 May 2020 at 15:38, Nikolay Aleksandrov wrote: > > On 22/05/2020 00:10, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > In cases where the bridge is offloaded by a switchdev, there are > > situations where we can optimize RX filtering towards the host. To be > > precise, the ho

RE: [PATCH v2 net-next 0/7] dpaa2-eth: add support for Rx traffic classes

2020-05-22 Thread Ioana Ciornei
> Subject: Re: [PATCH v2 net-next 0/7] dpaa2-eth: add support for Rx traffic > classes > > On Wed, 20 May 2020 20:24:43 + Ioana Ciornei wrote: > > > Subject: Re: [PATCH v2 net-next 0/7] dpaa2-eth: add support for Rx > > > traffic classes > > > > > > On Wed, 20 May 2020 15:10:42 + Ioana Cio

Re: [RFC PATCH v12 07/11] psci: Add hypercall service for kvm ptp.

2020-05-22 Thread Steven Price
On 22/05/2020 09:37, Jianyong Wu wrote: ptp_kvm modules will get this service through smccc call. The service offers real time and counter cycle of host for guest. Also let caller determine which cycle of virtual counter or physical counter to return. Signed-off-by: Jianyong Wu --- include/li

Re: [PATCH net-next] mptcp: adjust tcp rcvspace after moving skbs from ssk to sk queue

2020-05-22 Thread Paolo Abeni
Hi, On Fri, 2020-05-22 at 14:43 +0200, Florian Westphal wrote: > TCP does tcp rcvbuf tuning when copying packets to userspace, e.g. in > tcp_read_sock(). In case of mptcp, that function is only rarely used > (when discarding retransmitted duplicate data). > > Instead, skbs are moved from the tcp

Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client

2020-05-22 Thread Pierre-Louis Bossart
+ ret = virtbus_register_device(vdev); + if (ret < 0) + return ret; + + /* make sure the probe is complete before updating client list */ + timeout = msecs_to_jiffies(SOF_CLIENT_PROBE_TIMEOUT_MS); + time = wait_for_completion_timeout(&cdev->probe_comp

Re: [PATCH v2 0/7] Share events between metrics

2020-05-22 Thread Arnaldo Carvalho de Melo
Em Fri, May 22, 2020 at 02:55:46PM +0530, kajoljain escreveu: > On 5/20/20 11:50 PM, Ian Rogers wrote: > > Metric groups contain metrics. Metrics create groups of events to > > ideally be scheduled together. Often metrics refer to the same events, > > for example, a cache hit and cache miss rate. U

Re: do a single memdup_user in sctp_setsockopt

2020-05-22 Thread Marcelo Ricardo Leitner
On Fri, May 22, 2020 at 08:02:09AM +, David Laight wrote: > From: Christoph Hellwig > > Sent: 21 May 2020 18:47 > > based on the review of Davids patch to do something similar I dusted off > > the series I had started a few days ago to move the memdup_user or > > copy_from_user from the inidivi

Re: [PATCH 16/17] dt-bindings: watchdog: renesas,wdt: Document r8a7742 support

2020-05-22 Thread Guenter Roeck
On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote: > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > therefore add relevant documentation. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > Reviewed-by: Wolfram Sang > Reviewed-by:

  1   2   3   4   >